- 05 Feb, 2020 1 commit
-
-
Rohit Rao authored
https://gn-review.googlesource.com/c/gn/+/5941 changed the default values of these switches to "-l" and "-L", but these new defaults do not work for Microsoft's toolchain. Crashpad still supports building with this toolchain. Change-Id: Ia112de6c2aae79aa23ff6f9444b489dccb252f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/2036658 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 01 Feb, 2020 2 commits
-
-
Rohit Rao authored
Change-Id: I188e620a7f845b9121fdcc78da03ad80a8dddea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/2032965 Reviewed-by:
Mark Mentovai <[email protected]>
-
Justin Cohen authored
Change-Id: I44246d3698bac61b4d4b097a8f45f07f17f5b2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/2032967 Reviewed-by:
Rohit Rao <[email protected]>
-
- 30 Jan, 2020 1 commit
-
-
Justin Cohen authored
This is necessary to set and hit breakpoints in Xcode. Change-Id: Ib540b2e37bafd1d2a83c51cf3a233ae370b7e70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/2028149 Reviewed-by:
Justin Cohen <[email protected]>
-
- 07 Dec, 2019 1 commit
-
-
Mark Mentovai authored
Change-Id: Ib288af565351452cc8b1fe3c2c0c4b425dd2322d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1954674 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 01 Nov, 2019 1 commit
-
-
Rohit Rao authored
Change-Id: Ifbcf52320f383cc58b89c2c27898620a6cc6ce95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1894624 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 30 Oct, 2019 1 commit
-
-
Rohit Rao authored
Bug: None Change-Id: Iec1bebe0d107807b39e9fa899fb0d6e8d93ef1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1887710 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 24 Oct, 2019 1 commit
-
-
Scott Graham authored
mini_chromium side of https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1876893. Change-Id: Iaa28c27344719904b964e8d2365aaa6274a47124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1876894 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 19 Sep, 2019 1 commit
-
-
Rohit Rao authored
Change-Id: Iee56b9fd108de0a9be52a771f27bda6f6a914fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1808712 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 18 Sep, 2019 1 commit
-
-
Rohit Rao authored
Change-Id: Ic113ce5a893b204c8a8ccb18c7de964e07806ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1797255 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 04 Sep, 2019 1 commit
-
-
Rohit Rao authored
Change-Id: Ib34a5f95761759047450243eb57692d521c5411e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1769190 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 30 Aug, 2019 1 commit
-
-
Rohit Rao authored
Xcode11 flags these with a warning. After removal, mini_chromium still builds with Xcode 9.3.1 and Xcode 10.2.1. Change-Id: I40f452464be37f0fb8847ac244c11c6fcff20310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1768856 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 28 Aug, 2019 1 commit
-
-
Scott Graham authored
This config will be added to Crashpad's BUILDCONFIG.gn defaults rather than forced into all common configs. Bug: crashpad:309 Change-Id: If4e2c0256b4f5c93604d57b14caf28880d40f646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1773504 Reviewed-by:
Joshua Peraza <[email protected]>
-
- 30 Jul, 2019 1 commit
-
-
Joshua Peraza authored
Updates the warnings disabled by the win/gyp build to match the win/gn build. Change-Id: Ie778dd27b9b813b34d30bf112bc321f67df17ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1723645 Reviewed-by:
Mark Mentovai <[email protected]> Reviewed-by:
Eric Astor <[email protected]>
-
- 21 Jun, 2019 1 commit
-
-
Adam Kallai authored
ARM Macro Assembler doesn't support '-D' define flag, and Windows specific build flags such as /c /Fo, so they are removed. Change-Id: I34d8ed54879ee2505dafb0749f6644cdcf99857c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1669447 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 16 May, 2019 1 commit
-
-
Eric Astor authored
Certain Android configurations use GNU-style strerror_r, signaled by _GNU_SOURCE with __ANDROID_API__ >= 23. Change-Id: Ie2e8b0c6d7f8a3d18ede379745dff0dbef61970c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1611030 Reviewed-by:
Eric Astor <[email protected]>
-
- 03 May, 2019 1 commit
-
-
Eric Astor authored
Change-Id: I77898f6c4e1a7cbbe91eb731901ec23a166780a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1592098 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 20 Mar, 2019 1 commit
-
-
Mark Mentovai authored
% gn gen out/debug_32 --args='target_cpu="x86"' % ninja -C out/debug_32 The 10.14 SDK does not contain support to link for 32-bit x86, so with Xcode 10, you may need to set the GN argument mac_sdk=10.13 (or lower) or target_sysroot to an equivalent path. It may also be necessary to coax Xcode into accepting this SDK. Change-Id: Ib1f8fab343ff6c968fc651ee8cf45a73c5af0225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1529146 Reviewed-by:
Scott Graham <[email protected]>
-
- 07 Mar, 2019 1 commit
-
-
Mark Mentovai authored
https://chromium-review.googlesource.com/c/+/1503688 brings an updated Fuchsia SDK into Crashpad. Now, a specific SDK for macOS build hosts is available. Previously, macOS build hosts “borrowed” the Linux build host SDK. The Fuchsia sysroot build configuration in mini_chromium needs to be updated for this change. Change-Id: I7b815b71d3b575c61a224f4aef82434e08fd2add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1506239 Reviewed-by:
Scott Graham <[email protected]>
-
- 20 Feb, 2019 2 commits
-
-
Mark Mentovai authored
Most importantly, this picks up: 97fa6e4bdf7b Remove a few unnecessary semicolons The entire range is: 1bb44b3c5f9b Remove unused cassert include in base/numerics/safe_conversions.h ef3f35d7e604 Remove more unnecessary includes, limits.h and climits in base/numerics 99bfa52d9dea Cleanup sign checking in safe math code 6b15c686879f Remove bad comment in HasSignBit 28c208fcaf68 Revert of Remove bad comment in HasSignBit (patchset #1 id:1 of https://codereview.chromium.org/2562643005/ ) f2896ed53d88 Revert of Cleanup sign checking in safe math code (patchset #1 id:1 of https://codereview.chromium.org/2564493003/ ) ba3c4f9491c6 Performance optimizations for base/numerics absolute value and multiply e2d3dd950af5 Make base/numerics abs match runtime libraries 186c7dbbea5e Support saturation overrides in saturated_cast 7772a0500fa2 Revert of Support saturation overrides in saturated_cast (patchset #7 id:180001 of https://codereview.chromium.org/2578613002/ ) 71b669adca7b Support saturation overrides in saturated_cast 8b34cfe3286e Improve saturated_cast performance 3e898ba28836 Revert of Improve saturated_cast performance (patchset #4 id:160001 of https://codereview.chromium.org/2585043002/ ) e3bd1f6de34f Improve saturated_cast performance af68077d100a SafeUnsignedAbs code size improvement for inlined function 6dfadc0dc4a5 Minor base/numerics cleanup 33232e07dc60 Simplify Checked Add, Sub, and Mul implementations 7308c7f7745c Convert remaining CheckedNumeric unary operators to constexpr 00c3bd0ec752 Switch IsValueInRangeForNumericType to IsValid() c8f03cd3ed7c Restructure saturated_cast<> internals 082b2bad6a2b Cleanup RangeCheck class and dependencies 8f2127bb83d8 [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files 9711f036f202 Handle large rects better 6d0446e51df5 Remove base::underlying_type, replace uses with std::underlying_type 6a2c67b92797 Split out code to be shared between CheckedNumeric and ClampedNumeric 5c0b1ec78ac4 Fix some result type issues in base/numerics b180f39aa6a2 Add ClampedNumeric templates 511dbccd99e3 Fix some documentation in base/numerics 48b272671a15 Move base/numerics compiler-specific intrinsics to their own file f3a69e049044 Add optimized arm implementations to base/numerics 66dbfe275dad Fix ios builders after refs/heads/[email protected]{#486438} 2caa66fd7e8f Revert "Fix ios builders after refs/heads/[email protected]{#486438}" e9d94b7d5d38 Revert "Add optimized arm implementations to base/numerics" a26da2727182 Add optimized arm implementations to base/numerics a81d2e5d1c20 Fix Max/Min methods for ClampedNumeric and add tests 191d11489cb9 Replace Saturated*() calls with Clamp*() templates b1573039b777 Revert "Replace Saturated*() calls with Clamp*() templates" a15cf3ca707d Add optimized negation to ClampedNumeric c77d482ba4a8 Fix template bug in base::saturated_cast<>() dc579148b2f7 Fix perf and constexpr correctness in safe negation a1639d986058 Improve performance of safe absolute value c8067e05e5e1 Replace Saturated*() calls with Clamp*() templates 5a28bfad5b3d Revert "Replace Saturated*() calls with Clamp*() templates" cbe684526321 Make base/numerics build with GCC 93e7d07e70af Warn on ignored return value from CheckedNumeric::AssignIfValid() 4a572da99ce7 Replace Saturated*() calls with Clamp*() templates 19bf43a04f98 Add missing inline directives for base/numerics 576f51b8db14 Reduce branches in ClampedNumeric 630ffea24378 Use std::isfinite at runtime in base/numerics 0d61b7ad82f1 Move blink layout-specific saturated math back to WTF 5cc331deecba Prevent dependency leaks to and from base/numerics 3f9078d8c228 Fix base/numerics compile-time constant handling 905089c657d6 Add missing header to base/numerics/BUILD.gn 5cc2abf4c5a1 Improve checked_cast and saturated_cast performance 4ad909a931bd Improve branching in CheckedNumeric and ClampedNumeric 72b0d836b116 Improve base/numerics docs 4d93ee3a4e69 Support enum in base/numerics cast templates 5d5c23fa54f7 Improve base/numerics documentation 680caa47a5c5 Use __debugbreak in base/numerics 2202c8efcee5 Move cc::MathUtil::ClampToRange() to base and use it more broadly 76ed066d302d Move constants for pi from cc to base and use them more widely 3725ec39917f Make ClampedNumeric and CheckedNumeric constexpr ffc71c032540 Reorder saturation calculation for ClampAddOp and ClampSupOp 95a989c109f4 Revert "Reorder saturation calculation for ClampAddOp and ClampSupOp" 92f328e4ab80 Move cc::MathUtil::ApproximatelyEqual() from cc/base/math_util.h to base/numerics/ranges.h 5ec7403b4e78 Simplify ClampedSubOp and ClampedAddOp ec48e4ae39ee Fix the build of base/numerics with GCC e4839b632724 Make base::ClampToRange() match std::clamp()'s definition 57a5f89e3e1f Minor documentation fix in base/numerics 091d6297a7ba Run clang-tidy modernize-use-equals-{delete,default} on //base headers 66e55526c0bc Small wording clarifications to safe_numerics.h readme.md f1e233b3fb8a Avoid instantiating SaturateFastAsmOp<> for types that do not use it 97fa6e4bdf7b Remove a few unnecessary semicolons Change-Id: Icfb765e96ba379aaa0ac992d2c952d90820de4cb Reviewed-on: https://chromium-review.googlesource.com/c/1476667 Reviewed-by:
Nico Weber <[email protected]>
-
Mark Mentovai authored
Bug: chromium:926235 Change-Id: I28474988d73ad014d248cc69156656c98402bbbb Reviewed-on: https://chromium-review.googlesource.com/c/1476666 Reviewed-by:
Nico Weber <[email protected]>
-
- 13 Feb, 2019 1 commit
-
-
Eric Astor authored
Partially reverts https://chromium.googlesource.com/chromium/mini_chromium/+/793e94e2c652. Change-Id: Ic816ff1ffb9cd8e9fda838e6a1a3cc917974492b Reviewed-on: https://chromium-review.googlesource.com/c/1467543 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 05 Jan, 2019 3 commits
-
-
Mark Mentovai authored
Change-Id: Icf9344d5cac3cbe7bf449aeee64c53d59e18bde4 Reviewed-on: https://chromium-review.googlesource.com/c/1396044 Reviewed-by:
Mark Mentovai <[email protected]>
-
Mark Mentovai authored
FAILED: obj/third_party/mini_chromium/mini_chromium/base/strings/base.stringprintf.obj ninja -t msvc -e environment.amd64 -- cl.exe /nologo /showIncludes -DNDEBUG -I../../third_party/mini_chromium/mini_chromium /DNOMINMAX /DUNICODE /DWIN32_LEAN_AND_MEAN /D_CRT_SECURE_NO_WARNINGS /D_HAS_EXCEPTIONS=0 /D_UNICODE /FS /W4 /WX /Zi /bigobj /wd4100 /wd4127 /wd4324 /wd4351 /wd4577 /wd4996 /GL /O2 /Ob2 /Oy- /Zc:inline /d2Zi+ /c ../../third_party/mini_chromium/mini_chromium/base/strings/stringprintf.cc /Foobj/third_party/mini_chromium/mini_chromium/base/strings/base.stringprintf.obj /Fd"obj/third_party/mini_chromium/mini_chromium/base/base_cc.pdb" ../../third_party/mini_chromium/mini_chromium/base/strings/stringprintf.cc(48): error C2220: warning treated as error - no 'object' file generated ../../third_party/mini_chromium/mini_chromium/base/strings/stringprintf.cc(106): note: see reference to function template instantiation 'void base::`anonymous-namespace'::StringAppendVT<std::string>(StringType *,const char *,va_list)' being compiled with [ StringType=std::string ] ../../third_party/mini_chromium/mini_chromium/base/strings/stringprintf.cc(48): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data FAILED: obj/third_party/mini_chromium/mini_chromium/base/base.logging.obj ninja -t msvc -e environment.amd64 -- cl.exe /nologo /showIncludes -DNDEBUG -I../../third_party/mini_chromium/mini_chromium /DNOMINMAX /DUNICODE /DWIN32_LEAN_AND_MEAN /D_CRT_SECURE_NO_WARNINGS /D_HAS_EXCEPTIONS=0 /D_UNICODE /FS /W4 /WX /Zi /bigobj /wd4100 /wd4127 /wd4324 /wd4351 /wd4577 /wd4996 /GL /O2 /Ob2 /Oy- /Zc:inline /d2Zi+ /c ../../third_party/mini_chromium/mini_chromium/base/logging.cc /Foobj/third_party/mini_chromium/mini_chromium/base/base.logging.obj /Fd"obj/third_party/mini_chromium/mini_chromium/base/base_cc.pdb" ../../third_party/mini_chromium/mini_chromium/base/logging.cc(76): error C2220: warning treated as error - no 'object' file generated ../../third_party/mini_chromium/mini_chromium/base/logging.cc(76): warning C4267: 'argument': conversion from 'size_t' to 'DWORD', possible loss of data Change-Id: I451ca75a91c9f967a6795d635dae29834f51abf2 Reviewed-on: https://chromium-review.googlesource.com/c/1396043 Reviewed-by:
Mark Mentovai <[email protected]>
-
Mark Mentovai authored
Its use was removed from Crashpad in c8a016b99d97, and it will be removed from Chromium in the future. Bug: chromium:837308 Change-Id: Idb4fc1a235bd1452547133b28ac74cd851fb3b07 Reviewed-on: https://chromium-review.googlesource.com/c/1396038 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 06 Dec, 2018 1 commit
-
-
Tom Tan authored
This is necessary for adding Windows ARM64 support to crashpad because crashpad depends on mini_chromium. Bug: 893460 Change-Id: I058d08e68ed661636778ffb6dc823196b343b730 Reviewed-on: https://chromium-review.googlesource.com/c/1345247 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 17 Nov, 2018 1 commit
-
-
Scott Graham authored
Bug: crashpad:266 Bug: fuchsia:DX-690 Change-Id: I6714c2ddf0dc0c3da3fa43d9062137fa00e471c0 Reviewed-on: https://chromium-review.googlesource.com/c/1340485 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 23 Oct, 2018 1 commit
-
-
Vlad Tsyrklevich authored
BUG=crashpad:262 Change-Id: Ie66643eca5ae7828f362568631d88af93682d052 Reviewed-on: https://chromium-review.googlesource.com/c/1277713 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 20 Oct, 2018 1 commit
-
-
Scott Graham authored
It's never as useful as it seems like it should be and it's removed from Chromium now. Upstreaming of https://chromium-review.googlesource.com/c/chromium/src/+/1290574/. Change-Id: Iac34e166f785074e91c19ece996e7c2e90db8249 Reviewed-on: https://chromium-review.googlesource.com/c/1291749 Reviewed-by:
Scott Graham <[email protected]>
-
- 19 Oct, 2018 1 commit
-
-
Scott Graham authored
The toolchain cipd recipe [1] sets VSINSTALLDIR, but doesn't have a vswhere binary. Add support for using the environment to locate the installation. This is an attempt to fix failures that look like this: https://logs.chromium.org/logs/crashpad/buildbucket/cr-buildbucket.appspot.com/8932376363796040144/+/steps/generate_build_files_x86/0/stdout. 1. https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/recipes/recipe_modules/windows_sdk/ Bug: chromium:892712 Change-Id: I80dc097e87327c5c50302620d38addf8b8e5ef8d Reviewed-on: https://chromium-review.googlesource.com/c/1287243 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 02 Aug, 2018 1 commit
-
-
Wez authored
Bug: chromium:852541 Change-Id: I60270c548ab3bd6f30c44a8e6a94cf3119eca7c4 Reviewed-on: https://chromium-review.googlesource.com/1159103 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 21 Jul, 2018 1 commit
-
-
Wez authored
We've already migrated to the new fdio_spawn*() API, and no longer use launchpad. Change-Id: Ieaba20eba2a1b9281429bfa7f4d564f8b167964a Reviewed-on: https://chromium-review.googlesource.com/1143715 Reviewed-by:
Mark Mentovai <[email protected]>
-
- 29 Jun, 2018 1 commit
-
-
Adam Barth authored
This CL updates our use of zx_cprng_draw to the target semantics. This syscall now always produces the requested random bytes and never fails. If the call would fail, the process is terminated instead. Change-Id: I3cc3145f4c8e22252533cf1a174ac5ac70d21db7 Reviewed-on: https://chromium-review.googlesource.com/1119161 Reviewed-by:
Scott Graham <[email protected]>
-
- 22 Jun, 2018 1 commit
-
-
Scott Graham authored
Goes with https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1110346. Also, mini_chromium and Crashpad won't build with VS2015 any more, so remove detection of that while we're here. Bug: crashpad:236 Change-Id: I842ad286db67b1d4f8923458ffdd12e4f39286fe Reviewed-on: https://chromium-review.googlesource.com/1110347 Reviewed-by:
Joshua Peraza <[email protected]>
-
- 13 Jun, 2018 1 commit
-
-
Adam Barth authored
We're removing the "actual" parameter from zx_cprng_draw. This CL is the first step. Change-Id: Id99a5713f8d59f28488791d5995edaad76e636d1 Reviewed-on: https://chromium-review.googlesource.com/1098224 Reviewed-by:
Scott Graham <[email protected]>
-
- 02 Jun, 2018 1 commit
-
-
Scott Graham authored
The clang that the Fuchsia team ships now requires -ldl and -lpthread for host (Linux) binaries, but that must currently be put manually on the command line. Additionally, while we were force linking fdio on Fuchsia, we weren't including zircon. But fdio won't work without zircon, so include it too. Bug: crashpad:30, crashpad:196 Change-Id: I13fba13acd0380bb18143524336160096bac10a6 Reviewed-on: https://chromium-review.googlesource.com/1083601 Reviewed-by:
Joshua Peraza <[email protected]>
-
- 23 May, 2018 1 commit
-
-
Scott Graham authored
Attempting to roll gtest: Now depends on fdio on Fuchsia for death tests. Bug: crashpad:196 Change-Id: I992138f8c4d909ebb565f4b2d87fc8aec87b58a2 Reviewed-on: https://chromium-review.googlesource.com/1069539 Reviewed-by:
Joshua Peraza <[email protected]>
-
- 19 May, 2018 1 commit
-
-
Scott Graham authored
Bug: crashpad:196 Change-Id: I5512e1a74c152f329d08fb7f4aab89036d02427f Reviewed-on: https://chromium-review.googlesource.com/1066827 Reviewed-by:
Joshua Peraza <[email protected]>
-
- 01 May, 2018 1 commit
-
-
Scott Graham authored
Bug: crashpad:196 Change-Id: Ib2c27204c381c61ae48f9d33a74ba673fe01fedb Reviewed-on: https://chromium-review.googlesource.com/1035921 Reviewed-by:
Joshua Peraza <[email protected]>
-
- 19 Apr, 2018 1 commit
-
-
Fabrice de Gans-Riberi authored
This follows the chromium change for consistency. Bug: chromium:812974 Change-Id: I1a831219ed02bbe11cc037bebd4a98d2d7d76739 Reviewed-on: https://chromium-review.googlesource.com/1016034 Reviewed-by:
Scott Graham <[email protected]>
-