diff --git a/lib/src/barback/dart2js_transformer.dart b/lib/src/barback/dart2js_transformer.dart index 0200ac389806337f88e2bf1ff57a78e8ba18321e..41427e6db66ebb5845792b7e137d4dbc60d68d3c 100644 --- a/lib/src/barback/dart2js_transformer.dart +++ b/lib/src/barback/dart2js_transformer.dart @@ -24,7 +24,7 @@ import 'asset_environment.dart'; /// The set of all valid configuration options for this transformer. final _validOptions = new Set<String>.from([ 'commandLineOptions', 'checked', 'csp', 'minify', 'verbose', 'environment', - 'analyzeAll', 'preserveUris', 'suppressWarnings', 'suppressHints', + 'preserveUris', 'suppressWarnings', 'suppressHints', 'suppressPackageWarnings', 'terse' ]); diff --git a/test/dart2js/minify_configuration_overrides_mode_test.dart b/test/dart2js/minify_configuration_overrides_mode_test.dart index 739bd9d0fd9fd0c392b26be2cc1eef631330bb92..da0e6bcc302d4cbed7ecd75aef016f64c646b475 100644 --- a/test/dart2js/minify_configuration_overrides_mode_test.dart +++ b/test/dart2js/minify_configuration_overrides_mode_test.dart @@ -15,7 +15,10 @@ main() { "transformers": [{ "\$dart2js": {"minify": true} }] - }) + }), + d.dir("web", [ + d.file("main.dart", "void main() => print('Hello!');") + ]) ]).create(); pubServe(); diff --git a/test/dart2js/supports_valid_options_test.dart b/test/dart2js/supports_valid_options_test.dart index 4bf175a7bf2c70ead67e07370d83dfd29bebe2ae..81212b0537fe14bd9a7dc8227e85322e0ea88d8d 100644 --- a/test/dart2js/supports_valid_options_test.dart +++ b/test/dart2js/supports_valid_options_test.dart @@ -22,14 +22,16 @@ main() { "minify": true, "verbose": true, "environment": {"name": "value"}, - "analyzeAll": true, "suppressWarnings": true, "suppressHints": true, "suppressPackageWarnings": false, "terse": true } }] - }) + }), + d.dir("web", [ + d.file("main.dart", "void main() => print('Hello!');") + ]) ]).create(); // None of these options should be rejected, either by pub or by dart2js. diff --git a/test/serve/utils.dart b/test/serve/utils.dart index 9516cd2ddb41fccb7d170dc42eae4b6a25938741..f84eb9a353f97c13dc97df922401882306a2451d 100644 --- a/test/serve/utils.dart +++ b/test/serve/utils.dart @@ -260,6 +260,7 @@ Future<http.Response> scheduleRequest(String urlPath, {String root}) { /// [headers] may be either a [Matcher] or a map to match an exact headers map. void requestShouldSucceed(String urlPath, expectation, {String root, headers}) { scheduleRequest(urlPath, root: root).then((response) { + expect(response.statusCode, equals(200)); if (expectation != null) expect(response.body, expectation); if (headers != null) expect(response.headers, headers); });