From da217aad91811937522bbea7e6118bbcfc55d9b8 Mon Sep 17 00:00:00 2001
From: tholenst <tholenst@google.com>
Date: Thu, 29 Aug 2019 01:29:06 -0700
Subject: [PATCH] Fix a test in the AesSivKeyManagerTest to actually check the
right thing (namely, if the wrong version makes validateKey fail).
PiperOrigin-RevId: 266087262
---
.../crypto/tink/daead/AesSivKeyManagerTest.java | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/java/src/test/java/com/google/crypto/tink/daead/AesSivKeyManagerTest.java b/java/src/test/java/com/google/crypto/tink/daead/AesSivKeyManagerTest.java
index 543762449..4d92431bb 100644
--- a/java/src/test/java/com/google/crypto/tink/daead/AesSivKeyManagerTest.java
+++ b/java/src/test/java/com/google/crypto/tink/daead/AesSivKeyManagerTest.java
@@ -101,18 +101,11 @@ public class AesSivKeyManagerTest {
@Test
public void validateKey_version() throws Exception {
AesSivKeyManager manager = new AesSivKeyManager();
-
- for (int i = 0; i < 100; i++) {
- if (i == 64) {
- manager.validateKey(createAesSivKey(i));
- } else {
- try {
- manager.validateKey(createAesSivKey(i));
- fail();
- } catch (GeneralSecurityException e) {
- // expected
- }
- }
+ try {
+ manager.validateKey(AesSivKey.newBuilder(createAesSivKey(64)).setVersion(1).build());
+ fail();
+ } catch (GeneralSecurityException e) {
+ // expected
}
}
--
GitLab