From 26983f755d30ccc85fde98a3bcbab2747db2e0e5 Mon Sep 17 00:00:00 2001
From: Tamir Duberstein <tamird@google.com>
Date: Tue, 23 Apr 2019 18:33:11 +0000
Subject: [PATCH] [netstack] correctly set loopback address
Turns out the test was just written incorrectly. This probably worked on
Linux because `connect()` on a UDP socket doesn't do as much validation.
NET-2125 #done
Change-Id: Ieada529c0f620f176b408d2c7681626801ce4a78
---
src/connectivity/network/tests/bsdsocket_test.cc | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/src/connectivity/network/tests/bsdsocket_test.cc b/src/connectivity/network/tests/bsdsocket_test.cc
index 47f8d0bd51a..5c44bff3592 100644
--- a/src/connectivity/network/tests/bsdsocket_test.cc
+++ b/src/connectivity/network/tests/bsdsocket_test.cc
@@ -97,19 +97,12 @@ TEST(LocalhostTest, ConnectAFMismatchINET6) {
struct sockaddr_in addr = {};
addr.sin_family = AF_INET;
- addr.sin_addr.s_addr = INADDR_LOOPBACK;
+ addr.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
addr.sin_port = htons(1337);
- // TODO(NET-2125): the behaviour is incorrect on Fuchsia. Fix this upstream
- // and re-enable the test.
EXPECT_EQ(
connect(s, reinterpret_cast<const struct sockaddr*>(&addr), sizeof(addr)),
-#if defined(__linux__)
0)
<< strerror(errno);
-#else
- -1);
- ASSERT_EQ(errno, EHOSTUNREACH) << strerror(errno);
-#endif
EXPECT_EQ(close(s), 0) << strerror(errno);
}
--
GitLab