From 3d2ca1fb226587f5c7c6b2c8325804544bd409c1 Mon Sep 17 00:00:00 2001
From: Lloyd Hilaiel <lloyd@hilaiel.com>
Date: Tue, 29 May 2012 09:59:48 +0300
Subject: [PATCH] rework uncaught exception handling: log an error, don't bring
the process down, bump a statsd counter: issue #1558
---
lib/logging.js | 6 +++---
lib/statsd.js | 4 ++++
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/lib/logging.js b/lib/logging.js
index d868df2f7..058d16186 100644
--- a/lib/logging.js
+++ b/lib/logging.js
@@ -40,7 +40,7 @@ exports.logger = new (winston.Logger)({
timestamp: function () { return new Date().toISOString() },
filename: filename,
colorize: true,
- handleExceptions: !!process.env['LOG_TO_CONSOLE']
+ handleExceptions: true
})]
});
@@ -51,6 +51,6 @@ exports.enableConsoleLogging = function() {
});
};
-
-
if (process.env['LOG_TO_CONSOLE']) exports.enableConsoleLogging();
+
+exports.logger.exitOnError = false;
diff --git a/lib/statsd.js b/lib/statsd.js
index 0e231f3c2..f7278dca5 100644
--- a/lib/statsd.js
+++ b/lib/statsd.js
@@ -29,3 +29,7 @@ if (statsd_config && statsd_config.enabled) {
statsd = new StatsD(options["host"], options["port"]);
}
+
+process.on('uncaughtException', function(err) {
+ if (statsd) statsd.increment(PREFIX + 'uncaught_exception');
+});
--
GitLab