From 7b9d1cdc1feec681e895166c405af0df5a6f78fe Mon Sep 17 00:00:00 2001 From: Lloyd Hilaiel <lloyd@hilaiel.com> Date: Mon, 15 Aug 2011 11:42:45 +0300 Subject: [PATCH] (mysql) fix how parameters are processed: namely allow undefined passwords. sheesh. --- browserid/lib/db_mysql.js | 6 +++--- libs/configuration.js | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/browserid/lib/db_mysql.js b/browserid/lib/db_mysql.js index 4bcb8d52e..eeef31847 100644 --- a/browserid/lib/db_mysql.js +++ b/browserid/lib/db_mysql.js @@ -94,13 +94,13 @@ exports.open = function(cfg, cb) { const defParams = { host: '127.0.0.1', port: "3306", - user: 'test', - password: 'pass', + user: undefined, + password: undefined, unit_test: false }; Object.keys(defParams).forEach(function(param) { - client[param] = cfg[param] ? cfg[param] : defParams[param]; + client[param] = cfg[param] !== undefined ? cfg[param] : defParams[param]; }); // let's figure out the database name diff --git a/libs/configuration.js b/libs/configuration.js index ecddccb7b..b65422ad7 100644 --- a/libs/configuration.js +++ b/libs/configuration.js @@ -58,8 +58,7 @@ exports.get = function(val) { var defaultHostedDatabaseConfig = { driver: "mysql", - user: 'browserid', - password: 'browserid' + user: 'browserid' }; // various deployment configurations -- GitLab