From ebf9fbcfa67566924fee03c001ed099e09f0224e Mon Sep 17 00:00:00 2001
From: Lloyd Hilaiel <lloyd@hilaiel.com>
Date: Fri, 4 May 2012 10:45:13 -0600
Subject: [PATCH] update the http_forward module to allow global request
 timeouts to be set, use this to implement a 15s upper bound on requests for
 declaration of support in development.  This should fix unit tests

---
 bin/browserid         |  2 +-
 bin/proxy             |  5 ++++-
 lib/configuration.js  |  6 +++++-
 lib/http_forward.js   | 20 +++++++++++++++++++-
 lib/wsapi.js          |  2 +-
 lib/wsapi/cert_key.js |  2 +-
 6 files changed, 31 insertions(+), 6 deletions(-)

diff --git a/bin/browserid b/bin/browserid
index 6f23273cb..03fa955e4 100755
--- a/bin/browserid
+++ b/bin/browserid
@@ -24,7 +24,7 @@ config = require('../lib/configuration.js'),
 heartbeat = require('../lib/heartbeat.js'),
 metrics = require('../lib/metrics.js'),
 logger = require('../lib/logging.js').logger,
-forward = require('../lib/http_forward'),
+forward = require('../lib/http_forward').forward,
 shutdown = require('../lib/shutdown'),
 views = require('../lib/browserid/views.js');
 
diff --git a/bin/proxy b/bin/proxy
index 02b2da157..ce26d1127 100755
--- a/bin/proxy
+++ b/bin/proxy
@@ -14,6 +14,9 @@ config = require('../lib/configuration.js');
 var port = config.has('bind_to.port') ? config.get('bind_to.port') : 0;
 var addy = config.has('bind_to.host') ? config.get('bind_to.host') : "127.0.0.1";
 
+// set a maximum allowed time on responses to declaration of support requests
+forward.setTimeout(config.get('declaration_of_support_timeout_ms'));
+
 const allowed = /^https:\/\/[a-zA-Z0-9\.\-_]+\/\.well-known\/browserid$/;
 
 var server = http.createServer(function (req, res) {
@@ -24,7 +27,7 @@ var server = http.createServer(function (req, res) {
     return;
   }
 
-  forward(url, req, res, function(err) {
+  forward.forward(url, req, res, function(err) {
     if (err) {
       res.writeHead(400);
       res.end('Oops: ' + err.toString());
diff --git a/lib/configuration.js b/lib/configuration.js
index 8ba0fabc9..c414472c7 100644
--- a/lib/configuration.js
+++ b/lib/configuration.js
@@ -187,7 +187,11 @@ var conf = module.exports = convict({
     env: 'DBWRITER_URL'
   },
   process_type: 'string',
-  email_to_console: 'boolean = false'
+  email_to_console: 'boolean = false',
+  declaration_of_support_timeout_ms: {
+    doc: "The amount of time we wait for a server to respond with a declaration of support, before concluding that they are not a primary.  Only relevant when our local proxy is in use, not in production or staging",
+    format: 'integer = 15000'
+  }
 });
 
 // At the time this file is required, we'll determine the "process name" for this proc
diff --git a/lib/http_forward.js b/lib/http_forward.js
index 5277aa956..d88cbd85d 100644
--- a/lib/http_forward.js
+++ b/lib/http_forward.js
@@ -9,7 +9,21 @@ https = require('https'),
 logger = require('./logging.js').logger,
 querystring = require('querystring');
 
-module.exports = function(dest, req, res, cb) {
+var global_forward_timeout = undefined;
+
+exports.setTimeout = function(to) {
+  if (typeof to != 'number') throw "setTimeout expects a numeric argument";
+  global_forward_timeout = to;
+};
+
+exports.forward = function(dest, req, res, cb) {
+  var _cb = cb;
+  var requestTimeout = undefined;
+  cb = function() {
+    if (requestTimeout) clearTimeout(requestTimeout);
+    if (_cb) _cb.apply(null, arguments);
+  }
+
   function cleanupReq() {
     if (preq) {
       preq.removeAllListeners();
@@ -56,6 +70,10 @@ module.exports = function(dest, req, res, cb) {
     cb(e);
   });
 
+  if (global_forward_timeout) {
+    requestTimeout = setTimeout(function() { preq.destroy(); }, global_forward_timeout);
+  }
+
   if (req.headers['content-type']) {
     preq.setHeader('Content-Type', req.headers['content-type']);
   }
diff --git a/lib/wsapi.js b/lib/wsapi.js
index c76c7e3e2..7b736425f 100644
--- a/lib/wsapi.js
+++ b/lib/wsapi.js
@@ -22,7 +22,7 @@ secrets = require('./secrets'),
 config = require('./configuration'),
 logger = require('./logging.js').logger,
 httputils = require('./httputils.js'),
-forward = require('./http_forward.js'),
+forward = require('./http_forward.js').forward,
 url = require('url'),
 fs = require('fs'),
 path = require('path'),
diff --git a/lib/wsapi/cert_key.js b/lib/wsapi/cert_key.js
index 777d61223..0f0c81ef3 100644
--- a/lib/wsapi/cert_key.js
+++ b/lib/wsapi/cert_key.js
@@ -6,7 +6,7 @@ const
 db = require('../db.js'),
 httputils = require('../httputils'),
 logger = require('../logging.js').logger,
-forward = require('../http_forward.js'),
+forward = require('../http_forward.js').forward,
 config = require('../configuration.js'),
 urlparse = require('urlparse'),
 wsapi = require('../wsapi.js');
-- 
GitLab