From f06440a3c896471aacfe18e17bedf3e9f13996b4 Mon Sep 17 00:00:00 2001 From: Shane Tomlinson <stomlinson@mozilla.com> Date: Fri, 14 Sep 2012 17:17:44 +0100 Subject: [PATCH] Fix IE8 showing the red line on the signin page. --- resources/static/pages/css/style.css | 3 ++- resources/views/partial/noscript-warning.ejs | 9 +++++++++ resources/views/signin.ejs | 4 +--- 3 files changed, 12 insertions(+), 4 deletions(-) create mode 100644 resources/views/partial/noscript-warning.ejs diff --git a/resources/static/pages/css/style.css b/resources/static/pages/css/style.css index 5eb988147..769621952 100644 --- a/resources/static/pages/css/style.css +++ b/resources/static/pages/css/style.css @@ -3,7 +3,8 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -noscript { +#noscript-warning { + position: absolute; position: fixed; display: block; background-color: #ef1010; diff --git a/resources/views/partial/noscript-warning.ejs b/resources/views/partial/noscript-warning.ejs new file mode 100644 index 000000000..2da8b420b --- /dev/null +++ b/resources/views/partial/noscript-warning.ejs @@ -0,0 +1,9 @@ +<noscript> + <!-- IE8 has a rendering bug with noscript tags, content must be placed + inside of another element to be styled --> + <p id="noscript-warning"> + <%- gettext('We\'re sorry, Persona requires that Javascript is enabled.') %> + </p> +</noscript> + + diff --git a/resources/views/signin.ejs b/resources/views/signin.ejs index 5534e344d..a58ec52fc 100644 --- a/resources/views/signin.ejs +++ b/resources/views/signin.ejs @@ -113,7 +113,5 @@ </div> </div> -<noscript> - <%- gettext('We\'re sorry, Persona requires that Javascript is enabled.') %> -</noscript> +<%- partial('partial/noscript-warning') %> -- GitLab