diff --git a/resources/static/pages/js/manage_account.js b/resources/static/pages/js/manage_account.js index 1abd43fca3616b8c0d4d6cfc03275c7d429e4f74..5582bd36320ec74faeef97df559a29f1113d75c4 100644 --- a/resources/static/pages/js/manage_account.js +++ b/resources/static/pages/js/manage_account.js @@ -90,8 +90,7 @@ BrowserID.manageAccount = (function() { _(emails).each(function(item) { var e = item.address; - var id = e.replace('@', '_').replace('.', '_', 'g'); - var identity = substitute(template, { email: e, id: id }); + var identity = substitute(template, { email: e }); var idEl = dom.appendTo(identity, list), deleteButton = dom.getDescendentElements(".delete", idEl); diff --git a/resources/static/test/cases/pages/js/manage_account.js b/resources/static/test/cases/pages/js/manage_account.js index 42cbd863bda92036f04215201e4c32a16fd8f18b..e9e6cd9823ea689eb515ac3cb3e879c7b2788155 100644 --- a/resources/static/test/cases/pages/js/manage_account.js +++ b/resources/static/test/cases/pages/js/manage_account.js @@ -9,6 +9,7 @@ var bid = BrowserID, xhr = bid.Mocks.xhr, errorScreen = bid.Screens.error, + user = bid.User, network = bid.Network, storage = bid.Storage, testHelpers = bid.TestHelpers, @@ -82,12 +83,11 @@ xhr.useResult("multiple"); createController(mocks, function() { - equal($("#emailList").children().length, 2, "there two children added"); - - var firstLI = $("#testuser2_testuser_com"); - var secondLI = $("#testuser_testuser_com"); - - equal(firstLI.next().is(secondLI), true, "names are in alphabetical order"); + var sortedEmails = user.getSortedEmailKeypairs(); + _.each(sortedEmails, function(addressInfo, index) { + var displayedAddress = $("#emailList .email").get(index).innerHTML; + equal(displayedAddress, addressInfo.address, "emails are displayed in sorted order"); + }); start(); }); diff --git a/resources/views/index.ejs b/resources/views/index.ejs index b4d6f2b65dcb9827bce45cbb329d03eb2dcedee6..68c5cdcb37a290b933dcb1aab5553b8502f22aec 100644 --- a/resources/views/index.ejs +++ b/resources/views/index.ejs @@ -19,13 +19,13 @@ </div> </div> - <!-- + <!-- These "templates" below aren't available as EJS client-side, since all EJS tags are processed when this view is served by the server. --> <script type="text/html" id="templateUser"> - <li class="identity cf" id="{{id}}"> + <li class="identity cf"> <div class="email">{{email}}</div> <button class="delete"><%- gettext('remove') %></button> </li>