From f5e8da9caa8f6f27c7713f36daeb94662ec18ffa Mon Sep 17 00:00:00 2001 From: Shane Tomlinson <stomlinson@mozilla.com> Date: Mon, 20 Aug 2012 14:40:37 +0100 Subject: [PATCH] Fix the Opera unit test flakiness when checking for element focus. --- resources/static/test/testHelpers/helpers.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/static/test/testHelpers/helpers.js b/resources/static/test/testHelpers/helpers.js index 8053729f5..73051f2c4 100644 --- a/resources/static/test/testHelpers/helpers.js +++ b/resources/static/test/testHelpers/helpers.js @@ -308,7 +308,7 @@ BrowserID.TestHelpers = (function() { testElementFocused: function(selector, msg) { var focusedEl = $(":focus"); - if (focusedEl.is(selector)) { + if ($(selector).is(":focus")) { ok(true, msg || selector + " is focused"); } else { @@ -317,7 +317,7 @@ BrowserID.TestHelpers = (function() { // check to see if it is possible to focus. If it is possible, this is // a failure. If it is not possible, print a message and continue. // Remove the element when complete. - var input = $("<input type='text' />").appendTo("body").focus(); + var input = $("<input type='radio' />").appendTo("body").focus(); if (input.is(":focus")) { ok(false, msg || selector + " is focused"); // refocus the original input element. -- GitLab