From 07dff7f589326862435c681d410b5fef3b95c8a9 Mon Sep 17 00:00:00 2001
From: Silas Davis <silas@erisindustries.com>
Date: Thu, 13 Apr 2017 10:48:14 +0100
Subject: [PATCH] Fix comments in permissions util
---
permission/types/util.go | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/permission/types/util.go b/permission/types/util.go
index 9f9000d1..c7ceae90 100644
--- a/permission/types/util.go
+++ b/permission/types/util.go
@@ -14,11 +14,11 @@
package types
-// ConvertMapStringIntToPermissions converts a map of string-integer pairs and a slice of
-// strings for the roles to an AccountPermissions type. The integer needs to be greater
-// than zero to set the permission. For all unmentioned permissions the ZeroBasePermissions
-// is defaulted to.
-// TODO: [ben] re-evaluate the use of int for setting the permission.
+// ConvertMapStringIntToPermissions converts a map of string-bool pairs and a slice of
+// strings for the roles to an AccountPermissions type. If the value in the
+// permissions map is true for a particular permission string then the permission
+// will be set in the AccountsPermissions. For all unmentioned permissions the
+// ZeroBasePermissions is defaulted to.
func ConvertPermissionsMapAndRolesToAccountPermissions(permissions map[string]bool, roles []string) (*AccountPermissions, error) {
var err error
accountPermissions := &AccountPermissions{}
@@ -30,8 +30,8 @@ func ConvertPermissionsMapAndRolesToAccountPermissions(permissions map[string]bo
return accountPermissions, nil
}
-// convertPermissionsMapStringIntToBasePermissions converts a map of string-integer pairs to
-// BasePermissions.
+// convertPermissionsMapStringIntToBasePermissions converts a map of string-bool
+// pairs to BasePermissions.
func convertPermissionsMapStringIntToBasePermissions(permissions map[string]bool) (BasePermissions, error) {
// initialise basePermissions as ZeroBasePermissions
basePermissions := ZeroBasePermissions
--
GitLab