Skip to content
Snippets Groups Projects
  1. May 25, 2012
    • Brian Warner's avatar
      validate hash-delivered email addresses · 82c31160
      Brian Warner authored
      This moves the assignment of params.email from the primary-controlled
      URL hash (#CREATE_EMAIL= and #ADD_EMAIL=) into the verification block,
      and adds bid.verifyEmail() to check them. Closes bug 758449.
      82c31160
  2. May 24, 2012
  3. May 23, 2012
    • Brian Warner's avatar
    • Shane Tomlinson's avatar
      Move the requiredEmail checks from resources/state.js to controllers/dialog.js. Add more tests. · 4ddbd3fa
      Shane Tomlinson authored
      * Add the startExternalDependencies option when initializing the dialog controller, if set to false, no external dependencies are loaded.  Used for testing.
      * Add a new test to check for script containing emails.
      * Add unit tests for tosURL and privacyURL.
      * Add a testHelpers.testErrorNotVisible
      * Removed the actions.js->doError and its tests, it is no longer used.
      4ddbd3fa
    • Brian Warner's avatar
      Move requiredEmail validation from state.js to dialog.js . Tests fail. · 80d83831
      Brian Warner authored
      Since validation is done earlier, invalid addresses are reported as with
      renderError() instead of startAction("doError"). So the tests which
      watch for doError are now failing (the frontend tests named
      "resources/state: start with invalid requiredEmail - print error screen"
      and "resources/state: start with empty requiredEmail - prints error
      screen". I don't know how to make them watch for renderError() instead.
      
      One upside of this patch is that @stomlinson told me the three-argument
      to startAction("doError"..) in state.js was a bug, as it only accepts
      two real arguments. Removing it is even easier than fixing it.
      80d83831
  4. May 22, 2012
  5. May 21, 2012
  6. Apr 24, 2012
  7. Feb 29, 2012
  8. Feb 24, 2012
  9. Feb 03, 2012
  10. Feb 02, 2012
    • Shane Tomlinson's avatar
      Fixing up a bunch of cancel primary verification flows. This is when a user is... · 9f7063d4
      Shane Tomlinson authored
      Fixing up a bunch of cancel primary verification flows. This is when a user is verifying with a primary and they hit ccancel and are redirected back to BrowserID.
      
      Flows:
      
      * Required email cancel.
      * Cancel add user to current account.
      * Cancel create new user.
      
      Others Items added.
      
      * Add a "cancel" button to the sample RP.
      * Defer how state should be handled for primary user verification from dialog to state.
      
      issue #983
      issue #1036
      9f7063d4
  11. Feb 01, 2012
    • Shane Tomlinson's avatar
      Split the state machine into state, state_machine, history, and command. · eb2a9ddc
      Shane Tomlinson authored
      * Pull out core state machine code from the original state_machine.js.
      * Update code and tests for use in new state machine.
      * Add new state_machine core.
      * Add history.
      * Add command.
      * Update tests.
      * Rename resources/state_machine to resources/state
      
      This should simplify a lot of these "cancel email verification" problems.
      eb2a9ddc
    • Shane Tomlinson's avatar
      Split the state machine into state, state_machine, history, and command. · 356a7f43
      Shane Tomlinson authored
      * Pull out core state machine code from the original state_machine.js.
      * Update code and tests for use in new state machine.
      * Add new state_machine core.
      * Add history.
      * Add command.
      * Update tests.
      * Rename resources/state_machine to resources/state
      
      This should simplify a lot of these "cancel email verification" problems.
      356a7f43
  12. Jan 10, 2012
  13. Dec 28, 2011
  14. Dec 27, 2011
  15. Dec 23, 2011
  16. Dec 22, 2011
  17. Dec 21, 2011
    • Shane Tomlinson's avatar
      Setting up the dialog to redirect to verify users with the primary. · 9d50170b
      Shane Tomlinson authored
      * Adding a window Mock.
      * Adding a new template for the "you've gotta verify" screen.
      * Hooking up the logic to redirect - which closes the window.
      9d50170b
    • Shane Tomlinson's avatar
      Starting next steps on frontend for primary user creation/authentication. · 3e76f6fd
      Shane Tomlinson authored
      * Add network.authenticateWithAssertion and related tests.
      * On signup page, start the redirection code to verify with primary in new tab.
      * in network.js, rename all the onSuccess to onComplete for clarity.
      * Simplify tests for primary user provisioning while "not authenticated".
      * Generate fake keys/certs in the provisioning mock.
      * Save off the keypair/cert given to us by the provisioning frame before getting an assertion.
      * Generate an assertion and log the user in on primary provisioning success.
      3e76f6fd
  18. Dec 20, 2011
  19. Dec 16, 2011
  20. Dec 15, 2011
    • Shane Tomlinson's avatar
      Starting to update the dialog controller to handle code versioning. · f9ab1ba9
      Shane Tomlinson authored
      * Adding getCodeVersion to network.
      * Adding error messages for if session_context fails during getCodeVersion.
      * Adding a code check module.
      * Updating start so that most modules are only registered whenever code is up to date.
      * If the scripts are out of date, append a new script to the head.
      * Cleaning up the dialog module's interface with the channel.
      * Updating the compression script.
      * Splitting off the actions into its own page module/controller for easier testing.
      
      issue #226
      issue #687
      f9ab1ba9
  21. Dec 14, 2011
  22. Nov 22, 2011
  23. Nov 21, 2011
    • Shane Tomlinson's avatar
      Updating tests for modules/splitting off state machine into its own module. · 33e256af
      Shane Tomlinson authored
      * Remove the state machine from the dialog module.
      * Add unit tests for the state machine.
      * The state machine has the ability to cancel any stage and go to the previous stage.
      * All cancel_* messages are now "cancel_stage" for uniformity.
      * Update all unit tests to create then start their modules.
      33e256af
    • Shane Tomlinson's avatar
      JavascriptMVC is now removed as a dependency. · 77c7f445
      Shane Tomlinson authored
      * StealJS is still the script loader.
      * Putting OpenAjax.hub into lib.
      * Adding a Class/SubClass mechanism.
      * Converting all controllers to be Subclassed from Modules.PageModule.
      * All Modules are registered first, then created/started on demand.\
      77c7f445
  24. Nov 18, 2011
    • Shane Tomlinson's avatar
      Splitting off the forgot password code into its own controller so that it can be shared. · a8002a9b
      Shane Tomlinson authored
      * Added forgotpassword_controller, forgotpassword.ejs, and forgotpassword_controller_unit_test.
      * Updated the authenticate controller/template/tests to remove the forgotpassword stuff.
      * Added several more tests to the authenticate suite.
      * Hooking up the expanded forgot password flow for "required email".
      * Unifying the styles between the "required email" screen and the normal flow.
      
      issue #608
      a8002a9b
    • Shane Tomlinson's avatar
      Break add email into its own module/controller with its own unit tests. · 5559c383
      Shane Tomlinson authored
      * Creating addemail_controller, addemail_controller_unit_tests, and addemail.ejs.
      * Shrink down pickemail_controller, and pickemail.ejs.
      * Update a lot of the pickemail_controller unit tests to be more complete.
      * Account consolidation is again possible.
      
      close #607
      close #612
      5559c383
    • Shane Tomlinson's avatar
      Preparing to use with modules. · ae312270
      Shane Tomlinson authored
      * Instead of using the JSMVC DOM binding methods, use ones defined in page_controller.
      * On stop, auto remove all DOM events.
      * Simplifying the creation of the pickemail controllers.
      
      issue #609
      ae312270
  25. Nov 16, 2011
Loading