Fix implicit casts in lib directory (#861)
There are still errors in tests which may be harder to fix so we can't check in the change to analysis options. This should make it easier to diagnose Dart 2 semantic issues as more of the places where there can be failures are explicit. Most of the changes are just adding explicit `as` statements and keeping the semantics that already existed. In a few places an uninitialized `var` is given a type, and in others a reused variable name with different types is split into multiple variables. The changes in the frontend code are the most risky, since some users might still be using that code in a non Dart 2 runtime and relying on looseness which is lost with an explicit cast. Pin to the dev.60 SDK for now since there are failures on the newer SDK.
Showing
- .travis.yml 1 addition, 1 deletion.travis.yml
- lib/src/backend/declarer.dart 1 addition, 1 deletionlib/src/backend/declarer.dart
- lib/src/backend/invoker.dart 4 additions, 4 deletionslib/src/backend/invoker.dart
- lib/src/backend/metadata.dart 24 additions, 24 deletionslib/src/backend/metadata.dart
- lib/src/backend/platform_selector.dart 1 addition, 1 deletionlib/src/backend/platform_selector.dart
- lib/src/backend/runtime.dart 8 additions, 8 deletionslib/src/backend/runtime.dart
- lib/src/backend/suite_platform.dart 2 additions, 1 deletionlib/src/backend/suite_platform.dart
- lib/src/bootstrap/browser.dart 2 additions, 1 deletionlib/src/bootstrap/browser.dart
- lib/src/bootstrap/node.dart 1 addition, 1 deletionlib/src/bootstrap/node.dart
- lib/src/executable.dart 1 addition, 1 deletionlib/src/executable.dart
- lib/src/frontend/async_matcher.dart 5 additions, 3 deletionslib/src/frontend/async_matcher.dart
- lib/src/frontend/expect.dart 6 additions, 4 deletionslib/src/frontend/expect.dart
- lib/src/frontend/expect_async.dart 1 addition, 1 deletionlib/src/frontend/expect_async.dart
- lib/src/frontend/future_matchers.dart 1 addition, 1 deletionlib/src/frontend/future_matchers.dart
- lib/src/frontend/prints_matcher.dart 2 additions, 2 deletionslib/src/frontend/prints_matcher.dart
- lib/src/frontend/spawn_hybrid.dart 1 addition, 1 deletionlib/src/frontend/spawn_hybrid.dart
- lib/src/frontend/stream_matchers.dart 1 addition, 1 deletionlib/src/frontend/stream_matchers.dart
- lib/src/runner.dart 6 additions, 5 deletionslib/src/runner.dart
- lib/src/runner/browser/browser.dart 1 addition, 1 deletionlib/src/runner/browser/browser.dart
- lib/src/runner/browser/browser_manager.dart 6 additions, 5 deletionslib/src/runner/browser/browser_manager.dart
Loading
Please register or sign in to comment