Skip to content
Snippets Groups Projects
Unverified Commit 00e2e7d7 authored by Nate Bosch's avatar Nate Bosch Committed by GitHub
Browse files

Fix implicit casts in lib directory (#861)

There are still errors in tests which may be harder to fix so we can't
check in the change to analysis options.

This should make it easier to diagnose Dart 2 semantic issues as more of
the places where there can be failures are explicit.

Most of the changes are just adding explicit `as` statements and keeping
the semantics that already existed. In a few places an uninitialized
`var` is given a type, and in others a reused variable name with
different types is split into multiple variables.

The changes in the frontend code are the most risky, since some users
might still be using that code in a non Dart 2 runtime and relying on
looseness which is lost with an explicit cast.

Pin to the dev.60 SDK for now since there are failures on the newer SDK.
parent 4302ce42
No related branches found
No related tags found
Loading
Showing
with 75 additions and 67 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment