Skip to content
Snippets Groups Projects
Unverified Commit 400f08ee authored by Nate Bosch's avatar Nate Bosch Committed by GitHub
Browse files

Remove unnecessary DelegatingStreamSink wrapping (#1064)

This was added in https://github.com/dart-lang/test/pull/729 when the
`Socket` class was missing a method in an interface it declared it had -
this caused a problem when some code tried to tear if off.

According to https://github.com/dart-lang/sdk/issues/31504 that method
now exists and can be torn off - calling that method would still throw,
but that would also be true with a `DelegatignStreamSink` wrapper.
parent 79834667
No related branches found
No related tags found
No related merge requests found
......@@ -109,10 +109,7 @@ class NodePlatform extends PlatformPlugin
process.stderr.transform(lineSplitter).listen(print);
var socket = await server.first;
// TODO(nweiz): Remove the DelegatingStreamSink wrapper when sdk#31504 is
// fixed.
var channel = StreamChannel(
socket.cast<List<int>>(), DelegatingStreamSink(socket))
var channel = StreamChannel(socket.cast<List<int>>(), socket)
.transform(StreamChannelTransformer.fromCodec(utf8))
.transform(chunksToLines)
.transform(jsonDocument)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment