Remove special handling for errors during parse (#985)

This is a holdback from Dart 1 where some syntax or type errors were not
reported until runtime.

pkgs/test_core/lib/src/bootstrap/vm.dart

@@ -7,13 +7,9 @@ import "dart:isolate";
 import "package:stream_channel/stream_channel.dart";
 
 import "package:test_core/src/runner/plugin/remote_platform_helpers.dart";
-import "package:test_core/src/runner/vm/catch_isolate_errors.dart";
 
 /// Bootstraps a vm test to communicate with the test runner.
 void internalBootstrapVmTest(Function getMain(), SendPort sendPort) {
-  var channel = serializeSuite(() {
-    catchIsolateErrors();
-    return getMain();
-  });
+  var channel = serializeSuite(getMain);
   IsolateChannel.connectSend(sendPort).pipe(channel);
 }

pkgs/test_core/lib/src/runner/vm/catch_isolate_errors.dart

-// Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-import 'dart:async';
-import 'dart:isolate';
-
-import 'package:stack_trace/stack_trace.dart';
-
-/// Capture any top-level errors (mostly lazy syntax errors, since other are
-/// caught below) and report them to the parent isolate.
-void catchIsolateErrors() {
-  var errorPort = ReceivePort();
-  // Treat errors non-fatal because otherwise they'll be double-printed.
-  Isolate.current.setErrorsFatal(false);
-  Isolate.current.addErrorListener(errorPort.sendPort);
-  errorPort.listen((message) {
-    // Masquerade as an IsolateSpawnException because that's what this would
-    // be if the error had been detected statically.
-    var error = IsolateSpawnException(message[0] as String);
-    var stackTrace =
-        message[1] == null ? Trace([]) : Trace.parse(message[1] as String);
-    Zone.current.handleUncaughtError(error, stackTrace);
-  });
-}

pkgs/test_core/lib/src/runner/vm/platform.dart

@@ -115,15 +115,11 @@ Future<Isolate> _spawnDataIsolate(String path, SendPort message) async {
     import "package:stream_channel/stream_channel.dart";
 
     import "package:test_core/src/runner/plugin/remote_platform_helpers.dart";
-    import "package:test_core/src/runner/vm/catch_isolate_errors.dart";
 
     import "${p.toUri(p.absolute(path))}" as test;
 
     void main(_, SendPort message) {
-      var channel = serializeSuite(() {
-        catchIsolateErrors();
-        return test.main;
-      });
+      var channel = serializeSuite(() => test.main);
       new IsolateChannel.connectSend(message).pipe(channel);
     }
   ''', message, checked: true);

pkgs/test_core/pubspec.yaml

 name: test_core
-version: 0.2.1+1
+version: 0.2.2-dev
 author: Dart Team <misc@dartlang.org>
 description: A basic library for writing tests and running them on the VM.
 homepage: https://github.com/dart-lang/test/blob/master/pkgs/test_core