Skip to content
Snippets Groups Projects
Unverified Commit e9826969 authored by Natalie Weizenbaum's avatar Natalie Weizenbaum Committed by GitHub
Browse files

Merge pull request #793 from dart-lang/fix-tests

Fix tests broken by dart2js using the CFE
parents 362f98d7 43299ca0
No related branches found
No related tags found
Loading
...@@ -415,7 +415,7 @@ void main() { ...@@ -415,7 +415,7 @@ void main() {
}); });
test("the compiler uses colors if the test runner uses colors", () async { test("the compiler uses colors if the test runner uses colors", () async {
await d.file("test.dart", "String main() => 12;\n").create(); await d.file("test.dart", "{").create();
var test = await runTest(["--color", "-p", "chrome", "test.dart"]); var test = await runTest(["--color", "-p", "chrome", "test.dart"]);
expect(test.stdout, emitsThrough(contains('\u001b[35m'))); expect(test.stdout, emitsThrough(contains('\u001b[35m')));
...@@ -450,7 +450,7 @@ void main() { ...@@ -450,7 +450,7 @@ void main() {
containsInOrder( containsInOrder(
[" main.<fn>", "package:test", "dart:async/zone.dart"])); [" main.<fn>", "package:test", "dart:async/zone.dart"]));
await test.shouldExit(1); await test.shouldExit(1);
}, tags: 'chrome'); }, tags: 'chrome', skip: 'Broken by sdk#32633');
test("doesn't dartify stack traces for JS-compiled tests with --js-trace", test("doesn't dartify stack traces for JS-compiled tests with --js-trace",
() async { () async {
......
...@@ -202,7 +202,7 @@ void main() { ...@@ -202,7 +202,7 @@ void main() {
containsInOrder( containsInOrder(
[" main.<fn>", "package:test", "dart:async/zone.dart"])); [" main.<fn>", "package:test", "dart:async/zone.dart"]));
await test.shouldExit(1); await test.shouldExit(1);
}); }, skip: 'Broken by sdk#32633');
test("doesn't dartify stack traces for JS-compiled tests with --js-trace", test("doesn't dartify stack traces for JS-compiled tests with --js-trace",
() async { () async {
......
...@@ -295,7 +295,7 @@ void main() { ...@@ -295,7 +295,7 @@ void main() {
await test.shouldExit(1); await test.shouldExit(1);
pub.kill(); pub.kill();
}, tags: 'node'); }, tags: 'node');
}); }, skip: 'Broken by sdk#32633');
group("doesn't dartify stack traces for JS-compiled tests with --js-trace", group("doesn't dartify stack traces for JS-compiled tests with --js-trace",
() { () {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment