Skip to content
Snippets Groups Projects
  1. Jun 15, 2018
  2. Jun 14, 2018
  3. Jun 13, 2018
  4. Jun 12, 2018
  5. Jun 11, 2018
    • Gary Roumanis's avatar
    • Nate Bosch's avatar
      Fix implicit casts in lib directory (#861) · 00e2e7d7
      Nate Bosch authored
      There are still errors in tests which may be harder to fix so we can't
      check in the change to analysis options.
      
      This should make it easier to diagnose Dart 2 semantic issues as more of
      the places where there can be failures are explicit.
      
      Most of the changes are just adding explicit `as` statements and keeping
      the semantics that already existed. In a few places an uninitialized
      `var` is given a type, and in others a reused variable name with
      different types is split into multiple variables.
      
      The changes in the frontend code are the most risky, since some users
      might still be using that code in a non Dart 2 runtime and relying on
      looseness which is lost with an explicit cast.
      
      Pin to the dev.60 SDK for now since there are failures on the newer SDK.
    • Nate Bosch's avatar
      Drop AsyncFunction typedef (#859) · 4302ce42
      Nate Bosch authored
      The typedef was misused to mean either `Function` or `Function()` in
      various places and worked because the difference was not checked. The
      doc comment was also incorrect because there were places it was used
      where a return value was explicitly necessary. Replace with an inline
      function type definition using the appropriate choice for the location.
      
      Where possible also replace with Function types that flow through the
      required return types.
  6. Jun 08, 2018
  7. Jun 07, 2018
  8. Jun 06, 2018
  9. Jun 05, 2018
  10. Jun 04, 2018
  11. Jun 01, 2018
    • Nate Bosch's avatar
      Drop sanitizeForWindows workaround (#845) · 0fe22192
      Nate Bosch authored
      We no longer support an SDK old enough that any of the referenced issues
      are still a problem.
    • Nate Bosch's avatar
      More Dart 2 runtime semantic fixes (#844) · cc537293
      Nate Bosch authored
      ```
      type 'WebSocketChannel' is not a subtype of type 'StreamChannel<String>' of 'channel'
      ```
      
      Cast the `WebSocketChannel` to indicate that all values in each
      direction will be `String`.
      
      ```
      type 'CloseGuaranteeChannel<dynamic>' is not a subtype of type 'VirtualChannel'
      ```
      
      Avoid using the `suiteChannel` variable for two types. It needs to start
      as a `VirtualChannel` which has the `id` field, and then later be a
      `StreamChannel`.
      
      ```
      type 'RunnerSuite' is not a subtype of type 'FutureOr<Future<RunnerSuite>>'
      ```
      
      Avoid the attempted Future flattening which was never correct but was
      supported in the Dart 1 VM.
  12. May 31, 2018
  13. May 30, 2018
  14. May 19, 2018
  15. May 14, 2018
  16. May 11, 2018
  17. May 10, 2018
  18. May 03, 2018
  19. May 02, 2018
Loading