Skip to content
Snippets Groups Projects
Commit 96c0d26d authored by keertip's avatar keertip
Browse files

Make package mime strong clean

BUG=https://github.com/dart-lang/mime/issues/5
R=kevmoo@google.com

Review URL: https://codereview.chromium.org//2561953002 .
parent b19e022e
No related branches found
No related tags found
No related merge requests found
analyzer:
strong-mode: true
......@@ -81,13 +81,13 @@ class BoundMultipartStream {
int _controllerState = _CONTROLLER_STATE_IDLE;
StreamController _controller;
StreamController<MimeMultipart> _controller;
Stream<MimeMultipart> get stream => _controller.stream;
StreamSubscription _subscription;
StreamController _multipartController;
StreamController<List<int>> _multipartController;
Map<String, String> _headers;
int _state = _START;
......
......@@ -25,13 +25,13 @@ enum TestMode { IMMEDIATE_LISTEN, DELAY_LISTEN, PAUSE_RESUME }
void _runParseTest(String message, String boundary, TestMode mode,
[List<Map> expectedHeaders, List expectedParts, bool expectError = false]) {
Future testWrite(List<int> data, [int chunkSize = -1]) {
StreamController controller = new StreamController(sync: true);
var controller = new StreamController<List<int>>(sync: true);
var stream =
controller.stream.transform(new MimeMultipartTransformer(boundary));
int i = 0;
var completer = new Completer();
var futures = [];
var futures = <Future>[];
stream.listen((multipart) {
int part = i++;
if (expectedHeaders != null) {
......@@ -91,7 +91,7 @@ void _runParseTest(String message, String boundary, TestMode mode,
Future testFirstPartOnly(List<int> data, [int chunkSize = -1]) {
var completer = new Completer();
var controller = new StreamController(sync: true);
var controller = new StreamController<List<int>>(sync: true);
var stream =
controller.stream.transform(new MimeMultipartTransformer(boundary));
......@@ -117,12 +117,12 @@ void _runParseTest(String message, String boundary, TestMode mode,
Future testCompletePartAfterCancel(List<int> data, int parts,
[int chunkSize = -1]) {
var completer = new Completer();
var controller = new StreamController(sync: true);
var controller = new StreamController<List<int>>(sync: true);
var stream =
controller.stream.transform(new MimeMultipartTransformer(boundary));
var subscription;
int i = 0;
var futures = [];
var futures = <Future>[];
subscription = stream.listen((multipart) {
int partIndex = i;
......
......@@ -93,7 +93,7 @@ void main() {
});
test('default magic number', () {
var actualMaxBytes = DEFAULT_MAGIC_NUMBERS.fold(0, (previous, magic) {
var actualMaxBytes = DEFAULT_MAGIC_NUMBERS.fold(0, (num previous, magic) {
return math.max(previous, magic.numbers.length);
});
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment