Drop support for --packages-dir flag (#1958)
Towards #1952 Drops support for the flag and updates tests that were depending on it or referring to it, but does not remove the supporting code. That will be done in a followup. - Parse but ignore the flag and warn when it is used. - Drop tests specifically for the packages dir behavior. - Remove unnecessary references to the flag. - Drop utility test code and constants for the packages dir. - Wherever possible replace checks for content within the packages dir with checks for content in the package spec, and sometimes cache. - When working with git shas which are unpredictable and have an ugly format in the package spec check instead for lines that contain the sha, or which have a package spec which either specificially did or did not change after an upgrade.
Showing
- lib/src/command/downgrade.dart 6 additions, 6 deletionslib/src/command/downgrade.dart
- lib/src/command/get.dart 7 additions, 4 deletionslib/src/command/get.dart
- lib/src/command/upgrade.dart 6 additions, 4 deletionslib/src/command/upgrade.dart
- test/descriptor.dart 0 additions, 18 deletionstest/descriptor.dart
- test/downgrade/doesnt_change_git_dependencies_test.dart 4 additions, 12 deletionstest/downgrade/doesnt_change_git_dependencies_test.dart
- test/get/broken_symlink_test.dart 0 additions, 48 deletionstest/get/broken_symlink_test.dart
- test/get/git/check_out_and_upgrade_test.dart 12 additions, 12 deletionstest/get/git/check_out_and_upgrade_test.dart
- test/get/git/check_out_branch_test.dart 9 additions, 6 deletionstest/get/git/check_out_branch_test.dart
- test/get/git/check_out_revision_test.dart 11 additions, 6 deletionstest/get/git/check_out_revision_test.dart
- test/get/git/check_out_test.dart 2 additions, 6 deletionstest/get/git/check_out_test.dart
- test/get/git/check_out_transitive_test.dart 3 additions, 7 deletionstest/get/git/check_out_transitive_test.dart
- test/get/git/check_out_twice_test.dart 2 additions, 6 deletionstest/get/git/check_out_twice_test.dart
- test/get/git/check_out_unfetched_revision_of_cached_repo_test.dart 4 additions, 6 deletions...git/check_out_unfetched_revision_of_cached_repo_test.dart
- test/get/git/check_out_with_trailing_slash_test.dart 8 additions, 5 deletionstest/get/git/check_out_with_trailing_slash_test.dart
- test/get/git/different_repo_name_test.dart 2 additions, 6 deletionstest/get/git/different_repo_name_test.dart
- test/get/git/doesnt_fetch_if_nothing_changes_test.dart 4 additions, 12 deletionstest/get/git/doesnt_fetch_if_nothing_changes_test.dart
- test/get/git/lock_version_test.dart 15 additions, 14 deletionstest/get/git/lock_version_test.dart
- test/get/git/locked_revision_without_repo_test.dart 15 additions, 14 deletionstest/get/git/locked_revision_without_repo_test.dart
- test/get/git/stay_locked_if_compatible_test.dart 4 additions, 12 deletionstest/get/git/stay_locked_if_compatible_test.dart
- test/get/git/unlock_if_incompatible_test.dart 19 additions, 12 deletionstest/get/git/unlock_if_incompatible_test.dart
Loading
Please register or sign in to comment