Skip to content
Snippets Groups Projects
Commit 2a27ff88 authored by gram@google.com's avatar gram@google.com
Browse files

Fix issue with async callbacks that get called synchronously while running...

Fix issue with async callbacks that get called synchronously while running test case function causing the test to be marked as complete prematurely.

Added an optional id to completion matchers that can be used in error messages (this was invaluable in tracking down the above problem).

Re-enable pub tests. https://code.google.com/p/dart/issues/detail?id=8862
Review URL: https://codereview.chromium.org//12393017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@19339 260f80e4-7a28-3924-810f-c04153c831b5
parent 1f5fcb6b
No related branches found
No related tags found
No related merge requests found
......@@ -9,9 +9,6 @@ pub_uploader_test: Pass,Fail
pub_lish_test: Pass, Fail # Issue 8868
validator_test: Pass, Fail # Issue 8868
# TODO(gram): These broke with r19269; investigating.
error_group_test: Fail
# Pub only runs on the VM, so just rule out all compilers.
[ $compiler == dart2js || $compiler == dart2dart ]
*: Skip
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment