Make Source.getDirectory synchronous.
It never really made sense for this to be asynchronous; most sources didn't even do any IO to determine the directory. The only exception was the git source, which would actually *clone a repository* if one didn't exist yet. This heavyweight behavior wasn't a good fit for what looks like a lightweight method anyway. Making this synchronous has a ripple effect of making a bunch of other methods synchronous, too. Hooray for synchrony! R=rnystrom@google.com Review URL: https://codereview.chromium.org//1276673006 .
Showing
- lib/src/command/cache_add.dart 1 addition, 1 deletionlib/src/command/cache_add.dart
- lib/src/command/list_package_dirs.dart 9 additions, 16 deletionslib/src/command/list_package_dirs.dart
- lib/src/entrypoint.dart 21 additions, 25 deletionslib/src/entrypoint.dart
- lib/src/global_packages.dart 8 additions, 12 deletionslib/src/global_packages.dart
- lib/src/source.dart 7 additions, 4 deletionslib/src/source.dart
- lib/src/source/cached.dart 11 additions, 10 deletionslib/src/source/cached.dart
- lib/src/source/git.dart 18 additions, 19 deletionslib/src/source/git.dart
- lib/src/source/hosted.dart 4 additions, 7 deletionslib/src/source/hosted.dart
- lib/src/source/path.dart 1 addition, 2 deletionslib/src/source/path.dart
- lib/src/source/unknown.dart 1 addition, 1 deletionlib/src/source/unknown.dart
- lib/src/system_cache.dart 4 additions, 2 deletionslib/src/system_cache.dart
- test/lock_file_test.dart 1 addition, 1 deletiontest/lock_file_test.dart
- test/pubspec_test.dart 1 addition, 1 deletiontest/pubspec_test.dart
- test/version_solver_test.dart 1 addition, 3 deletionstest/version_solver_test.dart
Loading
Please register or sign in to comment