Commits · 6c3517658eb05f796fc633c03e63f99332063a07 · fuchsia-mirror / dart.googlesource.com-pub

May 28, 2015

Expect pub to live in pkg_tested in the SDK repo. · 6c351765
Natalie Weizenbaum authored 9 years ago
```
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1161873009
```
6c351765
- Update expected string in pub test. · 7efa5a8c
Ivan Posva authored 9 years ago
```
BUG=

Review URL: https://codereview.chromium.org//1159983005
```
7efa5a8c

- Include original, loaded URI in error message. · 947c1dd0

Ivan Posva authored 9 years ago

- Update error string comparison in pub.

BUG=

Review URL: https://codereview.chromium.org//1156983003

947c1dd0

Escape arguments in pub error message command line reproduction. · 2c051a14

William Hesse authored 9 years ago

BUG=dartbug.com/23505
Rebase of https://codereview.chromium.org/1035853003/

R=nweiz@google.com

Review URL: https://codereview.chromium.org//1156663002

2c051a14

Always ignore non-public transformers. · ef743d58

Natalie Weizenbaum authored 9 years ago

This was happening for the most part, but the dependency computer could
get tripped up when a package used a transformer from a dev dependency
on only private files.

R=rnystrom@google.com
BUG= http://dartbug.com/23480

Review URL: https://codereview.chromium.org//1143453006

ef743d58

Update README.md · 8ec94a2b
Kathy Walrath authored 9 years ago

8ec94a2b

Fix a crash in pub's version solver. · 23826187

nweiz@google.com authored 9 years ago

The solver was choking when pub's implicit dependencies on barback
failed and had to be backtracked.

R=rnystrom@google.com
TBR

Review URL: https://codereview.chromium.org//1142693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45832 260f80e4-7a28-3924-810f-c04153c831b5

23826187

Load SDK sources from compiler_unsupported. · 6f379bd4

Natalie Weizenbaum authored 9 years ago

When running from the pub repo, dart2js needs to see SDK sources that
match up with its own version. compiler_unsupported contains its own
copy of the SDK for exactly this purpose; this CL loads SDK sources from
that copy when running tests from the pub repo.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1155583007

6f379bd4

Remove a conflicting definition of runningAsTest. · 7a09eba5

Natalie Weizenbaum authored 9 years ago

It turns out this variable already existed, with slightly different
semantics. Everything has now been updated, so "runningAsTest" means
running in a test file and "runningFromTest" means running in pub called
by a test file.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1145373006

7a09eba5

May 22, 2015
- Use "package:" imports for pub. · a2373cc5
  Natalie Weizenbaum authored 9 years ago
```
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1153643002
```
  a2373cc5
May 21, 2015

Move assets into lib/src. · 3a6ce000
Natalie Weizenbaum authored 9 years ago
```
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1145973003
```
3a6ce000

Change the way we look up packages for tests. · 3bcc99ab

Natalie Weizenbaum authored 9 years ago

Instead of looking in the repo's third party deps, this uses the
packages installed for pub in the package cache. Archived versions of
barback and source_maps are included via Git submodules.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1147233002

3bcc99ab

Fix asset and SDK path detection. · 99f642af
Natalie Weizenbaum authored 9 years ago
```
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1145993003
```
99f642af

May 20, 2015
- Use an auto-generated pub snapshot for tests. · a620958d
  Natalie Weizenbaum authored 9 years ago
```
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1148443005
```
  a620958d
May 15, 2015

Use package:compiler_unsupported for development. · d6ec5e35
Natalie Weizenbaum authored 9 years ago

d6ec5e35
Add template files. · 0cdd4e13
Natalie Weizenbaum authored 9 years ago

0cdd4e13

Fix VersionSelection.getDependenciesOn. · 5aabadfb

nweiz@google.com authored 9 years ago

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1130263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45803 260f80e4-7a28-3924-810f-c04153c831b5

5aabadfb

Rewrite pub's version solver. · f401f117

nweiz@google.com authored 9 years ago

The idea of this change is to eagerly check, before selecting a package version,
whether that version is compatible with the existing dependencies. This avoids a
bunch of unnecessary backtracking, and makes the progression of the solver more
comprehensible when

R=rnystrom@google.com
BUG= dartbug.com/17429

Review URL: https://codereview.chromium.org//1140083005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45799 260f80e4-7a28-3924-810f-c04153c831b5

f401f117

May 14, 2015

pub: don't start the admin server if no --admin-port flag was given. · 73f4e1ee

floitsch@google.com authored 9 years ago

`pub serve` used to bind its admin port to the port below the main port. For example `pub serve --port=8081` would automatically bind its admin port to 8080.
With this change the admin server is only started if an --admin-port flag was provided.

BUG= http://dartbug.com/20922
R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45614
Reverted: https://code.google.com/p/dart/source/detail?r=45633

Review URL: https://codereview.chromium.org//1126403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45675 260f80e4-7a28-3924-810f-c04153c831b5

73f4e1ee

Revert "pub: don't start the admin server if no --admin-port flag was given." · 8ebffd52

ricow@google.com authored 9 years ago

This reverts commit 45614

Causes redness on the bots, floitsch@ will investigate offline

R=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//1129403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45633 260f80e4-7a28-3924-810f-c04153c831b5

8ebffd52

Fix an invalid variable name in DependencyQueue. · 3c3b7295

nweiz@google.com authored 9 years ago

Also fix an analysis hint.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1126263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45622 260f80e4-7a28-3924-810f-c04153c831b5

3c3b7295

pub: don't start the admin server if no --admin-port flag was given. · 581c006c

floitsch@google.com authored 9 years ago

`pub serve` used to bind its admin port to the port below the main port. For example `pub serve --port=8081` would automatically bind its admin port to 8080.
With this change the admin server is only started if an --admin-port flag was provided.

BUG= http://dartbug.com/20922
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1126403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45614 260f80e4-7a28-3924-810f-c04153c831b5

581c006c

Convert a bunch of version solver code to use async/await. · d0f2ff71

nweiz@google.com authored 9 years ago

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1125373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45612 260f80e4-7a28-3924-810f-c04153c831b5

d0f2ff71

Remove dart2dart support from testing scripts and status files · 266a2e6f

ricow@google.com authored 9 years ago

I will leave it to the dart2js people to remove the support from the dart2js tools (there is also a bunch of comments still in code, do a git grep)

R=kustermann@google.com, floitsch@google.com, kmillikin@google.com
BUG=

Review URL: https://codereview.chromium.org//1126363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45588 260f80e4-7a28-3924-810f-c04153c831b5

266a2e6f

Fix or work around failing pub tests. · d541a9a8

nweiz@google.com authored 9 years ago

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1123323003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45572 260f80e4-7a28-3924-810f-c04153c831b5

d541a9a8

Cache pubspecs when HostedSource.getVersions is called. · e5d84f70

nweiz@google.com authored 9 years ago

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1113363004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45571 260f80e4-7a28-3924-810f-c04153c831b5

e5d84f70

Fix version solver tests. · 54006da6

nweiz@google.com authored 9 years ago

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1128683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45545 260f80e4-7a28-3924-810f-c04153c831b5

54006da6

Don't let the version solver starve the event queue. · 59774587

nweiz@google.com authored 9 years ago

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1127863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45543 260f80e4-7a28-3924-810f-c04153c831b5

59774587

Fix version solving in pub. · 4eef44a6

nweiz@google.com authored 9 years ago

I deleted a line in r45508 because it had an unused variable, but it
turned out that it also had relevant side-effects.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1123473005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45513 260f80e4-7a28-3924-810f-c04153c831b5

4eef44a6

Fix all the analysis hints in pub. · 2e0ad9e7

nweiz@google.com authored 9 years ago

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1101343004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45508 260f80e4-7a28-3924-810f-c04153c831b5

2e0ad9e7

Support defining environment constants for dart2js via the command-line. · 61aefab4

nweiz@google.com authored 9 years ago

These constants only work for dart2js because neither Dartium nor the isolate
API support defining them.

BUG= http://dartbug.com/15806
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1106713003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45416 260f80e4-7a28-3924-810f-c04153c831b5

61aefab4

Properly print an error when failing to load a transformer. · d6427a16

nweiz@google.com authored 9 years ago

R=rnystrom@google.com
BUG= http://dartbug.com/21490

Review URL: https://codereview.chromium.org//1106803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45414 260f80e4-7a28-3924-810f-c04153c831b5

d6427a16

Fix off-by-one error in https://code.google.com/p/dart/source/detail?r=45153 · 9e106d45

dgrove@google.com authored 9 years ago

and https://code.google.com/p/dart/source/detail?r=45154 .

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1055283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45189 260f80e4-7a28-3924-810f-c04153c831b5

9e106d45

dart2js implementation of StringBuffer.writeAll that optimizes better. · 482c7c9e

sra@google.com authored 9 years ago

Sometimes we can avoid the StringBuffer object:

    t1 = new P.StringBuffer(leftDelimiter);
    t1.writeAll$2(parts, ", ");
    t1 = t1._contents += rightDelimiter;
    return t1.charCodeAt(0) == 0 ? t1 : t1;
-->
    t1 = P.StringBuffer__writeAll(leftDelimiter, parts, ", ") + rightDelimiter;
    return t1.charCodeAt(0) == 0 ? t1 : t1;

Also updated tests with missing cases.

R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45184
Reverted: https://code.google.com/p/dart/source/detail?r=45186

Review URL: https://codereview.chromium.org//1086043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45188 260f80e4-7a28-3924-810f-c04153c831b5

482c7c9e

Update pub 404-page-test to expect . instead of /. · f47e8ee9

lrn@google.com authored 9 years ago

Review URL: https://codereview.chromium.org//1073953005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45154 260f80e4-7a28-3924-810f-c04153c831b5

f47e8ee9

Clear out outdated binary snapshots when installing. · 20ef4aff

nweiz@google.com authored 9 years ago

BUG= http://dartbug.com/23113
R=kevmoo@google.com

Review URL: https://codereview.chromium.org//1087053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45147 260f80e4-7a28-3924-810f-c04153c831b5

20ef4aff

Delete windows signal test · 2066c859

sigmund@google.com authored 9 years ago

BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//1076003003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45033 260f80e4-7a28-3924-810f-c04153c831b5

2066c859

Fix hanging process (kill of parent process leaves child as a zombie) · 142bd07b

sigmund@google.com authored 9 years ago

R=nweiz@google.com

Review URL: https://codereview.chromium.org//1075963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45026 260f80e4-7a28-3924-810f-c04153c831b5

142bd07b

Fix windows signal test · ab804834

sigmund@google.com authored 9 years ago

(this amends a bit the changes in
https://code.google.com/p/dart/source/detail?r=44902)

R=kevmoo@google.com

Review URL: https://codereview.chromium.org//1078803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45020 260f80e4-7a28-3924-810f-c04153c831b5

ab804834

Fix nonexistent script test in windows · f66817c0

sigmund@google.com authored 9 years ago

R=kevmoo@google.com

Review URL: https://codereview.chromium.org//1077683003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45018 260f80e4-7a28-3924-810f-c04153c831b5

f66817c0