- Mar 15, 2017
-
-
Jacob MacDonald authored
-
- Mar 10, 2017
-
-
Natalie Weizenbaum authored
"git ls-files" doesn't recurse into submodules, so we need to do so manually. Closes #1523
-
- Aug 01, 2016
-
-
Natalie Weizenbaum authored
R=rnystrom@google.com Review URL: https://codereview.chromium.org//2184303002 .
-
- Jun 23, 2016
-
-
Natalie Weizenbaum authored
This allows PackageName equality to include description equality, and it substantially cleans up other logic dealing with sources. See #912 R=rnystrom@google.com Review URL: https://codereview.chromium.org//2079303003 .
-
- May 05, 2016
-
-
Natalie Weizenbaum authored
We had a logic error wherein we were checking dependencies only for cached packages when we should have been checking them only for *uncached* packages. R=rnystrom@google.com Review URL: https://codereview.chromium.org//1956543002 .
-
- Apr 05, 2016
-
-
Natalie Weizenbaum authored
"git ls-files" doesn't natively resolve symlinks, so this adds some logic to do so manually. This brings the behavior of uploading from a Git repo in line with non-Git uploading. We still don't have a multipart parser in Dart, so we unfortunately have to way of writing automated tests that the tarballs are created as expected. I did verify this behavior locally, though. Closes #1400 R=rnystrom@google.com Review URL: https://codereview.chromium.org//1862833002 .
-
- Jan 13, 2016
-
-
Natalie Weizenbaum authored
R=rnystrom@google.com Review URL: https://codereview.chromium.org//1585513002 .
-
- Dec 17, 2015
-
-
Natalie Weizenbaum authored
This folds the distinction between "resolved" and "unresolved" descriptions into the distinction between PackageIds and PackageRefs. In other words, all PackageIds now have resolved descriptions and all PackageRefs now have unresolved descriptions. This makes it easier to track which descriptions are resolved and express resolution constraints via the type system. This also restricts the creation of PackageRefs and PackageIds to source classes, which helps ensure that the description format—which is an implementation detail—doesn't leak into surrounding code. R=rnystrom@google.com Review URL: https://codereview.chromium.org//1528523003 .
-
- Aug 27, 2015
-
-
Natalie Weizenbaum authored
If the root directory of a package is .gitignored, it will no longer be considered to be a "git package", since that just means that it'll be seen to contain no files at all. Closes #1321 R=rnystrom@google.com Review URL: https://codereview.chromium.org//1317043002 .
-
Natalie Weizenbaum authored
Pub won't upload gitignored files, so its validation shouldn't consider them to exist either. See #1321 R=rnystrom@google.com Review URL: https://codereview.chromium.org//1310253007 .
-
- Jul 10, 2015
-
-
Natalie Weizenbaum authored
Closes #1296 R=rnystrom@google.com Review URL: https://codereview.chromium.org//1233533002 .
-
- Jul 09, 2015
-
-
Natalie Weizenbaum authored
* Normalize paths before they're passed to dart2js. It handles "." and ".." path components poorly. * Ensure that paths emitted by list-package-dirs are always absolute and normalized for backwards-compatibility with the existing protocol. * Make Package.listFiles work for an in-memory package. * Fix an error message expectation in packages_file_test. R=rnystrom@google.com Review URL: https://codereview.chromium.org//1228683003 .
-
- May 28, 2015
-
-
nweiz@google.com authored
The solver was choking when pub's implicit dependencies on barback failed and had to be backtracked. R=rnystrom@google.com TBR Review URL: https://codereview.chromium.org//1142693002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45832 260f80e4-7a28-3924-810f-c04153c831b5
-
- May 15, 2015
-
-
nweiz@google.com authored
The idea of this change is to eagerly check, before selecting a package version, whether that version is compatible with the existing dependencies. This avoids a bunch of unnecessary backtracking, and makes the progression of the solver more comprehensible when R=rnystrom@google.com BUG= dartbug.com/17429 Review URL: https://codereview.chromium.org//1140083005 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45799 260f80e4-7a28-3924-810f-c04153c831b5
-
- May 14, 2015
-
-
rnystrom@google.com authored
R=nweiz@google.com Review URL: https://codereview.chromium.org//602253002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40849 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
(Still use it for publishing.) BUG=https://code.google.com/p/dart/issues/detail?id=9841 R=nweiz@google.com Review URL: https://codereview.chromium.org//599303002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40661 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
BUG=20859 R=rnystrom@google.com Review URL: https://codereview.chromium.org//583853002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40612 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG=https://code.google.com/p/dart/issues/detail?id=18539 R=nweiz@google.com Review URL: https://codereview.chromium.org//566093003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40471 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
R=rnystrom@google.com BUG=20483 Review URL: https://codereview.chromium.org//475093003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39787 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG=https://code.google.com/p/dart/issues/detail?id=20628 R=nweiz@google.com Review URL: https://codereview.chromium.org//485893008 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39502 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
R=rnystrom@google.com Review URL: https://codereview.chromium.org//489943002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39437 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
R=rnystrom@google.com BUG=20482 Review URL: https://codereview.chromium.org//482053002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39424 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
R=rnystrom@google.com Review URL: https://codereview.chromium.org//345413004 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@37616 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
R=rnystrom@google.com TBR Review URL: https://codereview.chromium.org//332003003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@37528 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
In r37514 I incorrectly assumed that the problem was Directory.list when in fact it's git. R=rnystrom@google.com Review URL: https://codereview.chromium.org//349503003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@37527 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
In particular, this makes barback and the "pub lish" validators use gitignore rules. R=rnystrom@google.com BUG=12102, 11198 Review URL: https://codereview.chromium.org//342553002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@37469 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG=https://code.google.com/p/dart/issues/detail?id=10582 R=nweiz@google.com Review URL: https://codereview.chromium.org//344493003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@37464 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG=https://code.google.com/p/dart/issues/detail?id=5391 RELNOTE=Add "pub cache repair" command to re-install cached packages. R=nweiz@google.com Review URL: https://codereview.chromium.org//228703006 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@35111 260f80e4-7a28-3924-810f-c04153c831b5
-
jmesserly@google.com authored
* missing returns * unused imports R=rnystrom@google.com Review URL: https://codereview.chromium.org//184823012 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@33298 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
1. Take overrides into account. 2. Do get if a cache package is not installed. BUG=http://dartbug.com/14590, http://dartbug.com/15180 R=nweiz@google.com Review URL: https://codereview.chromium.org//83173011 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@30832 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
- Parse them in pubspec. - Pass them to solver. - Warn when they are used. - Error on publish. BUG=https://code.google.com/p/dart/issues/detail?id=8566 R=nweiz@google.com Review URL: https://codereview.chromium.org//74013007 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@30376 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
The code for parsing the package descriptions had gotten increasingly hacky. This unhacks it. R=nweiz@google.com Review URL: https://codereview.chromium.org//72193002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@30264 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG=https://code.google.com/p/dart/issues/detail?id=7351 R=nweiz@google.com Review URL: https://codereview.chromium.org//26284002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@28330 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG= R=nweiz@google.com Review URL: https://codereview.chromium.org//23702061 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@27977 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
The user-visible effect of this is to make operations that only look at part of a pubspec work if other parts of the pubspec are somehow invalid. This is particularly important for the following scenario: 1. We release a version of pub in SDK 1.0.0 that parses pubspec field "foo" as an integer. 2. Sally uploads version 0.1.0 of her package, libsally. 3. We release a new version of pub in SDK 1.1.0 that supports strings in "foo". 4. Sally uploads libsally 0.2.0, which uses a string in "foo". The new version of libsally has an SDK constraint of ">= 1.1.0", since it uses the new "foo" feature. 5. Tom is using SDK 1.0.0 and runs "pub install" in a package that depends on libsally. Everyone's done everything right here; we made a backwards-compatible pubspec change, Sally chose the correct SDK constraint, and Tom has a dependency on a package that has a compatible version available. However, prior to this change, Tom's "pub install" would crash. His outdated version of pub would try and fail to parse libsally 0.2.0's "foo" field, and his version resolution would crash. With this change, it will only attempt to parse the SDK constraint portion of Sally's pubspec, and ignore anything else it doesn't understand. R=rnystrom@google.com BUG= Review URL: https://codereview.chromium.org//24246002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@27784 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG= R=nweiz@google.com Review URL: https://codereview.chromium.org//22941002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@26040 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
R=nweiz@google.com Review URL: https://codereview.chromium.org//21147002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@25648 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
R=ajohnsen@google.com Review URL: https://codereview.chromium.org//18356011 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@24964 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
R=nweiz@google.com Review URL: https://codereview.chromium.org//18143002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@24555 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
Review URL: https://codereview.chromium.org//16034002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@23182 260f80e4-7a28-3924-810f-c04153c831b5
-