Skip to content
Snippets Groups Projects
Unverified Commit 590abf70 authored by Nate Bosch's avatar Nate Bosch Committed by GitHub
Browse files

Remove an unnecessary await on event loop (#1164)

Closes #865

Move a `pumpEventQueue` to fix a failing test.

The test was passing because of the extra event loop cycle in
`close()`. The intent of the test is to check behavior when a test
hasn't completed yet. By closing immediately the test was actually
looking at behavior of when the tests hadn't even been declared yet, and
the extra `await` was hiding that.

Reorder the closing of the `_suiteController` and
`_onSuiteAddedController`. Values flow first through the
`_suitController` and then to the `_onSuitAddedController`. I saw at
least one case where a value flowed through late and cause an error
attempting to add a value on a closed controller.
parent 26ba571a
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment