- Nov 03, 2011
-
-
Craig Silverstein authored
A user reported a bug that configure should die when g++ isn't installed, but wasn't: http://code.google.com/p/google-perftools/issues/detail?id=217 This turned out to be a bug in autoconf: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=357378 The workaround is simple: check for CXX before checking for CC. This means that if g++ is installed but gcc isn't, we won't die (at cc-checking time), but I tested, and the configure script dies later. In any case, it seems unlikely someone would have a c++ compiler installed but not a c compiler. This fixes the 4 opensource projects I work on that are susceptible to this. R=iant DELTA=1437 (694 added, 694 deleted, 49 changed) Revision created by MOE tool push_codebase. MOE_MIGRATION=3222 git-svn-id: https://gflags.googlecode.com/svn/trunk@66 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
Craig Silverstein authored
Now I can get rid of the old constructor! R=jkline,ncalvin DELTA=28 (0 added, 27 deleted, 1 changed) Revision created by MOE tool push_codebase. MOE_MIGRATION=3169 git-svn-id: https://gflags.googlecode.com/svn/trunk@65 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
Craig Silverstein authored
http://code.google.com/p/google-gflags/issues/detail?id=45 reports that the error isn't always getting flushed on cygwin. So do that explicitly. R=desovski DELTA=1 (1 added, 0 deleted, 0 changed) Revision created by MOE tool push_codebase. MOE_MIGRATION=3140 git-svn-id: https://gflags.googlecode.com/svn/trunk@64 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
Craig Silverstein authored
Report category names via the xml help output (but not, yet, during 'normal' help output). R=ncalvin DELTA=3 (3 added, 0 deleted, 0 changed) Revision created by MOE tool push_codebase. MOE_MIGRATION=3066 git-svn-id: https://gflags.googlecode.com/svn/trunk@63 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
Craig Silverstein authored
Add back in a backwards-compatible constructor for FlagRegisterer. Because this backwards-compatible API is intended to be short-lived, I did it in the simplest, least invasive way possible, which involved cutting-and-pasting. R=ncalvin,jkline DELTA=27 (27 added, 0 deleted, 0 changed) Revision created by MOE tool push_codebase. MOE_MIGRATION=3065 git-svn-id: https://gflags.googlecode.com/svn/trunk@62 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
Craig Silverstein authored
NOTE: I'm checking this in just to have a record in source control of the idea. We've decided for now it doesn't make sense to go forward with flag categories -- and the __VA_ARGS__ for macros has caused lots of problems with uncaught accidental commas, already -- so a future commit will back this out. (Actually, it's all a series of commits, for annoying technical reasons.) Add support for flag categories. In this CL, all you can do is set categories in the DEFINE_* macros and then retrieve them via GetCommandLineFlagInfo and similar. In future CLs, we will start to give some semantic meaning to particular flag values, as described in the designdoc. In particular, we will start to use flag categories to revamp --help output. Implementation-wise: to keep categories an optional macro argument, I had to use __VA_ARGS__, which means future gflags releases will no longer work with MSVC 7.1. We're at MSVC 10 now, so I'm pretty much ok with that. The downside of __VA_ARGS__ is there is no error if you specify more args after the ones we expect. To get around that, I only use __VA_ARGS_ in this idiom: static const OptionalDefineArgs var = { __VA_ARGS__ }; The new OptionalDefineArgs struct defines all the args that may be optionally specified in the DEFINE_* macros. For now, that's only the 'categories' arg, though in theory more could be added later. R=titus,ncalvin DELTA=92 (54 added, 3 deleted, 35 changed) Revision created by MOE tool push_codebase. MOE_MIGRATION=3057 git-svn-id: https://gflags.googlecode.com/svn/trunk@61 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Aug 18, 2011
-
-
Craig Silverstein authored
Clean up the 'GFLAGS_DLL_DECL' stuff better: reduce use outside of windows/ directory. R=jyrki DELTA=33 (0 added, 27 deleted, 6 changed) Revision created by MOE tool push_codebase. MOE_MIGRATION=3016 git-svn-id: https://gflags.googlecode.com/svn/trunk@60 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Aug 04, 2011
-
-
Craig Silverstein authored
Fix a bug in StringPrintf() that caused it to not print large strings properly. R=nilton DELTA=1 (0 added, 0 deleted, 1 changed) Revision created by MOE tool push_codebase. MOE_MIGRATION=2886 git-svn-id: https://gflags.googlecode.com/svn/trunk@59 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
Craig Silverstein authored
Add a new unittest case, that tests the --help output for a really long helpstring. Opensource gflags had a bug where we were cutting off the output too soon; this test should protect against such a thing. R=nilton DELTA=16 (16 added, 0 deleted, 0 changed) Revision created by MOE tool push_codebase. MOE_MIGRATION=2885 git-svn-id: https://gflags.googlecode.com/svn/trunk@58 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Jul 30, 2011
-
-
Craig Silverstein authored
Ready to release gflags 1.6! * google-gflags: version 1.6 * BUGFIX: Fix a bug where we were leaving out a required $(top_srcdir) * Fix definition of clstring (jyrki) * Split up flag declares into its own file (jyrki) * Add --version support (csilvers) * Update teh README for gflags with static libs * Update acx_pthread.m4 for nostdlib * Change REparseCommandLineFlags to return void (csilvers) * Some doc typofixes and example augmentation (various) R=jperkins DELTA=44 (41 added, 0 deleted, 3 changed) Revision created by MOE tool push_codebase. MOE_MIGRATION=2838 git-svn-id: https://gflags.googlecode.com/svn/trunk@56 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
Craig Silverstein authored
It turns out we don't want all this dll-decl stuff for mingw. So make the #ifdef correct for mscv-but-not-mingw. I think the right fix would be to take all this logic out and insert it via a MOE directive, just for the windows versions of these files. This is what ctemplate does. But it's a more-major change, and I'm looking to get this release out today, so I'm submitting this (TBR), since it's a much more minor change. Revision created by MOE tool push_codebase. MOE_MIGRATION=2837 git-svn-id: https://gflags.googlecode.com/svn/trunk@55 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Jul 29, 2011
-
-
Craig Silverstein authored
mingw fixes: 1) mingw needs an #include to have access to mkdir. 2) It needs to always #include port.h (this is an identical bit of code, in configure.ac, that I have in other opensource projects for mingw support.) 3) I moved some code from port.cc to port.h, so I didn't have to add logic to link in port.cc for mingw. Last change before new release! (*knock on wood*) Submitting TBR so I can get the release out today. This isn't exactly a trivial change, so I'm chary to submit TBR, but it's pretty isolated to windows and mingw, and I've tested on those platforms to make sure they compile and all tests pass. DELTA=70 (37 added, 30 deleted, 3 changed) Revision created by MOE tool push_codebase. MOE_MIGRATION=2823 git-svn-id: https://gflags.googlecode.com/svn/trunk@54 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
Craig Silverstein authored
version of autotools (taht we're using now). Get rid of them to clean up the svn tree. Also get rid of the 'python' file -- I don't know what that is, but it's been a long time since the python version of gflags has moved to its own project. git-svn-id: https://gflags.googlecode.com/svn/trunk@53 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
Craig Silverstein authored
maintaining this opensource tree. Some of this reorganization is entirely a result of reorganization: blank lines in a few different places, etc. Here are the others: 1) I've added a new file, util.h, with lots of new, helpful routines, most notably StringPrintf (printf returning a string). I've also moved some routines from the .cc and unittest.cc file here, such as the CHECK macros, testing framework, and #ifdefs for 16-bit ints. Quite a bit of code was rewritten to use these new routines. 2) I noticed that the special-case setenv() code was only needed for windows systems, so I moved it to port.h/cc. 3) I also had to add a new vsnprintf wrapper in port.h/cc, to support StringPrintf. 4) A few places I used an old name, commandlineflags, instead of gflags. Most or all of these should be fixed now. 5) Some of my copyright dates weren't quite right. Fixed them up. 6) In some .cc files, I added using directives to not have to use std:: so much. 7) I've added a minor new test, adding 10000 or so flags to see how the system scales. 8) Some compile-warning fixes, such as int -> size_t when appropriate, and better protected #defines in mutex.h 9) The .h files gained some logic defining GFLAGS_DLL_DECL. This is true even for .h files outside the windows directory, which will never have these dll issues. But one big advantage of my new organization is auto-generating the windows versions of these files from the unix versions, so there's some unnecessary (but harmless) duplication as a result. 10) Fixed a bug in rpm.sh which would cause an unnecessary crash when dpkg was missing. git-svn-id: https://gflags.googlecode.com/svn/trunk@52 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
Craig Silverstein authored
(from 2.65). I'm moving to a new system for maintaining the opensource version, which involves using a 'hermetic' version of autotools, and those are the versions installed in the hermetic system. There shouldn't be a user-noticeable change here. git-svn-id: https://gflags.googlecode.com/svn/trunk@51 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Jul 28, 2011
-
-
Craig Silverstein authored
* Fix a bug where we were leaving out a required $(top_srcdir) git-svn-id: https://gflags.googlecode.com/svn/trunk@50 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- May 19, 2011
-
-
Craig Silverstein authored
git-svn-id: https://gflags.googlecode.com/svn/trunk@49 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Apr 21, 2011
-
-
Craig Silverstein authored
* Add --version support (csilvers) * Fix doc typo (sudit) * Update the README instructions for gflags with static libs (csilvers) git-svn-id: https://gflags.googlecode.com/svn/trunk@48 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Mar 03, 2011
-
-
Craig Silverstein authored
which is then displayed in --version. git-svn-id: https://gflags.googlecode.com/svn/trunk@47 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Mar 02, 2011
-
-
Craig Silverstein authored
* Typo fix in docs (bogdand) * Change ReparseCommandLineFlags to return void (csilvers) git-svn-id: https://gflags.googlecode.com/svn/trunk@46 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Jan 25, 2011
-
-
Craig Silverstein authored
* google-gflags: version 1.5 * Better reporting of current vs default value (handler) * Add API for cleaning up of memory at program-exit (jmarantz) * Fix macros to work inside namespaces (csilvers) * Use our own string typedef in case string is redefined (csilvers) * Updated to autoconf 2.65 git-svn-id: https://gflags.googlecode.com/svn/trunk@44 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Jan 14, 2011
-
-
Craig Silverstein authored
* Remove superfluous friend declaration (mec) * Better reporting of current vs default value (handler) * Allow cleaning up of memory at program-exit (jmarantz) * Put CompileAssert in correct namespace (csilvers) git-svn-id: https://gflags.googlecode.com/svn/trunk@43 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Nov 16, 2010
-
-
Craig Silverstein authored
* Set up configure.ac to give proper library version numbers (csilvers) * Update from autoconf 2.64 to 2.65. Also hermeticize libtool a bit git-svn-id: https://gflags.googlecode.com/svn/trunk@42 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Oct 14, 2010
-
-
Craig Silverstein authored
* google-gflags: version 1.4 * Add a check to prevent passing 0 to DEFINE_string (jorg) * Reduce compile (.o) size (jyrki) * Some small changes to quiet debug compiles (alexk) * PORTING: better support static linking on windows (csilvers) * DOCUMENTATION: change default values, use validators, etc. * Update the NEWS file to be non-empty * Add pkg-config (.pc) files for libgflags and libgflags_nothreads git-svn-id: https://gflags.googlecode.com/svn/trunk@40 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Sep 16, 2010
-
-
Craig Silverstein authored
* Document how to change the default flag value (csilvers) * Add a windows-specific README (csilvers) * A few comment updates (wojtekm) git-svn-id: https://gflags.googlecode.com/svn/trunk@39 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- May 07, 2010
-
-
Craig Silverstein authored
* Fixed email address in maintainers to actually work (csilvers) * Update docs with info on validators (wojtekm) git-svn-id: https://gflags.googlecode.com/svn/trunk@38 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Mar 10, 2010
-
-
Craig Silverstein authored
* Better error message on parse failure (tstromberg) git-svn-id: https://gflags.googlecode.com/svn/trunk@37 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Jan 05, 2010
-
-
Craig Silverstein authored
* google-gflags: version 1.3 * PORTABILITY: can now build and run tests under MSVC (csilvers) * Remove the python gflags code, which is now its own package (tansell) * Clarify that "last flag wins" in the docs (csilvers) * Comment danger of using GetAllFlags in validators (wojtekm) * PORTABILITY: Some fixes necessary for c++0x (mboerger) * Makefile fix: $(srcdir) -> $(top_srcdir) in one place (csilvres) * INSTALL: autotools to autoconf v2.64 + automake v1.11 (csilvers) git-svn-id: https://gflags.googlecode.com/svn/trunk@35 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Nov 10, 2009
-
-
Craig Silverstein authored
* Comment danger of using GetAllFlags in validators (wojtekm) * Add python support for gnu_getopt (hobe) * DEFINE_list now accepts a list as a default (dsturtevant) * TMPDIR -> TEST_TMPDIR in Makefile, fixing objcopy behavior (csilvers) * Fix the 'cp' command to use $(top_srcdir) in the Makefile (csilvers) git-svn-id: https://gflags.googlecode.com/svn/trunk@34 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Sep 11, 2009
-
-
Craig Silverstein authored
* google-gflags: version 1.2 * PORTABILITY: can now build and run tests under mingw (csilvers) * Using a string arg for a bool flag is a compile-time error (rbayardo) * Add --helpxml to gflags.py (salcianu) * Protect against a hypothetical global d'tor mutex problem (csilvers) * BUGFIX: can now define a flag after 'using namespace google' (hamaji) git-svn-id: https://gflags.googlecode.com/svn/trunk@32 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Jul 17, 2009
-
-
Craig Silverstein authored
http://code.google.com/p/google-gflags/issues/detail?id=24 git-svn-id: https://gflags.googlecode.com/svn/trunk@31 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Apr 15, 2009
-
-
Craig Silverstein authored
* google-gflags: version 1.1 * Add both foo and nofoo for boolean flags, with --undefok (andychu) * Better document how validators work (wojtekm) * Improve binary-detection for bash-completion (mtamsky) * Python: Add a concept of "key flags", used with --help (salcianu) * Python: Robustify flag_values (salcianu) * Python: Add a new DEFINE_bool alias (keir, andrewliu) * Python: Do module introspection based on module name (dsturtevant) * Fix autoconf a bit better, especially on windows and solaris (ajenjo) * BUG FIX: gflags_nothreads was linking against the wrong lib (ajenjo) * BUG FIX: threads-detection failed on FreeBSD; replace it (ajenjo) * PORTABILITY: Quiet an internal compiler error with SUSE 10 (csilvers) * PORTABILITY: Update deb.sh for more recenty debuilds (csilvers) * PORTABILITY: #include more headers to satify new gcc's (csilvers) * INSTALL: Updated to autoconf 2.61 and libtool 1.5.26 (csilvers) git-svn-id: https://gflags.googlecode.com/svn/trunk@29 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Sep 19, 2008
-
-
Craig Silverstein authored
* google-gflags: version 1.0rc2 * Report current flag values in --helpxml (hdn) * Fix compilation troubles with gcc 4.3.3 (simonb) * BUG FIX: I was missing a std:: in DECLARE_string (csilvers) * BUG FIX: Clarify in docs how to specify --bool flags (csilvers) * BUG FIX: Fix --helpshort for source files not in a subdir (csilvers) * BUG FIX: Fix python unittest for 64-bit builds (bcmills) git-svn-id: https://gflags.googlecode.com/svn/trunk@27 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Aug 21, 2008
-
-
Craig Silverstein authored
* google-gflags: version 1.0rc1 * Move #include files from google/ to gflags/ (csilvers) * Small optimizations to reduce binary (library) size (jyrki) * BUGFIX: forgot a std:: in one of the .h files (csilvers) * Speed up locking by making sure calls are inlined (ajenjo) * 64-BIT COMPATIBILITY: Use %PRId64 instead of %lld (csilvers) * PORTABILITY: fix Makefile to work with Cygwin (ajenjo) * PORTABILITY: fix code to compile under Visual Studio (ajenjo) * PORTABILITY: fix code to compile under Solaris 10 with CC (csilvers) git-svn-id: https://gflags.googlecode.com/svn/trunk@25 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Jul 22, 2008
-
-
Craig Silverstein authored
* google-gflags: version 0.9 * Add the ability to validate a command-line flag (csilvers) * Add completion support for commandline flags in bash (daven) * Add -W compile flags to Makefile, when using gcc (csilvers) * Allow helpstring to be NULL (cristianoc) * Improved documentation of classes in the .cc file (csilvers) * Fix python bug with AppendFlagValues + shortnames (jjtswan) * Use bool instead of int for boolean flags in gflags.py (bcmills) * Simplify the way we declare flags, now more foolproof (csilvers) * Better error messages when bool flags collide (colohan) * Only evaluate DEFINE_foo macro args once (csilvers) git-svn-id: https://gflags.googlecode.com/svn/trunk@23 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Mar 27, 2008
-
-
Craig Silverstein authored
* google-gflags: version 0.8 * Export DescribeOneFlag() in the API * Add support for automatic line wrapping at 80 cols for gflags.py * Bugfix: do not treat an isolated "-" the same as an isolated "--" * Update rpm spec to point to Google Code rather than sourceforge (!) * Improve documentation (including documenting thread-safety) * Improve #include hygiene * Improve testing git-svn-id: https://gflags.googlecode.com/svn/trunk@21 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Oct 18, 2007
-
-
Craig Silverstein authored
* google-gflags: version 0.7 * Deal even more correctly with libpthread not linked in (csilvers) * Add STRIP_LOG, an improved DO_NOT_SHOW_COMMANDLINE_HELP (sioffe) * Be more accurate printing default flag values in --help (dsturtevant) * Reduce .o file size a bit by using shorter namespace names (jeff) * Use relative install path, so 'setup.py --home' works (csilvers) * Notice when a boolean flag has a non-boolean default (bnmouli) * Broaden --helpshort to match foo-main.cc and foo_main.cc (hendrie) * Fix "no modules match" message for --helpshort, etc (hendrie) git-svn-id: https://gflags.googlecode.com/svn/trunk@19 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Aug 15, 2007
-
-
Craig Silverstein authored
* google-gflags: version 0.6 * Deal correctly with case that libpthread is not linked in (csilvers) * Update Makefile/tests so we pass "make distcheck" (csilvers) * Document and test that last assignment to a flag wins (wan) git-svn-id: https://gflags.googlecode.com/svn/trunk@17 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Jun 12, 2007
-
-
Craig Silverstein authored
* google-gflags: version 0.5 * Include all m4 macros in the distribution (csilvers) * Python: Fix broken data_files field in setup.py (sidlon) * Python: better string serliaizing and unparsing (abo, csimmons) * Fix checks for NaN and inf to work with Mac OS X (csilvers) git-svn-id: https://gflags.googlecode.com/svn/trunk@15 6586e3c6-dcc4-952a-343f-ff74eb82781d
-
- Apr 20, 2007
-
-
Craig Silverstein authored
* google-gflags: version 0.4 * Remove is_default from GetCommandLineFlagInfo (csilvers) * Portability fixes: includes, strtoll, gcc4.3 errors (csilvers) * A few doc typo cleanups (csilvers) git-svn-id: https://gflags.googlecode.com/svn/trunk@13 6586e3c6-dcc4-952a-343f-ff74eb82781d
-