Skip to content
Snippets Groups Projects
  1. Jul 18, 2017
    • Jungshik Shin's avatar
      Add es, en and ar variants · 1fec0c83
      Jungshik Shin authored
      The following locale variants are added to the ICU. Only source/data/locales
      are added and other locale categories are left alone.
      
      - es-* variants
      - en-SG and en-HK
      - Arabic variants whose NumberElements are different from ar.
      
      Data file size changes:
      
      - desktop:
         10192200 - 10178576 = 13624  (adding es variants)
         10197040 - 10192200 =  4840  (adding ar variants)
      - Android: 6635632 - 6616864 = 18768
      - iOS: 6623888 - 6605152 = 18736
      
      
      Bug:chromium:732762
      Test:See the bug report and comment 13
      TBR=littledan@chromium.org
      Change-Id: I3e87be3413e22aa49f24f81b0e25bd6e4187c0d4
      Reviewed-on: https://chromium-review.googlesource.com/576113
      
      
      Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      1fec0c83
  2. Jul 17, 2017
  3. Jun 02, 2017
  4. Jun 01, 2017
  5. May 31, 2017
  6. May 18, 2017
  7. May 16, 2017
  8. May 15, 2017
  9. May 14, 2017
    • Jungshik Shin's avatar
      Update ICU to 59.1 · 87232d8d
      Jungshik Shin authored
      * Highlights:
        - Emoji 5.0 data (partial; Emoji_Component property not included)
        - CLDR 31.0.1 (http://blog.unicode.org/2017/03/cldr-version-31-released.html)
          UTC and GMT are treated as distinct)
        - New case mapping API for styled text
        - C++ 11 is required
        - char16_t for UChar (UTF-16)
        - Source code is in UTF-8
      
      * Size changes
      
        common: 10,130,560 => 10,175,056
        android: 6,573,872 => 6,616,864
        iOS: 6,562,352 => 6,605,152
      
      On top of ICU 59.1 from the upstream, the following changes were applied.
      See https://chromium.googlesource.com/chromium/deps/icu/+log/chromium/59staging
      
        - Fix C++ 11 string literal assignment issue (upstream bug: 13192)
        - Fix C4229 warning by MSVC
        - Apply utf32.patch and include unistr.h in fuzzer_util
        - Update ICU data files
        - Fix wpo.patch
        - Apply Google locale patch and locale1.patch
        - update readme
        - Apply breakiterator related patches
        - Apply and update wpo.patch
        - Drop unused patch, apply data.build.win.patch, update README.chromium
        - Add /utf-8 flag for Windows/Visual Studio
        - Update BUILD.gn for UChar, stubdata and apply data_sym.patch
        - use stubdata.cpp instead of stubdata.c in icu.gyp
        - Update icu.gyp* files for v8
        - Update BUILD.gn, apply data.build.patch and vscomp.patch
        - Add new files in ICU 59.1
        - Get a fresh copy of ICU 59.1 from the upstream
        - Update update.sh script
      
      TBR=drott@chromium.org, yangguo@chromium.org
      Bug:699469
      TEST: layout tests, all unittests, browser tests
      Change-Id: Ie1e77323aa0c7f872153680c4deca6471a771a5c
      Reviewed-on: https://chromium-review.googlesource.com/505173
      
      
      Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      87232d8d
  10. May 05, 2017
    • Jungshik Shin's avatar
      Customize the ICU data for iOS · 4b06aadd
      Jungshik Shin authored
      Add ios/icudtl.dat and ios/patch_locale.sh.
      
      Update README.chromium and BUILD.gn accordingly.
      Update scripts/copy_data.sh to take (ios|common|android).
      
      At the moment, iOS data is almost identical to that of Android, but in the future
      more cuts may be made (e.g. dictionary data for breakiterator).
      
      Bug: 718955
      TEST: iOS Chrome works as before.
      Review-Url: https://codereview.chromium.org/2743123002 .
      4b06aadd
  11. Apr 25, 2017
  12. Apr 11, 2017
    • Jungshik Shin's avatar
      Update timezone db to 2017b · b34251f8
      Jungshik Shin authored
      See
      
        http://mm.icann.org/pipermail/tz-announce/2017-March/000046.html
      
      for details.
      
        - Haiti resumed observing DST.
      
      Data file size changes:
      
         android/icudtl.dat 6573792 =>  6573872
         common/icudt*.dat 10130480 => 10130560
      
      BUG=473288
      TEST=Try the following in d8 or Chrome's JS console:
       > (new Date("3/12/2016 12:00Z")).toLocaleString("en", {timeZone:
       "America/Port-au-Prince"})
       "3/12/2016, 7:00:00 AM"
       > (new Date("3/12/2017 12:00Z")).toLocaleString("en", {timeZone:
       "America/Port-au-Prince"})
       "3/12/2017, 8:00:00 AM"
      
      Review-Url: https://codereview.chromium.org/2807343004 .
      b34251f8
    • Jungshik Shin's avatar
      Update trim_data to deal with locale fallback failure for units · d5c238dc
      Jungshik Shin authored
      Delete empty units,units{Narrow,Short} blocks after trimming units data.
      Empty units* blocks in en_GB and a few other locales after trimming
      causes ICU to fail to fall back to get the duration data for those
      locales.
      
      In addition, fix source/data/translit/root_subset.txt. Rule*Ids block has
      to be present even though it's empty. When dropping Hans-Hant transform
      rules, root_subset.txt was changed to be completely empty, which broke
      "components_unittests --g_test_filter=AutofillProfileComparato*" .
      
      With these changes, regenerate ICU data files. The size is slightly smaller.
      
      android/icudtl.dat  6573872 => 6573792
      common/icudt*dat    10130560 => 10130480
      
      BUG=707515,677043,684609
      TEST=components_unittests --gtest_filter=AutofillProfileComparato*
      TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm*
      R=derat@chromium.org
      
      Review-Url: https://codereview.chromium.org/2812943003 .
      d5c238dc
  13. Mar 16, 2017
  14. Mar 15, 2017
  15. Mar 07, 2017
  16. Feb 21, 2017
  17. Jan 27, 2017
  18. Dec 12, 2016
  19. Dec 09, 2016
    • Jungshik Shin's avatar
      Fix big endian support for MIPS · 73e24736
      Jungshik Shin authored
      Recent changes in detecting big endian targets don't work when cross
      compiling for a target with different endianness. This brakes MIPS.
      Added additional checks for big endian MIPS and MIPS64 targets to fix
      this.
      
      Patch by miran.karic@imgtec.com
      
      BUG=None
      R=bjaideep@ca.ibm.com, jshin@chromium.org
      
      Review URL: https://codereview.chromium.org/2518533002 .
      73e24736
  20. Dec 07, 2016
  21. Nov 17, 2016
  22. Nov 15, 2016
    • Bruce Dawson's avatar
      Return to suppressing deprecation warnings · 4d136324
      Bruce Dawson authored
      The previous change re-enabled warnings too aggressively. While the icu
      target built correctly the icu nacl targets (such as
      irt_x64/obj/third_party/icu/icuuc/uidna.o on Windows and
      newlib_pnacl/obj/third_party/icu/icuuc/uidna.o on other platforms)
      failed to compile due to deprecation warnings. This change adds back
      suppression of that one warning.
      
      BUG=21515
      R=thakis@chromium.org
      
      Review URL: https://codereview.chromium.org/2504463002 .
      4d136324
  23. Nov 14, 2016
    • Bruce Dawson's avatar
      Re-enable as many clang warning as possible · 3c89207b
      Bruce Dawson authored
      ICU has historically had many clang warnings disabled, but some of the
      underlying causes have been fixed. One of the VC++ specific warning
      disables was recently removed (crrev.com/2494793002) and this change
      removes a bunch more, for clang and VC++. For some of them there are
      specific icu bugs that have been fixed that allow this, and for others
      I just have the evidence that on Linux and Windows icu compiles with
      clang and VC++ with these changes.
      
      BUG=21515
      R=thakis@chromium.org
      
      Review URL: https://codereview.chromium.org/2492553006 .
      3c89207b
  24. Nov 11, 2016
  25. Oct 28, 2016
    • Jungshik Shin's avatar
      ICU update to 58 part 2 · e0d9b90c
      Jungshik Shin authored
      Follw-up to https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad5
      (due to a rietveld issue, part 1 was manually pushed).
      
      Update ICU to 58.1 release from ICU 56.1 part2.
      
      Listed below a tiny subset of what's new in 58.1:
      
        1. Unicode 9.0 from Unicode 8.0
          - Updated character properties including Emoji data up to 4.0beta.
          - Updated grapheme/word/line breaking rules for Emoji sequences and others.
      
        2. CLDR 30.0.2 from CLDR 28
          - Numerous locale data updates/improvements
      
        3. Spoofing API changes
        4. Greek uppercasing support as a part of regular case-mapping API.
        5. Line breaking rule file format optimization. This change enables me
           to add CJ loose line breaking rules back (previously, it's dropped
           to save space) so that Blink can use it for CJ.
      
      See http://site.icu-project.org/download/58 for more details on ICU 58.1
      and http://site.icu-project.org/download/57 for more details on ICU 57.1
      
      For CLDR 30, see http://cldr.unicode.org/index/downloads/cldr-30 .
      
      The size impact:
         Non-Android: 10,127,200 => 10,128,624 (delta = 1,424 / 0.014%)
         Android: 6,563,152 => 6,571,936 (delta = 8,784 / 0.13%)
      
      Below are the list of changes made on top of the upstream ICU 58.1
      in reverse order. Most of these changes were made in 58staging branch
      to run trybots and cherry-picked back for this CL. See
         https://chromium.googlesource.com/chromium/deps/icu/+/log/chromium/58staging
         https://codereview.chromium.org/2447513002/ : cr+blink update cl with
             58staging branch head.
      
      * Fix a build on Win without std::string (v8)
      * Add ms932 alias to Shift_JIS
      
      * Apply Google-specific locale data patches
      
      * Fix a bug in scriptset
      
      * Update windows-1255 mapping
      
      * Disable C4333 warning by MSVC (harmless)
      
      * Apply and update utf32.patch and README.chromium
      
      * Update and apply vscomp.patch
        stringpiece patch removed. VS2015 seems to be fine with a redefinition.
      
      * Update pre-built ICU data files
         Update *local.mk with a new copyright line
      
      * Apply more patches
        The following patches were applied and updated: data_symb, vscomp, wpo
      
        The unnecessary part was dropped from vscomp
      
      * Update BUILD.gn and icu.gyp* files
      
      * Update android/brkitr.patch
      
      * Update and apply more patches
      
      * Update and apply cjdict.patch
         Apply data.build.patch
      
      * Delete obsolete patches: cmemory,regex
      
      * Update README.chromium and apply brkitr patches
      
        - Update README.chromium
        - Remove obsolete patches
        - Update linebrk.patch and apply it: add back line_loose_cj
      
      * Update wordbrk.patch and apply it
      
      * Update and apply khmer-dictbe.patch
      
      * Update data trimming
      
        - android/patch_locale.sh
        - scripts/trim_data.sh
           ExemplarCh* removed
           charac*Label removed
           relative/relativeTime removed for daysOfWeek and quarter
      
      * Update the following patches
      
        android/brkitr.patch
        patches/linebrk.patch
        patches/data.build.patch
      
      * Update cjdict.patch and linebrk.patch
      
      BUG=637001
      TEST=Layout tests, all unittests, browser tests, ui tests.
      R=jsbell@chromium.org, mark@chromium.org
      
      Review URL: https://codereview.chromium.org/2442923002 .
      e0d9b90c
  26. Oct 23, 2016
    • Jungshik Shin's avatar
      Update ICU to 58 part1 · 5feb9ad5
      Jungshik Shin authored
      * Note that this CL will be followed by CLs with local changes.
        Until then, ICU should not be rolled in DEPS. See READ_THIS_FIRST
        for details.
      
      * Adjust scripts/update.sh and scripts/data_files_to_preserve.txt
        - CLDR/ICU added ckb/ast locale data. Drop them from the list to preserve.
        - source/layout does not exist in 58.1 any more.
      
      * Update the tree to ICU 58.1 from the upstream by running
        scripts/update.sh
      
      * Update README.chromium and add READ_THIS_FIRST to warn about the
        status of the tree.
      
      BUG=637001
      TEST=None
      5feb9ad5
  27. Oct 21, 2016
    • Jungshik Shin's avatar
      Delete Visual Studio build files · f8aa31da
      Jungshik Shin authored
      There's no need for VS build files.
      Besides, update scripts/update.sh to post-edit source/configure
      for missing test/ directory.
      
      This clean up is necessary to get 'git cl upload/rietveld' work
      smoothly in an upcoming ICU update.
      
      BUG=637001
      TEST=source/runConfigureICU Linux --disable-tests --disable-layout
      
      Review URL: https://codereview.chromium.org/2443653002 .
      f8aa31da
    • Jungshik Shin's avatar
      Delete source/test · 2e57f555
      Jungshik Shin authored
      We don't use source/test. It's kept to give API usage examples, but
      it got in the way of a version update (git cl upload keeps timing out).
      
      Also, update update.sh to delete source/test after downloading a new
      version from the upstream.
      
      BUG=637001
      TEST=None
      
      Review URL: https://codereview.chromium.org/2435373002 .
      2e57f555
  28. Sep 13, 2016
  29. Aug 17, 2016
  30. Aug 09, 2016
  31. Aug 08, 2016
  32. Aug 02, 2016
    • Jungshik Shin's avatar
      List header files explicitly in BUILD.gn · 56680aaa
      Jungshik Shin authored
      Private headers are listed in source[] while public headers are listed
      in public[] for icuuc and icu18n targets.
      
      This change is to let trybot analyze step recompile icuuc or icu18n even
      when the only change in CL is in a header file (public or private).
      
      BUG=632438
      TEST=`gn check <out_dir>` does not complain.
      TEST=`gn ref <out_dir> third_party/icu/source/common/umutex.h` matches icuuc.
      TEST=`gn ref <out_dir> third_party/icu/source/common/unicode/unistr.h`
           matches icuuc.
      
      R=brettw@chromium.org
      
      Review URL: https://codereview.chromium.org/2186343002 .
      56680aaa
Loading