- Mar 12, 2019
-
-
Yang Guo authored
On non-Windows platforms, we generate assembly to bundle ICU data. On Windows however, we previously use a checked in icudt.dll, which is no longer maintained. We could use the same assembly approach if we wrap in inline assembly. Bug: chromium:938223 Change-Id: Ieced205ae2e082a5290bd45499216c6c86751ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1503032 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Feb 28, 2019
-
-
Jungshik Shin authored
Region-name patch was not applied to 3 locales (zh-Hant, lt, and lv) when updating ICU to 63.1 by mistake. This affects the region display names for HK, MO, and FK. Update the patch file: locale_google.patch accordingly. TBR=yyushkina@chromium.org Bug: 926644 Test: In settings-language menu, HK's display name in zh-Hant is '香港'. Change-Id: Idc259d75ffa092ff3fee5b126bcbd88db364979b Reviewed-on: https://chromium-review.googlesource.com/c/1493786 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Feb 16, 2019
-
-
Frank Tang authored
Locale has bugs related to grandfather tag processing. This block the v8 Intl.Locale launch. Upstream bugs: https://unicode-org.atlassian.net/browse/ICU-20187 https://unicode-org.atlassian.net/browse/ICU-20407 https://unicode-org.atlassian.net/browse/ICU-20410 https://unicode-org.atlassian.net/browse/ICU-20411 Upstream fixes: https://github.com/unicode-org/icu/pull/418 https://github.com/unicode-org/icu/pull/414 https://github.com/unicode-org/icu/pull/416 Bug: 913298,v8:8260,v8:8242 Test: In v8, fix intl402/Locale/constructor-non-iana-canon Test: v8: intl402/Locale/constructor-tag, and intl402/Locale/likely-subtags-grandfathered Change-Id: Ifcff754587bba75413987729fac8f563ba5e75e0 Reviewed-on: https://chromium-review.googlesource.com/c/1476117 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jan 17, 2019
-
-
Eli Ribble authored
This was removed to save space. The latest YT Music app apprently needs this data and cast crashes without it. cast/icudtl.dat size before change: 4747296 bytes cast/icudtl.dat size after change: 5126768 bytes Size increase: 379472 bytes Bug: b/120812705 Test: On Chromecast Audio Change-Id: I543cd61b05b28a4b51fcab20d75116b2fe05bed7 Reviewed-on: https://chromium-review.googlesource.com/c/1416138 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jan 04, 2019
-
-
Jungshik Shin authored
2018h and 2018i were announced in a quick succession in the last week of 2018. https://mm.icann.org/pipermail/tz-announce/2018-December/000053.html https://mm.icann.org/pipermail/tz-announce/2018-December/000052.html Timezones in a part of Kazakhstan (Asia/Qyzylorda changed its offset and new timezone Asia/Qostanay was added), a part of Alaska, São Tomé and Príncipe changed at the end of 2018 or at the beginning of 2019. They require this update now. Either in JS console in Chrome or v8 should work like these: d8> new Date(Date.UTC(2018,11,20,12)).toLocaleString("en", {timeZone: "Asia/Qyzylorda"}) "12/20/2018, 6:00:00 PM" d8> new Date(Date.UTC(2018,11,21,12)).toLocaleString("en", {timeZone: "Asia/Qyzylorda"}) "12/21/2018, 5:00:00 PM" d8> new Date(Date.UTC(2018,11,20,12)).toLocaleString("en", {timeZone: "Asia/Qostanay"}) "12/20/2018, 6:00:00 PM" d8> new Date(Date.UTC(2018,11,21,12)).toLocaleString("en", {timeZone: "Asia/Qostanay"}) "12/21/2018, 6:00:00 PM" d8> new Date(Date.UTC(2018,11,31,12)).toLocaleString("en", {timeZone: "Africa/Sao_Tome"}) "12/31/2018, 1:00:00 PM" d8> new Date(Date.UTC(2019,0,1,12)).toLocaleString("en", {timeZone: "Africa/Sao_Tome"}) "1/1/2019, 12:00:00 PM" Future expected changes in Iran and Moroco are also included in this update. Bug: 473288 Test: See the above. Change-Id: If9f8503eebbf1e7eefb504a73140b4e3a37c3cf9 TBR=gsathya@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1395498 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Dec 14, 2018
-
-
Jungshik Shin authored
Windows component build with clang has this compile error. icu_63::uprv_detectWindowsTimeZone' should not add 'dllexport' attribute [-Werror,-Wdll-attribute-on-redeclaration] uprv_detectWindowsTimeZone() Cherry-pick https://github.com/unicode-org/icu/pull/318 TBR=gsathya@chromium.org,ftang@chromium.org Bug: 913298 Test: Windows component build compiles w/o any error. Change-Id: I45fc8ac2c1f5fa7821178fea5985c5df6afea850 Reviewed-on: https://chromium-review.googlesource.com/c/1377561 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
Jungshik Shin authored
Windows 7 has a 'bug' in one of its timezone APIs. ICU's timezone detection code was hardened to work 'around' the bug. Upstream bug: https://unicode-org.atlassian.net/browse/ICU-20302 Upstream fix: https://github.com/unicode-org/icu/pull/315 TBR=gsathya@chromium.org,ftang@chromium.org Bug: 913298 Test: See bug comment 35 Change-Id: Ib13b6a2809c629929490c5bfd73bee93b2c918c2 Reviewed-on: https://chromium-review.googlesource.com/c/1377557 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Dec 12, 2018
-
-
Frank Tang authored
Fix the locale parsing with tz which resolved to a tz name which have a _ in it. "uslax" is resolved to "Los_Angles" and cause that. TEST=In v8 or Chrome console, new Intl.DateTimeFormat("ja-u-tz-uslax") works fine. resolvedOptions().timeZone is 'America/Los_Angenles'. Bug: v8:8469 Change-Id: I996790b1ce59fbb5f6b0a460ff8acdb674894df1 Reviewed-on: https://chromium-review.googlesource.com/c/1372810 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Nov 17, 2018
-
-
Jungshik Shin authored
According to the announcement at https://mm.icann.org/pipermail/tz-announce/2018-October/000052.html , Morocco switches from +00/+01 to permanent +01 effective 2018-10-27, so its clocks will not fall back on 2018-10-28 as previously scheduled. The tz-related files are updated by running update_tz.sh and ICU data files are rebuilt. In 2017, on the last Sunday of October, there was fall backward. d8> new Date(Date.UTC(2017, 9, 28,12)).toLocaleString("en", {timeZone: "Africa/Casablanca"}) "10/28/2017, 1:00:00 PM" d8> new Date(Date.UTC(2017, 9, 29,12)).toLocaleString("en", {timeZone: "Africa/Casablanca"}) "10/29/2017, 12:00:00 PM" In 2018, there is no transition on the last Sunday of October. d8> new Date(Date.UTC(2018,9,27,12)).toLocaleString("en", {timeZone: "Africa/Casablanca"}) "10/27/2018, 1:00:00 PM" d8> new Date(Date.UTC(2018,9,28,12)).toLocaleString("en", {timeZone: "Africa/Casablanca"}) "10/28/2018, 1:00:00 PM" TBR=ftang@chromium.org Bug: 473288 Test: See the above Change-Id: Icc2c2a377e3c2d03c7d57cd99a1594773cb10c81 Reviewed-on: https://chromium-review.googlesource.com/c/1341453 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
Jungshik Shin authored
Make the locale variant support more uniform across locale categories. What's supported in the main locale categories (data/locales) are added to data/{unit,curr} as well. The list of locales in data/zone is not yet updated. Moreover, sr and sw variants are added to data/{locales,unit,curr}. The cast removal list is simplified using 'glob' pattern instead of listing individual files for curr and unit categories. The data size is still under control on most platforms. They're actually smaller than the first ICU 63.1 update thanks to additional trimming in zone/unit categories except on desktop (59kB increase). Initial 63.1 This CL Platform 6375056 6353648 android 4916608 4745488 cast 10268240 10324816 common 880512 880928 flutter 6361376 6313376 ios TBR=almasrymina@chromium.org,ftang@chromium.org,gsathya@chromium.org Change-Id: I21dc5ec752795f485cfeb64ab1eb7eb8b23f3991 Bug: 863739 Test: {base,components,net}_unittests, blink, v8(intl/*,test262/intl402) Reviewed-on: https://chromium-review.googlesource.com/c/1335789 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Nov 14, 2018
-
-
Jungshik Shin authored
Cherry-pick another upstream patch to improve the performance of UnicodeSet. https://github.com/unicode-org/icu/pull/278 Bug: 899983,901532 Test: Android webview start-up perf and Windows perf graph Change-Id: I2c2a22a398883178734a2c2a6c5975d9551b039e TBR=ftang@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1335799 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
Jungshik Shin authored
On Android, add Islamic calendar to Arabic and Farsi locales and Indian calendar to Hindi locale. Also add both variants of Ethiopic calendars to am/root. There was a 'typo' in the locale trimming script for Android ('arabic' instead of 'islamic' was specified.). As a result, Date formatting in ar-SA (where the default calendar is Islamic) failed for the lack of locale data. Add back calendar entries to data/locales/root.txt. They're necessary to support locale-specific calendars on Android (e.g. islamic on ar/fa, japanese on ja, hebrew on he, etc). Adjust the drop list for the data file for cast. More locale variants have been added since it's made. Drop locale bundles for newly added variants. Drop zone/unit data for 8 locales Android Chrome does not yet support. This saves over 100 kB. For all platforms, drop a few more items not yet used in Chromium/v8. With this change, the net data size decreased on all platforms, paving the way to add more locale variants in a subsequent CL. Previous This CL Platform 6375056 6235856 android 4916608 4714896 cast 10268240 10258960 common 880512 879104 flutter 6361376 6195600 ios TBR=ftang@chromium.org,gsathya@chromium.org Bug: v8:8432 Test: v8: intl/regress-8432-* Change-Id: Iafd94c08ea4e88b33aed4724309636c3e224bdc2 Reviewed-on: https://chromium-review.googlesource.com/c/1325943 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Nov 08, 2018
-
-
Jungshik Shin authored
The start-up performance regression reported for Android WebView and Windows Chrome is traced to UnicodeSet creation for Unicode character properties. This upstream PR speeds up UnicodeSet creation. Upstream bug: https://unicode-org.atlassian.net/browse/ICU-20250 Upstream PR: https://github.com/unicode-org/icu/pull/265 TBR=ftang@chromium.org Bug: 899983,901532 Test: Android webview start-up perf. Change-Id: Iffb6eac4ddde2cabd2f55fe718a9b4e3f39b4e05 Reviewed-on: https://chromium-review.googlesource.com/c/1325398 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Nov 06, 2018
-
-
Jungshik Shin authored
'fields' block in source/data/locales/es_VE.txt is empty after the data trimming. An empty block prevents locale fallback chain from kicking in (es-VE => es-419) leading to a failure in relative date format. Fix trim_data.sh to remove an empty 'fields' block. TBR=ftang@chromium.org Bug: v8:8414 Test: v8: intl/regress-8414.js Change-Id: Ibac63e869ab2e3320f7ec272919c49aedceccd75 Reviewed-on: https://chromium-review.googlesource.com/c/1319093 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Nov 04, 2018
-
-
Jungshik Shin authored
The encoding of 373 code point into ISO-2022-JP failed because they're mapped to SJIS code points for which there's no JIS 208 mapping. Using JIS X 208 table in EUC-JP solves this issue. Upstream bug: https://unicode-org.atlassian.net/browse/ICU-20251 Bug: 901255 Test: https://www.w3.org/International/tests/repo/run?base=encoding&batch=encoding-dbl-byte&test=legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form.html Change-Id: I3237fa1269a3ae2e89b22e246aaf2ae43fd56c7d Reviewed-on: https://chromium-review.googlesource.com/c/1314052 Reviewed-by:
Joshua Bell <jsbell@chromium.org>
-
- Nov 02, 2018
-
-
Jungshik Shin authored
Fix: https://github.com/unicode-org/icu/pull/253 Bug: https://unicode-org.atlassian.net/browse/ICU-20246 TBR=ftang@chromium.org Bug: 900059 Test: See the bug Change-Id: I6c75502e44b41f7b77f6f6265dfd099e42196178 Reviewed-on: https://chromium-review.googlesource.com/c/1312653 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Oct 24, 2018
-
-
Jungshik Shin authored
What's new in ICU 63.1: - CLDR 34 locale data http://cldr.unicode.org/index/downloads/cldr-34-1 - Curreny/Number range format - Better/more support for field iterator in formatters - necessary for v8's Ecma 402 implementation - Better/safer locale APIs - See http://site.icu-project.org/download/62 for more details. The update steps are recorded : https://chromium.googlesource.com/chromium/deps/icu/+log/ccad447..b0bb170 * Update update.sh to point to ICU's new repo location * Import the pristine copy of ICU 63.1 and update BUILD files with update.sh * Update and apply locale data patches - locale_google.patch - locale1.patch * Adjust/apply/update brkiter related patches - In place of line_normal_fi.txt, add back line_loose.txt (Finnish tailoring is absorbed into root). - data/brkitr/* are adjusted accordingly - android/brkitr.patch and flutter/brkitr.patch are updated - Use 'normal-cj' for line-breaking in zh/ja locales by default - Apply cjdict.patch and khmerdict.patch * Apply build-related patches {wpo,vscomp,data.build,data.build.win,data_symb}.patch * Delete obsolete patches and apply still relevant patches {isvalidenum,doubleconversion}.patch * Fix a Windows compilation issue with clang * Drop pluralrange.res from flutter's data * Update the timezone data update script and update the timezone data to 2018f * Add VES (new Venezuelan currency) to and drop VEF - {scripts/android}/currencies.list * ICU data files are rebuilt (up to 22kB increase) ICU 62 ICU 63 Platform 6364832 6375056 android 4907488 4916608 cast 10246512 10268240 common 884352 880512 flutter 6351136 6361376 ios TBR=ftang@chromium.org Bug: 893196, v8:8272 Change-Id: Icac23f6c065f38a9b1b4ae397fbe0e6b62934f15 Reviewed-on: https://chromium-review.googlesource.com/c/1296893 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Oct 21, 2018
-
-
Jungshik Shin authored
https://unicode-org.atlassian.net/browse/ICU-20001 We have exactly the same fix already in 69 branch for another class. See crbug.com/865100 . TBR=ftang@chromium.org Bug: 896322 Test: See bug comment 21 Change-Id: I8aed41a29ed7382ea19ac90825d3440f58372247 Reviewed-on: https://chromium-review.googlesource.com/c/1293071 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
Jungshik Shin authored
The IANA timezone data 2018f was announced on Oct 18. https://mm.icann.org/pipermail/tz-announce/2018-October/000051.html Europe/Volgograd will move from UTC+3 to UTC+4 on Oct 28 and Fiji will end DST on 2019-01-13 instead of 2019-01-20. d8> new Date(Date.UTC(2018,9,27,12)).toLocaleString("en", {timeZone: "Europe/Volgograd"}) "10/27/2018, 3:00:00 PM" d8> new Date(Date.UTC(2018,9,28,12)).toLocaleString("en", {timeZone: "Europe/Volgograd"}) "10/28/2018, 4:00:00 PM" d8> new Date(Date.UTC(2019,0,12,0)).toLocaleString("en", {timeZone: "Pacific/Fiji"}) "1/12/2019, 1:00:00 PM" d8> new Date(Date.UTC(2019,0,13,0)).toLocaleString("en", {timeZone: "Pacific/Fiji"}) "1/13/2019, 12:00:00 PM" This CL will be followed by a fix for a memory alignment bug on ARM. TBR=ftang@chromium.org Bug: 473288 Test: See the above Change-Id: Ic7b99bb7442c137a4e3f0a0db9debc9641f51948 Reviewed-on: https://chromium-review.googlesource.com/c/1293149 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Oct 09, 2018
-
-
Jungshik Shin authored
This is to cherry-pick fixes from the upstream to fix the timezone detection issue when a remote Windows session is used. The detected timezone should be that of a remote machine Chrome is running on, but without this fix, it uses the timezone of machine where a RDP connection originates. Bugs: https://unicode-org.atlassian.net/browse/ICU-13842 https://unicode-org.atlassian.net/browse/ICU-13827 Fixes (included in the upstream ICU 63 release candidate) https://github.com/unicode-org/icu/pull/55 https://github.com/unicode-org/icu/pull/129 TBR=yangguo@chromium.org Bug: 854387 Test: Manual. See the bug Change-Id: Ic21e82987c1569e107d9b5e17bdc0d21e65fda3c Reviewed-on: https://chromium-review.googlesource.com/c/1270635 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Sep 21, 2018
-
-
Jungshik Shin authored
Duplicate U-ext keywords are allowed, but previously it's rejected. Cherry-pick an upstream patch for that. See https://github.com/unicode-org/icu/pull/136 TBR=gsathya@chromium.org Bug: v8:8136 Test: v8 - test262/intl402/Locale/constructor-unicode-ext-valid Change-Id: Iaec82e28e728afb09f5b1d6b63b1d72bedf02e47 Reviewed-on: https://chromium-review.googlesource.com/1238056 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Sep 09, 2018
-
-
Jungshik Shin authored
Extlang subtag can only be preceded by 2 or 3 letter language code. The length check for the preceding subtag was missing. In addition, the singleton check for private use extension was buggy. Add 'USE_CHROMIUM_ICU" to BUILD.gn to let v8 take different code paths depending on whether or not Chromium's ICU with patches is used. This distinction can be important for Node.js TBR=gsathya@chromium.org Bug: v8:8135 Test: v8: test262/intl402/Intl/getCanonicalLocales/* Change-Id: I431d582ec5b8e730698067d1795b1107dd3d016f Reviewed-on: https://chromium-review.googlesource.com/1214645 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Sep 08, 2018
-
-
Jungshik Shin authored
1. Do not trim 'quarter'-related strings from the locale data and regenerate the ICU data files. ICU data file size is increased by 24 ~ 35 kB. 2. Chery-pick upstream patch to support quarter in RelativeDateFormat upstream bug: https://unicode-org.atlassian.net/browse/ICU-20022 PR to fix: https://github.com/unicode-org/icu/pull/77 This will unblock the following CL: https://chromium-review.googlesource.com/c/v8/v8/+/1214522 TBR=ftang@chromium.org Bug: v8:7869 Test: See the bug Change-Id: I11740d9b2a1fdb9b2f7bb497eda2746353fa8428 Reviewed-on: https://chromium-review.googlesource.com/1214642 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Aug 25, 2018
-
-
Michael Goderbauer authored
Uncompressed size: 883,280B (862.6 KB), minus 363.2KB Compressed size: 460,972B (450.2KB), minus 83.9KB The following unused resources are removed: * uts46.nrm * nfkc_cf.nrm * cnvalias.icu * Break Iterators for: * Sentence breaks * Title breaks * CSS-specific line breaks ("regular" line breaks are still supported) Change-Id: I26f932b2e991f44c6d86fe9858724d34c5c323b7 Reviewed-on: https://chromium-review.googlesource.com/1162775 Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Greg Spencer <gspencer@google.com>
-
- Aug 22, 2018
-
-
Jungshik Shin authored
In some locales, currency data turns empty after currency list filtering on Android. This leads v8's currency formatter to fall back to 3-letter currency code instead of currency symbol (e.g. 'GBP' in en-GB). Fix the ICU data trimming script to remove an empty Currency block after filtering and rebuild ICU data files. Bug: 870338 Test: See the bug TBR=gsathya@chromium.org Change-Id: Idf7af0a5f00b05b7f26d2ad42b21abd1aca47d07 Reviewed-on: https://chromium-review.googlesource.com/1184505 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jul 24, 2018
-
-
Michael Goderbauer authored
This reduces the size of the ICU data file shipping with Flutter: from 6.3MB to 1.2MB uncompressed from 2.2MB to 534KB compressed (zip) See go/flutter-icu for detailed analysis. Change-Id: Iff5a4aa5286c685d5410b28d98ac8d49987d2eef Reviewed-on: https://chromium-review.googlesource.com/1144234 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jul 23, 2018
-
-
Manoj Gupta authored
The buffer used in placement new should have the same alignment as the underlying type DecimalFormatProperties. Fixes login crashes in Chrome OS. BUG=chromium:865100 TEST=locally built chrome os image works. Change-Id: Ic71cb4e7962f1b9170e0a4ef00223767c621bc67 Reviewed-on: https://chromium-review.googlesource.com/1145582 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
Jungshik Shin authored
ICU bug tracker moved to Jira. Update bug urls referred to in README.chromium https://unicode-org.atlassian.net/browse/ICU-{bug #} Bug: None Test: None Change-Id: I12bfdc9c011293b1ee066ae689fd662df1c74d94 Reviewed-on: https://chromium-review.googlesource.com/1146488 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jul 07, 2018
-
-
Jungshik Shin authored
What's new in ICU 62.1: - Unicode 11 (new scripts, Emoji update, Text Boundary/Line break updates) - CLDR 33.1 (locale data; http://cldr.unicode.org/index/downloads/cldr-33-1 ) - More Numberformatter improvements and its support in MsgFormat - See http://site.icu-project.org/download/62 for more details. The update steps are recorded in https://chromium.googlesource.com/chromium/deps/icu/+log/172d331..c28591b The list of local changes are: Cherry-pick Greek lowercasing fix Fix a DecimalFormat maxSignificantDigits issue. * Rebuild the data files: size eduction of ~ 45 KiB 6386176 => 6340576 android 4929248 => 4883232 cast 10264208 => 10218000 common 6372480 => 6326896 ios * Update README.chromium and remove a reference to icudt.dll for Windows because it's not used any more. * Drop patches that became unnecessary. * Apply the remaining patches Isvalidenum.patch, locid_map.patch, double_conversion.patch * Apply data-build related patches {wpo,vscomp,data.build,data.build.win,data_symb}.patch * Apply BreakIterator related patches + locale1 patch * Apply Google's patch for locale data - region display names - likely subtags - Arabic locale: default number system => Latn - AM/PM markers for Hindi and a few Indic locales * Check in ICU 62.1 to the tree (62staging branch) by running scripts/update.sh. Build files are updated by the script. TBR=drott@chromium.org Bug: 850334 Test: None Change-Id: I7327363c90b9bccda20c1be8f4a65399f36c4e99 Reviewed-on: https://chromium-review.googlesource.com/1128503 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jun 09, 2018
-
-
Jungshik Shin authored
ICU's Windows timezone detection is broken on Japanese/Korean (and potentially other non-English) Windows. Cherrypick the upstream fix. See http://bugs.icu-project.org/trac/ticket/13826 . TBR=gsathya@chromium.org Bug: 849724 Test: Set the timezone to Tokyo on Japanese Windows Test: In JS console, 'new Date()' outputs 'Japan Standard Time' in parens. Change-Id: Ie76c1e97ee2e965825f2fe99442c55e797b45f41 Reviewed-on: https://chromium-review.googlesource.com/1094322 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- May 08, 2018
-
-
Jungshik Shin authored
What's new in ICU 61.1: - CLDR 33 (locale data; http://cldr.unicode.org/index/downloads/cldr-33 ) - A new number formatting API - Rewrote U8_NEXT - See http://site.icu-project.org/download/61 for more details. The update steps are recorded in https://chromium.googlesource.com/chromium/deps/icu/+log/f7ab784..b0e0b84 On top of the above, IANA timezone db was updated once more to the latest 2018e (released on May 4th). The list of local changes are: * Update the currency list. For desktop, include all the national currencies (see https://bugs.chromium.org/p/v8/issues/detail?id=7472 ) * Clean up disabled warning list in BUILD.gn/icu.gyp * Fix clang on Windows and MSVC build failures https://github.com/google/double-conversion/issues/66 http://bugs.icu-project.org/trac/ticket/13752 http://bugs.icu-project.org/trac/ticket/13750 * Rebuild the data files Size is reduced by ~100kB for non-desktop. Desktop(common): increase by 90kB 6,386,176 android/icudtl.dat (6,502,048) 4,929,248 cast/icudtl.dat (5,032,368) 10,264,208 common/icudtl.dat (10,171,920) 6,372,480 ios/icudtl.dat (6,488,384) * Update IANA tz DB to 2018e * Update README.chromium * Drop patches that became unnecessary. * Apply the remaining patches Isvalidenum.patch, simplify_smallintformatter.patch, word_long.patch, locid_map.patch * Apply data-build related patches {wpo,vscomp,data.build,data.build.win,data_symb}.patch * Apply BreakIterator related patches + locale1 patch * Apply Google's patch for locale data * ICU 61.1 update step 1 Check in ICU 61.1 to the tree (61staging branch) by running scripts/update.sh. Build files are updated by the script. * Update prep TBR=thakis@chromium.org Bug: 838383 Test: None Change-Id: Ib83ed624fe764abdb7fbfd567ae5e982497089bd Reviewed-on: https://chromium-review.googlesource.com/1041578 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Apr 25, 2018
-
-
Jungshik Shin authored
1. Update grandfathered tag list and map 2. Update redundant tag list and map 3. Update deprecated lang list 4. Add deprecated region list and map them to modern region subtags. 5. Map ja-Latn-hepburn-heploc to ja-Latn-alalc97 The IANA language subtag regisry is used to update. https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry Upstream bugs: https://ssl.icu-project.org/trac/ticket/13726 https://ssl.icu-project.org/trac/ticket/13723 https://ssl.icu-project.org/trac/ticket/13721 https://ssl.icu-project.org/trac/ticket/13720 https://ssl.icu-project.org/trac/ticket/13719 TBR=gsathya@chromium.org Bug: v8:7669, v8:5693 Test: v8 test will be added and updated. Change-Id: I773475ede43bb7a3048f176dde2cee6bfdf9a3e7 Reviewed-on: https://chromium-review.googlesource.com/1026797 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Apr 12, 2018
-
-
Jungshik Shin authored
* Fix the undefined behavior in decimal number parsing http://bugs.icu-project.org/trac/changeset/40950 * Fix the handling of non-BMP characters in CJK breakiterator http://www.icu-project.org/trac/changeset/40949 * Limit the recursion depth of UnicodeSet pattern http://bugs.icu-project.org/trac/changeset/40979 TBR=inferno@chromium.org Bug: chromium:799850, chromium:796807, chromium:796752 Test: See the bugs. Change-Id: I1a8909371b601f36faca911039b10d36c7a92c85 Reviewed-on: https://chromium-review.googlesource.com/1009001 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Apr 11, 2018
-
-
Jungshik Shin authored
The ICU word break rules are updated to deal with a performance issue with selecting a very long word by double-click. In addition, update the IANA tz database to 2018d. Palestine started DST (UTC+3) on March 24 instead of March 31. > new Date(Date.UTC(2018,2,24, 12)).toLocaleString("en", {'timeZone': 'Asia/Gaza'}) "3/24/2018, 3:00:00 PM" Bug: chromium:829144, chromium:473288 Test: See the 1st bug description. Test: See the above JS code snippet and result. Change-Id: Ic8beeaaa4f0e5a16701b0d8b1563fc8537c6b0ab TBR=mark@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1006521 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Feb 05, 2018
-
-
Jungshik Shin authored
See http://mm.icann.org/pipermail/tz-announce/2018-January/000048.html for details. Most notable is that Brazil will start DST (UTC-3 => UTC-2 in São Paulo) on the 1st Sunday of November instead of the 2nd Sunday of October. In JS console: > new Date(Date.UTC(2018, 9,31, 5)).toLocaleString("en", {timeZone: 'America/Sao_Paulo'}) "10/31/2018, 2:00:00 AM" > new Date(Date.UTC(2017, 9,31, 5)).toLocaleString("en", {timeZone: 'America/Sao_Paulo'}) "10/31/2017, 3:00:00 AM" TBR=mark@chromium.org Bug: 473288 Test: See the above Change-Id: I7cb1c48c461a8406cee1e34042c8eec0fb31f85f Reviewed-on: https://chromium-review.googlesource.com/898245 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jan 29, 2018
-
-
David 'Digit' Turner authored
This is a re-land of https://chromium-review.googlesource.com/c/836554 which was reverted because it includes a C++14 constexpr expression that failed on the V8 build-bots (which are restricted to C++11 language features, unlike the Chromium ones). The patch now uses a C++11-compatible constexpr function. Drastically reduce the size of the SmallIntFormatter code. This should make the code slightly slower, but reduce the overall size of the generated library by about 16 kiB. It is unlikely that the performance difference will be noticeable on any existing system Chromium runs on. R=ajwong@chromium.org, jshin@chromium.org Bug: NONE Change-Id: I425626a53e0a04af4110acd0410655e6a08d8568 Reviewed-on: https://chromium-review.googlesource.com/870039 Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jan 16, 2018
-
-
Jungshik Shin authored
This reverts commit 2e0c90b4. It is to make gcc with '-std=gnu+11' happy. v8 trybots with gcc(C++ 11) failed to compile with this CL. Bug: 802890 Test: None Change-Id: I4c77d07281ebaefec9bb03fd4fba92e436009bd2 TBR=digit@chromium.org Reviewed-on: https://chromium-review.googlesource.com/869110 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jan 14, 2018
-
-
Jungshik Shin authored
When the time is set to MAX_MILLIS, Islamic calendar year and month calculation results in an integer overflow. TBR=littledan@chromium.org Bug: 801602 Test: See the bug (v8 test will be added) Change-Id: Ifcb6907de81de83b690f76a536818054815a15a7 Reviewed-on: https://chromium-review.googlesource.com/865524 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jan 11, 2018
-
-
David 'Digit' Turner authored
Drastically reduce the size of the SmallIntFormatter code. This should make the code slightly slower, but reduce the overall size of the generated library by about 48 kiB. It is unlikely that the performance difference will be noticeable on any existing system Chromium runs on. Bug: NONE Change-Id: I1faa6020c0e9a7cc61f0f274b9a2c4ab6701aece Reviewed-on: https://chromium-review.googlesource.com/836554 Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org>
-
- Jan 09, 2018
-
-
Jungshik Shin authored
38e3cf74 has a typo. Bug: None Change-Id: Id16f30ab5f2938bef567ef898f481696122a1dd3 TBR=hablich@chromium.org Reviewed-on: https://chromium-review.googlesource.com/856237 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-