Skip to content
Snippets Groups Projects
Select Git revision
  • upstream/master
  • master default
  • upstream/chromium/65staging
  • upstream/chromium/char16t_test
  • upstream/chromium/64staging
  • upstream/chromium/m74
  • upstream/chromium/m71
  • upstream/chromium/m72
  • upstream/chromium/win7tz
  • upstream/chromium/char16tv2
  • upstream/chromium/63staging
  • upstream/chromium/m70
  • backup/master
  • upstream/chromium/62staging
  • upstream/chromium/61staging
  • upstream/upstream/master
  • upstream/chromium/m63
  • upstream/upstream/chromium/m63
  • upstream/chromium/60staging
  • upstream/upstream/chromium/60staging
20 results
Search by author
  • Any Author
  • banggua banggua banggua
1 author
  1. Dec 15, 2014
    • Jungshik Shin (jungshik at google)'s avatar
      Add the minimal locale data for ckb and ku · 51c1a4ce
      Jungshik Shin (jungshik at google) authored 
      To have keyboard layouts for ku and ckb, we need to have the minimal
locale data for them - native display name, writing direction, and
exemplar characters.

These are added and the icu data was rebuilt. The Android icu data was
not rebuilt because Android Chrome does not use them.

BUG=204049
TEST=None until ckb and ku are added to the A-L list in a Chrome CL.
When they're,  language and input settings will have ckb and ku listed
with the display name in the current UI language (e.g. Englsih) and native
display name.

Review URL: https://codereview.chromium.org/805073003
      51c1a4ce
  3. Dec 11, 2014
  5. Dec 10, 2014
  7. Dec 04, 2014
  9. Nov 26, 2014
  11. Nov 19, 2014
  13. Nov 14, 2014
  15. Oct 30, 2014
  17. Oct 15, 2014
  19. Oct 13, 2014
  21. Oct 04, 2014
  23. Sep 25, 2014
    • jshin@chromium.org's avatar
      Check in word_ja.txt for Android. · abeeb961
      jshin@chromium.org authored 
      word_ja.txt has not been checked in although the icu data file for Android
(android/icudtl.dat) was built with the file.

README.chromium about Android's brkitr patch was not updated when moving to
ICU 52.1. It's changed to reflect what we do in ICU 52.1 (where the upstream
copy does have cjdict for CJ word breaking).

TBR=andrewhayden@chromium.org
BUG=NONE
TEST=NONE (there's no change affecting Chrome/Blink builds).

Review URL: https://codereview.chromium.org/609493003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292144 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      abeeb961
    • jshin@chromium.org's avatar
      Turn on UCONFIG_NO_NON_HTML5_CONVERTER · 52e8245c
      jshin@chromium.org authored 
      UCONFIG_NO_NON_HTML5_CONVERTER was added earlier to our copy of ICU, but
it was never set to 1.  It's my oversight.

1. Turns UCON..CONVERTER on in icu.gyp to drop all the encodings not
   required by the Encoding spec. Dropped encodings include
   UTF-7, BOCU, SCSU, CESU, ISCII, ISO-2022-{KR, CN*}, HZ-GB, ISO-2022-JP's
   other than the original.

2. A lot more sections of the ICU converter code are excluded when
   it's set to 1 including the code for LMB (Lotus Multibyte) encodings and
   X11 compound text encoding (icu common).

3. The character encoding detections for encodings excluded are also disabled.
   (icu i18n)

4. ISO-2022-{KR, CN*} and HZ-GB can be dropped now because Blink treats them
   as replacement encoding. The corresponding alias entries from convertrs.txt
   are also removed.

5. ibm-874 was removed. We used to need it before Blink started, but not any
   more. We only need windows-874.

6. A mistaken in convertrs.txt was corrected : Big5-HKSCS was pointing to
   an old mapping table.

7. Per ICU upstream's suggestion, use '-html' suffix instead of '-html5'
for the encoding tables derived from the WHATWG's encoding spec (ibm866,
shift_jis and euc-jp).

The static 64-bit release build of Chrome on Linux went down from
141,596,616 to 141,491,968 bytes (~ 100 kB reduction). Besides, the icu data
size got smaller by ~ 19 kB ( 10,490,576 to 10,471,008 bytes).

See http://bugs.icu-project.org/trac/ticket/11296 for an upstream bug
I've filed on the issue.


BUG=76328
TEST=browser_tests --gtest_filter="*ncoding*"
TEST=net_unittest --gtest_filter="*ilenameUtil*"
TEST=base_unittests --gtest_filter="*Conv*"
TEST=Blink: fast/encoding/*
TEST=With shared library build, the following has no match.
  nm libicuuc.so | egrep  -i '(bocu|scsu|utf7|2022kr|2022cn|iscii)'
  nm libicui18n.so | egrep  -i '(2022kr|2022cn|ibm42)'
TEST=With static library build, the following has no match.
  nm chrome | egrep -i '(bocu|scsu|utf7|2022kr|2022cn|iscii|ibm42)'

R=jsbell@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/587833004

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292131 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      52e8245c
  25. Sep 17, 2014
  27. Sep 03, 2014
    • torne@chromium.org's avatar
      Remove invalid link_settings from target condition. · 89831135
      torne@chromium.org authored 
      ICU fails to gyp when run with GYP_DEFINES="android_webview_build=1
use_system_icu=0 use_system_stlport=1" which is a combination of
settings we're trying to bring up temporarily as we migrate away from
system libraries. It fails because it's not permitted to specify
link_settings in a target_condition as the processing is too late.

Remove the invalid link_settings, since we can't do this outside
target_conditions as it's not valid to use -lgabi++ on the host build of
ICU. The link dependency on gabi++ will have to be satisfied manually in
the main libwebviewchromium target instead for this configuration.

BUG=409851
R=mkosiba@chromium.org
TBR=jshin@chromium.org

Review URL: https://codereview.chromium.org/527193003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@291781 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      89831135
  29. Sep 02, 2014
    • jshin@chromium.org's avatar
      Update tz data to 2014f and add SJIS for the encoding spec · ff835309
      jshin@chromium.org authored 
      1. Timezone data files (4 of them) in source/data/misc to 2014f (the latest)
   to prepare for an upcoming Russian timezone change.
2. Add Shift_JIS converter compliant to the WHATWG encoding spec.
3. Update converters.txt and ucmlocal.mk accordingly
4. Update the pre-built data files for Linux/Mac/Android/Windows.
   (icudt.dll is not updated in this CL. It's not used in the default
    configuration. It'll be updated in a separate CL).
5. Fix a typo in ibm866_gen.sh. The acual table used does not need a change.


BUG=277062,404445
TEST=After rolling icu to this revision, the following tests should pass.
TEST=Blink: fast/encoding/* all pass except for
fast/encoding/api/ascii-supersets.html that should fail by *passing*
the test for Shift_JIS, which is expected to fail. Blink layout tests needs
to be updated.
TEST=browser_tests --gtest_filter="*ncoding*"
TEST=In JS console, run the following to check if Europe/Moscow is
3 hrs ahead of UTC after Oct 26 and 4 hrs ahead before that and
if Asia/Kamchatka remains 12 hrs ahead of UTC.
  nov1_2014_1500=new Date("11/01/2014 15:00Z")
  nov1_2014_1500.toLocaleString("en", {timeZone: "Europe/Moscow"})
  nov1_2014_1500.toLocaleString("en", {timeZone: "UTC"})
  nov1_2014_1500.toLocaleString("en", {timeZone: "Asia/Kamchatka"})
  oct24_2014_1500=new Date("10/24/2014 15:00Z")
  oct24_2014_1500.toLocaleString("en", {timeZone: "Europe/Moscow"})
  oct24_2014_1500.toLocaleString("en", {timeZone: "UTC"})
  oct24_2014_1500.toLocaleString("en", {timeZone: "Asia/Kamchatka"})
TEST=net_unittest --gtest_filter="*ilenameUtil*"
TEST=base_unittests --gtest_filter="*Conv*"
R=jsbell@chromium.org

Review URL: https://codereview.chromium.org/497543003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@291774 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      ff835309
  31. Aug 28, 2014
  33. Aug 26, 2014
  35. Aug 21, 2014
  37. Aug 01, 2014
  39. Jul 24, 2014
  41. Jun 18, 2014
  43. Jun 17, 2014
  45. Jun 10, 2014
  47. May 24, 2014
  49. May 20, 2014
  51. May 06, 2014
  53. May 05, 2014
    • jshin@chromium.org's avatar
      Add back display names for non-UI languages in A-L list · 4266d6d1
      jshin@chromium.org authored 
      I was too aggressive in trimming the data and dropped the display
names for languages that Chromium needs (for non-UI languages
that are in the A-L list). It's not my intention (the comment in
trim_data.sh said one thing, but the code did another). 

Besides, add Norweigian (nb) and Malay (ms) locale data that were not 
included by mistake.

Also update trim_data.sh script NOT to drop 'ALIAS' lines which are
used to indicate that a given locale is an alias to another locale.
That also required adding ro_MD.txt (null locale which mo.txt is 
aliased to).

The above three adds about 110kB to the icu data (from 10.3MB to 10.4MB).

Also update the pre-built icu data files for Linux, Mac and Windows.
The Android data will be updated in a follow-up patch.

BUG=132145
TEST=When ICU is rolled, unit_tests:ExtensionL10* pass.
TBR=mark

Review URL: https://codereview.chromium.org/264973016

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@268285 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      4266d6d1
  55. Apr 30, 2014
  57. Apr 29, 2014
  59. Apr 28, 2014
    • jshin@chromium.org's avatar
      Add icudt.dll for Windows · 8df7e257
      jshin@chromium.org authored 
      1. Generate and add windows/icudt.dll with the procedure outlined
in README.chromium. It uses a out-of-tree copy of the upstream ICU
along with our custom-built icudtl.dat and a locally modified version
of makedata.mak.

We used to have a separate build/ directory for VS solution/project files
to build icudtl.dll. Maintaining them is rather cumbersom now that we
want to update our ICU (major version changes) more frequently. 

Note that icudt.dll is not used by default (icu_use_data_file_flag=1). 
The GN build still uses it by default and we should not break that build.

2. Add scripts/make_mac_assembly.sh to simplify the generation of the icu
data assembly source file for Mac.

3. Update README.chromium accordingly.

This CL was uploaded and reviewed at 

https://codereview.chromium.org/255943004/

Due to a malfunction at codereview.chromium.org, I'm landing this CL 
manually in two parts. 
This check-in is the 2nd part of the CL dealing with #2 and #3
above.

BUG=132145
TEST=None until icu is rolled to this version.


git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@266602 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      8df7e257
    • jshin@chromium.org's avatar
      Add icudt.dll for Windows · be1611ad
      jshin@chromium.org authored 
      1. Generate and add windows/icudt.dll with the procedure outlined
in README.chromium. It uses a out-of-tree copy of the upstream ICU
along with our custom-built icudtl.dat and a locally modified version
of makedata.mak.

We used to have a separate build/ directory for VS solution/project files
to build icudtl.dll. Maintaining them is rather cumbersom now that we
want to update our ICU (major version changes) more frequently. 

Note that icudt.dll is not used by default (icu_use_data_file_flag=1). 
The GN build still uses it by default and we should not break that build.

2. Add scripts/make_mac_assembly.sh to simplify the generation of the icu
data assembly source file for Mac.

3. Update README.chromium accordingly.

This CL was uploaded and reviewed at 

https://codereview.chromium.org/255943004/

Due to a malfunction at codereview.chromium.org, I'm landing this CL 
manually.

BUG=132145
TEST=None until icu is rolled to this version.


git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@266601 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      be1611ad
  61. Apr 24, 2014