- Aug 29, 2019
-
-
Frank Tang authored
Issue discovered in https://chromium-review.googlesource.com/c/v8/v8/+/1771954 Bug: chromium:997401 Change-Id: I1afa6beb195b5d350f7d4c4e39ad7a0b20a8b99a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1776986 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Aug 22, 2019
-
-
Frank Tang authored
Merge https://github.com/unicode-org/icu/pull/714 https://github.com/unicode-org/icu/pull/671 https://github.com/unicode-org/icu/pull/747 Bug: v8:7051 Change-Id: I3aa88f0b08d3fcfe89f07f71bfd5db0a6c337790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1763047 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Aug 19, 2019
-
-
Frank Tang authored
This newly built DAT file contains new locales for Android: "bn", "et", "gu", "kn", "ml", "mr", "ms", "ta", "te", "af", "az", "eu", "gl", "hy", "is", "ka", "kk", "km", "ky", "lo", "mk", "mn", "my", "ne", "pa", "si", "sq", "ur", "uz", "zu" It can be used in conjunction with android_small/icudtl.dat The application (chrome on android) should load the icudtl_extra.dat FIRST before loading android_small/icudtl.dat To work around the limitation of ICU's handling of multiple data packages, the following is done for android_small/icudatl_extra.dat. a. Do not use pool bundles. usePoolBundle is set to false in android_extra.json. b. Filter out res_index.res files with "icupkg -r" Bug: chromium:969181 Change-Id: I9a3407bfcbe4a55e1f9bda1daa713e4487fbfbba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1648623 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Aug 14, 2019
-
-
Frank Tang authored
This is needed to split icu data resources into multiple files without requiring root.res to be present in all of them. https://unicode-org.atlassian.net/browse/ICU-20774 Bug: chromium:969181 Change-Id: I7b397b95bfd691cc07e4f04a05bf54d691fd5995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1754515 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Aug 13, 2019
-
-
Frank Tang authored
This patch adds 'usePoolBundle' to the build tool. When building android_small/icudatl_extra.dat, 'userPoolBundle' has to be set to false. See https://unicode-org.atlassian.net/browse/ICU-20660 and https://github.com/unicode-org/icu/pull/682 for details. Bug: chromium:969181 Change-Id: Ie721d63eaa8426f952d2809c7189574b8f737c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1753028 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Aug 09, 2019
-
-
Frank Tang authored
According to the announcement at https://mm.icann.org/pipermail/tz-announce/2019-July/000056.html Brazil no longer observes DST. Palestine's 2019 spring-forward transition was on 03-29, not 03-30. The tz-related files are updated by running update_tz.sh and ICU data files are rebuilt. Either in JS console in Chrome or v8 should work like these: d8> new Date(Date.UTC(2020, 0, 20, 9, 59)).toLocaleString("en", {timeZone: "America/Sao_Paulo", timeZoneName: "long"}) d8> new Date(Date.UTC(2020, 0, 20, 9, 59)).toLocaleString("en", {timeZone: "America/Cuiaba", timeZoneName: "long"}) d8> new Date(Date.UTC(2020, 0, 20, 9, 59)).toLocaleString("en", {timeZone: "America/Campo_Grande", timeZoneName: "long"}) EXPECT to see these dates are under Standard Time. "1/20/2020, 6:59:00 AM Brasilia Standard Time" "1/20/2020, 5:59:00 AM Amazon Standard Time" "1/20/2020, 5:59:00 AM Amazon Standard Time" BEFORE this CL we got them under Summer Time. "1/20/2020, 7:59:00 AM Brasilia Summer Time" "1/20/2020, 6:59:00 AM Amazon Summer Time" "1/20/2020, 6:59:00 AM Amazon Summer Time" Notice the change only apply to future date and summer in Brazil is during the winter of USA. Bug: chromium:991739 Test: See the above. Change-Id: I348254c4a5042c6b16c6a72cb7d69742f3d57778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1745356 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jul 24, 2019
-
-
Frank Tang authored
Reduce the size impact to android and iOS android_small & ios reduce 29.3K from the previous check in. Bug: v8:9475 Change-Id: I47ee04647b754c2032c44b9e541e96789ab7b14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1715623 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jul 23, 2019
-
-
Frank Tang authored
Add missing 'yard' data. Adding volume units and vehicle mileage context for unified-intl-numberformat To sync with https://github.com/tc39/proposal-unified-intl-numberformat/pull/48 Size increase: android_small & ios 34.6K android 53.8K chromeos 43.3K common 15K Bug: v8:9475 Change-Id: I69bb19c47d540062ca5e92b77a5adcd29569ffe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1699115 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jun 20, 2019
-
-
Frank Tang authored
Change-Id: Ic1c344b7a0631a51fc696cfa7c3e9ea3098cbc20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1669795 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
Frank Tang authored
Upstream bug: https://unicode-org.atlassian.net/browse/ICU-20654 Upstream PR: https://github.com/unicode-org/icu/pull/674 Test: test/intl402/RelativeTimeFormat/prototype/format/en-us-numeric-auto.js (changed by https://github.com/tc39/test262/pull/2191) Bug: v8:9327 Change-Id: Ib80f7d1554594f25a625f31f6e7755ee48b9758c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1670016 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- May 31, 2019
-
-
Frank Tang authored
Upstream PR: https://github.com/unicode-org/icu/pull/663 Bug: chromium:966377 Change-Id: Icde4128f0c333e6c1cf79704789f893b9a5f3780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1637963 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- May 29, 2019
-
-
Yang Guo authored
The symbol currently defined in the generated assembly does not match what the linker expects. Also remove the outdated special case for is_win. R=jshin@chromium.org Bug: chromium:938223 Change-Id: I2c2d3a16df7fa7f6801d70cdf4a80e99e2572f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1599430 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- May 23, 2019
-
-
Frank Tang authored
1. Move the post filtering logic from (cast|flutter)/(cast|flutter)-removed-resources.txt to filters/(cast|flutter).json 2. Reduce cast/icudtl.dat by 8K & flutter/icudtl.dat by 6.2K by removing unnecessary entries in res_index.res which the real res files was previously removed by bin/icupkg. 3. Simplified copy_data.sh and diff_data.sh 4. Remove the reference of flutter/flutter-removed-resources.txt from flutter/README.md Bug: chromium:943348 Change-Id: Iedaad3a5c05098aa8ad67a9bf7165ef74ee816e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1623634 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- May 21, 2019
-
-
Frank Tang authored
Android/iOS do not use Language/Script names except for zh*, Han* and a few others. There's no need to have a complex lang display name rules. Reduce ios/icudtl.dat 2.1K by removing Languages%short Languages%variant Scripts%short Scripts%variant Bug: 951636 Change-Id: I590c41bf68652d8d99bedd035a7fded3210533a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1565281 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- May 15, 2019
-
-
Frank Tang authored
Preparation work to implement Unified Intl.NumberFormat Feature Proposal. Add all units in https://github.com/tc39/proposal-unified-intl-numberformat/pull/42 Size Impact: No size changes to common, cast, flutter Minor (0.3K - 10K) increase to chromeos, android and ios Buil BEFORE AFTER INCREASE chromeos 10394080 10405072 10992 android 7760528 7767088 6560 android_small 6420432 6420784 352 ios 6372800 6373152 352 Bug: v8:8515 Change-Id: I0a48d416bb4cf794233ca04853e4cd9c9825f237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1614319 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- May 11, 2019
-
-
Frank Tang authored
This is an update to the previous fix at https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1602037 It takes care of threading issue in initDefault in timezone.cpp as well. See https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8913891060019594592/+/steps/Check/0/logs/DateCache.AdoptDefaultMixed/0 Upstream bug: https://unicode-org.atlassian.net/browse/ICU-20595 upstream PR: https://github.com/unicode-org/icu/pull/649/ Bug: chromium:950851 Test: v8 unittests - DateCache:AdoptDefault* Change-Id: Ifc215e02992050af5c55e1cc0208cff61112c9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1604257 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- May 10, 2019
-
-
Frank Tang authored
The icu::TimeZone::adoptDefault may delete a old default timezone while anther thread is calling the clone() to that old default timezone in the createDefault running on another thread. Need to protect the delete and DEFAULT_ZONE->clone() running concurrently. Otherwise, the returned cloned TimeZone could contains partially trashed data and cause crash later on. test in https://chromium-review.googlesource.com/c/v8/v8/+/1601370 Upstream bug: https://unicode-org.atlassian.net/browse/ICU-20595 upstream PR: https://github.com/unicode-org/icu/pull/649/ Bug: chromium:950851 Test: v8 unittests - DateCache:AdoptDefault* Change-Id: Ic8a1c374f20a50f5ebd567df8d34a65987315a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1602037 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- May 08, 2019
-
-
Frank Tang authored
1. copy_data.sh is modified to copy 3 timezone resource files tzres for a separate tz update on fucshia. 2. Adds ulayout back for Blink to use in layout (vertical orientation, Indic layout properties, etc). Increase 13K on all data file except iOS. File ICU64-2 NEW DIFF chromeos 10380672 10394080 13408 common 10396864 10410272 13408 cast 5101760 5115168 13408 android 7747120 7760528 13408 android_small 6407040 6420432 13392 ios 6372800 6372800 0 flutter 894736 908144 13408 Bug: 958948,959155 Change-Id: I185f1c0554a515cfa8fe670935ca785698974c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1599896 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Apr 19, 2019
-
-
Frank Tang authored
Also fix Abrt in icu_64::RegexCompile::handleCloseParen Upstream PR and bug in ICU https://unicode-org.atlassian.net/browse/ICU-20391 https://github.com/unicode-org/icu/pull/628 Bug: chromium:952851 Change-Id: I74540026171591c582747742c85abaf35b7edc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1573807 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Apr 18, 2019
-
-
Frank Tang authored
Test in https://chromium-review.googlesource.com/c/v8/v8/+/1573038 Bug: v8:8604 Change-Id: I139442a7eb85ee1c141c1678270a6334783096fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1570225 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Apr 12, 2019
-
-
Frank Tang authored
- Support new Japanese Era (952305) - Update to Unicode 12.1 - Fix undefined U_DISABLE_VERSION_SUFFIX warning (949962) For more detail, see http://site.icu-project.org/download/64 Also - Fix Fuzzer bug of RegExp breakage (949885) Bug: 952305, 949962, 949885, 952305 Change-Id: I32616f805c0d824b80786b502d96a13c201e15b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1566439 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
Jungshik Shin authored
'disable-layoutex' has to be passed when running runConfigureICU for data configuration because layoutex directory is not present in Chrome's ICU. Also, fold config_data.sh into make_data_all.sh as a function 'config_data'. That way, it's easier to bail out early when config_data fails. TBR=ftang@chromium.org BUG=None Test=make_data_all.sh produces identical data files for all platforms Change-Id: Ief4dafd3693e7a8e8f52ae49d4ff67dd7e499e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1564213 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Apr 11, 2019
-
-
Frank Tang authored
Copy the old filters/android.json to filters/android_small.json Copy the old android/icudtl.dat to android_small/icudtl.dat Add 32 locales to filters/android.json and rebuild. Change the BUILD.gn to use android_small for now. af az eu fr-CA gl hy is ka kk km ky lo mk mn my ne pa si sq ur uz zh-HK zu bn et gu kn ml mr ms ta te Compare to android/icudtl.dat. It increase 1.28M. 7746368 android/icudtl.dat 6406288 android_small/icudtl.dat Bug: 951636 Change-Id: I4c4f43add3c76adf5da215342ec4460bbaf2de87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1562954 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Apr 09, 2019
-
-
Frank Tang authored
2019a was announced on March 26 2019. https://mm.icann.org/pipermail/tz-announce/2019-March/000055.html Palestine "springs forward" on 2019-03-30 instead of 2019-03-23. Metlakatla "fell back" to rejoin Alaska Time on 2019-01-20 at 02:00. Either in JS console in Chrome or v8 should work like these: new Date(Date.UTC(2019, 0, 20, 9, 59)).toLocaleString("en", {timeZone: "America/Metlakatla", timeZoneName: "long"}) new Date(Date.UTC(2019, 0, 20, 10, 00)).toLocaleString("en", {timeZone: "America/Metlakatla", timeZoneName: "long"}) new Date(Date.UTC(2019, 2, 10, 10, 59)).toLocaleString("en", {timeZone: "America/Metlakatla", timeZoneName: "long"}) new Date(Date.UTC(2019, 2, 10, 11, 00)).toLocaleString("en", {timeZone: "America/Metlakatla", timeZoneName: "long"}) EXPECT to see the 2nd and 3rd dates are under Alaska Time. "1/20/2019, 1:59:00 AM Pacific Standard Time" "1/20/2019, 1:00:00 AM Alaska Standard Time" "3/10/2019, 1:59:00 AM Alaska Standard Time" "3/10/2019, 3:00:00 AM Alaska Daylight Time" BEFORE this CL we got the 2nd and third date in Pacific Time. "1/20/2019, 1:59:00 AM Pacific Standard Time" "1/20/2019, 2:00:00 AM Pacific Standard Time" "3/10/2019, 2:59:00 AM Pacific Standard Time" "3/10/2019, 3:00:00 AM Alaska Daylight Time" Bug: 473288 Test: See the above. Change-Id: Id5add2356fb235f31ab17da2eef74adabb1a21fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1555215 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Apr 04, 2019
-
-
Frank Tang authored
What's new in ICU 64.1: - Unicode 12: 554 new characters, including 4 new scripts and 61 new emoji characters. - CLDR 35 locale data http://blog.unicode.org/2019/03/unicode-cldr-version-35-languagelocale.html - ICU 64 now uses "rearguard" TZ data. (Recent versions have used "vanguard" data with certain overrides.) (ICU-20398) - ICU data filtering: The ICU4C build accepts an optional filter script that specifies a subset of the data to be built, with whitelists and blacklists for locales and for resource bundle paths. (ICU-10923, design doc) - MessageFormat has new pattern syntax for specifying the style of a date/time argument via a locale-independent skeleton rather than a locale-specific pattern. (ICU-9622) * Date/time skeletons use the same "::" prefix as number skeletons. * Example MessageFormat pattern string: "We close on {closing,date,::MMMMd} at {closing,time,::jm}." - Many formatting APIs can now output a new type of result object which is-a FormattedValue (Java & C++), or convertible to a UFormattedValue (C). * These combine the result strings with easy iteration over FieldPosition metadata. - New C++ class LocaleBuilder for building a Locale from subtags, keywords, and extensions. (ICU-20328) Parallel to the existing ICU4J ULocale.Builder class. - For C++ MeasureUnit instances, there are now additional factory methods that return units by value, not by pointer-with-ownership. (ICU-20337) - Various Out-Of-Memory (OOM) issues have been fixed. (ticket query) - See http://site.icu-project.org/download/64 for more details. The update steps are recorded : https://chromium.googlesource.com/chromium/deps/icu/+log/20690c6..6d422ff - Update update.sh to point to ICU's new repo location - Import the pristine copy of ICU 64.1 and update BUILD files with update.sh - Update and apply locale data patches 1. patches/locale_google.patch: * Google's internal ICU locale changes * Simpler region names for Hong Kong and Macau in all locales * Currency signs in ru and uk locales (do not include 'tr' locale changes) * AM/PM, midnight, noon formatting for a few Indian locales * Timezone name changes in Korean and Chinese locales * Default digit for Arabic locale is European digits. - patches/locale1.patch: Minor fixes for Korean 2. Breakiterator patches - patches/wordbrk.patch for word.txt a. Move full stops (U+002E, U+FF0E) from MidNumLet to MidNum so that FQDN labels can be split at '.' b. Move fullwidth digits (U+FF10 - U+FF19) from Ideographic to Numeric. See http://unicode.org/cldr/trac/ticket/6555 - patches/khmer-dictbe.patch Adjust parameters to use a smaller Khmer dictionary (khmerdict.txt). https://unicode-org.atlassian.net/browse/ICU-9451 - Add several common Chinese words that were dropped previously to source/data/cjdict/brkitr/cjdict.txt patch: patches/cjdict.patch upstream bug: https://unicode-org.atlassian.net/browse/ICU-10888 3. Build-related changes - patches/configure.patch: * Remove a section of configure that will cause breakage while running runConfigureICU. - patches/wpo.patch (only needed when icudata dll is used). upstream bugs : https://unicode-org.atlassian.net/browse/ICU-8043 https://unicode-org.atlassian.net/browse/ICU-5701 - patches/data_symb.patch : Put ICU_DATA_ENTRY_POINT(icudtXX_dat) in common when we use the icu data file or icudt.dll - patches/staticmutex.patch : Change the static UMutex code to avoid static_initializers error. upstream bug: https://unicode-org.atlassian.net/browse/ICU-20520 - patches/buildtool.patch : Fix the build tool which ommited res_index.res */res_index.res files upstream bug: https://unicode-org.atlassian.net/browse/ICU-20529 upstream PR: https://github.com/unicode-org/icu/pull/571/ 4. Double conversion library build failure - patches/double_conversion.patch - upstream bugs: https://unicode-org.atlassian.net/browse/ICU-13750 https://github.com/google/double-conversion/issues/66 5. ISO-2022-JP encoding (fromUnicode) change per WHATWG encoding spec. - patches/iso2022jp.patch - upstream bug: https://unicode-org.atlassian.net/browse/ICU-20251 - ICU data files are rebuilt Up to 67kB increase. Since we also save 43K in https://chromium-review.googlesource.com/c/v8/v8/+/1478710 , the net increase is only 24KB. ** ICU Data Size Change ** Data Size ICU63 ICU64-1 DIFF chromeos 10326064 10378624 52560 common 10326064 10394816 68752 cast 5126144 5101616 -24528 android 6355520 6406256 50736 ios 6315248 6372016 56768 flutter 880928 894752 13824 Created by: git rev-list --reverse 20690c62..6d422ffa | \ xargs git cherry-pick --strategy=recursive -X theirs Bug: chromium:943348 Change-Id: Ia7f86abfa8625dd24aae2f71456abd679fda3dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1552155 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Mar 23, 2019
-
-
Jungshik Shin authored
Mobile data size is reduced by ~150 kB. 6355520 6197072 android/icudtl.dat 5126144 5053168 cast/icudtl.dat 10326064 10326064 common/icudtl.dat 880928 880336 flutter/icudtl.dat 6315248 6156800 ios/icudtl.dat Bug: None Change-Id: I1f8afee17362f6575f7716fa5d61691281a4fc11 TBR=ftang@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1536568 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Mar 18, 2019
-
-
Frank Tang authored
This is to prepare for later we can trim data only needed for chromeos from the data files in common. Bug: v8:8515 Change-Id: I81e88376046e57a7c415dae9d05083abf6d91558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1503687 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Mar 12, 2019
-
-
Yang Guo authored
On non-Windows platforms, we generate assembly to bundle ICU data. On Windows however, we previously use a checked in icudt.dll, which is no longer maintained. We could use the same assembly approach if we wrap in inline assembly. Bug: chromium:938223 Change-Id: Ieced205ae2e082a5290bd45499216c6c86751ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1503032 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Feb 28, 2019
-
-
Jungshik Shin authored
Region-name patch was not applied to 3 locales (zh-Hant, lt, and lv) when updating ICU to 63.1 by mistake. This affects the region display names for HK, MO, and FK. Update the patch file: locale_google.patch accordingly. TBR=yyushkina@chromium.org Bug: 926644 Test: In settings-language menu, HK's display name in zh-Hant is '香港'. Change-Id: Idc259d75ffa092ff3fee5b126bcbd88db364979b Reviewed-on: https://chromium-review.googlesource.com/c/1493786 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Feb 16, 2019
-
-
Frank Tang authored
Locale has bugs related to grandfather tag processing. This block the v8 Intl.Locale launch. Upstream bugs: https://unicode-org.atlassian.net/browse/ICU-20187 https://unicode-org.atlassian.net/browse/ICU-20407 https://unicode-org.atlassian.net/browse/ICU-20410 https://unicode-org.atlassian.net/browse/ICU-20411 Upstream fixes: https://github.com/unicode-org/icu/pull/418 https://github.com/unicode-org/icu/pull/414 https://github.com/unicode-org/icu/pull/416 Bug: 913298,v8:8260,v8:8242 Test: In v8, fix intl402/Locale/constructor-non-iana-canon Test: v8: intl402/Locale/constructor-tag, and intl402/Locale/likely-subtags-grandfathered Change-Id: Ifcff754587bba75413987729fac8f563ba5e75e0 Reviewed-on: https://chromium-review.googlesource.com/c/1476117 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jan 17, 2019
-
-
Eli Ribble authored
This was removed to save space. The latest YT Music app apprently needs this data and cast crashes without it. cast/icudtl.dat size before change: 4747296 bytes cast/icudtl.dat size after change: 5126768 bytes Size increase: 379472 bytes Bug: b/120812705 Test: On Chromecast Audio Change-Id: I543cd61b05b28a4b51fcab20d75116b2fe05bed7 Reviewed-on: https://chromium-review.googlesource.com/c/1416138 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Jan 04, 2019
-
-
Jungshik Shin authored
2018h and 2018i were announced in a quick succession in the last week of 2018. https://mm.icann.org/pipermail/tz-announce/2018-December/000053.html https://mm.icann.org/pipermail/tz-announce/2018-December/000052.html Timezones in a part of Kazakhstan (Asia/Qyzylorda changed its offset and new timezone Asia/Qostanay was added), a part of Alaska, São Tomé and Príncipe changed at the end of 2018 or at the beginning of 2019. They require this update now. Either in JS console in Chrome or v8 should work like these: d8> new Date(Date.UTC(2018,11,20,12)).toLocaleString("en", {timeZone: "Asia/Qyzylorda"}) "12/20/2018, 6:00:00 PM" d8> new Date(Date.UTC(2018,11,21,12)).toLocaleString("en", {timeZone: "Asia/Qyzylorda"}) "12/21/2018, 5:00:00 PM" d8> new Date(Date.UTC(2018,11,20,12)).toLocaleString("en", {timeZone: "Asia/Qostanay"}) "12/20/2018, 6:00:00 PM" d8> new Date(Date.UTC(2018,11,21,12)).toLocaleString("en", {timeZone: "Asia/Qostanay"}) "12/21/2018, 6:00:00 PM" d8> new Date(Date.UTC(2018,11,31,12)).toLocaleString("en", {timeZone: "Africa/Sao_Tome"}) "12/31/2018, 1:00:00 PM" d8> new Date(Date.UTC(2019,0,1,12)).toLocaleString("en", {timeZone: "Africa/Sao_Tome"}) "1/1/2019, 12:00:00 PM" Future expected changes in Iran and Moroco are also included in this update. Bug: 473288 Test: See the above. Change-Id: If9f8503eebbf1e7eefb504a73140b4e3a37c3cf9 TBR=gsathya@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1395498 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Dec 14, 2018
-
-
Jungshik Shin authored
Windows component build with clang has this compile error. icu_63::uprv_detectWindowsTimeZone' should not add 'dllexport' attribute [-Werror,-Wdll-attribute-on-redeclaration] uprv_detectWindowsTimeZone() Cherry-pick https://github.com/unicode-org/icu/pull/318 TBR=gsathya@chromium.org,ftang@chromium.org Bug: 913298 Test: Windows component build compiles w/o any error. Change-Id: I45fc8ac2c1f5fa7821178fea5985c5df6afea850 Reviewed-on: https://chromium-review.googlesource.com/c/1377561 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
Jungshik Shin authored
Windows 7 has a 'bug' in one of its timezone APIs. ICU's timezone detection code was hardened to work 'around' the bug. Upstream bug: https://unicode-org.atlassian.net/browse/ICU-20302 Upstream fix: https://github.com/unicode-org/icu/pull/315 TBR=gsathya@chromium.org,ftang@chromium.org Bug: 913298 Test: See bug comment 35 Change-Id: Ib13b6a2809c629929490c5bfd73bee93b2c918c2 Reviewed-on: https://chromium-review.googlesource.com/c/1377557 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Dec 12, 2018
-
-
Frank Tang authored
Fix the locale parsing with tz which resolved to a tz name which have a _ in it. "uslax" is resolved to "Los_Angles" and cause that. TEST=In v8 or Chrome console, new Intl.DateTimeFormat("ja-u-tz-uslax") works fine. resolvedOptions().timeZone is 'America/Los_Angenles'. Bug: v8:8469 Change-Id: I996790b1ce59fbb5f6b0a460ff8acdb674894df1 Reviewed-on: https://chromium-review.googlesource.com/c/1372810 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Nov 17, 2018
-
-
Jungshik Shin authored
According to the announcement at https://mm.icann.org/pipermail/tz-announce/2018-October/000052.html , Morocco switches from +00/+01 to permanent +01 effective 2018-10-27, so its clocks will not fall back on 2018-10-28 as previously scheduled. The tz-related files are updated by running update_tz.sh and ICU data files are rebuilt. In 2017, on the last Sunday of October, there was fall backward. d8> new Date(Date.UTC(2017, 9, 28,12)).toLocaleString("en", {timeZone: "Africa/Casablanca"}) "10/28/2017, 1:00:00 PM" d8> new Date(Date.UTC(2017, 9, 29,12)).toLocaleString("en", {timeZone: "Africa/Casablanca"}) "10/29/2017, 12:00:00 PM" In 2018, there is no transition on the last Sunday of October. d8> new Date(Date.UTC(2018,9,27,12)).toLocaleString("en", {timeZone: "Africa/Casablanca"}) "10/27/2018, 1:00:00 PM" d8> new Date(Date.UTC(2018,9,28,12)).toLocaleString("en", {timeZone: "Africa/Casablanca"}) "10/28/2018, 1:00:00 PM" TBR=ftang@chromium.org Bug: 473288 Test: See the above Change-Id: Icc2c2a377e3c2d03c7d57cd99a1594773cb10c81 Reviewed-on: https://chromium-review.googlesource.com/c/1341453 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
Jungshik Shin authored
Make the locale variant support more uniform across locale categories. What's supported in the main locale categories (data/locales) are added to data/{unit,curr} as well. The list of locales in data/zone is not yet updated. Moreover, sr and sw variants are added to data/{locales,unit,curr}. The cast removal list is simplified using 'glob' pattern instead of listing individual files for curr and unit categories. The data size is still under control on most platforms. They're actually smaller than the first ICU 63.1 update thanks to additional trimming in zone/unit categories except on desktop (59kB increase). Initial 63.1 This CL Platform 6375056 6353648 android 4916608 4745488 cast 10268240 10324816 common 880512 880928 flutter 6361376 6313376 ios TBR=almasrymina@chromium.org,ftang@chromium.org,gsathya@chromium.org Change-Id: I21dc5ec752795f485cfeb64ab1eb7eb8b23f3991 Bug: 863739 Test: {base,components,net}_unittests, blink, v8(intl/*,test262/intl402) Reviewed-on: https://chromium-review.googlesource.com/c/1335789 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Nov 14, 2018
-
-
Jungshik Shin authored
Cherry-pick another upstream patch to improve the performance of UnicodeSet. https://github.com/unicode-org/icu/pull/278 Bug: 899983,901532 Test: Android webview start-up perf and Windows perf graph Change-Id: I2c2a22a398883178734a2c2a6c5975d9551b039e TBR=ftang@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1335799 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
Jungshik Shin authored
On Android, add Islamic calendar to Arabic and Farsi locales and Indian calendar to Hindi locale. Also add both variants of Ethiopic calendars to am/root. There was a 'typo' in the locale trimming script for Android ('arabic' instead of 'islamic' was specified.). As a result, Date formatting in ar-SA (where the default calendar is Islamic) failed for the lack of locale data. Add back calendar entries to data/locales/root.txt. They're necessary to support locale-specific calendars on Android (e.g. islamic on ar/fa, japanese on ja, hebrew on he, etc). Adjust the drop list for the data file for cast. More locale variants have been added since it's made. Drop locale bundles for newly added variants. Drop zone/unit data for 8 locales Android Chrome does not yet support. This saves over 100 kB. For all platforms, drop a few more items not yet used in Chromium/v8. With this change, the net data size decreased on all platforms, paving the way to add more locale variants in a subsequent CL. Previous This CL Platform 6375056 6235856 android 4916608 4714896 cast 10268240 10258960 common 880512 879104 flutter 6361376 6195600 ios TBR=ftang@chromium.org,gsathya@chromium.org Bug: v8:8432 Test: v8: intl/regress-8432-* Change-Id: Iafd94c08ea4e88b33aed4724309636c3e224bdc2 Reviewed-on: https://chromium-review.googlesource.com/c/1325943 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Nov 08, 2018
-
-
Jungshik Shin authored
The start-up performance regression reported for Android WebView and Windows Chrome is traced to UnicodeSet creation for Unicode character properties. This upstream PR speeds up UnicodeSet creation. Upstream bug: https://unicode-org.atlassian.net/browse/ICU-20250 Upstream PR: https://github.com/unicode-org/icu/pull/265 TBR=ftang@chromium.org Bug: 899983,901532 Test: Android webview start-up perf. Change-Id: Iffb6eac4ddde2cabd2f55fe718a9b4e3f39b4e05 Reviewed-on: https://chromium-review.googlesource.com/c/1325398 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-