Skip to content
Snippets Groups Projects
Select Git revision
  • upstream/master
  • master default
  • upstream/chromium/65staging
  • upstream/chromium/char16t_test
  • upstream/chromium/64staging
  • upstream/chromium/m74
  • upstream/chromium/m71
  • upstream/chromium/m72
  • upstream/chromium/win7tz
  • upstream/chromium/char16tv2
  • upstream/chromium/63staging
  • upstream/chromium/m70
  • backup/master
  • upstream/chromium/62staging
  • upstream/chromium/61staging
  • upstream/upstream/master
  • upstream/chromium/m63
  • upstream/upstream/chromium/m63
  • upstream/chromium/60staging
  • upstream/upstream/chromium/60staging
20 results
Search by author
  • Any Author
  • banggua banggua banggua
1 author
  1. Nov 02, 2018
  3. Oct 24, 2018
    • Jungshik Shin's avatar
      Update ICU to 63.1 + Chromium patches · 42d50279
      Jungshik Shin authored 
      What's new in ICU 63.1:
  - CLDR 34 locale data
    http://cldr.unicode.org/index/downloads/cldr-34-1
  - Curreny/Number range format
  - Better/more support for field iterator in formatters - necessary
    for v8's Ecma 402 implementation
  - Better/safer locale APIs
  - See http://site.icu-project.org/download/62 for more details.

The update steps are recorded :
  https://chromium.googlesource.com/chromium/deps/icu/+log/ccad447..b0bb170

* Update update.sh to point to ICU's new repo location

* Import the pristine copy of ICU 63.1 and update BUILD
  files with update.sh

* Update and apply locale data patches
  - locale_google.patch
  - locale1.patch

* Adjust/apply/update brkiter related patches
  - In place of line_normal_fi.txt, add back
    line_loose.txt (Finnish tailoring is absorbed into
    root).
  - data/brkitr/* are adjusted accordingly
  - android/brkitr.patch and flutter/brkitr.patch
    are updated
  - Use 'normal-cj' for line-breaking in zh/ja locales by
    default
  - Apply cjdict.patch and khmerdict.patch

* Apply build-related patches
  {wpo,vscomp,data.build,data.build.win,data_symb}.patch

* Delete obsolete patches and apply still relevant patches
  {isvalidenum,doubleconversion}.patch

* Fix a Windows compilation issue with clang

* Drop pluralrange.res from flutter's data

* Update the timezone data update script and update the
  timezone data to 2018f

* Add VES (new Venezuelan currency) to and drop VEF
   - {scripts/android}/currencies.list

* ICU data files are rebuilt (up to 22kB increase)

   ICU 62      ICU 63   Platform
   6364832     6375056  android
   4907488     4916608  cast
  10246512    10268240  common
    884352      880512  flutter
   6351136     6361376  ios


TBR=ftang@chromium.org
Bug: 893196, v8:8272
Change-Id: Icac23f6c065f38a9b1b4ae397fbe0e6b62934f15
Reviewed-on: https://chromium-review.googlesource.com/c/1296893


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      42d50279
  5. Oct 21, 2018
  7. Oct 09, 2018
  9. Sep 21, 2018
  11. Sep 09, 2018
  13. Sep 08, 2018
  15. Aug 25, 2018
  17. Aug 22, 2018
    • Jungshik Shin's avatar
      Fix ICU data file for Android · a191af9d
      Jungshik Shin authored 
      In some locales, currency data turns empty after currency list filtering
on Android. This leads v8's currency formatter to fall back to 3-letter
currency code instead of currency symbol (e.g. 'GBP' in en-GB).

Fix the ICU data trimming script to remove an empty Currency block after
filtering and rebuild ICU data files.

Bug: 870338
Test: See the bug
TBR=gsathya@chromium.org
Change-Id: Idf7af0a5f00b05b7f26d2ad42b21abd1aca47d07
Reviewed-on: https://chromium-review.googlesource.com/1184505


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      a191af9d
  19. Jul 24, 2018
  21. Jul 23, 2018
  23. Jul 07, 2018
    • Jungshik Shin's avatar
      Update ICU to 62.1 + local patches · a9a2bd3e
      Jungshik Shin authored 
      What's new in ICU 62.1:
  - Unicode 11 (new scripts, Emoji update, Text Boundary/Line break updates)
  - CLDR 33.1 (locale data; http://cldr.unicode.org/index/downloads/cldr-33-1 )
  - More Numberformatter improvements and its support in MsgFormat
  - See http://site.icu-project.org/download/62 for more details.

The update steps are recorded in
  https://chromium.googlesource.com/chromium/deps/icu/+log/172d331..c28591b

The list of local changes are:

  Cherry-pick Greek lowercasing fix
  Fix a DecimalFormat maxSignificantDigits issue.

* Rebuild the data files: size eduction of ~ 45 KiB

   6386176 => 6340576 android
   4929248 => 4883232 cast
  10264208 => 10218000 common
   6372480 => 6326896 ios

* Update README.chromium and remove a reference to
  icudt.dll for Windows because it's not used any more.

* Drop patches that became unnecessary.

* Apply the remaining patches
   Isvalidenum.patch, locid_map.patch,
   double_conversion.patch

* Apply data-build related patches
  {wpo,vscomp,data.build,data.build.win,data_symb}.patch

* Apply BreakIterator related patches + locale1 patch

* Apply Google's patch for locale data
  - region display names
  - likely subtags
  - Arabic locale: default number system => Latn
  - AM/PM markers for Hindi and a few Indic locales

* Check in ICU 62.1 to the tree (62staging branch) by
  running scripts/update.sh.
  Build files are updated by the script.

TBR=drott@chromium.org
Bug: 850334
Test: None
Change-Id: I7327363c90b9bccda20c1be8f4a65399f36c4e99
Reviewed-on: https://chromium-review.googlesource.com/1128503


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      a9a2bd3e
  25. Jun 09, 2018
  27. May 08, 2018
  29. Apr 25, 2018
  31. Apr 12, 2018
  33. Apr 11, 2018
  35. Feb 05, 2018
  37. Jan 29, 2018
  39. Jan 16, 2018
  41. Jan 14, 2018
  43. Jan 11, 2018
  45. Jan 09, 2018
  47. Dec 14, 2017
  49. Dec 13, 2017
  51. Dec 12, 2017
  53. Dec 08, 2017
    • Jungshik Shin's avatar
      Fix trim_data.sh to delete empty currency blocks · e3b480d3
      Jungshik Shin authored 
      After data trimming, data/curr/en_GB.txt has empty "Currencies" block.
This prevents a locale fallback chain from being triggered for currency
symbols (en-GB => en-001 => en), leading all the currency symbols in en-GB
to be the last resort value (ISO 3-letter currency code). To avoid that,
trim_data.sh is revised to drop empty "Currencies" block entirely ('Missing'
triggers a fallback chain, but 'empty' goes straight to the last resort.)

Additional currency data fixes:

1. Serbian: RON and ROL display names are swapped. RON is the current
currency and should be included with a shorter display name.

2. Add a few more en-* locale variants to the locale list for currency.

Moreover, make_data_all.sh is updated to work wherever the Chromium
source tree is.

Finally, update the list of resources to remove from cast's ICU data
and rebuild it with ICU 60.  Added entries to cast-removed-resources.txt
are data for locale-variants that are not useful in Cast.

Bug: 791318
Test: See the bug
Change-Id: Ib09ee36e3447557636d60d8aeabc7ca047718236
Reviewed-on: https://chromium-review.googlesource.com/810099


Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
      e3b480d3
  55. Dec 07, 2017
  57. Nov 20, 2017
    • Mina Almasry's avatar
      Intergrate Cast Audio icudtl.dat generation into chromium process. · 741688eb
      Mina Almasry authored 
      Our Cast Audio devices use a stripped down version of the android
icudtl.dat. Essentially the patch_locale.sh has been modified to keep in
things provided by Java, as cast doesn't have Java and needs there
resources.

On the other hand, a bunch of resources have been stripped from the
icudtl.dat to reduce its size because we are very constrained on that.

We have been using this icudtl.dat process for a long time now, and it's
throughly validated. However, we used to generate this in our internal
repo, which meant that we have to manually update it whenever chromium
updates their icudtl.dat.

This CL aims to intergrate the generation of the icudtl.dat in chromium,
so we no longer have to manually update in our internal repo.

Bug: internal b/28053340
Test: On cast audio device

Change-Id: I881eb2ddf046fdd16fd7efbfb0d56877abfaf947
Reviewed-on: https://chromium-review.googlesource.com/773591


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      741688eb
  59. Nov 09, 2017
  61. Nov 07, 2017
  63. Nov 03, 2017
  65. Oct 11, 2017
  67. Oct 10, 2017
  69. Aug 14, 2017
  71. Aug 03, 2017