Skip to content
Snippets Groups Projects
Select Git revision
  • upstream/master
  • master default
  • upstream/chromium/65staging
  • upstream/chromium/char16t_test
  • upstream/chromium/64staging
  • upstream/chromium/m74
  • upstream/chromium/m71
  • upstream/chromium/m72
  • upstream/chromium/win7tz
  • upstream/chromium/char16tv2
  • upstream/chromium/63staging
  • upstream/chromium/m70
  • backup/master
  • upstream/chromium/62staging
  • upstream/chromium/61staging
  • upstream/upstream/master
  • upstream/chromium/m63
  • upstream/upstream/chromium/m63
  • upstream/chromium/60staging
  • upstream/upstream/chromium/60staging
20 results
Search by author
  • Any Author
  • banggua banggua banggua
1 author
  1. Jul 01, 2015
  3. Jun 30, 2015
  5. Jun 23, 2015
  7. Jun 18, 2015
  9. Jun 09, 2015
  11. Jun 04, 2015
  13. Jun 01, 2015
    • Jungshik Shin's avatar
      Remove unnecessary clang flags for ICU · dbed54da
      Jungshik Shin authored 
      1. -Wno-return-type-c-linkage
 - became unnecessary with ICU bug 9504 fixed 3 years ago.
 - remove from both BUILD.gn and icu.gyp

2. -Wnoheader-hygine
 - became unnecessary a long time ago.
 - remove from BUILD.gn (icu.gyp does not have it)

3. -Wstring-conversion and -Wheader-hygine
 - add to BUILD.gn by NOT excluding clang:extra_warnings

BUG=114660
TEST=Build icuuc/icui18n targets (both gyp and GN) after regenerating build files.
R=brettw@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1158933005
      dbed54da
  15. May 26, 2015
  17. May 15, 2015
  19. May 11, 2015
  21. Apr 21, 2015
  23. Apr 06, 2015
  25. Apr 03, 2015
  27. Apr 02, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      Update tz db to 2015b · 5f18004f
      Jungshik Shin (jungshik at google) authored 
      1. Update the IANA tz db to 2015b.
  - http://mm.icann.org/pipermail/tz-announce/2015-March/000029.html
  - Mongolia decided to observe DST again in 2015 starting on the last
    Sunday in March.
  - Palestine's DST start date is corrected to be March 28 instead of 27th.

2. Add a script to download the tz database files (update_tz.sh)

3. Check in scripts/make_n_copy_data.sh that I've been using to build ICU
   data/assembly files and update README.chromium.

4. Update android/patch_locale.sh to apply android/brkitr.patch as well.

BUG=473288
TEST=1. In JavaScript console, run the following.
  mar27_2015_1200 = new Date("03/27/2015 12:00Z")
  mar28_2015_1200 = new Date("03/28/2015 12:00Z")
  mar27_2015_1200.toLocaleString("en", {timeZone: "Asia/Gaza"}
  mar28_2015_1200.toLocaleString("en", {timeZone: "Asia/Gaza"}
  apr15_2014_1200 = new Date("04/15/2014 12:00Z")
  apr15_2015_1200 = new Date("04/15/2015 12:00Z")
  apr15_2014_1200.toLocaleString("en", {timeZone: "Asia/Ulan_Bator"}
  apr15_2015_1200.toLocaleString("en", {timeZone: "Asia/Ulan_Bator"}

In Asia/Gaza, Mar 27 12:00Z should be 2PM and mar28 12:00Z should be 3PM.
In Asia/Ulan_Bator, April 15 12:00Z should be 8PM in 2014 and should be 9PM
in 2015. Ulan_Bator does not work due to http://crbug.com/364374.

R=mark@chromium.org

Review URL: https://codereview.chromium.org/1051193002
      5f18004f
  29. Mar 26, 2015
  31. Mar 21, 2015
  33. Mar 19, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      Set U_CHARSET_IS_UTF8 to 1 in BUILD.gn · 009e7a78
      Jungshik Shin (jungshik at google) authored 
      I forgot to include this change in
  https://codereview.chromium.org/984233002

TBR=jochen@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/1021673003
      009e7a78
    • Jungshik Shin (jungshik at google)'s avatar
      Update CJK converters and their generating scripts · dafa8443
      Jungshik Shin (jungshik at google) authored 
      1. Update ucmlocal.mk and convertrs.txt to refer to euc-kr-html.ucm
instead of windows-949.ucm

2. Tighten up the valid code range for the following converters:

   EUC-KR, Shift_JIS, Big5

This is to add back an ASCII range byte to the stream per
the encoding spec when they're either illegal as a 'trail byte' or
there's no assigned code point for a "lead + trail" sequence.
For instance, with this change, '0xF3 0x41' in EUC-KR is converted to
'U+FFFD U+0041' instead of 'U+FFFD'.

This change requires adding 2 ~ 8 new states to the conversion
table of each converter mentioned above leading to 6.5kB net increase
in the final data size.

3. Tighten the trail byte range for 2-byte sequences starting with 0x8E
from [A1,E2] to [A1,DF] in EUC-JP and update the corresponding generating
script.

4. Change the substitution characters for EUC-JP and Shift_JIS to
match other converters. i.e. make them produce U+FFFD when encountering
an invalid input. Before this chaange, they emitted U+001A.

5. Enable 'U_CHARSET_IS_UTF8' configuration flag.
Chromium/Blink does not rely on ICU for the code conversion between
the 'system native encoding' (if it's one of legacy encodings)
and Unicode. With this configuration, we can cut down the code size
a bit.

6. Update the icudtl.dat (all platforms) and assembly files (mac,linux)
   and the icudata dll (windows)

See https://codereview.chromium.org/1026453002 for a new blink test
added ( fast/encoding/char-decoding-invalid-trail.html )

BUG=450312,430823
TEST=Blink: fast/encoding/char-decoding-{truncated,invalid-trail}.html
TEST=base_unittests --gtest_filter=*Conv*, browser_tests --gtest_filter=*ncoding*
R=jsbell@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/984233002
      dafa8443
    • Jochen Eisinger's avatar
      Import BUILD.gn into ICU repo · d319ad9e
      Jochen Eisinger authored 
      BUG=none
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1014393002
      d319ad9e
  35. Mar 03, 2015
  37. Mar 02, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      Update the ICU data · db16fd86
      Jungshik Shin (jungshik at google) authored 
      Fix the following errors found by jochen@ in
  https://codereview.chromium.org/960263002/

1. brkitr: en_US_POSIX is not supported. Remove it from brklocal.mk
   : We don't use en_US_POSIX and the remaining dependency on it in
   some unittests was already removed. (we may need it back later,
   though, for breaking an FQDN into components.)
2. coll: Explicitly add id.txt required as the alias/parent of "in" and
   "id_ID". This should not affect the collation in Indonesian locale
   because falling back to the root locale should be fine.
3. lang: Add 'ro_MD.txt' required as the alias of 'mo.txt'.

Also update make_mac_asseymbly.sh to get it to read off the ICU major
version automatically.

Besides, update README.chromium to refer to ICU 54 as done by the
aforementioned CL.

Rebuild the data files and assembly sources (the latter still required
by stand-alone v8 builds) for all the platforms.

icudtl.dll for Windows will be built and checked in in  another CL.

BUG=428145
TEST=Usual ICU update tests before rolling DEPS. See https://codereview.chromium.org/878723002
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/962643003
      db16fd86
  39. Feb 27, 2015
  41. Feb 20, 2015
  43. Feb 19, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      Fix en_GB's language name failure · 8d46830a
      Jungshik Shin (jungshik at google) authored 
      data/lang/en_GB.txt has an empty "Languages" block leading
getDisplay{Name,Language} to fail in en-GB.

Update trim_data.sh to remove an empty "Languages" block and run the
script to fix data/lang/en_GB.txt and other locales if any. (only
en_GB.txt is affected).

Rebuild the icu data with the above changes for both Android and non-Android
platforms.

BUG=428145
TEST=linux_chromeos bots: browser_tests --gtest_filter=*GetUILang*
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/930203004
      8d46830a
  45. Feb 17, 2015
  47. Feb 14, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      Move stubdata.c from icudata to icuuc · d158fece
      Jungshik Shin (jungshik at google) authored 
      This is to fix a linker error when linking icuuc.dll;  ICU_DATA_ENTRY (icudt54_dat) symbol is not found on Windows clean build from the scratch (component=shared_library).

Move stubdata.c to icuuc target from icudata target. Also, make
U_DATA_API (used for U_ICU_DATA_ENTRYPOINT in common/udata.cpp) to be
U_EXPORT instead of U_IMPORT when icu_use_data_file_flag = 1 or
on Windows. On Windows, using the icudt.dll  (i.e. icu_use_data_file_flag=0) also requires this change.

BUG=428145
TEST=All trybots can build a target that requires ICU.
R=mark@chromium.org, scottmg@chromium.org

Review URL: https://codereview.chromium.org/926113004
      d158fece
  49. Feb 10, 2015
  51. Feb 09, 2015
  53. Jan 31, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      ICU update to 54.1 step 7 · 26c111a7
      Jungshik Shin (jungshik at google) authored 
      1. Fix a Windows build failure due to:
   a. 'signed vs unsigned' comparison
   b. 'possible data loss' in conversion : Apply pkasting's patch at
      http://bugs.icu-project.org/trac/ticket/11104

2. Drop a few currencies to cut down the data size by 50kB for non-Android
   platforms.

2. Build the ICU data for Android and check in.
  - Drop all display names for languages/scripts/regions except for zh-Han{s,t}
    as before. ( ~ 1.2MB reduction)
  - Drop cjdict by applying android/brkitr.patch. (~ 2MB reduction)
  - Include the display names for only 60+ currencies ( ~ 400kB reduction
    from the non-Android data.
  - Minimize the locale data for 9 locales Chrome on Android is not localized
    to. Drop currency names for those 9 locales. ( ~ 150kB reduction)

Size change:
  1. Non-android: 10,255,584 to 10,200,880
  2. Android:
     - Final : 6,270,880
       With 60+ currency names added (for bug 370849) and
       9 unnecessary locale data dropped.
       It's 232,240 bytes larger than ICU 52.1 (6,038,640).
     - Without any currency names but with 9 unnecessary locale data: 6,026,816
     - With 60+ currency names and 9 unnecessary locale data: 6,426,368

BUG=370849,428145
TEST=Build on Windows. Blink layout tests, webkit unittests.
R=mark@chromium.org, wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/877193003
      26c111a7
  55. Jan 23, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      ICU update to 54 - step 6 · b9090ea5
      Jungshik Shin (jungshik at google) authored 
      1. Add {coll,curr,lang,locales,rbnf,region,sprep,translit,unit,zone}/*local.mk
to exclude locale data for languages/locales that Chromium does not need.

2. Run scripts/trim_data.sh to cut down the data size further by excluding
unused entries in each locale files.
   - Keep the display names for languages/scripts/locales in Chrome's
     Accept-Language list and remove the display names outside the set.
   - Minimize the locale data in data/{locales,lang} for non-UI languages
     in the A-L list. For them,
     we just need the "native" display name and exemplar character set.
   - Exclude historic, obscure and otherwise unnecessary currency display
     names.
   - Drop unnecessary Chinese collation rules; Big5/GB2312/UniHan.
   - Keep only the minimal unit data for duration and compound units.

3. Add css3transform.txt to data/translit for Greek upper/lowercasing support.

4. Add the minimal locale data for ckb and ku.

5. The tz db was updated previously to 2014j (the latest) so that no change
   is made except for README.chromium update.

6. Add the minimal locale data for ckb and ku.

7. Check in the pre-built data (icudtl.dat) shared by all non-Android
   platforms and assembly files for Linux/Mac

The final data size is 10,255,584 bytes, which is about 200kB smaller than
that for ICU 52.1.  The pristine upstream ICU has the data of
25,343,024 bytes.

The remaining steps are to build a smaller data file for Android and
to build icudtl.dll for Windows (non-default build option).

BUG=428145
TEST=net_unittests --gtest_filter="*ilenameUtil*"
TEST=net_unittests --gtest_filter="*IDN*"
TEST=base_unittests --gtest_filter="*Conv*"
TEST=browser_tests --gtest_filter="*ncoding*"
TEST=Blink: layout tests
R=mark@chromium.org

Review URL: https://codereview.chromium.org/872903002
      b9090ea5
    • Jungshik Shin (jungshik at google)'s avatar
      ICU update to 54.1 - step 5 · 4a0ebf11
      Jungshik Shin (jungshik at google) authored 
      1. Apply Chrome's locale data change on top of Google's locale data
   changes

2. Breakiterator changes
  - Apply brkitr.patch with update to ICU 54.1; line/word.txt
  - Check in a more compact Khmer dictionary along with
    a parameter adjustment in dictbe.cpp
  - Add a few common words to the CJ dictionary
  - Update brklocal.mk (out customized build file) to ICU 54
  - Update android/brkitr.patch and data/brkitr/word_ja.txt for Android

Data size checkpoint:
 * Non-Android: 19,575,216 bytes. ~500kB reduction relative
   to the previous step comes mainly from the compact Khmer dictionary.
 * Android: 17,601,520 bytes. 2MB difference comes from removing cjdict.

BUG=428145
TEST=net_unittests --gtest_filter="*IDN*"
TEST=layout tests
R=mark@chromium.org

Review URL: https://codereview.chromium.org/858363003
      4a0ebf11
  57. Jan 21, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      ICU update to 54 - step 4 · 7f05ab40
      Jungshik Shin (jungshik at google) authored 
      Google's locale data changes are applied before Chrome's own locale data
trimming.

1. Use "Rs." instead of the Indian Rupee sign (U+20A8) for which the font
   support is not available on all platforms.
   Google platforms (CrOS / Android ) have them, but other
   platforms may not.
2. Use shorter names for Hong Kong and Macau without 'S.A.R.' at the
   end. This cuts down the data size a bit.
3. Timezone names for Korea standard time and a couple of other zones
   are shortened.
4. zh_Hant_TW, pa_Arab_PK and a few more locales are changed.

Besides, update data.build.patch and README.chromium to drop
the collation rule files ('-R' option to genrb.). This should have been
done in ICU update step 2.

Data size checkpoint: 20,066,624 bytes
 - about 500k reduction from step 3 mostly due to '-R' option with
    the rest attributed to shorter display names for HK, MO and Korean tz.
 - the original ICU 54.1 : 25,343,024

BUG=428145
TEST=NONE
TBR=mark

Review URL: https://codereview.chromium.org/856153003
      7f05ab40
    • Jungshik Shin (jungshik at google)'s avatar
      ICU update to 54 step 3 · afd723ba
      Jungshik Shin (jungshik at google) authored 
      A. Converter update per HTML encoding spec along with changes in
  the encoding name alias table.
B. Remove all the codes for converters Blink and Chromium do not need
(SCSU, Lotus, ISO-2022-xx other than JP, BOCU, UTF-7, etc).

This is reapplying the following CLs (that we used for ICU 52.1) to ICU 54.1 :

https://codereview.chromium.org/598383002
https://codereview.chromium.org/654153002

We have two upstream bugs filed for A and B above:
  http://www.icu-project.org/trac/ticket/11296
  http://www.icu-project.org/trac/ticket/10303

In addiition to A and B, we unified Big5 and Big5-HKSCS per
the encoding spec (bug 277868). That also includes properly supporting
the four 2-character sequences ( see http://crbug.com/277868#c3 ).
big5_gen.sh deviates from the current spec to work around a bug
in the spec. (see https://www.w3.org/Bugs/Public/show_bug.cgi?id=27878)

Moreover, ucmlocal.mk is added to list only encodings we want to support.

Also, tighten the state table for windows-946-2000.ucm that we use
for EUC-KR for now. And, drop 'base' map for windows-{936,949}-2000.ucm.

Finally, add euc-kr-html.ucm along with scripts/euckr_gen.sh, but
it is not yet used pending the resolution of bug 450312.

Data size checkpoint: 20,566,864 bytes (the original ICU 54=25,343,024)

BUG=277868, 428145, 450312
TEST=net_unittests --gtest_filter="*ilenameUtil*"
TEST=base_unittests --gtest_filter="*Conv*"
TEST=browser_tests --gtest_filter="*ncoding*"
TEST=Blink: fast/encoding/*
R=jsbell@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/839713003
      afd723ba
  59. Jan 12, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      ICU upgrade to 54.1 step 2 · 5580ad69
      Jungshik Shin (jungshik at google) authored 
      Update the following patches and apply to the fresh copy of icu 54.1:

  configure.patch
  declspec.patch
  locid.patch
  platform_nacl.patch
  regex.patch
  wpo.patch
  vscomp.patch: two chunks are not necessary any more; upstream has
                them.
  data.build.patch
  data.build_win.patch

Delete the following patches:
  putil.patch: not necessary any more; upstream has it.
  regex2.patch: merged to regex.patch.
  col.patch: not necessary any more; upstream code changed drastically
             and does not have a bug any more.
  clang_win.patch: not necessary any more; upstream has it.

BUG=428145
TEST=None
R=mark@chromium.org

Review URL: https://codereview.chromium.org/822213003
      5580ad69
  61. Jan 08, 2015
  63. Dec 15, 2014
    • Jungshik Shin (jungshik at google)'s avatar
      Add the minimal locale data for ckb and ku · 51c1a4ce
      Jungshik Shin (jungshik at google) authored 
      To have keyboard layouts for ku and ckb, we need to have the minimal
locale data for them - native display name, writing direction, and
exemplar characters.

These are added and the icu data was rebuilt. The Android icu data was
not rebuilt because Android Chrome does not use them.

BUG=204049
TEST=None until ckb and ku are added to the A-L list in a Chrome CL.
When they're,  language and input settings will have ckb and ku listed
with the display name in the current UI language (e.g. Englsih) and native
display name.

Review URL: https://codereview.chromium.org/805073003
      51c1a4ce