Skip to content
Snippets Groups Projects
Select Git revision
0 results
Search by author
  • Any Author
  • banggua banggua banggua
1 author
  1. Oct 01, 2015
  3. Sep 25, 2015
  5. Aug 25, 2015
    • Nico Weber's avatar
      Fix -Wmicrosoft-unqualified-friend warning. · 6b3ce817
      Nico Weber authored 
      The warning complains that StringThreadTest is declared in the global namespace,
but the friend line says `friend class StringThreadTest;` instead of
`friend class ::StringThreadTest`.  MSVC doesn't require this ::, but gcc does
-- without it, the friend line declares a new class in the namespace containing
UnicodeString.

Since StringThreadTest was in test/threadtest which isn't built as part of
Chromium's build and which was removed in upstream ICU in ICU 37392, just
delete the friend line, it has no effect.

BUG=505296
R=jshin@chromium.org

Review URL: https://codereview.chromium.org/1317603003 .
      6b3ce817
  7. Aug 18, 2015
    • Nico Weber's avatar
      Build icu with -Wno-unused-function. · 89dcdec1
      Nico Weber authored 
      Also add a few comments to the .gn file.

BUG=505316
R=jshin@chromium.org

Review URL: https://codereview.chromium.org/1301493002 .
      89dcdec1
    • Nico Weber's avatar
      Fix -Woverloaded-virtual warnings in ICU. · 80ac4c39
      Nico Weber authored 
      1.
In Win32NumberFormat, rename the private format() method to variadicFormat().
It's just an implementation detail of the class. Fixes:
..\..\third_party\icu\source\i18n/winnmfmt.h(146,20) :  error(clang):
        'icu_54::Win32NumberFormat::format' hides overloaded virtual functions
        [-Werror,-Woverloaded-virtual]
    UnicodeString &format(int32_t numDigits, UnicodeString &appendTo, const wchar_t *format, ...) const;
                   ^
..\..\third_party\icu\source\i18n\unicode/numfmt.h(255,28) :  note(clang):
        hidden overloaded virtual function 'icu_54::NumberFormat::format'
        declared here: different number of parameters (4 vs 3)
    virtual UnicodeString& format(const Formattable& obj,
                           ^
...

2.
In Win32DateFormat, remove the two-argument format() function that just
forwards to the base class.  (If this happens to produce compile errors,
the function should be replaced by
`using Win32DateFormat::format(UDate, UnicodeString&) const;`) Fixes:
..\..\third_party\icu\source\i18n/windtfmt.h(55,20) :  error(clang):
        'icu_54::Win32DateFormat::format' hides overloaded virtual functions
        [-Werror,-Woverloaded-virtual]
    UnicodeString& format(UDate date, UnicodeString& appendTo) const;
                   ^
..\..\third_party\icu\source\i18n\unicode/datefmt.h(240,28) :  note(clang):
        hidden overloaded virtual function 'icu_54::DateFormat::format'
        declared here: different number of parameters (4 vs 2)
    virtual UnicodeString& format(const Formattable& obj,
                           ^
...

BUG=505301
R=jshin@chromium.org

Review URL: https://codereview.chromium.org/1296803002 .
      80ac4c39
  9. Aug 05, 2015
  11. Jul 16, 2015
  13. Jul 14, 2015
  15. Jul 06, 2015
  17. Jul 03, 2015
  19. Jul 01, 2015
  21. Jun 30, 2015
  23. Jun 23, 2015
  25. Jun 18, 2015
  27. Jun 09, 2015
  29. Jun 04, 2015
  31. Jun 01, 2015
    • Jungshik Shin's avatar
      Remove unnecessary clang flags for ICU · dbed54da
      Jungshik Shin authored 
      1. -Wno-return-type-c-linkage
 - became unnecessary with ICU bug 9504 fixed 3 years ago.
 - remove from both BUILD.gn and icu.gyp

2. -Wnoheader-hygine
 - became unnecessary a long time ago.
 - remove from BUILD.gn (icu.gyp does not have it)

3. -Wstring-conversion and -Wheader-hygine
 - add to BUILD.gn by NOT excluding clang:extra_warnings

BUG=114660
TEST=Build icuuc/icui18n targets (both gyp and GN) after regenerating build files.
R=brettw@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1158933005
      dbed54da
  33. May 26, 2015
  35. May 15, 2015
  37. May 11, 2015
  39. Apr 21, 2015
  41. Apr 06, 2015
  43. Apr 03, 2015
  45. Apr 02, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      Update tz db to 2015b · 5f18004f
      Jungshik Shin (jungshik at google) authored 
      1. Update the IANA tz db to 2015b.
  - http://mm.icann.org/pipermail/tz-announce/2015-March/000029.html
  - Mongolia decided to observe DST again in 2015 starting on the last
    Sunday in March.
  - Palestine's DST start date is corrected to be March 28 instead of 27th.

2. Add a script to download the tz database files (update_tz.sh)

3. Check in scripts/make_n_copy_data.sh that I've been using to build ICU
   data/assembly files and update README.chromium.

4. Update android/patch_locale.sh to apply android/brkitr.patch as well.

BUG=473288
TEST=1. In JavaScript console, run the following.
  mar27_2015_1200 = new Date("03/27/2015 12:00Z")
  mar28_2015_1200 = new Date("03/28/2015 12:00Z")
  mar27_2015_1200.toLocaleString("en", {timeZone: "Asia/Gaza"}
  mar28_2015_1200.toLocaleString("en", {timeZone: "Asia/Gaza"}
  apr15_2014_1200 = new Date("04/15/2014 12:00Z")
  apr15_2015_1200 = new Date("04/15/2015 12:00Z")
  apr15_2014_1200.toLocaleString("en", {timeZone: "Asia/Ulan_Bator"}
  apr15_2015_1200.toLocaleString("en", {timeZone: "Asia/Ulan_Bator"}

In Asia/Gaza, Mar 27 12:00Z should be 2PM and mar28 12:00Z should be 3PM.
In Asia/Ulan_Bator, April 15 12:00Z should be 8PM in 2014 and should be 9PM
in 2015. Ulan_Bator does not work due to http://crbug.com/364374.

R=mark@chromium.org

Review URL: https://codereview.chromium.org/1051193002
      5f18004f
  47. Mar 26, 2015
  49. Mar 21, 2015
  51. Mar 19, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      Set U_CHARSET_IS_UTF8 to 1 in BUILD.gn · 009e7a78
      Jungshik Shin (jungshik at google) authored 
      I forgot to include this change in
  https://codereview.chromium.org/984233002

TBR=jochen@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/1021673003
      009e7a78
    • Jungshik Shin (jungshik at google)'s avatar
      Update CJK converters and their generating scripts · dafa8443
      Jungshik Shin (jungshik at google) authored 
      1. Update ucmlocal.mk and convertrs.txt to refer to euc-kr-html.ucm
instead of windows-949.ucm

2. Tighten up the valid code range for the following converters:

   EUC-KR, Shift_JIS, Big5

This is to add back an ASCII range byte to the stream per
the encoding spec when they're either illegal as a 'trail byte' or
there's no assigned code point for a "lead + trail" sequence.
For instance, with this change, '0xF3 0x41' in EUC-KR is converted to
'U+FFFD U+0041' instead of 'U+FFFD'.

This change requires adding 2 ~ 8 new states to the conversion
table of each converter mentioned above leading to 6.5kB net increase
in the final data size.

3. Tighten the trail byte range for 2-byte sequences starting with 0x8E
from [A1,E2] to [A1,DF] in EUC-JP and update the corresponding generating
script.

4. Change the substitution characters for EUC-JP and Shift_JIS to
match other converters. i.e. make them produce U+FFFD when encountering
an invalid input. Before this chaange, they emitted U+001A.

5. Enable 'U_CHARSET_IS_UTF8' configuration flag.
Chromium/Blink does not rely on ICU for the code conversion between
the 'system native encoding' (if it's one of legacy encodings)
and Unicode. With this configuration, we can cut down the code size
a bit.

6. Update the icudtl.dat (all platforms) and assembly files (mac,linux)
   and the icudata dll (windows)

See https://codereview.chromium.org/1026453002 for a new blink test
added ( fast/encoding/char-decoding-invalid-trail.html )

BUG=450312,430823
TEST=Blink: fast/encoding/char-decoding-{truncated,invalid-trail}.html
TEST=base_unittests --gtest_filter=*Conv*, browser_tests --gtest_filter=*ncoding*
R=jsbell@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/984233002
      dafa8443
    • Jochen Eisinger's avatar
      Import BUILD.gn into ICU repo · d319ad9e
      Jochen Eisinger authored 
      BUG=none
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1014393002
      d319ad9e
  53. Mar 03, 2015
  55. Mar 02, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      Update the ICU data · db16fd86
      Jungshik Shin (jungshik at google) authored 
      Fix the following errors found by jochen@ in
  https://codereview.chromium.org/960263002/

1. brkitr: en_US_POSIX is not supported. Remove it from brklocal.mk
   : We don't use en_US_POSIX and the remaining dependency on it in
   some unittests was already removed. (we may need it back later,
   though, for breaking an FQDN into components.)
2. coll: Explicitly add id.txt required as the alias/parent of "in" and
   "id_ID". This should not affect the collation in Indonesian locale
   because falling back to the root locale should be fine.
3. lang: Add 'ro_MD.txt' required as the alias of 'mo.txt'.

Also update make_mac_asseymbly.sh to get it to read off the ICU major
version automatically.

Besides, update README.chromium to refer to ICU 54 as done by the
aforementioned CL.

Rebuild the data files and assembly sources (the latter still required
by stand-alone v8 builds) for all the platforms.

icudtl.dll for Windows will be built and checked in in  another CL.

BUG=428145
TEST=Usual ICU update tests before rolling DEPS. See https://codereview.chromium.org/878723002
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/962643003
      db16fd86
  57. Feb 27, 2015
  59. Feb 20, 2015
  61. Feb 19, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      Fix en_GB's language name failure · 8d46830a
      Jungshik Shin (jungshik at google) authored 
      data/lang/en_GB.txt has an empty "Languages" block leading
getDisplay{Name,Language} to fail in en-GB.

Update trim_data.sh to remove an empty "Languages" block and run the
script to fix data/lang/en_GB.txt and other locales if any. (only
en_GB.txt is affected).

Rebuild the icu data with the above changes for both Android and non-Android
platforms.

BUG=428145
TEST=linux_chromeos bots: browser_tests --gtest_filter=*GetUILang*
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/930203004
      8d46830a
  63. Feb 17, 2015