Skip to content
Snippets Groups Projects
Select Git revision
  • upstream/master
  • master default
  • upstream/chromium/65staging
  • upstream/chromium/char16t_test
  • upstream/chromium/64staging
  • upstream/chromium/m74
  • upstream/chromium/m71
  • upstream/chromium/m72
  • upstream/chromium/win7tz
  • upstream/chromium/char16tv2
  • upstream/chromium/63staging
  • upstream/chromium/m70
  • backup/master
  • upstream/chromium/62staging
  • upstream/chromium/61staging
  • upstream/upstream/master
  • upstream/chromium/m63
  • upstream/upstream/chromium/m63
  • upstream/chromium/60staging
  • upstream/upstream/chromium/60staging
20 results
Search by author
  • Any Author
  • banggua banggua banggua
1 author
  1. May 23, 2019
  3. May 21, 2019
  5. May 15, 2019
  7. May 11, 2019
  9. May 10, 2019
  11. May 08, 2019
    • Frank Tang's avatar
      Adds back ulayout and add tz res files. · 3a162e7a
      Frank Tang authored 
      1. copy_data.sh is modified to copy 3 timezone resource files
   tzres for a separate tz update on fucshia.
2. Adds ulayout back for Blink to use in layout (vertical orientation,
   Indic layout properties, etc).

Increase 13K on all data file except iOS.

File           ICU64-2  NEW     DIFF
chromeos      10380672 10394080 13408
common        10396864 10410272 13408
cast           5101760  5115168 13408
android        7747120  7760528 13408
android_small  6407040  6420432 13392
ios            6372800  6372800     0
flutter         894736   908144 13408

Bug: 958948,959155
Change-Id: I185f1c0554a515cfa8fe670935ca785698974c71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1599896


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      3a162e7a
  13. Apr 19, 2019
  15. Apr 18, 2019
  17. Apr 12, 2019
  19. Apr 11, 2019
    • Frank Tang's avatar
      Add 32 more locales for Android · 85768aa2
      Frank Tang authored 
      Copy the old filters/android.json to filters/android_small.json
Copy the old android/icudtl.dat to android_small/icudtl.dat
Add 32 locales to filters/android.json and rebuild.
Change the BUILD.gn to use android_small for now.

af az eu fr-CA gl hy is ka kk km ky lo mk mn my ne
pa si sq ur uz zh-HK zu
bn et gu kn ml mr ms ta te

Compare to android/icudtl.dat. It increase 1.28M.
 7746368 android/icudtl.dat
 6406288 android_small/icudtl.dat


Bug: 951636
Change-Id: I4c4f43add3c76adf5da215342ec4460bbaf2de87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1562954


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      85768aa2
  21. Apr 09, 2019
    • Frank Tang's avatar
      Update IANA timezone database to 2019a · 4ae7482a
      Frank Tang authored 
      2019a was announced on March 26 2019.

https://mm.icann.org/pipermail/tz-announce/2019-March/000055.html

Palestine "springs forward" on 2019-03-30 instead of 2019-03-23.
Metlakatla "fell back" to rejoin Alaska Time on 2019-01-20 at 02:00.


Either in JS console in Chrome or v8 should work like these:
new Date(Date.UTC(2019, 0, 20, 9, 59)).toLocaleString("en", {timeZone: "America/Metlakatla", timeZoneName: "long"})
new Date(Date.UTC(2019, 0, 20, 10, 00)).toLocaleString("en", {timeZone: "America/Metlakatla", timeZoneName: "long"})
new Date(Date.UTC(2019, 2, 10, 10, 59)).toLocaleString("en", {timeZone: "America/Metlakatla", timeZoneName: "long"})
new Date(Date.UTC(2019, 2, 10, 11, 00)).toLocaleString("en", {timeZone: "America/Metlakatla", timeZoneName: "long"})

EXPECT to see the 2nd and 3rd dates are under Alaska Time.
"1/20/2019, 1:59:00 AM Pacific Standard Time"
"1/20/2019, 1:00:00 AM Alaska Standard Time"
"3/10/2019, 1:59:00 AM Alaska Standard Time"
"3/10/2019, 3:00:00 AM Alaska Daylight Time"

BEFORE this CL we got the 2nd and third date in Pacific Time.
"1/20/2019, 1:59:00 AM Pacific Standard Time"
"1/20/2019, 2:00:00 AM Pacific Standard Time"
"3/10/2019, 2:59:00 AM Pacific Standard Time"
"3/10/2019, 3:00:00 AM Alaska Daylight Time"

Bug: 473288
Test: See the above.
Change-Id: Id5add2356fb235f31ab17da2eef74adabb1a21fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1555215


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      4ae7482a
  23. Apr 04, 2019
    • Frank Tang's avatar
      Update ICU to 64.1 + Chromium patches · 69c72a6d
      Frank Tang authored 
      What's new in ICU 64.1:
  - Unicode 12: 554 new characters, including 4 new scripts and 61 new
    emoji characters.
  - CLDR 35 locale data
    http://blog.unicode.org/2019/03/unicode-cldr-version-35-languagelocale.html
  - ICU 64 now uses "rearguard" TZ data. (Recent versions have used
    "vanguard" data with certain overrides.) (ICU-20398)
  - ICU data filtering: The ICU4C build accepts an optional filter
    script that specifies a subset of the data to be built, with
    whitelists and blacklists for locales and for resource bundle paths.
    (ICU-10923, design doc)
  - MessageFormat has new pattern syntax for specifying the style of
    a date/time argument via a locale-independent skeleton rather than
    a locale-specific pattern. (ICU-9622)
    * Date/time skeletons use the same "::" prefix as number skeletons.
    * Example MessageFormat pattern string:
      "We close on {closing,date,::MMMMd} at {closing,time,::jm}."
  - Many formatting APIs can now output a new type of result object
    which is-a FormattedValue (Java & C++), or convertible to a
    UFormattedValue (C).
    * These combine the result strings with easy iteration over
      FieldPosition metadata.
  - New C++ class LocaleBuilder for building a Locale from subtags,
    keywords, and extensions. (ICU-20328) Parallel to the existing
    ICU4J ULocale.Builder class.
  - For C++ MeasureUnit instances, there are now additional factory
    methods that return units by value, not by pointer-with-ownership.
    (ICU-20337)
  - Various Out-Of-Memory (OOM) issues have been fixed. (ticket query)
  - See http://site.icu-project.org/download/64 for more details.

The update steps are recorded :
  https://chromium.googlesource.com/chromium/deps/icu/+log/20690c6..6d422ff

  - Update update.sh to point to ICU's new repo location
  - Import the pristine copy of ICU 64.1 and update BUILD
    files with update.sh
  - Update and apply locale data patches

    1. patches/locale_google.patch:
      * Google's internal ICU locale changes
      * Simpler region names for Hong Kong and Macau in all locales
      * Currency signs in ru and uk locales (do not include 'tr' locale changes)
      * AM/PM, midnight, noon formatting for a few Indian locales
      * Timezone name changes in Korean and Chinese locales
      * Default digit for Arabic locale is European digits.
      - patches/locale1.patch: Minor fixes for Korean
    2. Breakiterator patches
      - patches/wordbrk.patch for word.txt
        a. Move full stops (U+002E, U+FF0E) from MidNumLet to MidNum so that
           FQDN labels can be split at '.'
        b. Move fullwidth digits (U+FF10 - U+FF19) from Ideographic to Numeric.
           See http://unicode.org/cldr/trac/ticket/6555
      - patches/khmer-dictbe.patch
        Adjust parameters to use a smaller Khmer dictionary (khmerdict.txt).
        https://unicode-org.atlassian.net/browse/ICU-9451
      - Add several common Chinese words that were dropped previously to
        source/data/cjdict/brkitr/cjdict.txt
        patch: patches/cjdict.patch
        upstream bug: https://unicode-org.atlassian.net/browse/ICU-10888
    3. Build-related changes
      - patches/configure.patch:
        * Remove a section of configure that will cause breakage while
          running runConfigureICU.
      - patches/wpo.patch (only needed when icudata dll is used).
        upstream bugs : https://unicode-org.atlassian.net/browse/ICU-8043
                        https://unicode-org.atlassian.net/browse/ICU-5701
      - patches/data_symb.patch :
          Put ICU_DATA_ENTRY_POINT(icudtXX_dat) in common when we use
          the icu data file or icudt.dll
      - patches/staticmutex.patch :
          Change the static UMutex code to avoid static_initializers error.
          upstream bug: https://unicode-org.atlassian.net/browse/ICU-20520
      - patches/buildtool.patch :
          Fix the build tool which ommited res_index.res */res_index.res files
          upstream bug: https://unicode-org.atlassian.net/browse/ICU-20529
          upstream PR: https://github.com/unicode-org/icu/pull/571/
    4. Double conversion library build failure
      - patches/double_conversion.patch
      - upstream bugs:
        https://unicode-org.atlassian.net/browse/ICU-13750
        https://github.com/google/double-conversion/issues/66
    5. ISO-2022-JP encoding (fromUnicode) change per WHATWG encoding spec.
      - patches/iso2022jp.patch
      - upstream bug:
        https://unicode-org.atlassian.net/browse/ICU-20251

 - ICU data files are rebuilt
   Up to 67kB increase. Since we also save 43K in
   https://chromium-review.googlesource.com/c/v8/v8/+/1478710 ,
   the net increase is only 24KB.

** ICU Data Size Change **
Data Size   ICU63   ICU64-1    DIFF
chromeos  10326064 10378624   52560
  common  10326064 10394816   68752
    cast   5126144  5101616  -24528
 android   6355520  6406256   50736
     ios   6315248  6372016   56768
 flutter    880928   894752   13824

Created by:
git rev-list --reverse 20690c62..6d422ffa | \
  xargs git cherry-pick --strategy=recursive -X theirs

Bug: chromium:943348
Change-Id: Ia7f86abfa8625dd24aae2f71456abd679fda3dae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1552155


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      69c72a6d
  25. Mar 23, 2019
  27. Mar 18, 2019
  29. Mar 12, 2019
  31. Feb 28, 2019
  33. Feb 16, 2019
  35. Jan 17, 2019
  37. Jan 04, 2019
    • Jungshik Shin's avatar
      Update IANA timezone database to 2018i · d6530149
      Jungshik Shin authored 
      2018h and 2018i were announced in a quick succession in the last week
of 2018.

https://mm.icann.org/pipermail/tz-announce/2018-December/000053.html
https://mm.icann.org/pipermail/tz-announce/2018-December/000052.html

Timezones in a part of Kazakhstan (Asia/Qyzylorda changed its offset and
new timezone Asia/Qostanay was added), a part of Alaska, São Tomé and
Príncipe changed at the end of 2018 or at the beginning of 2019. They
require this update now.

Either in JS console in Chrome or v8 should work like these:
d8> new Date(Date.UTC(2018,11,20,12)).toLocaleString("en", {timeZone: "Asia/Qyzylorda"})
"12/20/2018, 6:00:00 PM"
d8> new Date(Date.UTC(2018,11,21,12)).toLocaleString("en", {timeZone: "Asia/Qyzylorda"})
"12/21/2018, 5:00:00 PM"
d8> new Date(Date.UTC(2018,11,20,12)).toLocaleString("en", {timeZone: "Asia/Qostanay"})
"12/20/2018, 6:00:00 PM"
d8> new Date(Date.UTC(2018,11,21,12)).toLocaleString("en", {timeZone: "Asia/Qostanay"})
"12/21/2018, 6:00:00 PM"
d8> new Date(Date.UTC(2018,11,31,12)).toLocaleString("en", {timeZone: "Africa/Sao_Tome"})
"12/31/2018, 1:00:00 PM"
d8> new Date(Date.UTC(2019,0,1,12)).toLocaleString("en", {timeZone: "Africa/Sao_Tome"})
"1/1/2019, 12:00:00 PM"

Future expected changes in Iran and Moroco are also included in this update.

Bug: 473288
Test: See the above.
Change-Id: If9f8503eebbf1e7eefb504a73140b4e3a37c3cf9
TBR=gsathya@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1395498


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      d6530149
  39. Dec 14, 2018
  41. Dec 12, 2018
  43. Nov 17, 2018
    • Jungshik Shin's avatar
      Update IANA timezone db to 2018g · 407b3930
      Jungshik Shin authored 
      According to the announcement at
  https://mm.icann.org/pipermail/tz-announce/2018-October/000052.html ,

Morocco switches from +00/+01 to permanent +01 effective 2018-10-27,
so its clocks will not fall back on 2018-10-28 as previously
scheduled.

The tz-related files are updated by running update_tz.sh and ICU
data files are rebuilt.

In 2017, on the last Sunday of October, there was fall backward.
d8> new Date(Date.UTC(2017, 9, 28,12)).toLocaleString("en", {timeZone: "Africa/Casablanca"})
"10/28/2017, 1:00:00 PM"
d8> new Date(Date.UTC(2017, 9, 29,12)).toLocaleString("en", {timeZone: "Africa/Casablanca"})
"10/29/2017, 12:00:00 PM"

In 2018, there is no transition on the last Sunday of October.
d8> new Date(Date.UTC(2018,9,27,12)).toLocaleString("en", {timeZone: "Africa/Casablanca"})
"10/27/2018, 1:00:00 PM"
d8>  new Date(Date.UTC(2018,9,28,12)).toLocaleString("en", {timeZone: "Africa/Casablanca"})
"10/28/2018, 1:00:00 PM"

TBR=ftang@chromium.org

Bug: 473288
Test: See the above
Change-Id: Icc2c2a377e3c2d03c7d57cd99a1594773cb10c81
Reviewed-on: https://chromium-review.googlesource.com/c/1341453


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      407b3930
    • Jungshik Shin's avatar
      Add more locale variants · 797b7c73
      Jungshik Shin authored 
      Make the locale variant support more uniform across locale
categories. What's supported in the main locale categories (data/locales)
are added to data/{unit,curr} as well. The list of locales in data/zone
is not yet updated.

Moreover, sr and sw variants are added to data/{locales,unit,curr}.

The cast removal list is simplified using 'glob' pattern instead of
listing individual files for curr and unit categories.

The data size is still under control on most platforms. They're actually
smaller than the first ICU 63.1 update thanks to additional trimming in
zone/unit categories except on desktop (59kB increase).

 Initial 63.1  This CL   Platform
  6375056       6353648  android
  4916608       4745488  cast
 10268240      10324816  common
   880512        880928  flutter
  6361376       6313376  ios


TBR=almasrymina@chromium.org,ftang@chromium.org,gsathya@chromium.org
Change-Id: I21dc5ec752795f485cfeb64ab1eb7eb8b23f3991
Bug: 863739
Test: {base,components,net}_unittests, blink, v8(intl/*,test262/intl402)
Reviewed-on: https://chromium-review.googlesource.com/c/1335789


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      797b7c73
  45. Nov 14, 2018
    • Jungshik Shin's avatar
      Unicoset Perf fix #2 · d13a96f4
      Jungshik Shin authored 
      Cherry-pick another upstream patch to improve the performance
of UnicodeSet.

https://github.com/unicode-org/icu/pull/278

Bug: 899983,901532
Test: Android webview start-up perf and Windows perf graph
Change-Id: I2c2a22a398883178734a2c2a6c5975d9551b039e
TBR=ftang@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1335799


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      d13a96f4
    • Jungshik Shin's avatar
      Adjust calendar locale data trimming on Andorid · ecae5c0e
      Jungshik Shin authored 
      On Android, add Islamic calendar to Arabic and Farsi locales
and Indian calendar to Hindi locale. Also add both variants
of Ethiopic calendars to am/root.

There was a 'typo' in the locale trimming script for Android
('arabic' instead of 'islamic' was specified.). As a result,
Date formatting in ar-SA (where the default calendar is
Islamic) failed for the lack of locale data.

Add back calendar entries to data/locales/root.txt. They're
necessary to support locale-specific calendars on Android
(e.g. islamic on ar/fa, japanese on ja, hebrew on he, etc).

Adjust the drop list for the data file for cast. More
locale variants have been added since it's made. Drop
locale bundles for newly added variants.

Drop zone/unit data for 8 locales Android Chrome does not
yet support. This saves over 100 kB.

For all platforms, drop a few more items not yet used in
Chromium/v8.

With this change, the net data size decreased on all platforms,
paving the way to add more locale variants in a subsequent CL.

    Previous   This CL  Platform
     6375056   6235856  android
     4916608   4714896  cast
    10268240  10258960  common
      880512    879104  flutter
     6361376   6195600  ios

TBR=ftang@chromium.org,gsathya@chromium.org
Bug: v8:8432
Test: v8: intl/regress-8432-*
Change-Id: Iafd94c08ea4e88b33aed4724309636c3e224bdc2
Reviewed-on: https://chromium-review.googlesource.com/c/1325943


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      ecae5c0e
  47. Nov 08, 2018
  49. Nov 06, 2018
  51. Nov 04, 2018
  53. Nov 02, 2018
  55. Oct 24, 2018
    • Jungshik Shin's avatar
      Update ICU to 63.1 + Chromium patches · 42d50279
      Jungshik Shin authored 
      What's new in ICU 63.1:
  - CLDR 34 locale data
    http://cldr.unicode.org/index/downloads/cldr-34-1
  - Curreny/Number range format
  - Better/more support for field iterator in formatters - necessary
    for v8's Ecma 402 implementation
  - Better/safer locale APIs
  - See http://site.icu-project.org/download/62 for more details.

The update steps are recorded :
  https://chromium.googlesource.com/chromium/deps/icu/+log/ccad447..b0bb170

* Update update.sh to point to ICU's new repo location

* Import the pristine copy of ICU 63.1 and update BUILD
  files with update.sh

* Update and apply locale data patches
  - locale_google.patch
  - locale1.patch

* Adjust/apply/update brkiter related patches
  - In place of line_normal_fi.txt, add back
    line_loose.txt (Finnish tailoring is absorbed into
    root).
  - data/brkitr/* are adjusted accordingly
  - android/brkitr.patch and flutter/brkitr.patch
    are updated
  - Use 'normal-cj' for line-breaking in zh/ja locales by
    default
  - Apply cjdict.patch and khmerdict.patch

* Apply build-related patches
  {wpo,vscomp,data.build,data.build.win,data_symb}.patch

* Delete obsolete patches and apply still relevant patches
  {isvalidenum,doubleconversion}.patch

* Fix a Windows compilation issue with clang

* Drop pluralrange.res from flutter's data

* Update the timezone data update script and update the
  timezone data to 2018f

* Add VES (new Venezuelan currency) to and drop VEF
   - {scripts/android}/currencies.list

* ICU data files are rebuilt (up to 22kB increase)

   ICU 62      ICU 63   Platform
   6364832     6375056  android
   4907488     4916608  cast
  10246512    10268240  common
    884352      880512  flutter
   6351136     6361376  ios


TBR=ftang@chromium.org
Bug: 893196, v8:8272
Change-Id: Icac23f6c065f38a9b1b4ae397fbe0e6b62934f15
Reviewed-on: https://chromium-review.googlesource.com/c/1296893


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      42d50279
  57. Oct 21, 2018
  59. Oct 09, 2018
  61. Sep 21, 2018
  63. Sep 09, 2018
  65. Sep 08, 2018
  67. Aug 25, 2018
  69. Aug 22, 2018
    • Jungshik Shin's avatar
      Fix ICU data file for Android · a191af9d
      Jungshik Shin authored 
      In some locales, currency data turns empty after currency list filtering
on Android. This leads v8's currency formatter to fall back to 3-letter
currency code instead of currency symbol (e.g. 'GBP' in en-GB).

Fix the ICU data trimming script to remove an empty Currency block after
filtering and rebuild ICU data files.

Bug: 870338
Test: See the bug
TBR=gsathya@chromium.org
Change-Id: Idf7af0a5f00b05b7f26d2ad42b21abd1aca47d07
Reviewed-on: https://chromium-review.googlesource.com/1184505


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      a191af9d