Skip to content
Snippets Groups Projects
Select Git revision
0 results
Search by author
  • Any Author
0 authors
  1. Mar 15, 2017
  3. Mar 07, 2017
  5. Feb 21, 2017
  7. Jan 27, 2017
  9. Dec 12, 2016
  11. Dec 09, 2016
    • Jungshik Shin's avatar
      Fix big endian support for MIPS · 73e24736
      Jungshik Shin authored 
      Recent changes in detecting big endian targets don't work when cross
compiling for a target with different endianness. This brakes MIPS.
Added additional checks for big endian MIPS and MIPS64 targets to fix
this.

Patch by miran.karic@imgtec.com

BUG=None
R=bjaideep@ca.ibm.com, jshin@chromium.org

Review URL: https://codereview.chromium.org/2518533002 .
      73e24736
  13. Dec 07, 2016
  15. Nov 17, 2016
  17. Nov 15, 2016
    • Bruce Dawson's avatar
      Return to suppressing deprecation warnings · 4d136324
      Bruce Dawson authored 
      The previous change re-enabled warnings too aggressively. While the icu
target built correctly the icu nacl targets (such as
irt_x64/obj/third_party/icu/icuuc/uidna.o on Windows and
newlib_pnacl/obj/third_party/icu/icuuc/uidna.o on other platforms)
failed to compile due to deprecation warnings. This change adds back
suppression of that one warning.

BUG=21515
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/2504463002 .
      4d136324
  19. Nov 14, 2016
    • Bruce Dawson's avatar
      Re-enable as many clang warning as possible · 3c89207b
      Bruce Dawson authored 
      ICU has historically had many clang warnings disabled, but some of the
underlying causes have been fixed. One of the VC++ specific warning
disables was recently removed (crrev.com/2494793002) and this change
removes a bunch more, for clang and VC++. For some of them there are
specific icu bugs that have been fixed that allow this, and for others
I just have the evidence that on Linux and Windows icu compiles with
clang and VC++ with these changes.

BUG=21515
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/2492553006 .
      3c89207b
  21. Nov 11, 2016
  23. Oct 28, 2016
    • Jungshik Shin's avatar
      ICU update to 58 part 2 · e0d9b90c
      Jungshik Shin authored 
      Follw-up to https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad5
(due to a rietveld issue, part 1 was manually pushed).

Update ICU to 58.1 release from ICU 56.1 part2.

Listed below a tiny subset of what's new in 58.1:

  1. Unicode 9.0 from Unicode 8.0
    - Updated character properties including Emoji data up to 4.0beta.
    - Updated grapheme/word/line breaking rules for Emoji sequences and others.

  2. CLDR 30.0.2 from CLDR 28
    - Numerous locale data updates/improvements

  3. Spoofing API changes
  4. Greek uppercasing support as a part of regular case-mapping API.
  5. Line breaking rule file format optimization. This change enables me
     to add CJ loose line breaking rules back (previously, it's dropped
     to save space) so that Blink can use it for CJ.

See http://site.icu-project.org/download/58 for more details on ICU 58.1
and http://site.icu-project.org/download/57 for more details on ICU 57.1

For CLDR 30, see http://cldr.unicode.org/index/downloads/cldr-30 .

The size impact:
   Non-Android: 10,127,200 => 10,128,624 (delta = 1,424 / 0.014%)
   Android: 6,563,152 => 6,571,936 (delta = 8,784 / 0.13%)

Below are the list of changes made on top of the upstream ICU 58.1
in reverse order. Most of these changes were made in 58staging branch
to run trybots and cherry-picked back for this CL. See
   https://chromium.googlesource.com/chromium/deps/icu/+/log/chromium/58staging
   https://codereview.chromium.org/2447513002/ : cr+blink update cl with
       58staging branch head.

* Fix a build on Win without std::string (v8)
* Add ms932 alias to Shift_JIS

* Apply Google-specific locale data patches

* Fix a bug in scriptset

* Update windows-1255 mapping

* Disable C4333 warning by MSVC (harmless)

* Apply and update utf32.patch and README.chromium

* Update and apply vscomp.patch
  stringpiece patch removed. VS2015 seems to be fine with a redefinition.

* Update pre-built ICU data files
   Update *local.mk with a new copyright line

* Apply more patches
  The following patches were applied and updated: data_symb, vscomp, wpo

  The unnecessary part was dropped from vscomp

* Update BUILD.gn and icu.gyp* files

* Update android/brkitr.patch

* Update and apply more patches

* Update and apply cjdict.patch
   Apply data.build.patch

* Delete obsolete patches: cmemory,regex

* Update README.chromium and apply brkitr patches

  - Update README.chromium
  - Remove obsolete patches
  - Update linebrk.patch and apply it: add back line_loose_cj

* Update wordbrk.patch and apply it

* Update and apply khmer-dictbe.patch

* Update data trimming

  - android/patch_locale.sh
  - scripts/trim_data.sh
     ExemplarCh* removed
     charac*Label removed
     relative/relativeTime removed for daysOfWeek and quarter

* Update the following patches

  android/brkitr.patch
  patches/linebrk.patch
  patches/data.build.patch

* Update cjdict.patch and linebrk.patch

BUG=637001
TEST=Layout tests, all unittests, browser tests, ui tests.
R=jsbell@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/2442923002 .
      e0d9b90c
  25. Oct 23, 2016
    • Jungshik Shin's avatar
      Update ICU to 58 part1 · 5feb9ad5
      Jungshik Shin authored 
      * Note that this CL will be followed by CLs with local changes.
  Until then, ICU should not be rolled in DEPS. See READ_THIS_FIRST
  for details.

* Adjust scripts/update.sh and scripts/data_files_to_preserve.txt
  - CLDR/ICU added ckb/ast locale data. Drop them from the list to preserve.
  - source/layout does not exist in 58.1 any more.

* Update the tree to ICU 58.1 from the upstream by running
  scripts/update.sh

* Update README.chromium and add READ_THIS_FIRST to warn about the
  status of the tree.

BUG=637001
TEST=None
      5feb9ad5
  27. Oct 21, 2016
    • Jungshik Shin's avatar
      Delete Visual Studio build files · f8aa31da
      Jungshik Shin authored 
      There's no need for VS build files.
Besides, update scripts/update.sh to post-edit source/configure
for missing test/ directory.

This clean up is necessary to get 'git cl upload/rietveld' work
smoothly in an upcoming ICU update.

BUG=637001
TEST=source/runConfigureICU Linux --disable-tests --disable-layout

Review URL: https://codereview.chromium.org/2443653002 .
      f8aa31da
    • Jungshik Shin's avatar
      Delete source/test · 2e57f555
      Jungshik Shin authored 
      We don't use source/test. It's kept to give API usage examples, but
it got in the way of a version update (git cl upload keeps timing out).

Also, update update.sh to delete source/test after downloading a new
version from the upstream.

BUG=637001
TEST=None

Review URL: https://codereview.chromium.org/2435373002 .
      2e57f555
  29. Sep 13, 2016
  31. Aug 17, 2016
  33. Aug 09, 2016
  35. Aug 08, 2016
  37. Aug 02, 2016
    • Jungshik Shin's avatar
      List header files explicitly in BUILD.gn · 56680aaa
      Jungshik Shin authored 
      Private headers are listed in source[] while public headers are listed
in public[] for icuuc and icu18n targets.

This change is to let trybot analyze step recompile icuuc or icu18n even
when the only change in CL is in a header file (public or private).

BUG=632438
TEST=`gn check <out_dir>` does not complain.
TEST=`gn ref <out_dir> third_party/icu/source/common/umutex.h` matches icuuc.
TEST=`gn ref <out_dir> third_party/icu/source/common/unicode/unistr.h`
     matches icuuc.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/2186343002 .
      56680aaa
  39. Jul 29, 2016
    • Jungshik Shin's avatar
      Fix isolate_tests/clean isolate step · ef5c7353
      Jungshik Shin authored 
      Add 'data' to copy() to for swarm-testing to work on trybots.
Otherwise, the ICU data bundle would not be copied in isolate_tests step and
all the tests requiring the ICU data would fail on trybots.

BUG=v8:4828
TEST=base_unittests and many other tests pass on trybots (with test isolation)
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/2197523002 .
      ef5c7353
  41. Jul 27, 2016
    • Jungshik Shin's avatar
      Update IANA timezone db to 2016f from 2016d · 4ba0bcf3
      Jungshik Shin authored 
      The only change affecting the current and future time stamp
is that Asia/Novosibirsk swiches from +06 to +07. The Egyptian
change in 2016f cancelled out the Egyptian change in 2016e.

http://mm.icann.org/pipermail/tz-announce/2016-July/000040.html

All the pre-built data files are updated except for icudt.dll
for Windows (non-default build configuration. The default build
configuration on Windows is covered by this CL).

BUG=473288
TEST=Try the following in d8 or Chrome's JS console:
> (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone:
"Asia/Novosibirsk"})
7/23/2016, 6:00:00 PM
> (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone:
"Asia/Novosibirsk"})
7/24/2016, 7:00:00 PM

Review URL: https://codereview.chromium.org/2183313002 .
      4ba0bcf3
    • Jungshik Shin's avatar
      Big Endian support part 4 · 3655cfba
      Jungshik Shin authored 
      Delete three pre-built assembly source files because they're now
generated at build-time.

Update data build scripts and README.chromium accordingly.

Update copy_data.sh and copy_data_android.sh so that the assembly
source files are not copied. Besides, convert the little endian
data bundle to the big endian data bundle for non-Android platforms.

BUG=v8:4828
TEST=Rebuild icu data following the procedure in README.chromium
TEST='gn args <builddir>' with icu_use_data_file set to true or false
TEST=build base_unittests and run with --gtest_filter=ICU*
TEST=build base_unittests and run with --gtest_filter=Message*ormat*
TEST=build 'd8' (v8) and try `(new Date()).toLocaleString("de")`

Review URL: https://codereview.chromium.org/2182883004 .
      3655cfba
  43. Jul 26, 2016
  45. Jul 22, 2016
  47. Jul 21, 2016
    • Miran Karic's avatar
      Add big endian support · e7d37b69
      Miran Karic authored 
      Add a script that generates an assembly file from a .dat file. This is
needed for generating big endian assembly file after using icupkg to
convert little endian icudtl.dat to big endian icudtb.dat. Also the
icu.gyp file is modified so big endian architectures use appropriate
files.

Patch by miran.karic@  ( https://codereview.chromium.org/1967523002/)
with a couple of fixes:

1. Two errors mentioned against PS#9 in the above CL.
2. Support copying icu data file for Big Endian targets.

Besides, icudtb.dat was added to common. icudtb.dat was created by
running 'icupkg -tb icudt56l.dat icudt56b.dat' and renaming icudt56b.dat
to icudtb.dat.

BUG=v8:4828
TEST='d8' is built correct with icu_use_data_file set to either 0 or 1.
TEST=run `GYP_DEFINES="target_arch=mips" ./gypfiles/gyp_v8` and make sure
that ninja files use 'b' data/assembly file for Big Endian.

Review URL: https://codereview.chromium.org/2162393003 .

Patch from Miran Karic <miran.karic@imgtec.com>.
      e7d37b69
  49. Jul 08, 2016
  51. Jun 24, 2016
  53. Jun 02, 2016
  55. May 26, 2016
  57. May 23, 2016
  59. May 20, 2016
    • Jungshik Shin's avatar
      Update IANA timezone DB to 2016d · 54f86bb1
      Jungshik Shin authored 
      What's new in 2016d is found at

  http://mm.icann.org/pipermail/tz-announce/2016-April/000038.html

Rebuilt ICU data/assembly files are checked in (not shown in the
codereview due to their sizes).

While I'm at it, add scripts/LICENSE file that is identical to
LICENSE at the top of the Chromium tree. Because LICENSE in
third_party/icu is for ICU and is not applicable to files in scripts/.

BUG=473288
TBR=mark
TEST=In JavaScript console, run the following.
      apr30_2016_1200 = new Date("04/30/2016 12:00Z")
      may01_2016_1200 = new Date("05/01/2016 12:00Z")
      apr30_2016_1200.toLocaleString("en", {timeZone: "America/Caracas"})
      may01_2016_1200.toLocaleString("en", {timeZone: "America/Caracas"})

  On April 30, 2016, Caracas is 4:30 behind UTC. On May 1, it's 4:00 behind.

Review URL: https://codereview.chromium.org/1985243002 .
      54f86bb1