Skip to content
Snippets Groups Projects
Select Git revision
  • upstream/master
  • master default
  • upstream/chromium/65staging
  • upstream/chromium/char16t_test
  • upstream/chromium/64staging
  • upstream/chromium/m74
  • upstream/chromium/m71
  • upstream/chromium/m72
  • upstream/chromium/win7tz
  • upstream/chromium/char16tv2
  • upstream/chromium/63staging
  • upstream/chromium/m70
  • backup/master
  • upstream/chromium/62staging
  • upstream/chromium/61staging
  • upstream/upstream/master
  • upstream/chromium/m63
  • upstream/upstream/chromium/m63
  • upstream/chromium/60staging
  • upstream/upstream/chromium/60staging
20 results
Search by author
  • Any Author
  • banggua banggua banggua
1 author
  1. Oct 15, 2014
  3. Oct 13, 2014
  5. Oct 04, 2014
  7. Sep 25, 2014
    • jshin@chromium.org's avatar
      Check in word_ja.txt for Android. · abeeb961
      jshin@chromium.org authored 
      word_ja.txt has not been checked in although the icu data file for Android
(android/icudtl.dat) was built with the file.

README.chromium about Android's brkitr patch was not updated when moving to
ICU 52.1. It's changed to reflect what we do in ICU 52.1 (where the upstream
copy does have cjdict for CJ word breaking).

TBR=andrewhayden@chromium.org
BUG=NONE
TEST=NONE (there's no change affecting Chrome/Blink builds).

Review URL: https://codereview.chromium.org/609493003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292144 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      abeeb961
    • jshin@chromium.org's avatar
      Turn on UCONFIG_NO_NON_HTML5_CONVERTER · 52e8245c
      jshin@chromium.org authored 
      UCONFIG_NO_NON_HTML5_CONVERTER was added earlier to our copy of ICU, but
it was never set to 1.  It's my oversight.

1. Turns UCON..CONVERTER on in icu.gyp to drop all the encodings not
   required by the Encoding spec. Dropped encodings include
   UTF-7, BOCU, SCSU, CESU, ISCII, ISO-2022-{KR, CN*}, HZ-GB, ISO-2022-JP's
   other than the original.

2. A lot more sections of the ICU converter code are excluded when
   it's set to 1 including the code for LMB (Lotus Multibyte) encodings and
   X11 compound text encoding (icu common).

3. The character encoding detections for encodings excluded are also disabled.
   (icu i18n)

4. ISO-2022-{KR, CN*} and HZ-GB can be dropped now because Blink treats them
   as replacement encoding. The corresponding alias entries from convertrs.txt
   are also removed.

5. ibm-874 was removed. We used to need it before Blink started, but not any
   more. We only need windows-874.

6. A mistaken in convertrs.txt was corrected : Big5-HKSCS was pointing to
   an old mapping table.

7. Per ICU upstream's suggestion, use '-html' suffix instead of '-html5'
for the encoding tables derived from the WHATWG's encoding spec (ibm866,
shift_jis and euc-jp).

The static 64-bit release build of Chrome on Linux went down from
141,596,616 to 141,491,968 bytes (~ 100 kB reduction). Besides, the icu data
size got smaller by ~ 19 kB ( 10,490,576 to 10,471,008 bytes).

See http://bugs.icu-project.org/trac/ticket/11296 for an upstream bug
I've filed on the issue.


BUG=76328
TEST=browser_tests --gtest_filter="*ncoding*"
TEST=net_unittest --gtest_filter="*ilenameUtil*"
TEST=base_unittests --gtest_filter="*Conv*"
TEST=Blink: fast/encoding/*
TEST=With shared library build, the following has no match.
  nm libicuuc.so | egrep  -i '(bocu|scsu|utf7|2022kr|2022cn|iscii)'
  nm libicui18n.so | egrep  -i '(2022kr|2022cn|ibm42)'
TEST=With static library build, the following has no match.
  nm chrome | egrep -i '(bocu|scsu|utf7|2022kr|2022cn|iscii|ibm42)'

R=jsbell@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/587833004

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292131 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      52e8245c
  9. Sep 17, 2014
  11. Sep 03, 2014
    • torne@chromium.org's avatar
      Remove invalid link_settings from target condition. · 89831135
      torne@chromium.org authored 
      ICU fails to gyp when run with GYP_DEFINES="android_webview_build=1
use_system_icu=0 use_system_stlport=1" which is a combination of
settings we're trying to bring up temporarily as we migrate away from
system libraries. It fails because it's not permitted to specify
link_settings in a target_condition as the processing is too late.

Remove the invalid link_settings, since we can't do this outside
target_conditions as it's not valid to use -lgabi++ on the host build of
ICU. The link dependency on gabi++ will have to be satisfied manually in
the main libwebviewchromium target instead for this configuration.

BUG=409851
R=mkosiba@chromium.org
TBR=jshin@chromium.org

Review URL: https://codereview.chromium.org/527193003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@291781 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      89831135
  13. Sep 02, 2014
    • jshin@chromium.org's avatar
      Update tz data to 2014f and add SJIS for the encoding spec · ff835309
      jshin@chromium.org authored 
      1. Timezone data files (4 of them) in source/data/misc to 2014f (the latest)
   to prepare for an upcoming Russian timezone change.
2. Add Shift_JIS converter compliant to the WHATWG encoding spec.
3. Update converters.txt and ucmlocal.mk accordingly
4. Update the pre-built data files for Linux/Mac/Android/Windows.
   (icudt.dll is not updated in this CL. It's not used in the default
    configuration. It'll be updated in a separate CL).
5. Fix a typo in ibm866_gen.sh. The acual table used does not need a change.


BUG=277062,404445
TEST=After rolling icu to this revision, the following tests should pass.
TEST=Blink: fast/encoding/* all pass except for
fast/encoding/api/ascii-supersets.html that should fail by *passing*
the test for Shift_JIS, which is expected to fail. Blink layout tests needs
to be updated.
TEST=browser_tests --gtest_filter="*ncoding*"
TEST=In JS console, run the following to check if Europe/Moscow is
3 hrs ahead of UTC after Oct 26 and 4 hrs ahead before that and
if Asia/Kamchatka remains 12 hrs ahead of UTC.
  nov1_2014_1500=new Date("11/01/2014 15:00Z")
  nov1_2014_1500.toLocaleString("en", {timeZone: "Europe/Moscow"})
  nov1_2014_1500.toLocaleString("en", {timeZone: "UTC"})
  nov1_2014_1500.toLocaleString("en", {timeZone: "Asia/Kamchatka"})
  oct24_2014_1500=new Date("10/24/2014 15:00Z")
  oct24_2014_1500.toLocaleString("en", {timeZone: "Europe/Moscow"})
  oct24_2014_1500.toLocaleString("en", {timeZone: "UTC"})
  oct24_2014_1500.toLocaleString("en", {timeZone: "Asia/Kamchatka"})
TEST=net_unittest --gtest_filter="*ilenameUtil*"
TEST=base_unittests --gtest_filter="*Conv*"
R=jsbell@chromium.org

Review URL: https://codereview.chromium.org/497543003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@291774 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      ff835309
  15. Aug 28, 2014
  17. Aug 26, 2014
  19. Aug 21, 2014
  21. Aug 01, 2014
  23. Jul 24, 2014
  25. Jun 18, 2014
  27. Jun 17, 2014
  29. Jun 10, 2014
  31. May 24, 2014
  33. May 20, 2014
  35. May 06, 2014
  37. May 05, 2014
    • jshin@chromium.org's avatar
      Add back display names for non-UI languages in A-L list · 4266d6d1
      jshin@chromium.org authored 
      I was too aggressive in trimming the data and dropped the display
names for languages that Chromium needs (for non-UI languages
that are in the A-L list). It's not my intention (the comment in
trim_data.sh said one thing, but the code did another). 

Besides, add Norweigian (nb) and Malay (ms) locale data that were not 
included by mistake.

Also update trim_data.sh script NOT to drop 'ALIAS' lines which are
used to indicate that a given locale is an alias to another locale.
That also required adding ro_MD.txt (null locale which mo.txt is 
aliased to).

The above three adds about 110kB to the icu data (from 10.3MB to 10.4MB).

Also update the pre-built icu data files for Linux, Mac and Windows.
The Android data will be updated in a follow-up patch.

BUG=132145
TEST=When ICU is rolled, unit_tests:ExtensionL10* pass.
TBR=mark

Review URL: https://codereview.chromium.org/264973016

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@268285 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      4266d6d1
  39. Apr 30, 2014
  41. Apr 29, 2014
  43. Apr 28, 2014
    • jshin@chromium.org's avatar
      Add icudt.dll for Windows · 8df7e257
      jshin@chromium.org authored 
      1. Generate and add windows/icudt.dll with the procedure outlined
in README.chromium. It uses a out-of-tree copy of the upstream ICU
along with our custom-built icudtl.dat and a locally modified version
of makedata.mak.

We used to have a separate build/ directory for VS solution/project files
to build icudtl.dll. Maintaining them is rather cumbersom now that we
want to update our ICU (major version changes) more frequently. 

Note that icudt.dll is not used by default (icu_use_data_file_flag=1). 
The GN build still uses it by default and we should not break that build.

2. Add scripts/make_mac_assembly.sh to simplify the generation of the icu
data assembly source file for Mac.

3. Update README.chromium accordingly.

This CL was uploaded and reviewed at 

https://codereview.chromium.org/255943004/

Due to a malfunction at codereview.chromium.org, I'm landing this CL 
manually in two parts. 
This check-in is the 2nd part of the CL dealing with #2 and #3
above.

BUG=132145
TEST=None until icu is rolled to this version.


git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@266602 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      8df7e257
    • jshin@chromium.org's avatar
      Add icudt.dll for Windows · be1611ad
      jshin@chromium.org authored 
      1. Generate and add windows/icudt.dll with the procedure outlined
in README.chromium. It uses a out-of-tree copy of the upstream ICU
along with our custom-built icudtl.dat and a locally modified version
of makedata.mak.

We used to have a separate build/ directory for VS solution/project files
to build icudtl.dll. Maintaining them is rather cumbersom now that we
want to update our ICU (major version changes) more frequently. 

Note that icudt.dll is not used by default (icu_use_data_file_flag=1). 
The GN build still uses it by default and we should not break that build.

2. Add scripts/make_mac_assembly.sh to simplify the generation of the icu
data assembly source file for Mac.

3. Update README.chromium accordingly.

This CL was uploaded and reviewed at 

https://codereview.chromium.org/255943004/

Due to a malfunction at codereview.chromium.org, I'm landing this CL 
manually.

BUG=132145
TEST=None until icu is rolled to this version.


git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@266601 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      be1611ad
  45. Apr 24, 2014
  47. Apr 22, 2014
    • jshin@chromium.org's avatar
      Trim unit* sections in data/locales/* · 4a39040d
      jshin@chromium.org authored 
      Add 'filter_locale_data' function to trim_data.sh

Chromium/Blink do not use most of unit* sections in locale data. Keep
only duration and compound sub-sections. 

Update the icudtl.dat and two assembly source files for Mac/Linux.

It saves ~200kB (uncompressed). 7z-compressed size reduction is 34kB.

With all these changes (up to this CL) applied, the net increase of the ICU data from icu 46 to 52 is 49kB with 7z-compressed.
(3,070,246 vs  3,021,457) and ~ 390kB uncompressed (10,370,656 vs 9,980,368 ). 

BUG=132145
TEST=None.
TBR=mark

Review URL: https://codereview.chromium.org/247663002

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@265354 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      4a39040d
  49. Apr 21, 2014
  51. Apr 18, 2014
    • jshin@chromium.org's avatar
      Remove {big5,gb2312}han collation data · 991d1f1e
      jshin@chromium.org authored 
      1. {big5,gb2312}han collation data is not used by anybody because they're
useless as a sorting order.

  Add a function to trim_data.sh to remove them from zh.txt

2. Remove remove_unihan.sh and add back unihan rules to coll/{zh,ja,ko}.txt.
In ICU 52, tools/genrb does NOT include unihan collation by default so that 
we don't have to bother to remove it from the rule files.

3. Remove obsolete patch files (locale[23].patch)

4. Add LICENSE file (converted from license.html)

5. Update README.chromium accordingly.

6. Check in the updated data file/assembly files.

The net saving in icudtl.dat is ~ 220kB.


BUG=132145
TEST=icudtl.dat is 10576480
TBR=mark

Review URL: https://codereview.chromium.org/243763002

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@264857 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      991d1f1e
    • jshin@chromium.org's avatar
      Trim ICU data to reduce the download size/memory usage · 4e493261
      jshin@chromium.org authored 
      Add a shell script to trim the ICU data further : trim_data.sh along with
locale list files.  The script does the following:

1. Remove the display names of languages NOT listed in Chrome's Accept-Language
   list. (800kB)
2. Minimize the locale data for locales listed in the A-L list that are
   not a UI locale in Chrome. For those locales, exemplar characters,
   the display name in the native language and layout direction are included.
   (640kB)
3. Filter the region data to drop numeric region display names other than 419
   (Latin-America). (50kB)
4. Filter the currency data (display name and plurals) for historic currencies.
   (200kB)

This CL also checks in icudtl.dat (source/data/in) and
icudt_dat.S (mac and linux). Note that I dropped '52' (the version number)
in the assembly source file name and icu.gyp was adjusted accordingly.

With all these changes, icudtl.dat is ~ 800kB larger than that in ICU 4.6.
The 7z compression (as used by the installer) makes the size difference
go down to ~ 130kB.

BUG=132145
TEST=The icudtl.dat (uncompressed) is about 10.7MB instead of 12.4MB without this CL.
R=mark@chromium.org

Review URL: https://codereview.chromium.org/239543018

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@264811 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      4e493261
  53. Apr 17, 2014
  55. Apr 11, 2014
    • jshin@chromium.org's avatar
      ICU 52 local change part 2 · 1084fe06
      jshin@chromium.org authored 
      Update patches/local1.patch

1. Drop a lot of changes that have been upstreamed since ICU 4.6.x
2. Keep and update exemplar character set for zh*, ja, Indic locales
3. Make timezone names more consistent. Most of the inconsistencies have
   been fixed in the upstream, but there are still some remaining while
   others were fixed after ICU 52.1
4. Minor fixes in other locale data : Date/interval formats, 
   AmPm markers (Indic locales), etc.

BUG=76328
TEST=None (when rolled, net_unittests:*IDN* passes).
TBR=mark

Review URL: https://codereview.chromium.org/232773005

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@263295 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      1084fe06
  57. Apr 07, 2014
    • jshin@chromium.org's avatar
      ICU 52 local changes part1 · 4dfa619c
      jshin@chromium.org authored 
      1. Remove all the obsolete patches. There are lots of them because most of
local patches to ICU 4.6.1 have either been accepted or become obsolete.
The largest local patch removed is our patches for CJ word breaker because
they were upstreamed.

Android didn't apply the CJK word breaker patch to ICU 4.6 to reduce the
data size. In a follow-up CL, we'll have an Android-specific change for this issue.

Besides, we don't include patches for files we locally add because the
patches for new files are redundant. Instead, they're mentioned in
README.chromium.

2. We don't need platform-specific headers any more (pmac, plinux, pwin, etc).
They're combined into a single file and all platforms we care about are
well-supported except for one issue on Android/QNX. putil.patch takes care
of it.


3. Breakiterator patches for a few remaining issues. We also use
a much smaller Khmer dictionary (upstream fix pending).

4. Converter
  - Introduced two WHATWG-encoding-standard-compliant mapping tables
    are added (derived directly from the spec with a script) for EUC-JP
    and CP866
  - Disabled various non-HTML5-encodings such as SCSU,BOCU, UTF-7, CESU-8
    saving ~30kB in the code size. Even though we link statically, they're
    still pulled in as a part of uconv.
  - Disabled ISO-2022-JP-[1-4] in ucnv2022.c
  - Removed a number of encoding alias entries in the alias table
    leading to ~40kB data size reduction.

5. Locale data : Haven't yet updated. We need to trim them substantially.

6. Unihan collation removal is now done with a script (scripts/remove_unihan.sh)

7. Updated timezone data to the latest (2014b) as of today.

8. Customized transliterator for Greek uppercasing

9. Updated data build related patches. The windows data build patch has yet
   to be updated.

10. The updated ICU data file/assembly source files are not included in this
    CL. They'll be updated in a separate CL.
    With all the size reduction changes applied, the data size went down
    from > 23MB to 12.4MB. However, it's still 2.5MB larger than ICU 4.6.1
    data. The locale data trimming will bring it down further.

11. Update README.chromium accordingly. The only exceptions are
item #5 and the android entry in item #3 (breakiterator. see #1 above)



BUG=259715,76328
TEST=Following the procedure outlined in README.chromium, one can build
the icu data file.

R=jsbell@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/224943002

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@262192 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      4dfa619c
  59. Apr 03, 2014