Skip to content
Snippets Groups Projects
Select Git revision
  • upstream/master
  • master default
  • upstream/chromium/65staging
  • upstream/chromium/char16t_test
  • upstream/chromium/64staging
  • upstream/chromium/m74
  • upstream/chromium/m71
  • upstream/chromium/m72
  • upstream/chromium/win7tz
  • upstream/chromium/char16tv2
  • upstream/chromium/63staging
  • upstream/chromium/m70
  • backup/master
  • upstream/chromium/62staging
  • upstream/chromium/61staging
  • upstream/upstream/master
  • upstream/chromium/m63
  • upstream/upstream/chromium/m63
  • upstream/chromium/60staging
  • upstream/upstream/chromium/60staging
20 results
Search by author
  • Any Author
  • banggua banggua banggua
1 author
  1. Jan 09, 2018
  3. Dec 14, 2017
  5. Dec 13, 2017
  7. Dec 12, 2017
  9. Dec 08, 2017
    • Jungshik Shin's avatar
      Fix trim_data.sh to delete empty currency blocks · e3b480d3
      Jungshik Shin authored 
      After data trimming, data/curr/en_GB.txt has empty "Currencies" block.
This prevents a locale fallback chain from being triggered for currency
symbols (en-GB => en-001 => en), leading all the currency symbols in en-GB
to be the last resort value (ISO 3-letter currency code). To avoid that,
trim_data.sh is revised to drop empty "Currencies" block entirely ('Missing'
triggers a fallback chain, but 'empty' goes straight to the last resort.)

Additional currency data fixes:

1. Serbian: RON and ROL display names are swapped. RON is the current
currency and should be included with a shorter display name.

2. Add a few more en-* locale variants to the locale list for currency.

Moreover, make_data_all.sh is updated to work wherever the Chromium
source tree is.

Finally, update the list of resources to remove from cast's ICU data
and rebuild it with ICU 60.  Added entries to cast-removed-resources.txt
are data for locale-variants that are not useful in Cast.

Bug: 791318
Test: See the bug
Change-Id: Ib09ee36e3447557636d60d8aeabc7ca047718236
Reviewed-on: https://chromium-review.googlesource.com/810099


Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
      e3b480d3
  11. Dec 07, 2017
  13. Nov 20, 2017
    • Mina Almasry's avatar
      Intergrate Cast Audio icudtl.dat generation into chromium process. · 741688eb
      Mina Almasry authored 
      Our Cast Audio devices use a stripped down version of the android
icudtl.dat. Essentially the patch_locale.sh has been modified to keep in
things provided by Java, as cast doesn't have Java and needs there
resources.

On the other hand, a bunch of resources have been stripped from the
icudtl.dat to reduce its size because we are very constrained on that.

We have been using this icudtl.dat process for a long time now, and it's
throughly validated. However, we used to generate this in our internal
repo, which meant that we have to manually update it whenever chromium
updates their icudtl.dat.

This CL aims to intergrate the generation of the icudtl.dat in chromium,
so we no longer have to manually update in our internal repo.

Bug: internal b/28053340
Test: On cast audio device

Change-Id: I881eb2ddf046fdd16fd7efbfb0d56877abfaf947
Reviewed-on: https://chromium-review.googlesource.com/773591


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      741688eb
  15. Nov 09, 2017
  17. Nov 07, 2017
  19. Nov 03, 2017
  21. Oct 11, 2017
  23. Oct 10, 2017
  25. Aug 14, 2017
  27. Aug 03, 2017
  29. Jul 27, 2017
  31. Jul 19, 2017
  33. Jul 18, 2017
    • Jungshik Shin's avatar
      Add es, en and ar variants · 1fec0c83
      Jungshik Shin authored 
      The following locale variants are added to the ICU. Only source/data/locales
are added and other locale categories are left alone.

- es-* variants
- en-SG and en-HK
- Arabic variants whose NumberElements are different from ar.

Data file size changes:

- desktop:
   10192200 - 10178576 = 13624  (adding es variants)
   10197040 - 10192200 =  4840  (adding ar variants)
- Android: 6635632 - 6616864 = 18768
- iOS: 6623888 - 6605152 = 18736


Bug:chromium:732762
Test:See the bug report and comment 13
TBR=littledan@chromium.org
Change-Id: I3e87be3413e22aa49f24f81b0e25bd6e4187c0d4
Reviewed-on: https://chromium-review.googlesource.com/576113


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      1fec0c83
  35. Jul 17, 2017
  37. Jun 02, 2017
  39. Jun 01, 2017
  41. May 31, 2017
  43. May 18, 2017
  45. May 16, 2017
  47. May 15, 2017
  49. May 14, 2017
    • Jungshik Shin's avatar
      Update ICU to 59.1 · 87232d8d
      Jungshik Shin authored 
      * Highlights:
  - Emoji 5.0 data (partial; Emoji_Component property not included)
  - CLDR 31.0.1 (http://blog.unicode.org/2017/03/cldr-version-31-released.html)
    UTC and GMT are treated as distinct)
  - New case mapping API for styled text
  - C++ 11 is required
  - char16_t for UChar (UTF-16)
  - Source code is in UTF-8

* Size changes

  common: 10,130,560 => 10,175,056
  android: 6,573,872 => 6,616,864
  iOS: 6,562,352 => 6,605,152

On top of ICU 59.1 from the upstream, the following changes were applied.
See https://chromium.googlesource.com/chromium/deps/icu/+log/chromium/59staging

  - Fix C++ 11 string literal assignment issue (upstream bug: 13192)
  - Fix C4229 warning by MSVC
  - Apply utf32.patch and include unistr.h in fuzzer_util
  - Update ICU data files
  - Fix wpo.patch
  - Apply Google locale patch and locale1.patch
  - update readme
  - Apply breakiterator related patches
  - Apply and update wpo.patch
  - Drop unused patch, apply data.build.win.patch, update README.chromium
  - Add /utf-8 flag for Windows/Visual Studio
  - Update BUILD.gn for UChar, stubdata and apply data_sym.patch
  - use stubdata.cpp instead of stubdata.c in icu.gyp
  - Update icu.gyp* files for v8
  - Update BUILD.gn, apply data.build.patch and vscomp.patch
  - Add new files in ICU 59.1
  - Get a fresh copy of ICU 59.1 from the upstream
  - Update update.sh script

TBR=drott@chromium.org, yangguo@chromium.org
Bug:699469
TEST: layout tests, all unittests, browser tests
Change-Id: Ie1e77323aa0c7f872153680c4deca6471a771a5c
Reviewed-on: https://chromium-review.googlesource.com/505173


Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      87232d8d
  51. May 05, 2017
    • Jungshik Shin's avatar
      Customize the ICU data for iOS · 4b06aadd
      Jungshik Shin authored 
      Add ios/icudtl.dat and ios/patch_locale.sh.

Update README.chromium and BUILD.gn accordingly.
Update scripts/copy_data.sh to take (ios|common|android).

At the moment, iOS data is almost identical to that of Android, but in the future
more cuts may be made (e.g. dictionary data for breakiterator).

Bug: 718955
TEST: iOS Chrome works as before.
Review-Url: https://codereview.chromium.org/2743123002 .
      4b06aadd
  53. Apr 25, 2017
  55. Apr 11, 2017
    • Jungshik Shin's avatar
      Update timezone db to 2017b · b34251f8
      Jungshik Shin authored 
      See

  http://mm.icann.org/pipermail/tz-announce/2017-March/000046.html

for details.

  - Haiti resumed observing DST.

Data file size changes:

   android/icudtl.dat 6573792 =>  6573872
   common/icudt*.dat 10130480 => 10130560

BUG=473288
TEST=Try the following in d8 or Chrome's JS console:
 > (new Date("3/12/2016 12:00Z")).toLocaleString("en", {timeZone:
 "America/Port-au-Prince"})
 "3/12/2016, 7:00:00 AM"
 > (new Date("3/12/2017 12:00Z")).toLocaleString("en", {timeZone:
 "America/Port-au-Prince"})
 "3/12/2017, 8:00:00 AM"

Review-Url: https://codereview.chromium.org/2807343004 .
      b34251f8
    • Jungshik Shin's avatar
      Update trim_data to deal with locale fallback failure for units · d5c238dc
      Jungshik Shin authored 
      Delete empty units,units{Narrow,Short} blocks after trimming units data.
Empty units* blocks in en_GB and a few other locales after trimming
causes ICU to fail to fall back to get the duration data for those
locales.

In addition, fix source/data/translit/root_subset.txt. Rule*Ids block has
to be present even though it's empty. When dropping Hans-Hant transform
rules, root_subset.txt was changed to be completely empty, which broke
"components_unittests --g_test_filter=AutofillProfileComparato*" .

With these changes, regenerate ICU data files. The size is slightly smaller.

android/icudtl.dat  6573872 => 6573792
common/icudt*dat    10130560 => 10130480

BUG=707515,677043,684609
TEST=components_unittests --gtest_filter=AutofillProfileComparato*
TEST=ui_base_unittests --gtest_filter=L10nUtilTest.TimeDurationForm*
R=derat@chromium.org

Review-Url: https://codereview.chromium.org/2812943003 .
      d5c238dc
  57. Mar 16, 2017
  59. Mar 15, 2017
  61. Mar 07, 2017
  63. Feb 21, 2017
  65. Jan 27, 2017
  67. Dec 12, 2016