- May 16, 2017
-
-
Jungshik Shin authored
http://www.icu-project.org/trac/ticket/12333 http://www.icu-project.org/trac/ticket/13189 http://www.icu-project.org/trac/ticket/12635 - patches/ucase_utf8.patch - patches/ucurr_locale.patch - patches/collator_range.patch Bug=chromium:722124 TEST=See the test TBR=inferno@chromium.org Change-Id: I3e754734a1c1121c8059a386ca1b5d0f004adb79 Reviewed-on: https://chromium-review.googlesource.com/506592 Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- May 14, 2017
-
-
Jungshik Shin authored
* Highlights: - Emoji 5.0 data (partial; Emoji_Component property not included) - CLDR 31.0.1 (http://blog.unicode.org/2017/03/cldr-version-31-released.html) UTC and GMT are treated as distinct) - New case mapping API for styled text - C++ 11 is required - char16_t for UChar (UTF-16) - Source code is in UTF-8 * Size changes common: 10,130,560 => 10,175,056 android: 6,573,872 => 6,616,864 iOS: 6,562,352 => 6,605,152 On top of ICU 59.1 from the upstream, the following changes were applied. See https://chromium.googlesource.com/chromium/deps/icu/+log/chromium/59staging - Fix C++ 11 string literal assignment issue (upstream bug: 13192) - Fix C4229 warning by MSVC - Apply utf32.patch and include unistr.h in fuzzer_util - Update ICU data files - Fix wpo.patch - Apply Google locale patch and locale1.patch - update readme - Apply breakiterator related patches - Apply and update wpo.patch - Drop unused patch, apply data.build.win.patch, update README.chromium - Add /utf-8 flag for Windows/Visual Studio - Update BUILD.gn for UChar, stubdata and apply data_sym.patch - use stubdata.cpp instead of stubdata.c in icu.gyp - Update icu.gyp* files for v8 - Update BUILD.gn, apply data.build.patch and vscomp.patch - Add new files in ICU 59.1 - Get a fresh copy of ICU 59.1 from the upstream - Update update.sh script TBR=drott@chromium.org, yangguo@chromium.org Bug:699469 TEST: layout tests, all unittests, browser tests Change-Id: Ie1e77323aa0c7f872153680c4deca6471a771a5c Reviewed-on: https://chromium-review.googlesource.com/505173 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- Mar 07, 2017
-
-
Jungshik Shin authored
BUG=None Review-Url: https://codereview.chromium.org/2736013003 .
-
- Nov 11, 2016
-
-
Jungshik Shin authored
They don't affect Chrome/Blink at the moment, but had better be fixed now. http://www.icu-project.org/trac/ticket/12815 http://www.icu-project.org/trac/ticket/12832 BUG=None Review URL: https://codereview.chromium.org/2499493002 .
-
- Oct 28, 2016
-
-
Jungshik Shin authored
Follw-up to https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad5 (due to a rietveld issue, part 1 was manually pushed). Update ICU to 58.1 release from ICU 56.1 part2. Listed below a tiny subset of what's new in 58.1: 1. Unicode 9.0 from Unicode 8.0 - Updated character properties including Emoji data up to 4.0beta. - Updated grapheme/word/line breaking rules for Emoji sequences and others. 2. CLDR 30.0.2 from CLDR 28 - Numerous locale data updates/improvements 3. Spoofing API changes 4. Greek uppercasing support as a part of regular case-mapping API. 5. Line breaking rule file format optimization. This change enables me to add CJ loose line breaking rules back (previously, it's dropped to save space) so that Blink can use it for CJ. See http://site.icu-project.org/download/58 for more details on ICU 58.1 and http://site.icu-project.org/download/57 for more details on ICU 57.1 For CLDR 30, see http://cldr.unicode.org/index/downloads/cldr-30 . The size impact: Non-Android: 10,127,200 => 10,128,624 (delta = 1,424 / 0.014%) Android: 6,563,152 => 6,571,936 (delta = 8,784 / 0.13%) Below are the list of changes made on top of the upstream ICU 58.1 in reverse order. Most of these changes were made in 58staging branch to run trybots and cherry-picked back for this CL. See https://chromium.googlesource.com/chromium/deps/icu/+/log/chromium/58staging https://codereview.chromium.org/2447513002/ : cr+blink update cl with 58staging branch head. * Fix a build on Win without std::string (v8) * Add ms932 alias to Shift_JIS * Apply Google-specific locale data patches * Fix a bug in scriptset * Update windows-1255 mapping * Disable C4333 warning by MSVC (harmless) * Apply and update utf32.patch and README.chromium * Update and apply vscomp.patch stringpiece patch removed. VS2015 seems to be fine with a redefinition. * Update pre-built ICU data files Update *local.mk with a new copyright line * Apply more patches The following patches were applied and updated: data_symb, vscomp, wpo The unnecessary part was dropped from vscomp * Update BUILD.gn and icu.gyp* files * Update android/brkitr.patch * Update and apply more patches * Update and apply cjdict.patch Apply data.build.patch * Delete obsolete patches: cmemory,regex * Update README.chromium and apply brkitr patches - Update README.chromium - Remove obsolete patches - Update linebrk.patch and apply it: add back line_loose_cj * Update wordbrk.patch and apply it * Update and apply khmer-dictbe.patch * Update data trimming - android/patch_locale.sh - scripts/trim_data.sh ExemplarCh* removed charac*Label removed relative/relativeTime removed for daysOfWeek and quarter * Update the following patches android/brkitr.patch patches/linebrk.patch patches/data.build.patch * Update cjdict.patch and linebrk.patch BUG=637001 TEST=Layout tests, all unittests, browser tests, ui tests. R=jsbell@chromium.org, mark@chromium.org Review URL: https://codereview.chromium.org/2442923002 .
-
- Apr 05, 2016
-
-
Jungshik Shin authored
Cherry pick http://bugs.icu-project.org/trac/changeset/38183 to add the support for Emoji properties. This will be followed by a Blink change to use the API. ( https://codereview.chromium.org/1856353002 ) There's no need to rebuild ICU data because Unicode character properties are hard-coded in the C++ source files that are patched by the cherry-pick above. source/data/in/{pnames,uprops}.icu are updated just for the record, but they're not actually used. The same is true of files in source/data/unidata. BUG=583378 TEST=None TBR=drott Review URL: https://codereview.chromium.org/1864463002 .
-
- Mar 25, 2016
-
-
Jungshik Shin authored
1. Update the IANA tz data to 2016c What's new in 2016b and 2016c are found at http://mm.icann.org/pipermail/tz-announce/2016-March/000036.html (2016b) http://mm.icann.org/pipermail/tz-announce/2016-March/000037.html (2016c) 2. Locale data fixes - en-AU date format fix from the upstream - ar and fa: Prepend 'percent sign' with RTL mark (U+200F). From Android. - tr: Use ₺ (U+20BA; Turkish Lira Sign) instead of 'TL'. This is to revert a locale patch picked up from Google's internal build of ICU. (Android also uses U+20BA). In addition, icudtl.dat (the prebuilt ICU data file for platforms other than Android is moved out of source/data/in to common/. This way, the data build steps for non-Android and Android can be unified and a bit more streamlined. icu.gyp and BUILD.gn are updated accordingly as well as README.chromium. BUG=598000 TEST=See bug comment 0 and comment 1 R=mark@chromium.org Review URL: https://codereview.chromium.org/1823293002 .
-
- Mar 20, 2016
-
-
Jungshik Shin authored
region.cpp has an unnecessary static initializer for a type UnicodeString and triggers a 'si check' failure. Upstream bug: http://bugs.icu-project.org/trac/ticket/12408 BUG=575007 TEST=`tools/linux/dump-static-initializers.py chrome` (static build) does not have an entry from region.cpp TEST=`tools/linux/dump-static-initializers.py libicui18n.so` (shared build) has no entry. TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1816843002 .
-
- Feb 04, 2016
-
-
Jungshik Shin authored
See http://crbug.com/417850 for UTF-32 See http://bugs.icu-project.org/trac/ticket/12147 for C4275 warning from MSVC. BUG=575007 TEST=Layout tests fast/encoding/* TEST=MSVC does not emit C4275 warning any more R=jsbell@chromium.org Review URL: https://codereview.chromium.org/1664293002 .
-
- Feb 02, 2016
-
-
Jungshik Shin authored
Set fLastSetLiteral to U_SENTINEL in the ctor and check if it's still U_SENTINEL before adding the range. BUG=582470 TEST=See comments 13 and 15 in the bug TBR=mmoroz Review URL: https://codereview.chromium.org/1656003004 .
-
Jungshik Shin authored
This is to cherry-pick a fix for http://bugs.icu-project.org/trac/ticket/12130 It's done by merging commit '2b12f877' (for m49 branch) to master. (ICU's m49 branch was fixed first because ICU master was in the middle of upgrading to ICU 56.1). BUG=575206 TEST=See comment 51 in the bug TBR=mmoroz@chromium.org Review URL: https://codereview.chromium.org/1662453002 .
-
Jungshik Shin authored
MSVC complains about '*/* foobar */'. Add a space between '*' and '/'. ICU uses a deprecated API internally and '-Wno-deprecated...' flag has to be turned on on Android as well as on Linux. Do not use ''-Wno-reorder' any more because it's not necessary. BUG=575007 TEST=Once rolled, Android and Windows build go through. R=thakis@chromium.org Review URL: https://codereview.chromium.org/1646623006 .
-
- Jan 29, 2016
-
-
Jungshik Shin authored
Below is the list of changes in reverse order. 1. Drop uconv.patch (upstream took my patch) 2. Apply data.build.win and data_sym patches 3. Apply vscomp.patch and update the patch file. update README.chromium about two parts of the patch that are not necessary any more. 4. Apply wpo patch and update the patch file 5. Android brkitr adjustment * Do not apply the patch but just updates the patch * Do not use CJdict on Android to save 2MB in the data size. 6. Clean up brkitr patches * Rename brkitr.patch to wordbkr.patch and keep only word.txt diff * Make a new linebrk.patch with line breaking adjustment (dropping loose rules to save space until the upstream implements space-efficient mechanism for line breaking rule variations) * Update README.chromium * Apply local patches for Khmer dictionary handling and cjdict 7. Adjust line breaking rules. This corresponds to set 2 in https://code.google.com/p/chromium/issues/detail?id=575007#c6 BUG=575007 TEST=None R=mark@chromium.org Review URL: https://codereview.chromium.org/1637683002 .
-
Jungshik Shin authored
1. Apply post-56 patches from the trunk for measure/date format http://bugs.icu-project.org/trac/ticket/11986 http://bugs.icu-project.org/trac/ticket/12031 http://bugs.icu-project.org/trac/ticket/12030 http://bugs.icu-project.org/trac/ticket/12041 2. Generate a combined patch (measure_format.patch) for the above. 3. Split locale_google.patch into 'locale_google.patch' and 'relative_date.patch'. The latter is taken from Android. 4. Update README.chromium Besides, apply two local patches : {tzdetect,xlit..}.patch and adjust gb18030.ucm and the corresponding patch Also, remove obsolte patches and update README.chromium BUG=575007 R=mark@chromium.org Review URL: https://codereview.chromium.org/1621943002 .
-
Jungshik Shin authored
1. AM/PM, midnight, noon formatting for a few Indian locales 2. Currency signs in ru/uk/tr locales 3. Region name change for Hong Kong and Macau in all locales 4. Timezone name changes in Korean and Chinese locales 5. Internval format changes from AOSP: https://android.googlesource.com/platform/external/icu/+/f9ffd5b%5E%21/#F0 6. Minor locale changes for Korean: locale1.patch BUG=575007 TEST=None R=mark@chromium.org Review URL: https://codereview.chromium.org/1625623003 .
-
- Jan 07, 2016
-
-
Jungshik Shin authored
Add scripts/udpate.sh that automates the initial check-out of a new version of ICU. BUG=575007 TEST=None R=mark@chromium.org Review URL: https://codereview.chromium.org/1566043002 .
-
- Sep 25, 2015
-
-
Jungshik Shin authored
In line 1105 of rbt_pars.cpp, variablesVector.elementAt(j) is cast to |UnicodeSet *|, but sometimes it's |Quantifier *|. Casting to a common parent class |UnicodeFunctor *| seems to work (this patch), but it may hide a deeper issue. Further investigation will be done in the upstream bug: http://bugs.icu-project.org/trac/ticket/11937 This CL was independently made by krasin@ and jshin@. ( https://codereview.chromium.org/1366563006/ ) BUG=528799 TEST=wtf_unittests --gtest_filter="*ToUpp*" and --gtest_filter="*ToLow*" with both regular and cfi build. TBR=krasin@chromium.org Review URL: https://codereview.chromium.org/1369653003 .
-
- Aug 25, 2015
-
-
Nico Weber authored
The warning complains that StringThreadTest is declared in the global namespace, but the friend line says `friend class StringThreadTest;` instead of `friend class ::StringThreadTest`. MSVC doesn't require this ::, but gcc does -- without it, the friend line declares a new class in the namespace containing UnicodeString. Since StringThreadTest was in test/threadtest which isn't built as part of Chromium's build and which was removed in upstream ICU in ICU 37392, just delete the friend line, it has no effect. BUG=505296 R=jshin@chromium.org Review URL: https://codereview.chromium.org/1317603003 .
-
- Aug 18, 2015
-
-
Nico Weber authored
1. In Win32NumberFormat, rename the private format() method to variadicFormat(). It's just an implementation detail of the class. Fixes: ..\..\third_party\icu\source\i18n/winnmfmt.h(146,20) : error(clang): 'icu_54::Win32NumberFormat::format' hides overloaded virtual functions [-Werror,-Woverloaded-virtual] UnicodeString &format(int32_t numDigits, UnicodeString &appendTo, const wchar_t *format, ...) const; ^ ..\..\third_party\icu\source\i18n\unicode/numfmt.h(255,28) : note(clang): hidden overloaded virtual function 'icu_54::NumberFormat::format' declared here: different number of parameters (4 vs 3) virtual UnicodeString& format(const Formattable& obj, ^ ... 2. In Win32DateFormat, remove the two-argument format() function that just forwards to the base class. (If this happens to produce compile errors, the function should be replaced by `using Win32DateFormat::format(UDate, UnicodeString&) const;`) Fixes: ..\..\third_party\icu\source\i18n/windtfmt.h(55,20) : error(clang): 'icu_54::Win32DateFormat::format' hides overloaded virtual functions [-Werror,-Woverloaded-virtual] UnicodeString& format(UDate date, UnicodeString& appendTo) const; ^ ..\..\third_party\icu\source\i18n\unicode/datefmt.h(240,28) : note(clang): hidden overloaded virtual function 'icu_54::DateFormat::format' declared here: different number of parameters (4 vs 2) virtual UnicodeString& format(const Formattable& obj, ^ ... BUG=505301 R=jshin@chromium.org Review URL: https://codereview.chromium.org/1296803002 .
-
- Jul 16, 2015
-
-
Jungshik Shin authored
Upstream CL : http://bugs.icu-project.org/trac/changeset/37670 BUG=508444 TEST=See bug R=inferno@chromium.org Review URL: https://codereview.chromium.org/1233663005 .
-
- Jul 14, 2015
-
-
Jungshik Shin authored
This is going back to PS #4 in https://codereview.chromium.org/1148463002/ BUG=466959, 508049, 508440 TEST=See bugs TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1237873002 .
-
Jungshik Shin authored
Takes an upstream patch (to be included in 56.x release) and patch our ICU 54. Clang-specific atomic ops will be used when clang is used to compile but C+11 atomic is disabled/unavailable. patch: http://bugs.icu-project.org/trac/changeset/37326 bug: http://bugs.icu-project.org/trac/ticket/11599 BUG=466959,508049,508440 TEST=See bugs R=glider@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1148463002 .
-
- Jun 18, 2015
-
-
http://bugs.icu-project.org/trac/changeset/36672Nico Weber authored
Else clang's -Winfinite-recursion will warn about filteredbrk.cpp BUG=none R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1191653011.
-
- Jun 09, 2015
-
-
Jungshik Shin authored
Previously, |referenceCounter != (uint32_t)~0| was used to check whether refcounting is used or not. Cherry-pick an upstream change: http://bugs.icu-project.org/trac/changeset/37476 BUG=465175 TEST=see the bug R=jyasskin@chromium.org Review URL: https://codereview.chromium.org/1171203002.
-
- Jun 04, 2015
-
-
Jungshik Shin authored
1. Add a one-way (encoding-only/fromUnicode) mapping for U+2212 to Shift_JIS, EUC-JP and ISO-2022-JP. The last just uses Shift_JIS. See https://www.w3.org/Bugs/Public/show_bug.cgi?id=28661 2. Make GBK aliases list compliant to the encoding spec. 3. Add "xA3xA0 => U+3000" to the GBK (windows-936) and gb18030. This makes it possible to remove the corresponding override in Blink 4. Modify the following to GBK (windows-936). See [1] - Add U+01F9 <=> \xA8\xBF - Drop U+E7C8 <=> \xA8\xBF 5. The following change is put on hold (NOT included in the CL) until the resolution of [1] - Add U+1E3F <=> \xA8\xBC - Drop U+E7C7 <=> \xA8\xBC The corresponding Blink CL is https://codereview.chromium.org/1167523003/ [1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=28740#c3 BUG=425417,493824 TEST=Once ICU is rolled to this CL, Blink layout test fast/encoding/*. R=jsbell@chromium.org Review URL: https://codereview.chromium.org/1162723008
-
- May 26, 2015
-
-
Jungshik Shin authored
A fix by mbarbella@. BUG=444573 TEST=See the bug R=inferno@chromium.org, mbarbella@chromium.org Review URL: https://codereview.chromium.org/1145963004
-
- Apr 06, 2015
-
-
Jungshik Shin (jungshik at google) authored
Due to caching, the 2nd timezone change is not detected properly. Upstream bug: http://bugs.icu-project.org/trac/ticket/11623 BUG=406382 TEST=manual. Call detectHostTimeZone() every time the OS tz is changed on Linux and check if it returns the correct present timezone. R=mark@chromium.org Review URL: https://codereview.chromium.org/1058353002
-
- Apr 03, 2015
-
-
Jungshik Shin (jungshik at google) authored
We need this new API to resolve bug 406382 across platforms. See http://bugs.icu-project.org/trac/ticket/11358 http://bugs.icu-project.org/trac/changeset/37148 BUG=406382 TEST=None R=mark@chromium.org TBR=mark@chromium.org Review URL: https://codereview.chromium.org/1062503003
-
- Mar 26, 2015
-
-
Jungshik Shin (jungshik at google) authored
BUG=470291 TEST=None R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1032783002
-
- Mar 21, 2015
-
-
Jungshik Shin (jungshik at google) authored
1. Cherry-pick security patches from the upstream. a. BiDi: integer overflow http://bugs.icu-project.org/trac/ticket/11451 http://crbug.com/451799 bidi.patch was updated to include patches for this issue. b. data race in cmemory; remove an unnecessary check with a global variable. http://bugs.icu-project.org/trac/ticket/11538 http://crbug.com/223352 cmemory.patch was added c. Locale::getBaseName() thread-safety http://bugs.icu-project.org/trac/ticket/11547 http://crbug.com/467836 locid.patch was updated to include patches for this issue. 2. Add UCONFIG_NO_NON_HTML5_CONVERSION=1 to BUILD.gn 3. Clean up a. Update README.chromium to flag patches that are already in the upstream. b. Split pkg_gen.patch from data.build.patch. pkg_gen.patch was already in the upstream while the rest of data.build.patch is Chromium-specific. c. Delete an unused converters.patch. BUG=223352,451799,467836 TEST=See bugs 223352, 467836, 468716, and 466838 R=jyasskin@chromium.org, mark@chromium.org Review URL: https://codereview.chromium.org/1020303002
-
- Feb 14, 2015
-
-
Jungshik Shin (jungshik at google) authored
This is to fix a linker error when linking icuuc.dll; ICU_DATA_ENTRY (icudt54_dat) symbol is not found on Windows clean build from the scratch (component=shared_library). Move stubdata.c to icuuc target from icudata target. Also, make U_DATA_API (used for U_ICU_DATA_ENTRYPOINT in common/udata.cpp) to be U_EXPORT instead of U_IMPORT when icu_use_data_file_flag = 1 or on Windows. On Windows, using the icudt.dll (i.e. icu_use_data_file_flag=0) also requires this change. BUG=428145 TEST=All trybots can build a target that requires ICU. R=mark@chromium.org, scottmg@chromium.org Review URL: https://codereview.chromium.org/926113004
-
- Feb 10, 2015
-
-
Jungshik Shin (jungshik at google) authored
Blink does not use ICU's Bidi API, but it may in the future. Moreover, Chrome UI does use ubidi API. Replace the current bidi.patch (that I should have deleted because it's already a part of ICU 54.1 and is not applied) with a new one. upstream bug: http://bugs.icu-project.org/trac/ticket/11177 BUG=428145 TEST=None R=mark@chromium.org Review URL: https://codereview.chromium.org/907333002
-
- Jan 31, 2015
-
-
Jungshik Shin (jungshik at google) authored
1. Fix a Windows build failure due to: a. 'signed vs unsigned' comparison b. 'possible data loss' in conversion : Apply pkasting's patch at http://bugs.icu-project.org/trac/ticket/11104 2. Drop a few currencies to cut down the data size by 50kB for non-Android platforms. 2. Build the ICU data for Android and check in. - Drop all display names for languages/scripts/regions except for zh-Han{s,t} as before. ( ~ 1.2MB reduction) - Drop cjdict by applying android/brkitr.patch. (~ 2MB reduction) - Include the display names for only 60+ currencies ( ~ 400kB reduction from the non-Android data. - Minimize the locale data for 9 locales Chrome on Android is not localized to. Drop currency names for those 9 locales. ( ~ 150kB reduction) Size change: 1. Non-android: 10,255,584 to 10,200,880 2. Android: - Final : 6,270,880 With 60+ currency names added (for bug 370849) and 9 unnecessary locale data dropped. It's 232,240 bytes larger than ICU 52.1 (6,038,640). - Without any currency names but with 9 unnecessary locale data: 6,026,816 - With 60+ currency names and 9 unnecessary locale data: 6,426,368 BUG=370849,428145 TEST=Build on Windows. Blink layout tests, webkit unittests. R=mark@chromium.org, wangxianzhu@chromium.org Review URL: https://codereview.chromium.org/877193003
-
- Jan 23, 2015
-
-
Jungshik Shin (jungshik at google) authored
1. Apply Chrome's locale data change on top of Google's locale data changes 2. Breakiterator changes - Apply brkitr.patch with update to ICU 54.1; line/word.txt - Check in a more compact Khmer dictionary along with a parameter adjustment in dictbe.cpp - Add a few common words to the CJ dictionary - Update brklocal.mk (out customized build file) to ICU 54 - Update android/brkitr.patch and data/brkitr/word_ja.txt for Android Data size checkpoint: * Non-Android: 19,575,216 bytes. ~500kB reduction relative to the previous step comes mainly from the compact Khmer dictionary. * Android: 17,601,520 bytes. 2MB difference comes from removing cjdict. BUG=428145 TEST=net_unittests --gtest_filter="*IDN*" TEST=layout tests R=mark@chromium.org Review URL: https://codereview.chromium.org/858363003
-
- Jan 21, 2015
-
-
Jungshik Shin (jungshik at google) authored
Google's locale data changes are applied before Chrome's own locale data trimming. 1. Use "Rs." instead of the Indian Rupee sign (U+20A8) for which the font support is not available on all platforms. Google platforms (CrOS / Android ) have them, but other platforms may not. 2. Use shorter names for Hong Kong and Macau without 'S.A.R.' at the end. This cuts down the data size a bit. 3. Timezone names for Korea standard time and a couple of other zones are shortened. 4. zh_Hant_TW, pa_Arab_PK and a few more locales are changed. Besides, update data.build.patch and README.chromium to drop the collation rule files ('-R' option to genrb.). This should have been done in ICU update step 2. Data size checkpoint: 20,066,624 bytes - about 500k reduction from step 3 mostly due to '-R' option with the rest attributed to shorter display names for HK, MO and Korean tz. - the original ICU 54.1 : 25,343,024 BUG=428145 TEST=NONE TBR=mark Review URL: https://codereview.chromium.org/856153003
-
Jungshik Shin (jungshik at google) authored
A. Converter update per HTML encoding spec along with changes in the encoding name alias table. B. Remove all the codes for converters Blink and Chromium do not need (SCSU, Lotus, ISO-2022-xx other than JP, BOCU, UTF-7, etc). This is reapplying the following CLs (that we used for ICU 52.1) to ICU 54.1 : https://codereview.chromium.org/598383002 https://codereview.chromium.org/654153002 We have two upstream bugs filed for A and B above: http://www.icu-project.org/trac/ticket/11296 http://www.icu-project.org/trac/ticket/10303 In addiition to A and B, we unified Big5 and Big5-HKSCS per the encoding spec (bug 277868). That also includes properly supporting the four 2-character sequences ( see http://crbug.com/277868#c3 ). big5_gen.sh deviates from the current spec to work around a bug in the spec. (see https://www.w3.org/Bugs/Public/show_bug.cgi?id=27878) Moreover, ucmlocal.mk is added to list only encodings we want to support. Also, tighten the state table for windows-946-2000.ucm that we use for EUC-KR for now. And, drop 'base' map for windows-{936,949}-2000.ucm. Finally, add euc-kr-html.ucm along with scripts/euckr_gen.sh, but it is not yet used pending the resolution of bug 450312. Data size checkpoint: 20,566,864 bytes (the original ICU 54=25,343,024) BUG=277868, 428145, 450312 TEST=net_unittests --gtest_filter="*ilenameUtil*" TEST=base_unittests --gtest_filter="*Conv*" TEST=browser_tests --gtest_filter="*ncoding*" TEST=Blink: fast/encoding/* R=jsbell@chromium.org, mark@chromium.org Review URL: https://codereview.chromium.org/839713003
-
- Jan 12, 2015
-
-
Jungshik Shin (jungshik at google) authored
Update the following patches and apply to the fresh copy of icu 54.1: configure.patch declspec.patch locid.patch platform_nacl.patch regex.patch wpo.patch vscomp.patch: two chunks are not necessary any more; upstream has them. data.build.patch data.build_win.patch Delete the following patches: putil.patch: not necessary any more; upstream has it. regex2.patch: merged to regex.patch. col.patch: not necessary any more; upstream code changed drastically and does not have a bug any more. clang_win.patch: not necessary any more; upstream has it. BUG=428145 TEST=None R=mark@chromium.org Review URL: https://codereview.chromium.org/822213003
-
- Dec 11, 2014
-
-
Jungshik Shin (jungshik at google) authored
README.chromium update and locid.patch were not included in the previous check-in (6bbe98e6 reviewed at https://codereview.chromium.org/796153002 ). BUG=403902 TEST=NONE TBR=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/799643002
-
- Dec 10, 2014
-
-
Jungshik Shin (jungshik at google) authored
A follow-up patch to https://codereview.chromium.org/751333003 BUG=433866 TEST=See the bug (comment 0) R=mbarbella@chromium.org Review URL: https://codereview.chromium.org/777783004
-
- Nov 26, 2014
-
-
jshin@chromium.org authored
BUG=433866 TEST=See the bug. R=mbarbella@google.com Review URL: https://codereview.chromium.org/751333003 git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@293126 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-