Skip to content
Snippets Groups Projects
  1. Mar 26, 2015
  2. Feb 19, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      Fix en_GB's language name failure · 8d46830a
      Jungshik Shin (jungshik at google) authored
      data/lang/en_GB.txt has an empty "Languages" block leading
      getDisplay{Name,Language} to fail in en-GB.
      
      Update trim_data.sh to remove an empty "Languages" block and run the
      script to fix data/lang/en_GB.txt and other locales if any. (only
      en_GB.txt is affected).
      
      Rebuild the icu data with the above changes for both Android and non-Android
      platforms.
      
      BUG=428145
      TEST=linux_chromeos bots: browser_tests --gtest_filter=*GetUILang*
      TBR=mark@chromium.org
      
      Review URL: https://codereview.chromium.org/930203004
      8d46830a
  3. Feb 17, 2015
  4. Feb 14, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      Move stubdata.c from icudata to icuuc · d158fece
      Jungshik Shin (jungshik at google) authored
      This is to fix a linker error when linking icuuc.dll;  ICU_DATA_ENTRY (icudt54_dat) symbol is not found on Windows clean build from the scratch (component=shared_library).
      
      Move stubdata.c to icuuc target from icudata target. Also, make
      U_DATA_API (used for U_ICU_DATA_ENTRYPOINT in common/udata.cpp) to be
      U_EXPORT instead of U_IMPORT when icu_use_data_file_flag = 1 or
      on Windows. On Windows, using the icudt.dll  (i.e. icu_use_data_file_flag=0) also requires this change.
      
      BUG=428145
      TEST=All trybots can build a target that requires ICU.
      R=mark@chromium.org, scottmg@chromium.org
      
      Review URL: https://codereview.chromium.org/926113004
      d158fece
  5. Feb 10, 2015
  6. Feb 09, 2015
  7. Jan 31, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      ICU update to 54.1 step 7 · 26c111a7
      Jungshik Shin (jungshik at google) authored
      1. Fix a Windows build failure due to:
         a. 'signed vs unsigned' comparison
         b. 'possible data loss' in conversion : Apply pkasting's patch at
            http://bugs.icu-project.org/trac/ticket/11104
      
      2. Drop a few currencies to cut down the data size by 50kB for non-Android
         platforms.
      
      2. Build the ICU data for Android and check in.
        - Drop all display names for languages/scripts/regions except for zh-Han{s,t}
          as before. ( ~ 1.2MB reduction)
        - Drop cjdict by applying android/brkitr.patch. (~ 2MB reduction)
        - Include the display names for only 60+ currencies ( ~ 400kB reduction
          from the non-Android data.
        - Minimize the locale data for 9 locales Chrome on Android is not localized
          to. Drop currency names for those 9 locales. ( ~ 150kB reduction)
      
      Size change:
        1. Non-android: 10,255,584 to 10,200,880
        2. Android:
           - Final : 6,270,880
             With 60+ currency names added (for bug 370849) and
             9 unnecessary locale data dropped.
             It's 232,240 bytes larger than ICU 52.1 (6,038,640).
           - Without any currency names but with 9 unnecessary locale data: 6,026,816
           - With 60+ currency names and 9 unnecessary locale data: 6,426,368
      
      BUG=370849,428145
      TEST=Build on Windows. Blink layout tests, webkit unittests.
      R=mark@chromium.org, wangxianzhu@chromium.org
      
      Review URL: https://codereview.chromium.org/877193003
      26c111a7
  8. Jan 23, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      ICU update to 54 - step 6 · b9090ea5
      Jungshik Shin (jungshik at google) authored
      1. Add {coll,curr,lang,locales,rbnf,region,sprep,translit,unit,zone}/*local.mk
      to exclude locale data for languages/locales that Chromium does not need.
      
      2. Run scripts/trim_data.sh to cut down the data size further by excluding
      unused entries in each locale files.
         - Keep the display names for languages/scripts/locales in Chrome's
           Accept-Language list and remove the display names outside the set.
         - Minimize the locale data in data/{locales,lang} for non-UI languages
           in the A-L list. For them,
           we just need the "native" display name and exemplar character set.
         - Exclude historic, obscure and otherwise unnecessary currency display
           names.
         - Drop unnecessary Chinese collation rules; Big5/GB2312/UniHan.
         - Keep only the minimal unit data for duration and compound units.
      
      3. Add css3transform.txt to data/translit for Greek upper/lowercasing support.
      
      4. Add the minimal locale data for ckb and ku.
      
      5. The tz db was updated previously to 2014j (the latest) so that no change
         is made except for README.chromium update.
      
      6. Add the minimal locale data for ckb and ku.
      
      7. Check in the pre-built data (icudtl.dat) shared by all non-Android
         platforms and assembly files for Linux/Mac
      
      The final data size is 10,255,584 bytes, which is about 200kB smaller than
      that for ICU 52.1.  The pristine upstream ICU has the data of
      25,343,024 bytes.
      
      The remaining steps are to build a smaller data file for Android and
      to build icudtl.dll for Windows (non-default build option).
      
      BUG=428145
      TEST=net_unittests --gtest_filter="*ilenameUtil*"
      TEST=net_unittests --gtest_filter="*IDN*"
      TEST=base_unittests --gtest_filter="*Conv*"
      TEST=browser_tests --gtest_filter="*ncoding*"
      TEST=Blink: layout tests
      R=mark@chromium.org
      
      Review URL: https://codereview.chromium.org/872903002
      b9090ea5
    • Jungshik Shin (jungshik at google)'s avatar
      ICU update to 54.1 - step 5 · 4a0ebf11
      Jungshik Shin (jungshik at google) authored
      1. Apply Chrome's locale data change on top of Google's locale data
         changes
      
      2. Breakiterator changes
        - Apply brkitr.patch with update to ICU 54.1; line/word.txt
        - Check in a more compact Khmer dictionary along with
          a parameter adjustment in dictbe.cpp
        - Add a few common words to the CJ dictionary
        - Update brklocal.mk (out customized build file) to ICU 54
        - Update android/brkitr.patch and data/brkitr/word_ja.txt for Android
      
      Data size checkpoint:
       * Non-Android: 19,575,216 bytes. ~500kB reduction relative
         to the previous step comes mainly from the compact Khmer dictionary.
       * Android: 17,601,520 bytes. 2MB difference comes from removing cjdict.
      
      BUG=428145
      TEST=net_unittests --gtest_filter="*IDN*"
      TEST=layout tests
      R=mark@chromium.org
      
      Review URL: https://codereview.chromium.org/858363003
      4a0ebf11
  9. Jan 21, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      ICU update to 54 - step 4 · 7f05ab40
      Jungshik Shin (jungshik at google) authored
      Google's locale data changes are applied before Chrome's own locale data
      trimming.
      
      1. Use "Rs." instead of the Indian Rupee sign (U+20A8) for which the font
         support is not available on all platforms.
         Google platforms (CrOS / Android ) have them, but other
         platforms may not.
      2. Use shorter names for Hong Kong and Macau without 'S.A.R.' at the
         end. This cuts down the data size a bit.
      3. Timezone names for Korea standard time and a couple of other zones
         are shortened.
      4. zh_Hant_TW, pa_Arab_PK and a few more locales are changed.
      
      Besides, update data.build.patch and README.chromium to drop
      the collation rule files ('-R' option to genrb.). This should have been
      done in ICU update step 2.
      
      Data size checkpoint: 20,066,624 bytes
       - about 500k reduction from step 3 mostly due to '-R' option with
          the rest attributed to shorter display names for HK, MO and Korean tz.
       - the original ICU 54.1 : 25,343,024
      
      BUG=428145
      TEST=NONE
      TBR=mark
      
      Review URL: https://codereview.chromium.org/856153003
      7f05ab40
    • Jungshik Shin (jungshik at google)'s avatar
      ICU update to 54 step 3 · afd723ba
      Jungshik Shin (jungshik at google) authored
      A. Converter update per HTML encoding spec along with changes in
        the encoding name alias table.
      B. Remove all the codes for converters Blink and Chromium do not need
      (SCSU, Lotus, ISO-2022-xx other than JP, BOCU, UTF-7, etc).
      
      This is reapplying the following CLs (that we used for ICU 52.1) to ICU 54.1 :
      
      https://codereview.chromium.org/598383002
      https://codereview.chromium.org/654153002
      
      We have two upstream bugs filed for A and B above:
        http://www.icu-project.org/trac/ticket/11296
        http://www.icu-project.org/trac/ticket/10303
      
      In addiition to A and B, we unified Big5 and Big5-HKSCS per
      the encoding spec (bug 277868). That also includes properly supporting
      the four 2-character sequences ( see http://crbug.com/277868#c3 ).
      big5_gen.sh deviates from the current spec to work around a bug
      in the spec. (see https://www.w3.org/Bugs/Public/show_bug.cgi?id=27878)
      
      Moreover, ucmlocal.mk is added to list only encodings we want to support.
      
      Also, tighten the state table for windows-946-2000.ucm that we use
      for EUC-KR for now. And, drop 'base' map for windows-{936,949}-2000.ucm.
      
      Finally, add euc-kr-html.ucm along with scripts/euckr_gen.sh, but
      it is not yet used pending the resolution of bug 450312.
      
      Data size checkpoint: 20,566,864 bytes (the original ICU 54=25,343,024)
      
      BUG=277868, 428145, 450312
      TEST=net_unittests --gtest_filter="*ilenameUtil*"
      TEST=base_unittests --gtest_filter="*Conv*"
      TEST=browser_tests --gtest_filter="*ncoding*"
      TEST=Blink: fast/encoding/*
      R=jsbell@chromium.org, mark@chromium.org
      
      Review URL: https://codereview.chromium.org/839713003
      afd723ba
  10. Jan 12, 2015
    • Jungshik Shin (jungshik at google)'s avatar
      ICU upgrade to 54.1 step 2 · 5580ad69
      Jungshik Shin (jungshik at google) authored
      Update the following patches and apply to the fresh copy of icu 54.1:
      
        configure.patch
        declspec.patch
        locid.patch
        platform_nacl.patch
        regex.patch
        wpo.patch
        vscomp.patch: two chunks are not necessary any more; upstream has
                      them.
        data.build.patch
        data.build_win.patch
      
      Delete the following patches:
        putil.patch: not necessary any more; upstream has it.
        regex2.patch: merged to regex.patch.
        col.patch: not necessary any more; upstream code changed drastically
                   and does not have a bug any more.
        clang_win.patch: not necessary any more; upstream has it.
      
      BUG=428145
      TEST=None
      R=mark@chromium.org
      
      Review URL: https://codereview.chromium.org/822213003
      5580ad69
  11. Jan 08, 2015
  12. Dec 15, 2014
    • Jungshik Shin (jungshik at google)'s avatar
      Add the minimal locale data for ckb and ku · 51c1a4ce
      Jungshik Shin (jungshik at google) authored
      To have keyboard layouts for ku and ckb, we need to have the minimal
      locale data for them - native display name, writing direction, and
      exemplar characters.
      
      These are added and the icu data was rebuilt. The Android icu data was
      not rebuilt because Android Chrome does not use them.
      
      BUG=204049
      TEST=None until ckb and ku are added to the A-L list in a Chrome CL.
      When they're,  language and input settings will have ckb and ku listed
      with the display name in the current UI language (e.g. Englsih) and native
      display name.
      
      Review URL: https://codereview.chromium.org/805073003
      51c1a4ce
  13. Dec 11, 2014
  14. Dec 10, 2014
  15. Dec 04, 2014
  16. Nov 26, 2014
  17. Nov 19, 2014
  18. Nov 14, 2014
  19. Oct 30, 2014
  20. Oct 15, 2014
  21. Oct 13, 2014
  22. Oct 04, 2014
  23. Sep 25, 2014
    • jshin@chromium.org's avatar
      Check in word_ja.txt for Android. · abeeb961
      jshin@chromium.org authored
      word_ja.txt has not been checked in although the icu data file for Android
      (android/icudtl.dat) was built with the file.
      
      README.chromium about Android's brkitr patch was not updated when moving to
      ICU 52.1. It's changed to reflect what we do in ICU 52.1 (where the upstream
      copy does have cjdict for CJ word breaking).
      
      TBR=andrewhayden@chromium.org
      BUG=NONE
      TEST=NONE (there's no change affecting Chrome/Blink builds).
      
      Review URL: https://codereview.chromium.org/609493003
      
      git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292144 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      abeeb961
    • jshin@chromium.org's avatar
      Turn on UCONFIG_NO_NON_HTML5_CONVERTER · 52e8245c
      jshin@chromium.org authored
      UCONFIG_NO_NON_HTML5_CONVERTER was added earlier to our copy of ICU, but
      it was never set to 1.  It's my oversight.
      
      1. Turns UCON..CONVERTER on in icu.gyp to drop all the encodings not
         required by the Encoding spec. Dropped encodings include
         UTF-7, BOCU, SCSU, CESU, ISCII, ISO-2022-{KR, CN*}, HZ-GB, ISO-2022-JP's
         other than the original.
      
      2. A lot more sections of the ICU converter code are excluded when
         it's set to 1 including the code for LMB (Lotus Multibyte) encodings and
         X11 compound text encoding (icu common).
      
      3. The character encoding detections for encodings excluded are also disabled.
         (icu i18n)
      
      4. ISO-2022-{KR, CN*} and HZ-GB can be dropped now because Blink treats them
         as replacement encoding. The corresponding alias entries from convertrs.txt
         are also removed.
      
      5. ibm-874 was removed. We used to need it before Blink started, but not any
         more. We only need windows-874.
      
      6. A mistaken in convertrs.txt was corrected : Big5-HKSCS was pointing to
         an old mapping table.
      
      7. Per ICU upstream's suggestion, use '-html' suffix instead of '-html5'
      for the encoding tables derived from the WHATWG's encoding spec (ibm866,
      shift_jis and euc-jp).
      
      The static 64-bit release build of Chrome on Linux went down from
      141,596,616 to 141,491,968 bytes (~ 100 kB reduction). Besides, the icu data
      size got smaller by ~ 19 kB ( 10,490,576 to 10,471,008 bytes).
      
      See http://bugs.icu-project.org/trac/ticket/11296 for an upstream bug
      I've filed on the issue.
      
      
      BUG=76328
      TEST=browser_tests --gtest_filter="*ncoding*"
      TEST=net_unittest --gtest_filter="*ilenameUtil*"
      TEST=base_unittests --gtest_filter="*Conv*"
      TEST=Blink: fast/encoding/*
      TEST=With shared library build, the following has no match.
        nm libicuuc.so | egrep  -i '(bocu|scsu|utf7|2022kr|2022cn|iscii)'
        nm libicui18n.so | egrep  -i '(2022kr|2022cn|ibm42)'
      TEST=With static library build, the following has no match.
        nm chrome | egrep -i '(bocu|scsu|utf7|2022kr|2022cn|iscii|ibm42)'
      
      R=jsbell@chromium.org, mark@chromium.org
      
      Review URL: https://codereview.chromium.org/587833004
      
      git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292131 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      52e8245c
  24. Sep 17, 2014
  25. Sep 03, 2014
    • torne@chromium.org's avatar
      Remove invalid link_settings from target condition. · 89831135
      torne@chromium.org authored
      ICU fails to gyp when run with GYP_DEFINES="android_webview_build=1
      use_system_icu=0 use_system_stlport=1" which is a combination of
      settings we're trying to bring up temporarily as we migrate away from
      system libraries. It fails because it's not permitted to specify
      link_settings in a target_condition as the processing is too late.
      
      Remove the invalid link_settings, since we can't do this outside
      target_conditions as it's not valid to use -lgabi++ on the host build of
      ICU. The link dependency on gabi++ will have to be satisfied manually in
      the main libwebviewchromium target instead for this configuration.
      
      BUG=409851
      R=mkosiba@chromium.org
      TBR=jshin@chromium.org
      
      Review URL: https://codereview.chromium.org/527193003
      
      git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@291781 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      89831135
  26. Sep 02, 2014
    • jshin@chromium.org's avatar
      Update tz data to 2014f and add SJIS for the encoding spec · ff835309
      jshin@chromium.org authored
      1. Timezone data files (4 of them) in source/data/misc to 2014f (the latest)
         to prepare for an upcoming Russian timezone change.
      2. Add Shift_JIS converter compliant to the WHATWG encoding spec.
      3. Update converters.txt and ucmlocal.mk accordingly
      4. Update the pre-built data files for Linux/Mac/Android/Windows.
         (icudt.dll is not updated in this CL. It's not used in the default
          configuration. It'll be updated in a separate CL).
      5. Fix a typo in ibm866_gen.sh. The acual table used does not need a change.
      
      
      BUG=277062,404445
      TEST=After rolling icu to this revision, the following tests should pass.
      TEST=Blink: fast/encoding/* all pass except for
      fast/encoding/api/ascii-supersets.html that should fail by *passing*
      the test for Shift_JIS, which is expected to fail. Blink layout tests needs
      to be updated.
      TEST=browser_tests --gtest_filter="*ncoding*"
      TEST=In JS console, run the following to check if Europe/Moscow is
      3 hrs ahead of UTC after Oct 26 and 4 hrs ahead before that and
      if Asia/Kamchatka remains 12 hrs ahead of UTC.
        nov1_2014_1500=new Date("11/01/2014 15:00Z")
        nov1_2014_1500.toLocaleString("en", {timeZone: "Europe/Moscow"})
        nov1_2014_1500.toLocaleString("en", {timeZone: "UTC"})
        nov1_2014_1500.toLocaleString("en", {timeZone: "Asia/Kamchatka"})
        oct24_2014_1500=new Date("10/24/2014 15:00Z")
        oct24_2014_1500.toLocaleString("en", {timeZone: "Europe/Moscow"})
        oct24_2014_1500.toLocaleString("en", {timeZone: "UTC"})
        oct24_2014_1500.toLocaleString("en", {timeZone: "Asia/Kamchatka"})
      TEST=net_unittest --gtest_filter="*ilenameUtil*"
      TEST=base_unittests --gtest_filter="*Conv*"
      R=jsbell@chromium.org
      
      Review URL: https://codereview.chromium.org/497543003
      
      git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@291774 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
      ff835309
  27. Aug 28, 2014
  28. Aug 26, 2014
  29. Aug 21, 2014
  30. Aug 01, 2014
  31. Jul 24, 2014
  32. Jun 18, 2014
  33. Jun 17, 2014
Loading