- Apr 03, 2015
-
-
Jungshik Shin (jungshik at google) authored
Due to a bug in patch_locale.sh, calendars intended for being stripped away are not removed from the ICU data for Android. Fixing the bug cuts down the ICU data size by 10kB on Android. BUG=472142 TEST=android/icudtl.dat is ~10kB smaller than before. (6,267,808 bytes) R=mark@chromium.org Review URL: https://codereview.chromium.org/1052333003
-
- Apr 02, 2015
-
-
Jungshik Shin (jungshik at google) authored
1. Update the IANA tz db to 2015b. - http://mm.icann.org/pipermail/tz-announce/2015-March/000029.html - Mongolia decided to observe DST again in 2015 starting on the last Sunday in March. - Palestine's DST start date is corrected to be March 28 instead of 27th. 2. Add a script to download the tz database files (update_tz.sh) 3. Check in scripts/make_n_copy_data.sh that I've been using to build ICU data/assembly files and update README.chromium. 4. Update android/patch_locale.sh to apply android/brkitr.patch as well. BUG=473288 TEST=1. In JavaScript console, run the following. mar27_2015_1200 = new Date("03/27/2015 12:00Z") mar28_2015_1200 = new Date("03/28/2015 12:00Z") mar27_2015_1200.toLocaleString("en", {timeZone: "Asia/Gaza"} mar28_2015_1200.toLocaleString("en", {timeZone: "Asia/Gaza"} apr15_2014_1200 = new Date("04/15/2014 12:00Z") apr15_2015_1200 = new Date("04/15/2015 12:00Z") apr15_2014_1200.toLocaleString("en", {timeZone: "Asia/Ulan_Bator"} apr15_2015_1200.toLocaleString("en", {timeZone: "Asia/Ulan_Bator"} In Asia/Gaza, Mar 27 12:00Z should be 2PM and mar28 12:00Z should be 3PM. In Asia/Ulan_Bator, April 15 12:00Z should be 8PM in 2014 and should be 9PM in 2015. Ulan_Bator does not work due to http://crbug.com/364374. R=mark@chromium.org Review URL: https://codereview.chromium.org/1051193002
-
- Mar 26, 2015
-
-
Jungshik Shin (jungshik at google) authored
BUG=470291 TEST=None R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1032783002
-
- Mar 21, 2015
-
-
Jungshik Shin (jungshik at google) authored
1. Cherry-pick security patches from the upstream. a. BiDi: integer overflow http://bugs.icu-project.org/trac/ticket/11451 http://crbug.com/451799 bidi.patch was updated to include patches for this issue. b. data race in cmemory; remove an unnecessary check with a global variable. http://bugs.icu-project.org/trac/ticket/11538 http://crbug.com/223352 cmemory.patch was added c. Locale::getBaseName() thread-safety http://bugs.icu-project.org/trac/ticket/11547 http://crbug.com/467836 locid.patch was updated to include patches for this issue. 2. Add UCONFIG_NO_NON_HTML5_CONVERSION=1 to BUILD.gn 3. Clean up a. Update README.chromium to flag patches that are already in the upstream. b. Split pkg_gen.patch from data.build.patch. pkg_gen.patch was already in the upstream while the rest of data.build.patch is Chromium-specific. c. Delete an unused converters.patch. BUG=223352,451799,467836 TEST=See bugs 223352, 467836, 468716, and 466838 R=jyasskin@chromium.org, mark@chromium.org Review URL: https://codereview.chromium.org/1020303002
-
- Mar 19, 2015
-
-
Jungshik Shin (jungshik at google) authored
I forgot to include this change in https://codereview.chromium.org/984233002 TBR=jochen@chromium.org BUG=NONE Review URL: https://codereview.chromium.org/1021673003
-
Jungshik Shin (jungshik at google) authored
1. Update ucmlocal.mk and convertrs.txt to refer to euc-kr-html.ucm instead of windows-949.ucm 2. Tighten up the valid code range for the following converters: EUC-KR, Shift_JIS, Big5 This is to add back an ASCII range byte to the stream per the encoding spec when they're either illegal as a 'trail byte' or there's no assigned code point for a "lead + trail" sequence. For instance, with this change, '0xF3 0x41' in EUC-KR is converted to 'U+FFFD U+0041' instead of 'U+FFFD'. This change requires adding 2 ~ 8 new states to the conversion table of each converter mentioned above leading to 6.5kB net increase in the final data size. 3. Tighten the trail byte range for 2-byte sequences starting with 0x8E from [A1,E2] to [A1,DF] in EUC-JP and update the corresponding generating script. 4. Change the substitution characters for EUC-JP and Shift_JIS to match other converters. i.e. make them produce U+FFFD when encountering an invalid input. Before this chaange, they emitted U+001A. 5. Enable 'U_CHARSET_IS_UTF8' configuration flag. Chromium/Blink does not rely on ICU for the code conversion between the 'system native encoding' (if it's one of legacy encodings) and Unicode. With this configuration, we can cut down the code size a bit. 6. Update the icudtl.dat (all platforms) and assembly files (mac,linux) and the icudata dll (windows) See https://codereview.chromium.org/1026453002 for a new blink test added ( fast/encoding/char-decoding-invalid-trail.html ) BUG=450312,430823 TEST=Blink: fast/encoding/char-decoding-{truncated,invalid-trail}.html TEST=base_unittests --gtest_filter=*Conv*, browser_tests --gtest_filter=*ncoding* R=jsbell@chromium.org, mark@chromium.org Review URL: https://codereview.chromium.org/984233002
-
Jochen Eisinger authored
BUG=none R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1014393002
-
- Mar 03, 2015
-
-
Jungshik Shin (jungshik at google) authored
V8 does still use the icu data dll. Build icudt.dll on Windows with the latest icudtl.dat. Follow-up to https://codereview.chromium.org/962643003/ BUG=428145 TEST=With icu_data_file_flag=0 in GYP_DEFINES, run 'gclient runhooks' and build base_unittests. Run it with '--gtest_filter=*Conv*' R=jochen@chromium.org TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/971973002
-
- Mar 02, 2015
-
-
Jungshik Shin (jungshik at google) authored
Fix the following errors found by jochen@ in https://codereview.chromium.org/960263002/ 1. brkitr: en_US_POSIX is not supported. Remove it from brklocal.mk : We don't use en_US_POSIX and the remaining dependency on it in some unittests was already removed. (we may need it back later, though, for breaking an FQDN into components.) 2. coll: Explicitly add id.txt required as the alias/parent of "in" and "id_ID". This should not affect the collation in Indonesian locale because falling back to the root locale should be fine. 3. lang: Add 'ro_MD.txt' required as the alias of 'mo.txt'. Also update make_mac_asseymbly.sh to get it to read off the ICU major version automatically. Besides, update README.chromium to refer to ICU 54 as done by the aforementioned CL. Rebuild the data files and assembly sources (the latter still required by stand-alone v8 builds) for all the platforms. icudtl.dll for Windows will be built and checked in in another CL. BUG=428145 TEST=Usual ICU update tests before rolling DEPS. See https://codereview.chromium.org/878723002 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/962643003
-
- Feb 27, 2015
-
-
Jochen Eisinger authored
BUG=none R=machenbach@chromium.org, jshin@chromium.org Review URL: https://codereview.chromium.org/962653002
-
- Feb 20, 2015
-
-
Jungshik Shin (jungshik at google) authored
Update the tz data source and rebuild the icu data for Android and non-Android. Note that timezoneTypes.txt hasn't changed between 2014j and 2015a. BUG=NONE TEST=None Review URL: https://codereview.chromium.org/946703002
-
- Feb 19, 2015
-
-
Jungshik Shin (jungshik at google) authored
data/lang/en_GB.txt has an empty "Languages" block leading getDisplay{Name,Language} to fail in en-GB. Update trim_data.sh to remove an empty "Languages" block and run the script to fix data/lang/en_GB.txt and other locales if any. (only en_GB.txt is affected). Rebuild the icu data with the above changes for both Android and non-Android platforms. BUG=428145 TEST=linux_chromeos bots: browser_tests --gtest_filter=*GetUILang* TBR=mark@chromium.org Review URL: https://codereview.chromium.org/930203004
-
- Feb 17, 2015
-
-
Jungshik Shin authored
When icu_use_data_file_flag==1, nothing is done other than copying icudtl.dat. [1] Therefore, the type is changed to 'none' from 'static_library'. Although I couldn't locally reproduce the problme, one of iOS try bots tried to link with libicudata.a [2] and failed when the type is 'static_library'. This change should fix the problem. [1] http://codereview.chromium.org/926113004 moved stubdata.c to icuuc. [2] https://codereview.chromium.org/878723002/ PS 14 has the above change in icu.gyp. ios_dbg_simulator_ng failed to link looking for libicudata.a in the 1st try. When I ran the trybot again, the compile went through. BUG=428145 TEST=All bots (including iOS bots) can build successfully. R=mark@chromium.org Review URL: https://codereview.chromium.org/937513002
-
- Feb 14, 2015
-
-
Jungshik Shin (jungshik at google) authored
This is to fix a linker error when linking icuuc.dll; ICU_DATA_ENTRY (icudt54_dat) symbol is not found on Windows clean build from the scratch (component=shared_library). Move stubdata.c to icuuc target from icudata target. Also, make U_DATA_API (used for U_ICU_DATA_ENTRYPOINT in common/udata.cpp) to be U_EXPORT instead of U_IMPORT when icu_use_data_file_flag = 1 or on Windows. On Windows, using the icudt.dll (i.e. icu_use_data_file_flag=0) also requires this change. BUG=428145 TEST=All trybots can build a target that requires ICU. R=mark@chromium.org, scottmg@chromium.org Review URL: https://codereview.chromium.org/926113004
-
- Feb 10, 2015
-
-
Jungshik Shin (jungshik at google) authored
Blink does not use ICU's Bidi API, but it may in the future. Moreover, Chrome UI does use ubidi API. Replace the current bidi.patch (that I should have deleted because it's already a part of ICU 54.1 and is not applied) with a new one. upstream bug: http://bugs.icu-project.org/trac/ticket/11177 BUG=428145 TEST=None R=mark@chromium.org Review URL: https://codereview.chromium.org/907333002
-
- Feb 09, 2015
-
-
Jungshik Shin (jungshik at google) authored
Remove the warning about 54.1 not being ready because it's now ready. BUG=428145 TEST=None Review URL: https://codereview.chromium.org/893883002
-
- Jan 31, 2015
-
-
Jungshik Shin (jungshik at google) authored
1. Fix a Windows build failure due to: a. 'signed vs unsigned' comparison b. 'possible data loss' in conversion : Apply pkasting's patch at http://bugs.icu-project.org/trac/ticket/11104 2. Drop a few currencies to cut down the data size by 50kB for non-Android platforms. 2. Build the ICU data for Android and check in. - Drop all display names for languages/scripts/regions except for zh-Han{s,t} as before. ( ~ 1.2MB reduction) - Drop cjdict by applying android/brkitr.patch. (~ 2MB reduction) - Include the display names for only 60+ currencies ( ~ 400kB reduction from the non-Android data. - Minimize the locale data for 9 locales Chrome on Android is not localized to. Drop currency names for those 9 locales. ( ~ 150kB reduction) Size change: 1. Non-android: 10,255,584 to 10,200,880 2. Android: - Final : 6,270,880 With 60+ currency names added (for bug 370849) and 9 unnecessary locale data dropped. It's 232,240 bytes larger than ICU 52.1 (6,038,640). - Without any currency names but with 9 unnecessary locale data: 6,026,816 - With 60+ currency names and 9 unnecessary locale data: 6,426,368 BUG=370849,428145 TEST=Build on Windows. Blink layout tests, webkit unittests. R=mark@chromium.org, wangxianzhu@chromium.org Review URL: https://codereview.chromium.org/877193003
-
- Jan 23, 2015
-
-
Jungshik Shin (jungshik at google) authored
1. Add {coll,curr,lang,locales,rbnf,region,sprep,translit,unit,zone}/*local.mk to exclude locale data for languages/locales that Chromium does not need. 2. Run scripts/trim_data.sh to cut down the data size further by excluding unused entries in each locale files. - Keep the display names for languages/scripts/locales in Chrome's Accept-Language list and remove the display names outside the set. - Minimize the locale data in data/{locales,lang} for non-UI languages in the A-L list. For them, we just need the "native" display name and exemplar character set. - Exclude historic, obscure and otherwise unnecessary currency display names. - Drop unnecessary Chinese collation rules; Big5/GB2312/UniHan. - Keep only the minimal unit data for duration and compound units. 3. Add css3transform.txt to data/translit for Greek upper/lowercasing support. 4. Add the minimal locale data for ckb and ku. 5. The tz db was updated previously to 2014j (the latest) so that no change is made except for README.chromium update. 6. Add the minimal locale data for ckb and ku. 7. Check in the pre-built data (icudtl.dat) shared by all non-Android platforms and assembly files for Linux/Mac The final data size is 10,255,584 bytes, which is about 200kB smaller than that for ICU 52.1. The pristine upstream ICU has the data of 25,343,024 bytes. The remaining steps are to build a smaller data file for Android and to build icudtl.dll for Windows (non-default build option). BUG=428145 TEST=net_unittests --gtest_filter="*ilenameUtil*" TEST=net_unittests --gtest_filter="*IDN*" TEST=base_unittests --gtest_filter="*Conv*" TEST=browser_tests --gtest_filter="*ncoding*" TEST=Blink: layout tests R=mark@chromium.org Review URL: https://codereview.chromium.org/872903002
-
Jungshik Shin (jungshik at google) authored
1. Apply Chrome's locale data change on top of Google's locale data changes 2. Breakiterator changes - Apply brkitr.patch with update to ICU 54.1; line/word.txt - Check in a more compact Khmer dictionary along with a parameter adjustment in dictbe.cpp - Add a few common words to the CJ dictionary - Update brklocal.mk (out customized build file) to ICU 54 - Update android/brkitr.patch and data/brkitr/word_ja.txt for Android Data size checkpoint: * Non-Android: 19,575,216 bytes. ~500kB reduction relative to the previous step comes mainly from the compact Khmer dictionary. * Android: 17,601,520 bytes. 2MB difference comes from removing cjdict. BUG=428145 TEST=net_unittests --gtest_filter="*IDN*" TEST=layout tests R=mark@chromium.org Review URL: https://codereview.chromium.org/858363003
-
- Jan 21, 2015
-
-
Jungshik Shin (jungshik at google) authored
Google's locale data changes are applied before Chrome's own locale data trimming. 1. Use "Rs." instead of the Indian Rupee sign (U+20A8) for which the font support is not available on all platforms. Google platforms (CrOS / Android ) have them, but other platforms may not. 2. Use shorter names for Hong Kong and Macau without 'S.A.R.' at the end. This cuts down the data size a bit. 3. Timezone names for Korea standard time and a couple of other zones are shortened. 4. zh_Hant_TW, pa_Arab_PK and a few more locales are changed. Besides, update data.build.patch and README.chromium to drop the collation rule files ('-R' option to genrb.). This should have been done in ICU update step 2. Data size checkpoint: 20,066,624 bytes - about 500k reduction from step 3 mostly due to '-R' option with the rest attributed to shorter display names for HK, MO and Korean tz. - the original ICU 54.1 : 25,343,024 BUG=428145 TEST=NONE TBR=mark Review URL: https://codereview.chromium.org/856153003
-
Jungshik Shin (jungshik at google) authored
A. Converter update per HTML encoding spec along with changes in the encoding name alias table. B. Remove all the codes for converters Blink and Chromium do not need (SCSU, Lotus, ISO-2022-xx other than JP, BOCU, UTF-7, etc). This is reapplying the following CLs (that we used for ICU 52.1) to ICU 54.1 : https://codereview.chromium.org/598383002 https://codereview.chromium.org/654153002 We have two upstream bugs filed for A and B above: http://www.icu-project.org/trac/ticket/11296 http://www.icu-project.org/trac/ticket/10303 In addiition to A and B, we unified Big5 and Big5-HKSCS per the encoding spec (bug 277868). That also includes properly supporting the four 2-character sequences ( see http://crbug.com/277868#c3 ). big5_gen.sh deviates from the current spec to work around a bug in the spec. (see https://www.w3.org/Bugs/Public/show_bug.cgi?id=27878) Moreover, ucmlocal.mk is added to list only encodings we want to support. Also, tighten the state table for windows-946-2000.ucm that we use for EUC-KR for now. And, drop 'base' map for windows-{936,949}-2000.ucm. Finally, add euc-kr-html.ucm along with scripts/euckr_gen.sh, but it is not yet used pending the resolution of bug 450312. Data size checkpoint: 20,566,864 bytes (the original ICU 54=25,343,024) BUG=277868, 428145, 450312 TEST=net_unittests --gtest_filter="*ilenameUtil*" TEST=base_unittests --gtest_filter="*Conv*" TEST=browser_tests --gtest_filter="*ncoding*" TEST=Blink: fast/encoding/* R=jsbell@chromium.org, mark@chromium.org Review URL: https://codereview.chromium.org/839713003
-
- Jan 12, 2015
-
-
Jungshik Shin (jungshik at google) authored
Update the following patches and apply to the fresh copy of icu 54.1: configure.patch declspec.patch locid.patch platform_nacl.patch regex.patch wpo.patch vscomp.patch: two chunks are not necessary any more; upstream has them. data.build.patch data.build_win.patch Delete the following patches: putil.patch: not necessary any more; upstream has it. regex2.patch: merged to regex.patch. col.patch: not necessary any more; upstream code changed drastically and does not have a bug any more. clang_win.patch: not necessary any more; upstream has it. BUG=428145 TEST=None R=mark@chromium.org Review URL: https://codereview.chromium.org/822213003
-
- Jan 08, 2015
-
-
Jungshik Shin (jungshik at google) authored
1. Replace 'src/' with a fresh copy of ICU 54.1 from the upstream. 2. Remove unncessary files/directories 3. Update the source/header file lists in icu.gypi and icu.gyp 4. Update README.chromium to warn that the ICU head is not usable for building Chromium/Blink/v8,yet. BUG=428145 TEST=None Review URL: https://codereview.chromium.org/845603002
-
- Dec 15, 2014
-
-
Jungshik Shin (jungshik at google) authored
To have keyboard layouts for ku and ckb, we need to have the minimal locale data for them - native display name, writing direction, and exemplar characters. These are added and the icu data was rebuilt. The Android icu data was not rebuilt because Android Chrome does not use them. BUG=204049 TEST=None until ckb and ku are added to the A-L list in a Chrome CL. When they're, language and input settings will have ckb and ku listed with the display name in the current UI language (e.g. Englsih) and native display name. Review URL: https://codereview.chromium.org/805073003
-
- Dec 11, 2014
-
-
Jungshik Shin (jungshik at google) authored
README.chromium update and locid.patch were not included in the previous check-in (6bbe98e6 reviewed at https://codereview.chromium.org/796153002 ). BUG=403902 TEST=NONE TBR=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/799643002
-
Jungshik Shin (jungshik at google) authored
The root cause is described in http://bugs.icu-project.org/trac/ticket/11421 The original two line fix is from gguangle@gmail.com. It was momdified to the minimum necessary because only |baseName| should be reset. TBR=phajdan.jr@chromium.org BUG=403902 TEST=Speculative: On Windows with the display language set to one other than English (e.g. ko, pt-BR, zh-CN, etc; just setting the default locale to one of them does not work on Win 7 or later or using --lang=foo does not work), start Chrome and go to ftp://ftp.vim.org. Render process should not crash. Review URL: https://codereview.chromium.org/796153002
-
- Dec 10, 2014
-
-
Jungshik Shin (jungshik at google) authored
A follow-up patch to https://codereview.chromium.org/751333003 BUG=433866 TEST=See the bug (comment 0) R=mbarbella@chromium.org Review URL: https://codereview.chromium.org/777783004
-
- Dec 04, 2014
-
-
Jungshik Shin (jungshik at google) authored
Add codereview.settings with the default values so that accepting default values in 'git cl config' works. BUG=438401 TEST=NONE R=vadimsh@chromium.org Review URL: https://codereview.chromium.org/775153003
-
- Nov 26, 2014
-
-
jshin@chromium.org authored
BUG=433866 TEST=See the bug. R=mbarbella@google.com Review URL: https://codereview.chromium.org/751333003 git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@293126 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-
- Nov 19, 2014
-
-
jshin@chromium.org authored
http://bugs.icu-project.org/trac/ticket/11371 BUG=432209 TEST=See bug (comment 0 and comment 10) R=markbrand@google.com Review URL: https://codereview.chromium.org/734213003 git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292996 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-
- Nov 14, 2014
-
-
jshin@chromium.org authored
BUG=422824,430353 TEST=NONE TBR=mbarbella Review URL: https://codereview.chromium.org/719943004 git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292944 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-
jshin@chromium.org authored
The patches for the following upstream two bugs are cherry-picked: http://bugs.icu-project.org/trac/ticket/11369 http://bugs.icu-project.org/trac/ticket/11370 BUG=422824,430353 TEST=See the bugs. TBR=mbarbella Review URL: https://codereview.chromium.org/732743002 git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292943 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-
- Oct 30, 2014
-
-
torne@chromium.org authored
We don't support using the system ICU on android any more (the library is not included in the NDK and so cannot be relied on). Remove the support for it in ICU gyp files, to eliminate remaining references to the deprecated "android_src" gyp variable. BUG= R=mkosiba@chromium.org Review URL: https://codereview.chromium.org/690603002 git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292738 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-
- Oct 15, 2014
-
-
jshin@chromium.org authored
Some layout tests and chrome browser tests compare the encoding labels case-sensitively. Fixing them all takes a while. In the meantime, change the ICU alias table to use exactly what they expects (Big5). Also drop big5-hkscs from the alias for Big5 for now. They'll be unified in another CL. See the layout test failures for PS #2 at https://codereview.chromium.org/649413002 BUG=412053 TEST=browser_tests --gtest_filter=*ncoding* TEST=Layout tests : http/tests/misc/char-encod*, fast/encoding/* R=jsbell@chromium.org TBR=jsbell@chromium.org Review URL: https://codereview.chromium.org/654153002 git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292476 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-
- Oct 13, 2014
-
-
jshin@chromium.org authored
1. Replace the current encoding alias list (heavily patched) with our own HTML5-specific alias list. It's mostly generated from encoding.json, which is in turn derived from the WHATWG Encoding living standard. The most notable difference is that UTF-32 entries are kept until bug 417850 is resolved. Two other differences are: a. Two aliases for iso-8859-8-i (logical and csiso88598i) are not listed. They're dealt with in Blink. b. Chinese (gb*, big5*) aliases are not yet aligned to the encoding spec pending our decision on the unification of Big5 / Big5-HKSCS and GBK / GB18030. 2. Replace all the single-byte mapping tables with what's automatically generated with scripts/single-byte-gen.sh that uses index-* files downloaded from the WHATWG spec site. This will fix the decoding (ToUnicode) of windows-874 and windows-1253 while removing a lot of fallback/spurrious mapping entries in encoding direction ('FromUnicode') in a number of encodings. 3. Regenerate the ICU binary data files for Linux/Mac/Android/Windows/CrOS. 4. Remove now obsolete noop-*ucm files used to make ISO-2022-CN* decoder to turn an empty string. They're not necessary any more because ISO-2022-CN* were made 'replacement' encodings in Blink and our version of ICU does not have any code for ISO-2022-CN* any more. This cuts down the data size by 15kB. On Android, there's virtually no change in the data size because the previous data file on Android accidentally had smaller locale data for nb and ms. BUG=412053 TEST=browser_tests --gtest_filter="*ncoding*" TEST=net_unittest --gtest_filter="*ilenameUtil*" TEST=base_unittests --gtest_filter="*Conv*" TEST=Blink: fast/encoding/* TEST=http://www.w3.org/International/tests/repository/encoding/indexes/results-indexes TEST=http://www.w3.org/International/tests/repository/encoding/indexes/results-aliases TEST=http://www.w3.org/International/tests/repository/run?manifest=encoding/indexes&test=windows-1253_test TEST=http://www.w3.org/International/tests/repository/run?manifest=encoding/indexes&test=windows-874_test R=jsbell@chromium.org Review URL: https://codereview.chromium.org/598383002 git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292447 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-
- Oct 04, 2014
-
-
maruel@chromium.org authored
That's the new name, and the next swarming_client roll will refuse the old name. R=jshin@chromium.org BUG= Review URL: https://codereview.chromium.org/607413006 git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292317 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-
- Sep 25, 2014
-
-
jshin@chromium.org authored
word_ja.txt has not been checked in although the icu data file for Android (android/icudtl.dat) was built with the file. README.chromium about Android's brkitr patch was not updated when moving to ICU 52.1. It's changed to reflect what we do in ICU 52.1 (where the upstream copy does have cjdict for CJ word breaking). TBR=andrewhayden@chromium.org BUG=NONE TEST=NONE (there's no change affecting Chrome/Blink builds). Review URL: https://codereview.chromium.org/609493003 git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292144 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-
jshin@chromium.org authored
UCONFIG_NO_NON_HTML5_CONVERTER was added earlier to our copy of ICU, but it was never set to 1. It's my oversight. 1. Turns UCON..CONVERTER on in icu.gyp to drop all the encodings not required by the Encoding spec. Dropped encodings include UTF-7, BOCU, SCSU, CESU, ISCII, ISO-2022-{KR, CN*}, HZ-GB, ISO-2022-JP's other than the original. 2. A lot more sections of the ICU converter code are excluded when it's set to 1 including the code for LMB (Lotus Multibyte) encodings and X11 compound text encoding (icu common). 3. The character encoding detections for encodings excluded are also disabled. (icu i18n) 4. ISO-2022-{KR, CN*} and HZ-GB can be dropped now because Blink treats them as replacement encoding. The corresponding alias entries from convertrs.txt are also removed. 5. ibm-874 was removed. We used to need it before Blink started, but not any more. We only need windows-874. 6. A mistaken in convertrs.txt was corrected : Big5-HKSCS was pointing to an old mapping table. 7. Per ICU upstream's suggestion, use '-html' suffix instead of '-html5' for the encoding tables derived from the WHATWG's encoding spec (ibm866, shift_jis and euc-jp). The static 64-bit release build of Chrome on Linux went down from 141,596,616 to 141,491,968 bytes (~ 100 kB reduction). Besides, the icu data size got smaller by ~ 19 kB ( 10,490,576 to 10,471,008 bytes). See http://bugs.icu-project.org/trac/ticket/11296 for an upstream bug I've filed on the issue. BUG=76328 TEST=browser_tests --gtest_filter="*ncoding*" TEST=net_unittest --gtest_filter="*ilenameUtil*" TEST=base_unittests --gtest_filter="*Conv*" TEST=Blink: fast/encoding/* TEST=With shared library build, the following has no match. nm libicuuc.so | egrep -i '(bocu|scsu|utf7|2022kr|2022cn|iscii)' nm libicui18n.so | egrep -i '(2022kr|2022cn|ibm42)' TEST=With static library build, the following has no match. nm chrome | egrep -i '(bocu|scsu|utf7|2022kr|2022cn|iscii|ibm42)' R=jsbell@chromium.org, mark@chromium.org Review URL: https://codereview.chromium.org/587833004 git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292131 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-
- Sep 17, 2014
-
-
jshin@chromium.org authored
Cherry-pick an upstream patch from http://bugs.icu-project.org/trac/ticket/11054 BUG=402297 TEST=See the comment 7 and comment 27 in the bug (after rolling DEPS with this CL). R=ckocagil@chromium.org TBR=ckocagil@chromium.org Review URL: https://codereview.chromium.org/566073003 git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@292003 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-
- Sep 03, 2014
-
-
torne@chromium.org authored
ICU fails to gyp when run with GYP_DEFINES="android_webview_build=1 use_system_icu=0 use_system_stlport=1" which is a combination of settings we're trying to bring up temporarily as we migrate away from system libraries. It fails because it's not permitted to specify link_settings in a target_condition as the processing is too late. Remove the invalid link_settings, since we can't do this outside target_conditions as it's not valid to use -lgabi++ on the host build of ICU. The link dependency on gabi++ will have to be satisfied manually in the main libwebviewchromium target instead for this configuration. BUG=409851 R=mkosiba@chromium.org TBR=jshin@chromium.org Review URL: https://codereview.chromium.org/527193003 git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu52@291781 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-