Skip to content
Snippets Groups Projects
  1. May 27, 2016
  2. May 18, 2016
  3. Apr 05, 2016
  4. Mar 30, 2016
  5. Mar 25, 2016
  6. Mar 20, 2016
  7. Mar 18, 2016
  8. Mar 11, 2016
  9. Feb 19, 2016
  10. Feb 08, 2016
  11. Feb 04, 2016
  12. Feb 03, 2016
    • Jungshik Shin's avatar
      Apply an overlooked patch to brkitr/word.txt · 452b580a
      Jungshik Shin authored
      patches/wordbrk.patch was not applied by mistake while updating ICU
      to 56.1.
      
      This affects how we break domain names (separated by full stop). We want
      them to be split at full stop at the cost of 'breaking' cases like
      "e.g." and "i.e.".
      
      All the ICU data files were rebuilt for the change.
      
      BUG=575007
      TEST=gfx_unittests --gtest_filter=RenderText*Word*
      TEST=layout tests: css1/text_properties/text_transform.html fast/text/window-find.html editing/text-iterator/findString.html css2.1/t1605-c545-txttrans-00-b-ag.html
      
      Review URL: https://codereview.chromium.org/1659833002 .
      452b580a
  13. Feb 02, 2016
  14. Jan 29, 2016
    • Jungshik Shin's avatar
      ICU 56 step 6:Check in the pre-built ICU data · d2c18300
      Jungshik Shin authored
      * Update the pre-built ICU data files for all platforms
      
        source/data/in/icudtl.dat for non-Android platforms
        {linux,mac}/icudt*.S for linux/mac
        android/icudtl.dat and android/icudt*.S for Android
        windows/icudt.dll for Windows
      
      * Update Android data trimming script
      
        1. Make sure that 'default' calendar is kept in locales where it's relevant
          : root, th, fa, ar_SA, etc.
        2. Add a minimal region data to work around a bug in ICU with pool.res
           handling
      
      * Update gn and gyp files
      * And add a TODO comment to update.sh to automate the build file update.
      * Add it_CH to the locale list.
      * Add sr_Latn to unit/reslocal.mk (required by sh) and
        line_normal_fi to brkitr/brklocal.mk (referred to in brkitr/fi.txt) in
        place of line_fi.
      
      * Update and add scripts for data building
      * Completely rewrite README.chromium
      * Check-in the prebuilt ICU data files/assembly sources for
        Linux,Mac,Windows,Chrome OS and Android.
      
      BUG=575007
      TEST=Blink layout tests, webkit unittests
      TEST=All bots can build successfully
      TEST=net_unittests --gtest_filter="*ilenameUtil*"
      TEST=net_unittests --gtest_filter="*IDN*" (pending bug 336973)
      TEST=base_unittests --gtest_filter="*Conv*"
      TEST=browser_tests --gtest_filter="*ncoding*"
      TEST=base_unittests --gtest_filter="*essage*"
      TEST=ui_base_unittests --gtest_filter="*ormat*"
      TEST=ui_base_unittests --gtest_filter="L10n*"
      R=mark@chromium.org
      
      Review URL: https://codereview.chromium.org/1639543006 .
      d2c18300
    • Jungshik Shin's avatar
      Apply the remaining local patches · 5dac1b26
      Jungshik Shin authored
      Below is the list of changes in reverse order.
      
      1. Drop uconv.patch (upstream took my patch)
      2. Apply data.build.win and data_sym patches
      3. Apply vscomp.patch and update the patch file.
         update README.chromium about two parts of the patch that
         are not necessary any more.
      
      4. Apply wpo patch and update the patch file
      
      5. Android brkitr adjustment
         * Do not apply the patch but just updates the patch
         * Do not use CJdict on Android to save 2MB in the data size.
      
      6. Clean up brkitr patches
        * Rename brkitr.patch to wordbkr.patch and keep only word.txt diff
        * Make a new linebrk.patch with line breaking adjustment (dropping
          loose rules to save space until the upstream implements space-efficient mechanism for line breaking rule variations)
        * Update README.chromium
        * Apply local patches for Khmer dictionary handling and cjdict
      
      7. Adjust line breaking rules.
        This corresponds to set 2 in
           https://code.google.com/p/chromium/issues/detail?id=575007#c6
      
      BUG=575007
      TEST=None
      R=mark@chromium.org
      
      Review URL: https://codereview.chromium.org/1637683002 .
      5dac1b26
    • Jungshik Shin's avatar
      ICU 56 step 4: Apply post-56 fixes for measure/date format · 825221bb
      Jungshik Shin authored
      1. Apply post-56 patches from the trunk for measure/date format
          http://bugs.icu-project.org/trac/ticket/11986
          http://bugs.icu-project.org/trac/ticket/12031
          http://bugs.icu-project.org/trac/ticket/12030
          http://bugs.icu-project.org/trac/ticket/12041
      2. Generate a combined patch (measure_format.patch) for the above.
      3. Split locale_google.patch into 'locale_google.patch' and
         'relative_date.patch'. The latter is taken from Android.
      4. Update README.chromium
      
      Besides, apply two local patches : {tzdetect,xlit..}.patch and
      adjust gb18030.ucm and the corresponding patch
      
      Also, remove obsolte patches and update README.chromium
      
      BUG=575007
      R=mark@chromium.org
      
      Review URL: https://codereview.chromium.org/1621943002 .
      825221bb
    • Jungshik Shin's avatar
      ICU 56 step 3: Apply Google's locale changes to ICU locale data · 46d3d102
      Jungshik Shin authored
      1. AM/PM, midnight, noon formatting for a few Indian locales
      2. Currency signs in ru/uk/tr locales
      3. Region name change for Hong Kong and Macau in all locales
      4. Timezone name changes in Korean and Chinese locales
      5. Internval format changes from AOSP:
         https://android.googlesource.com/platform/external/icu/+/f9ffd5b%5E%21/#F0
      6. Minor locale changes for Korean: locale1.patch
      
      BUG=575007
      TEST=None
      R=mark@chromium.org
      
      Review URL: https://codereview.chromium.org/1625623003 .
      46d3d102
    • Jungshik Shin's avatar
      ICU 56 step 2 · 27b09232
      Jungshik Shin authored
      Make the tree ready for the application Google's and Chrome's data
      and post-56 code patches.
      
      1. Fix trim_data.sh to run from anywhere.
      2. Update patch_locale.sh for Android and add en_IN to the locale list
      3. Apply data.build.patch
      4. Exclude non-UI locale data for unit locale category
      5. Add some regional variant locales to locale, unit, zone and coll.
      6. Update locale lists for locale, unit, zone, and coll
      
      BUG=575007
      TEST=None
      R=mark@chromium.org
      
      Review URL: https://codereview.chromium.org/1624643003 .
      27b09232
    • Jungshik Shin's avatar
      ICU 56 update step 1 · 70f8250f
      Jungshik Shin authored
      Run scripts/update.sh to get icu 56.1 from the upstream while
      preserving local configuration files and converter files.
      
      BUG=575007
      TEST=None
      
      Review URL: https://codereview.chromium.org/1621843002 .
      70f8250f
  15. Jan 07, 2016
  16. Dec 14, 2015
  17. Nov 03, 2015
  18. Oct 01, 2015
  19. Sep 25, 2015
  20. Aug 25, 2015
    • Nico Weber's avatar
      Fix -Wmicrosoft-unqualified-friend warning. · 6b3ce817
      Nico Weber authored
      The warning complains that StringThreadTest is declared in the global namespace,
      but the friend line says `friend class StringThreadTest;` instead of
      `friend class ::StringThreadTest`.  MSVC doesn't require this ::, but gcc does
      -- without it, the friend line declares a new class in the namespace containing
      UnicodeString.
      
      Since StringThreadTest was in test/threadtest which isn't built as part of
      Chromium's build and which was removed in upstream ICU in ICU 37392, just
      delete the friend line, it has no effect.
      
      BUG=505296
      R=jshin@chromium.org
      
      Review URL: https://codereview.chromium.org/1317603003 .
      6b3ce817
  21. Aug 18, 2015
    • Nico Weber's avatar
      Build icu with -Wno-unused-function. · 89dcdec1
      Nico Weber authored
      Also add a few comments to the .gn file.
      
      BUG=505316
      R=jshin@chromium.org
      
      Review URL: https://codereview.chromium.org/1301493002 .
      89dcdec1
    • Nico Weber's avatar
      Fix -Woverloaded-virtual warnings in ICU. · 80ac4c39
      Nico Weber authored
      1.
      In Win32NumberFormat, rename the private format() method to variadicFormat().
      It's just an implementation detail of the class. Fixes:
      ..\..\third_party\icu\source\i18n/winnmfmt.h(146,20) :  error(clang):
              'icu_54::Win32NumberFormat::format' hides overloaded virtual functions
              [-Werror,-Woverloaded-virtual]
          UnicodeString &format(int32_t numDigits, UnicodeString &appendTo, const wchar_t *format, ...) const;
                         ^
      ..\..\third_party\icu\source\i18n\unicode/numfmt.h(255,28) :  note(clang):
              hidden overloaded virtual function 'icu_54::NumberFormat::format'
              declared here: different number of parameters (4 vs 3)
          virtual UnicodeString& format(const Formattable& obj,
                                 ^
      ...
      
      2.
      In Win32DateFormat, remove the two-argument format() function that just
      forwards to the base class.  (If this happens to produce compile errors,
      the function should be replaced by
      `using Win32DateFormat::format(UDate, UnicodeString&) const;`) Fixes:
      ..\..\third_party\icu\source\i18n/windtfmt.h(55,20) :  error(clang):
              'icu_54::Win32DateFormat::format' hides overloaded virtual functions
              [-Werror,-Woverloaded-virtual]
          UnicodeString& format(UDate date, UnicodeString& appendTo) const;
                         ^
      ..\..\third_party\icu\source\i18n\unicode/datefmt.h(240,28) :  note(clang):
              hidden overloaded virtual function 'icu_54::DateFormat::format'
              declared here: different number of parameters (4 vs 2)
          virtual UnicodeString& format(const Formattable& obj,
                                 ^
      ...
      
      BUG=505301
      R=jshin@chromium.org
      
      Review URL: https://codereview.chromium.org/1296803002 .
      80ac4c39
  22. Aug 05, 2015
  23. Jul 16, 2015
  24. Jul 14, 2015
  25. Jul 06, 2015
  26. Jul 03, 2015
  27. Jul 01, 2015
  28. Jun 30, 2015
  29. Jun 23, 2015
  30. Jun 18, 2015
Loading