- May 27, 2016
-
-
Jungshik Shin authored
Cherry-pick 54f86bb1 for M52 branch. Trunk CL: https://codereview.chromium.org/1985243002 . What's new in 2016d is found at http://mm.icann.org/pipermail/tz-announce/2016-April/000038.html Rebuilt ICU data/assembly files are checked in (not shown in the codereview due to their sizes). While I'm at it, add scripts/LICENSE file that is identical to LICENSE at the top of the Chromium tree. Because LICENSE in third_party/icu is for ICU and is not applicable to files in scripts/. BUG=473288 TBR=mark TEST=In JavaScript console, run the following. apr30_2016_1200 = new Date("04/30/2016 12:00Z") may01_2016_1200 = new Date("05/01/2016 12:00Z") apr30_2016_1200.toLocaleString("en", {timeZone: "America/Caracas"}) may01_2016_1200.toLocaleString("en", {timeZone: "America/Caracas"}) On April 30, 2016, Caracas is 4:30 behind UTC. On May 1, it's 4:00 behind. Review URL: https://codereview.chromium.org/2011163003 .
-
- May 18, 2016
-
-
Sami Kyostila authored
BUG=610673 R=alexclarke@chromium.org, dpranke@chromium.org Review URL: https://codereview.chromium.org/1991833002 .
-
- Apr 05, 2016
-
-
Jungshik Shin authored
Cherry pick http://bugs.icu-project.org/trac/changeset/38183 to add the support for Emoji properties. This will be followed by a Blink change to use the API. ( https://codereview.chromium.org/1856353002 ) There's no need to rebuild ICU data because Unicode character properties are hard-coded in the C++ source files that are patched by the cherry-pick above. source/data/in/{pnames,uprops}.icu are updated just for the record, but they're not actually used. The same is true of files in source/data/unidata. BUG=583378 TEST=None TBR=drott Review URL: https://codereview.chromium.org/1864463002 .
-
- Mar 30, 2016
-
-
Jungshik Shin authored
BUG=575007 R=jshin@chromium.org Review URL: https://codereview.chromium.org/1838103003 .
-
- Mar 25, 2016
-
-
Jungshik Shin authored
1. Update the IANA tz data to 2016c What's new in 2016b and 2016c are found at http://mm.icann.org/pipermail/tz-announce/2016-March/000036.html (2016b) http://mm.icann.org/pipermail/tz-announce/2016-March/000037.html (2016c) 2. Locale data fixes - en-AU date format fix from the upstream - ar and fa: Prepend 'percent sign' with RTL mark (U+200F). From Android. - tr: Use ₺ (U+20BA; Turkish Lira Sign) instead of 'TL'. This is to revert a locale patch picked up from Google's internal build of ICU. (Android also uses U+20BA). In addition, icudtl.dat (the prebuilt ICU data file for platforms other than Android is moved out of source/data/in to common/. This way, the data build steps for non-Android and Android can be unified and a bit more streamlined. icu.gyp and BUILD.gn are updated accordingly as well as README.chromium. BUG=598000 TEST=See bug comment 0 and comment 1 R=mark@chromium.org Review URL: https://codereview.chromium.org/1823293002 .
-
- Mar 20, 2016
-
-
Jungshik Shin authored
region.cpp has an unnecessary static initializer for a type UnicodeString and triggers a 'si check' failure. Upstream bug: http://bugs.icu-project.org/trac/ticket/12408 BUG=575007 TEST=`tools/linux/dump-static-initializers.py chrome` (static build) does not have an entry from region.cpp TEST=`tools/linux/dump-static-initializers.py libicui18n.so` (shared build) has no entry. TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1816843002 .
-
- Mar 18, 2016
-
-
Jungshik Shin authored
ICU in Chromium is compiled with exception disabled [1], but U_NOEXCEPT is set to 'noexcept' regardless of whether _HAS_EXCEPTION is set to 0 or (in source/common/unicode/platform.h ). [2]. Set U_NOEXCEPT to empty in our build files to avoid this issue. [1] http://bugs.icu-project.org/trac/ticket/8343 [2] http://bugs.icu-project.org/trac/ticket/12406 BUG=575007 TEST=Build on Windows with MSVS 2015 succeeds. R=thakis@chromium.org Review URL: https://codereview.chromium.org/1816673002 .
-
- Mar 11, 2016
-
-
Sylvain Defresne authored
BUG=297668 R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1755473004 .
-
- Feb 19, 2016
-
-
Jungshik Shin authored
This is, among other things, to make sure that a change is not made against ToT while ICU is in the middle of update to a new version. For such a change, a branch has to be used. BUG=None Review URL: https://codereview.chromium.org/1713163002 .
-
- Feb 08, 2016
-
-
Jungshik Shin authored
Update the copyright years in LICENSE (taken from license.html) and IANA timezone DB version in README.chromium. Incorporate the format fixes made by Mostyn Bramley-Moore <mostynb@opera.com> in https://codereview.chromium.org/1530343003/ BUG=575007 TEST=None TBR=mostynb@opera.com Review URL: https://codereview.chromium.org/1678243002 .
-
- Feb 04, 2016
-
-
Jungshik Shin authored
1. ast,an,wa locale data (minimal) - make up the minimal locale data for 3 languages. - update source/data/{locale,lang}/reslocal.mk to have 3 languages - update scripts/data_file_to_preserve.txt to have files for 3 locales listed. - In chromium, these languages have to be added to the A-L list to show up in the A-L pull-down in settings. 2. IANA timezone db updte to 2016a See http://mm.icann.org/pipermail/tz-announce/2016-January/000035.html for the change. 3. Pre-built-data files are updated. Data (icudtl.dat) size changes between 54.1 and 56.1 non-Android platforms: 10,124,096 bytes (net change: -83,840) Android: 6,560,080 bytes (net change: +291,840 / 4.66%) BUG=575007,474333 R=jsbell@chromium.org Review URL: https://codereview.chromium.org/1665113004 .
-
Jungshik Shin authored
See http://crbug.com/417850 for UTF-32 See http://bugs.icu-project.org/trac/ticket/12147 for C4275 warning from MSVC. BUG=575007 TEST=Layout tests fast/encoding/* TEST=MSVC does not emit C4275 warning any more R=jsbell@chromium.org Review URL: https://codereview.chromium.org/1664293002 .
-
- Feb 03, 2016
-
-
Jungshik Shin authored
patches/wordbrk.patch was not applied by mistake while updating ICU to 56.1. This affects how we break domain names (separated by full stop). We want them to be split at full stop at the cost of 'breaking' cases like "e.g." and "i.e.". All the ICU data files were rebuilt for the change. BUG=575007 TEST=gfx_unittests --gtest_filter=RenderText*Word* TEST=layout tests: css1/text_properties/text_transform.html fast/text/window-find.html editing/text-iterator/findString.html css2.1/t1605-c545-txttrans-00-b-ag.html Review URL: https://codereview.chromium.org/1659833002 .
-
- Feb 02, 2016
-
-
Jungshik Shin authored
Set fLastSetLiteral to U_SENTINEL in the ctor and check if it's still U_SENTINEL before adding the range. BUG=582470 TEST=See comments 13 and 15 in the bug TBR=mmoroz Review URL: https://codereview.chromium.org/1656003004 .
-
Jungshik Shin authored
This is to cherry-pick a fix for http://bugs.icu-project.org/trac/ticket/12130 It's done by merging commit '2b12f877' (for m49 branch) to master. (ICU's m49 branch was fixed first because ICU master was in the middle of upgrading to ICU 56.1). BUG=575206 TEST=See comment 51 in the bug TBR=mmoroz@chromium.org Review URL: https://codereview.chromium.org/1662453002 .
-
Jungshik Shin authored
MSVC complains about '*/* foobar */'. Add a space between '*' and '/'. ICU uses a deprecated API internally and '-Wno-deprecated...' flag has to be turned on on Android as well as on Linux. Do not use ''-Wno-reorder' any more because it's not necessary. BUG=575007 TEST=Once rolled, Android and Windows build go through. R=thakis@chromium.org Review URL: https://codereview.chromium.org/1646623006 .
-
- Jan 29, 2016
-
-
Jungshik Shin authored
* Update the pre-built ICU data files for all platforms source/data/in/icudtl.dat for non-Android platforms {linux,mac}/icudt*.S for linux/mac android/icudtl.dat and android/icudt*.S for Android windows/icudt.dll for Windows * Update Android data trimming script 1. Make sure that 'default' calendar is kept in locales where it's relevant : root, th, fa, ar_SA, etc. 2. Add a minimal region data to work around a bug in ICU with pool.res handling * Update gn and gyp files * And add a TODO comment to update.sh to automate the build file update. * Add it_CH to the locale list. * Add sr_Latn to unit/reslocal.mk (required by sh) and line_normal_fi to brkitr/brklocal.mk (referred to in brkitr/fi.txt) in place of line_fi. * Update and add scripts for data building * Completely rewrite README.chromium * Check-in the prebuilt ICU data files/assembly sources for Linux,Mac,Windows,Chrome OS and Android. BUG=575007 TEST=Blink layout tests, webkit unittests TEST=All bots can build successfully TEST=net_unittests --gtest_filter="*ilenameUtil*" TEST=net_unittests --gtest_filter="*IDN*" (pending bug 336973) TEST=base_unittests --gtest_filter="*Conv*" TEST=browser_tests --gtest_filter="*ncoding*" TEST=base_unittests --gtest_filter="*essage*" TEST=ui_base_unittests --gtest_filter="*ormat*" TEST=ui_base_unittests --gtest_filter="L10n*" R=mark@chromium.org Review URL: https://codereview.chromium.org/1639543006 .
-
Jungshik Shin authored
Below is the list of changes in reverse order. 1. Drop uconv.patch (upstream took my patch) 2. Apply data.build.win and data_sym patches 3. Apply vscomp.patch and update the patch file. update README.chromium about two parts of the patch that are not necessary any more. 4. Apply wpo patch and update the patch file 5. Android brkitr adjustment * Do not apply the patch but just updates the patch * Do not use CJdict on Android to save 2MB in the data size. 6. Clean up brkitr patches * Rename brkitr.patch to wordbkr.patch and keep only word.txt diff * Make a new linebrk.patch with line breaking adjustment (dropping loose rules to save space until the upstream implements space-efficient mechanism for line breaking rule variations) * Update README.chromium * Apply local patches for Khmer dictionary handling and cjdict 7. Adjust line breaking rules. This corresponds to set 2 in https://code.google.com/p/chromium/issues/detail?id=575007#c6 BUG=575007 TEST=None R=mark@chromium.org Review URL: https://codereview.chromium.org/1637683002 .
-
Jungshik Shin authored
1. Apply post-56 patches from the trunk for measure/date format http://bugs.icu-project.org/trac/ticket/11986 http://bugs.icu-project.org/trac/ticket/12031 http://bugs.icu-project.org/trac/ticket/12030 http://bugs.icu-project.org/trac/ticket/12041 2. Generate a combined patch (measure_format.patch) for the above. 3. Split locale_google.patch into 'locale_google.patch' and 'relative_date.patch'. The latter is taken from Android. 4. Update README.chromium Besides, apply two local patches : {tzdetect,xlit..}.patch and adjust gb18030.ucm and the corresponding patch Also, remove obsolte patches and update README.chromium BUG=575007 R=mark@chromium.org Review URL: https://codereview.chromium.org/1621943002 .
-
Jungshik Shin authored
1. AM/PM, midnight, noon formatting for a few Indian locales 2. Currency signs in ru/uk/tr locales 3. Region name change for Hong Kong and Macau in all locales 4. Timezone name changes in Korean and Chinese locales 5. Internval format changes from AOSP: https://android.googlesource.com/platform/external/icu/+/f9ffd5b%5E%21/#F0 6. Minor locale changes for Korean: locale1.patch BUG=575007 TEST=None R=mark@chromium.org Review URL: https://codereview.chromium.org/1625623003 .
-
Jungshik Shin authored
Make the tree ready for the application Google's and Chrome's data and post-56 code patches. 1. Fix trim_data.sh to run from anywhere. 2. Update patch_locale.sh for Android and add en_IN to the locale list 3. Apply data.build.patch 4. Exclude non-UI locale data for unit locale category 5. Add some regional variant locales to locale, unit, zone and coll. 6. Update locale lists for locale, unit, zone, and coll BUG=575007 TEST=None R=mark@chromium.org Review URL: https://codereview.chromium.org/1624643003 .
-
Jungshik Shin authored
Run scripts/update.sh to get icu 56.1 from the upstream while preserving local configuration files and converter files. BUG=575007 TEST=None Review URL: https://codereview.chromium.org/1621843002 .
-
- Jan 07, 2016
-
-
Jungshik Shin authored
Add scripts/udpate.sh that automates the initial check-out of a new version of ICU. BUG=575007 TEST=None R=mark@chromium.org Review URL: https://codereview.chromium.org/1566043002 .
-
- Dec 14, 2015
-
-
Jungshik Shin authored
* Big5 : https://www.w3.org/Bugs/Public/show_bug.cgi?id=27878 Special case the following four more code points in addition to U+5341, U+5345 that are already special cased. U+2550, U+255E, U+2561, U+256A For those 6 code points, the last pointer instead of the first pointer in index-big5.txt is used for round-trip. The first pointer is for decoding-only. * KOI8-U ( https://www.w3.org/Bugs/Public/show_bug.cgi?id=17053 ) - 0xAE and 0xBE are mapped to U+04[50]E instead of U+255[DC]. - Add an alias KOI8-RU BUG=544228 TEST=1. http://goo.gl/reGQPU : encoding(form) test 2. Layout test: fast/encoding/* R=jsbell@chromium.org Review URL: https://codereview.chromium.org/1514253003 .
-
- Nov 03, 2015
-
-
Peter Kotwicz authored
The new GN rule will enable removal of code which copies icudtl.dat in Android GN code (for instance "copy_content_shell_assets"). BUG=547162 R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1419583008 .
-
- Oct 01, 2015
-
-
Brett Wilson authored
Previously GN would implicitly make a group's deps public. I'm making this behave like other target types, so ICU's group's deps need to be public to forward the build information to dependents. TBR=dpranke@chromium.org Review URL: https://codereview.chromium.org/1374173003 .
-
- Sep 25, 2015
-
-
Jungshik Shin authored
In line 1105 of rbt_pars.cpp, variablesVector.elementAt(j) is cast to |UnicodeSet *|, but sometimes it's |Quantifier *|. Casting to a common parent class |UnicodeFunctor *| seems to work (this patch), but it may hide a deeper issue. Further investigation will be done in the upstream bug: http://bugs.icu-project.org/trac/ticket/11937 This CL was independently made by krasin@ and jshin@. ( https://codereview.chromium.org/1366563006/ ) BUG=528799 TEST=wtf_unittests --gtest_filter="*ToUpp*" and --gtest_filter="*ToLow*" with both regular and cfi build. TBR=krasin@chromium.org Review URL: https://codereview.chromium.org/1369653003 .
-
- Aug 25, 2015
-
-
Nico Weber authored
The warning complains that StringThreadTest is declared in the global namespace, but the friend line says `friend class StringThreadTest;` instead of `friend class ::StringThreadTest`. MSVC doesn't require this ::, but gcc does -- without it, the friend line declares a new class in the namespace containing UnicodeString. Since StringThreadTest was in test/threadtest which isn't built as part of Chromium's build and which was removed in upstream ICU in ICU 37392, just delete the friend line, it has no effect. BUG=505296 R=jshin@chromium.org Review URL: https://codereview.chromium.org/1317603003 .
-
- Aug 18, 2015
-
-
Nico Weber authored
Also add a few comments to the .gn file. BUG=505316 R=jshin@chromium.org Review URL: https://codereview.chromium.org/1301493002 .
-
Nico Weber authored
1. In Win32NumberFormat, rename the private format() method to variadicFormat(). It's just an implementation detail of the class. Fixes: ..\..\third_party\icu\source\i18n/winnmfmt.h(146,20) : error(clang): 'icu_54::Win32NumberFormat::format' hides overloaded virtual functions [-Werror,-Woverloaded-virtual] UnicodeString &format(int32_t numDigits, UnicodeString &appendTo, const wchar_t *format, ...) const; ^ ..\..\third_party\icu\source\i18n\unicode/numfmt.h(255,28) : note(clang): hidden overloaded virtual function 'icu_54::NumberFormat::format' declared here: different number of parameters (4 vs 3) virtual UnicodeString& format(const Formattable& obj, ^ ... 2. In Win32DateFormat, remove the two-argument format() function that just forwards to the base class. (If this happens to produce compile errors, the function should be replaced by `using Win32DateFormat::format(UDate, UnicodeString&) const;`) Fixes: ..\..\third_party\icu\source\i18n/windtfmt.h(55,20) : error(clang): 'icu_54::Win32DateFormat::format' hides overloaded virtual functions [-Werror,-Woverloaded-virtual] UnicodeString& format(UDate date, UnicodeString& appendTo) const; ^ ..\..\third_party\icu\source\i18n\unicode/datefmt.h(240,28) : note(clang): hidden overloaded virtual function 'icu_54::DateFormat::format' declared here: different number of parameters (4 vs 2) virtual UnicodeString& format(const Formattable& obj, ^ ... BUG=505301 R=jshin@chromium.org Review URL: https://codereview.chromium.org/1296803002 .
-
- Aug 05, 2015
-
-
Brett Wilson authored
The Chromium build currently defines both is_component_build (boolean) and component_mode (a string). We're trying to standardize on the boolean. TBR=jshin Review URL: https://codereview.chromium.org/1273843002 .
-
- Jul 16, 2015
-
-
Jungshik Shin authored
Upstream CL : http://bugs.icu-project.org/trac/changeset/37670 BUG=508444 TEST=See bug R=inferno@chromium.org Review URL: https://codereview.chromium.org/1233663005 .
-
- Jul 14, 2015
-
-
Jungshik Shin authored
This is going back to PS #4 in https://codereview.chromium.org/1148463002/ BUG=466959, 508049, 508440 TEST=See bugs TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1237873002 .
-
Jungshik Shin authored
Takes an upstream patch (to be included in 56.x release) and patch our ICU 54. Clang-specific atomic ops will be used when clang is used to compile but C+11 atomic is disabled/unavailable. patch: http://bugs.icu-project.org/trac/changeset/37326 bug: http://bugs.icu-project.org/trac/ticket/11599 BUG=466959,508049,508440 TEST=See bugs R=glider@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1148463002 .
-
- Jul 06, 2015
-
-
https://codereview.chromium.org/1224463003/Nico Weber authored
No intended behavior change (except fewer duplicated compiler flags). BUG=505319 TBR=mgiuca@chromium.org Review URL: https://codereview.chromium.org/1220363002.
-
- Jul 03, 2015
-
-
Matt Giuca authored
This warning is currently globally suppressed in Chromium, but this suppression will be switched off, making a local suppression necessary. BUG=505319 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1224463003.
-
- Jul 01, 2015
-
-
Sam McNally authored
BUG=505304 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1215103002.
-
- Jun 30, 2015
-
-
Daniel Cheng authored
Some Windows-specific ICU code uses this pattern, which triggers a clang warning. BUG=505302 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1209413007.
-
- Jun 23, 2015
-
-
Dirk Pranke authored
R=brettw@chromium.org, dpranke@chromium.org Review URL: https://codereview.chromium.org/1183493003.
-
- Jun 18, 2015
-
-
http://bugs.icu-project.org/trac/changeset/36672Nico Weber authored
Else clang's -Winfinite-recursion will warn about filteredbrk.cpp BUG=none R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1191653011.
-