Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
F
fuchsia.googlesource.com-third_party-tink
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Model registry
Analyze
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
fuchsia-mirror
fuchsia.googlesource.com-third_party-tink
Commits
6495d823
Commit
6495d823
authored
5 years ago
by
Niklas Keller
Committed by
Thomas Holenstein
5 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Java: Remove e.printStracktrace() in favor of a cause (#207)
parent
d0687dbf
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
java/src/main/java/com/google/crypto/tink/subtle/EngineFactory.java
+9
-14
9 additions, 14 deletions
...ain/java/com/google/crypto/tink/subtle/EngineFactory.java
with
9 additions
and
14 deletions
java/src/main/java/com/google/crypto/tink/subtle/EngineFactory.java
+
9
−
14
View file @
6495d823
...
...
@@ -155,28 +155,23 @@ public final class EngineFactory<T_WRAPPER extends EngineWrapper<T_ENGINE>, T_EN
}
public
T_ENGINE
getInstance
(
String
algorithm
)
throws
GeneralSecurityException
{
for
(
Provider
p
:
this
.
policy
)
{
if
(
tryProvider
(
algorithm
,
p
))
{
return
this
.
instanceBuilder
.
getInstance
(
algorithm
,
p
);
Exception
cause
=
null
;
for
(
Provider
provider
:
this
.
policy
)
{
try
{
return
this
.
instanceBuilder
.
getInstance
(
algorithm
,
provider
);
}
catch
(
Exception
e
)
{
if
(
cause
==
null
)
{
cause
=
e
;
}
}
}
if
(
letFallback
)
{
return
this
.
instanceBuilder
.
getInstance
(
algorithm
,
null
);
}
throw
new
GeneralSecurityException
(
"No good Provider found."
);
throw
new
GeneralSecurityException
(
"No good Provider found."
,
cause
);
}
private
T_WRAPPER
instanceBuilder
;
private
List
<
Provider
>
policy
;
private
boolean
letFallback
;
private
boolean
tryProvider
(
String
algorithm
,
Provider
provider
)
{
try
{
this
.
instanceBuilder
.
getInstance
(
algorithm
,
provider
);
return
true
;
}
catch
(
Exception
e
)
{
// Don't care which one specifically.
e
.
printStackTrace
();
return
false
;
}
}
}
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment