Skip to content
Snippets Groups Projects
  1. Apr 18, 2018
  2. Apr 13, 2018
  3. Apr 12, 2018
  4. Apr 06, 2018
  5. Apr 04, 2018
  6. Mar 31, 2018
    • Thai Duong's avatar
      Excluding failing or slow Android tests and running the rest as presubmit. · 4bec791c
      Thai Duong authored
      The excluded tests are documented at https://github.com/google/tink/blob/master/doc/KNOWN-ISSUES.md.
      
      Also reducing the iterations of some tests to make them run faster.
      
      PiperOrigin-RevId: 191134067
      GitOrigin-RevId: c87ec893094991ff8217bafe8a1c64b16cdb394f
      4bec791c
    • Haris Andrianakis's avatar
      tink-objc: Sync hybrid/BUILD.bazel with hybrid/BUILD. · 6803b6ef
      Haris Andrianakis authored
      PiperOrigin-RevId: 191120531
      GitOrigin-RevId: 2d724585b1ee28ccae0fdb51241bfa1a0b4fc069
      6803b6ef
    • Thai Duong's avatar
      Fixing ECDH tests. · 157277bf
      Thai Duong authored
      1/ Catching unchecked exceptions to not crash the JVM.
      
      Wycheproof found that some Java security providers would throw unchecked exceptions when processing attacker-controlled input. To prevent DoS attacks, we'd catch these exceptions in Tink.
      
      2/ Do not report errors if the shared secret is correct.
      
      Android M and N ignore the public key parameters, thus we'd stop reporting errors in tests that modify parameters if the shared secret is still correct.
      
      3/ Skipping CVE-2017-10176 test because it's not a severe issue.
      
      PiperOrigin-RevId: 191113399
      GitOrigin-RevId: b069f3af3f515b30b5cc1e2af791b226fb0635c5
      157277bf
    • Thai Duong's avatar
      Fixing the pre-Keystore -> Keystore upgrade path. · 3d7f6fe3
      Thai Duong authored
      If Keystore was disabled in the past and cleartext keyset written to storage, then Keystore is enabled, trying to decrypt the cleartext keyset immediately throws a security exception. The existing code assumes that decryption will succeed and generate "junk data", throwing an InvalidProtocolBufferException.
      
      The fix, proposed by pkorth@, is to catch the exception that is actually thrown in this edge case, and fall back to reading the cleartext keyset as intended.
      
      While I'm here, reformatting the code and ensuring that we don't throw unchecked exception when reading keysets from private preferences.
      
      PiperOrigin-RevId: 191108969
      GitOrigin-RevId: b3b53ef357ff326689dd92e906e931adc3ddd409
      3d7f6fe3
    • Haris Andrianakis's avatar
      tink-objc: Update hybrid to use the new config and memory management. · da839c70
      Haris Andrianakis authored
      - Hybrid now holds an std::unique_ptr with the C++ object and frees it in the destructor. This is consistent with the other Obj-C classes.
      - Removed the deprecated registerStandardKeyTypes and replaced it with the new Config model.
      - Updated the tests and build files. In a following CL I will move the tests to the main BUILD file.
      
      PiperOrigin-RevId: 191105535
      GitOrigin-RevId: c52e1dfd6a9189bbc2b48aa6f17be82f74f16783
      da839c70
    • Bartosz Przydatek's avatar
      Replacing pre-generation of Ed25519 Constants by static initialization. · 63c6970a
      Bartosz Przydatek authored
      PiperOrigin-RevId: 191011474
      GitOrigin-RevId: 2225b676b9bb680ae5dc6c7b6051636ab27b95e3
      63c6970a
Loading