Skip to content
Snippets Groups Projects
  1. Aug 13, 2019
  2. Aug 12, 2019
  3. Aug 09, 2019
  4. Aug 08, 2019
    • tholenst's avatar
      Add the streaming_aead_test_util_test to CMake. · c72d510c
      tholenst authored
      This was forgotten in a previous cl.
      
      PiperOrigin-RevId: 262357462
      c72d510c
    • paulavidas's avatar
      Fix ciphertext segment size validation. · 9cdfccc3
      paulavidas authored
      We changed the segment size validation in all Tink streaming keys such that the first block always needs to have room for at least 1 byte of ciphertext. Previously it was not consistent. The decision whether to allow empty ciphertexts in the first segment is somewhat arbitrary, but it should be consistent everywhere.
      
      PiperOrigin-RevId: 262315914
      9cdfccc3
    • tholenst's avatar
      Add using declarations for the type parameters in KeyTypeManagers and use them. · c101e379
      tholenst authored
      We previously used passed an owned raw pointer from registry.h to registry_impl.h, because this makes it possible to infer template parameters (which doesn't work with unique pointers). However, it is better to instead specify the parameters explicitly, which is easiest if we add typedefs to the KeyTypeManager class.
      
      This will also be useful elsewhere (to create [1] automatically).
      
      PiperOrigin-RevId: 262295924
      c101e379
  5. Aug 07, 2019
  6. Aug 06, 2019
  7. Aug 05, 2019
  8. Aug 02, 2019
  9. Jul 31, 2019
    • tholenst's avatar
      C++/Objc Tink: Remove building the RegistryConfig protos. · d73d7be4
      tholenst authored
      These are not needed anymore, since we simply register all key managers directly; they were only needed for catalogue support.
      
      PiperOrigin-RevId: 260986202
      d73d7be4
    • tholenst's avatar
      Stop using the lastest config RegistryConfig from python. · 9e9100ce
      tholenst authored
      We plan to remove these; so we instead manually register all key managers in python.
      
      PiperOrigin-RevId: 260936807
      9e9100ce
    • tholenst's avatar
      Java Tink: Remove building the RegistryConfig protos. · 1054dba0
      tholenst authored
      These are not needed anymore, since we simply register all key managers directly; they were only needed for catalogue support (what's more is: this didn't work properly anyhow, see the explanation in cl/260891485).
      
      PiperOrigin-RevId: 260935372
      1054dba0
    • tanujdhir's avatar
      Fix 'an streaming' typo · 857700b7
      tanujdhir authored
      PiperOrigin-RevId: 260912173
      857700b7
    • tholenst's avatar
      Remove the Register(const KeyTypeEntry&) code and do what we do previously.... · 378fd95b
      tholenst authored
      Remove the Register(const KeyTypeEntry&) code and do what we do previously. Also, simply register everything in the Register(const RegistryConfig&) code.
      
      The only way this can break someone we can think of is when the want to register fewer key managers, and have an implementation of one which they want to use instead, so a call to RegisterKeyManager now fails; this seems very unlikely and would be easy to detect and fix.
      
      This should allow me to get rid of the config generation code.
      
      PiperOrigin-RevId: 260902291
      378fd95b
    • tholenst's avatar
      Java: remove the remaining catalogues. · 465910be
      tholenst authored
      PiperOrigin-RevId: 260899742
      465910be
    • tholenst's avatar
      Deprecated the KeyTypeEntry proto and the RegistryConfig proto · 4fde5860
      tholenst authored
      PiperOrigin-RevId: 260897053
      4fde5860
    • tholenst's avatar
      Java: Remove the streaming aead catalogue. · 6972ff06
      tholenst authored
      Catalogues are no longer supported, instead we register key managers directly.
      
      Removing these in Java is actually more easy than in C++ because the static initialization basically broke the functionality already: for example, suppose someone calls
      
      Config.register(AeadConfig.TINK_1_0);
      
      Then, presumably he wants to have the Aead's in the binary which were present in Tink 1.0. However, what happens is that due to accessing AeadConfig.TINK_1_0, the static initialized in AeadConfig runs, which calls AeadConfig.register() internally. This then calls Config.register(LATEST), so that the user anyhow gets all the key managers, also those only present in later versions (e.g. XChaCha20Poly1305Key).
      
      PiperOrigin-RevId: 260891485
      6972ff06
    • tanujdhir's avatar
      Fix a typo. · 107b91b2
      tanujdhir authored
      PiperOrigin-RevId: 260886081
      107b91b2
  10. Jul 30, 2019
Loading