Skip to content
Snippets Groups Projects
  1. Oct 02, 2018
  2. Sep 20, 2018
    • Thomas Holenstein's avatar
      Remove the main files from (hopefully) all tests. · 6a4c9498
      Thomas Holenstein authored
      Our tests are linked with gunit_main (or gunit_main_no_google3), which means that main is already defined in another translation unit. Having two main functions violates ODR and hence can result in undefined behavior.
      
      There is no need to fear losing tests. If a build system tries to run a test and there is no main function, then it will fail. Hence, i cannot see a way for this to stop testing a test.
      
      PiperOrigin-RevId: 213593596
      GitOrigin-RevId: 1fd8b2dcc18d24901d77170082587557cc5303e3
      6a4c9498
  3. Aug 01, 2018
  4. Jul 06, 2018
  5. Jul 03, 2018
  6. Jun 27, 2018
    • Daniel Bleichenbacher's avatar
      Adding a version of AES-EAX using boringssl as underlying · dd39e299
      Daniel Bleichenbacher authored
      library.
      
      Things not done:
      Things to check:
      - The code does not use EVP. There are plans to just add code in assembly.
        Hence this is kind of backup code for the case where AES instructions are
        not available. Hence it is unclear whether using that horrible EVP interface
        makes sense.
      - depot/google3/security/util/crypt/ contains a version of AES_EAX using
        EVP. The main problem with this implementation is that it is not thread safe.
      - The code needs unaligned big-endian load and store. I have not been able
        to find a function that achieves this efficiently. Compilers can sometimes
        (but not always) optimize the load or stores.
      
      PiperOrigin-RevId: 201177778
      GitOrigin-RevId: 2601a0d6eb42804747718f283761774922cdf8f5
      dd39e299
Loading