Commits · daaaacb35172763eb9d774f893442117ed0e5d64 · fuchsia-mirror / fuchsia.googlesource.com-third_party-tink

Sep 06, 2017

Add support for Android Keystore as a KMS. · daaaacb3

Thai Duong authored 7 years ago

Unfortunately there is no test, as Bazel has not supported testing with
android_test yet, see https://github.com/bazelbuild/bazel/issues/903.
I'll add tests once we sync this to Google internal.

Also move AWS KMS integration code to integration.awskws and GCP KMS to
integration.gcpkms.

Change-Id: Idb715310f870a975ca6bcd2a314618680ab91fb9
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: dc397b0d2ad53deb6d98ce739626fce39a94e656

daaaacb3

Replacing text option with JSON in Tinkey. · fbd55bdd

Thai Duong authored 7 years ago

Exception: key templates are still text because they have comments
which are not supported in JSON.

Change-Id: Ifb00c32d0159beaf0391fa6a324e563254f8059a
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: ec95e3fa65912e89426a49129d9fd19cc108276f

fbd55bdd

Adding description of primitives, updating description of interfaces. · 23a1d504

Bartosz Przydatek authored 7 years ago

Change-Id: I9d172a416d89c1159155823304d9977447f7fb71
ORIGINAL_AUTHOR=Bartosz Przydatek <przydatek@google.com>
GitOrigin-RevId: a004f09da80b6ad1ffc39d113c4c0f6167841c6b

23a1d504

Moving com.google.payments to com.google.crypto.tink.apps.paymentmethodtoken. · 76bca789

Thai Duong authored 7 years ago

This is needed to ensure that the Maven artifacts of this app can be
managed by Tink team.

Also moving apps/googlepayments to apps/paymentmethodtoken, fixing Javadoc
errors, and adding pom.xml.

Change-Id: I2804d6cac5f4462d991e3b4b2f1974f091e965e2
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: bd6c0896199ff18ccc93cd35385ab9edaa7bcf9f

76bca789

Fix KeysetHandle for Obj-C so that it hides the C++ KeysetHandle. · b093c386

Haris Andrianakis authored 7 years ago

Change-Id: If142d76a200e13ca7ac91a38a2f2e958b2b62b92
ORIGINAL_AUTHOR=Haris Andrianakis <candrian@google.com>
GitOrigin-RevId: 4c2d343d902663fa3e67824df417643c9ec1713a

b093c386

Fix Lint and compatibility errors. · 7a0dc039

Thai Duong authored 7 years ago

Change-Id: I8ae127ab0766ccb22343cec77d4f1f5212789620
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 077164429d1694dc65e43432d16275eb6171143c

7a0dc039

Sep 01, 2017

Fix Javadoc errors in public APIs. · 1269d811

Thai Duong authored 7 years ago

Change-Id: Ia165a22dd2261dd31e6a373d5951da1d2dbfdcbc
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: e5fb1e8eb6de60312eeedf88227e75e04735d2c5

1269d811

Fixing Maven issues and run Maven as a presubmit check. · 588b6407

Thai Duong authored 7 years ago

Also fixing Javadoc issues in XyzConfig classes and temporarily
removing registry/config logging.

Change-Id: I1032d7c3e9409ab2bbcb126fc2d99e1651e0959d
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: f50e21a56939e97b8ce1d87029386a8d02ed7c73

588b6407

Style cleanup after sync. · 1913b433

Bartosz Przydatek authored 7 years ago

Change-Id: Ic497392503b9e6ffb129b039895fc5a2fc5a02ac
ORIGINAL_AUTHOR=Bartosz Przydatek <przydatek@google.com>
GitOrigin-RevId: 19648fdb4d66c4d93db5e85125cacc87ea3b9485

1913b433

Fixing style issues. · cc8d6273

Bartosz Przydatek authored 7 years ago

Change-Id: I4f928caa6fbd877d2169fee572ae5c0381460e0b
ORIGINAL_AUTHOR=Bartosz Przydatek <przydatek@google.com>
GitOrigin-RevId: cbcaf65319ea010372050ac9ddd6bbc8d7f82c91

cc8d6273

Add tests for the Obj-C hybrid implementation · 7dddc4e0

Haris Andrianakis authored 7 years ago

Change-Id: Id21248b58980281e215d89c41d5cac5bb8054aa9
ORIGINAL_AUTHOR=Haris Andrianakis <candrian@google.com>
GitOrigin-RevId: 0766c349904b00f32db19a6dfb4978cbdef02772

7dddc4e0

Move util to crypto::tink::util. · 14f57e6f

Thai Duong authored 7 years ago

Change-Id: I2e628298c31e26da0067196634b5dc4d3bd5ed84
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 9b88cb7f7aad68ff16094ab7ff6a3a1620f58cd5

14f57e6f

Implements all the Hybrid crypto classes for Obj-C. · fa20557a

Haris Andrianakis authored 7 years ago

TINKHybridDecrypt: Public protocol that describes the functions implemented by
the crypto primitives returned by TINKHybridDecryptFactory. The developer
will use TINKHybridDecryptFactory to get a primitive that conforms to this
protocol.

TINKHybridDecryptConfig: Public configuration interface. The user creates an
instance and uses it to configure the TINKHybridDecryptFactory.

TINKHybridDecryptFactory: Public Factory that returns the crypto primitives.
This is the only way to get a crypto primitive (TINKHybridDecrypt).

TINKHybridDecryptInternal: Internal-only class that's used to implement the
crypto primitives. The user is not allowed to use this class to create a
crypto primitive. Instead he should use the TINKHybridDecryptFactory. This
class conforms to the public protocol TINKHybridDecrypt.

TINKHybridDecryptKeyManager: Parent class of all HybridDecrypt key managers.
Doesn't contain any functionality we just use it to restrict the type of
customKeyManagers that can be accepted by TINKHybridDecryptConfig.

TINKPBEciesAeadHkdfPrivateKeyManager:
TINKPBEciesAeadHkdfPublicKeyManager: These are both custom key managers that
can be used with the TINKHyrbidDecryptConfig. After syncing with Thai these
might not be needed as the user will have to implement and supply his own
custom key managers.

Change-Id: I006ab7ea705bb913e068baf892981c1dc4f7cfb5
ORIGINAL_AUTHOR=Haris Andrianakis <candrian@google.com>
GitOrigin-RevId: 4a03068d668054fb314264c3e137bdec5a06b07b

fa20557a

Add JSON Keyset readers and writers. · 65e5b488

Thai Duong authored 7 years ago

Change-Id: Icb2327285c65bc656e35d37183cc42af3eb72138
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: b37b6c3013ada55d92666b303fa109842a60bda9

65e5b488

Add per-primitive Configs and Catalogues. · c0e08474

Thai Duong authored 7 years ago

Some refactoring:

- Moving the registration of catalogue to Registry. Does NOT allow
overwriting catalogues.

- Deprecating registerStandardKeyTypes.

- Ensuring that primitive-specific tests register only the corresponding
key types.

- com.google.crypto.tink.config.Config becomes
com.google.crypto.tink.Config and does not depend on any primitives.

- com.google.crypto.tink.proto.TinkConfig is renamed to
com.google.crypto.tink.proto.RegistryConfig.

- Add com.google.crypto.tink.crypto.config.TinkConfig that depends
on all primitives.

Examples:

- To register all Aead primitives in Tink 1.0.0:

Config.register(AeadConfig.TINK_1_0_0);

- To register all primitives:

Config.register(TinkConfig.TINK_1_0_0);

- To use custom catalogues and configs:

Register.addCatalogue("name", MyCatalogue());
RegistryConfig customConfig = ...;
TinkConfig.init();
Config.register(customConfig);

Change-Id: I7e593e1c3f1f404555e02672c0d0a3a214b660d9
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 0c99b04cf280f6b30e315521860315c8d65e27c7

c0e08474

Adding basic test for Validators. · 1a33b6f2

Bartosz Przydatek authored 7 years ago

Change-Id: Iaba9492fd29e067b729a13f0a7f747dafd333c8a
ORIGINAL_AUTHOR=Bartosz Przydatek <przydatek@google.com>
GitOrigin-RevId: 34518c31e45494478fc3eb1f3d0a7c5b6073c1af

1a33b6f2

Add more commands to Tinkey and corresponding APIs to KeysetManager. · 0db7e600

Thai Duong authored 7 years ago

Change-Id: I4a86ffe9fc11d1f22e92dc88c81f9418f6d643d7
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 4d2dc50e5e3725c7df048d015746680cc13dc433

0db7e600

Aug 23, 2017

Do not throw exception when repeatedly registering the same key manager. · e6e20e01

Thai Duong authored 7 years ago

Change-Id: Ic9742cd59ccbfb02ff7b6ed177f5c3749be64281
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: fbb44dcb49f28fc38684644088b6fa1f5ce25f6e

e6e20e01

Set public classes final and non-public class package-private. · 79c57ff6

Thai Duong authored 7 years ago

Change-Id: If26f2f79ec36416b63f1e776894aeb5a8fd5fcbb
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 65db81ba4da5f3a74df647de798ee6f5b3acf888

79c57ff6

Move validating functions to subtle.Validators. · b9539d21

Thai Duong authored 7 years ago

This finally allows us to make SubtleUtil package private.

Change-Id: I05466ac2fac69fa61e2571a1391b45cd35954f7e
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 33c1df6196afe149fac09689cd059e132cfedf94

b9539d21

Rename subtle.EcUtil to subtle.EllipticCurves which is more descriptive. · fd90717a

Thai Duong authored 7 years ago

Change-Id: I4792c3532258418be121aae43d30462deed90414
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: ab0a5c0539d0f952bb35c671a47da32e5ef7d5bf

fd90717a

Add base64 and move hex and bytes utils to their own classes. · 28284120

Thai Duong authored 7 years ago

Change-Id: I4928ff37fc8743f30902aef34dd42473071d7845
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 131ffa255ca84589a3fc3d77f00a60ffeba760b1

28284120

Checking messageExpiration in PaymentMethodTokenRecipient. · a8ff6c22

Google Engineers authored 7 years ago

Change-Id: I712abfcf9712175471dd3f0f29d66a5f8f7265f6
ORIGINAL_AUTHOR=Google Engineers <noreply@google.com>
GitOrigin-RevId: ee27f3ae2d40c20c49a00e59def5ed08297063ca

a8ff6c22

Fix Lint and compatibility issues. · 29e29eb5

Thai Duong authored 7 years ago

Change-Id: I62a4a98c2ebf5651576a42c065e9ea3582b1f041
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: d7860b81c481959dfd6fac540026ba3c9747fa4a

29e29eb5

Use the new KmsClient API in Tinkey. · 9cb632d7

Thai Duong authored 7 years ago

Also implement the Add and Rotate commands and refactor Tinkey's unit tests.

Change-Id: Ifa30c8e00415a91eb7d2410eed73a95f1914546a
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 2e3a8a8d05243d4da464169c3597eb2e83e400d5

9cb632d7

Aug 17, 2017

Add an implementation of Google Payment Method Token standard. · 4ab63a2d

Thai Duong authored 7 years ago

Change-Id: Ie2590b090ef518cde78f74225a7df9f70835829a
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 6d9c372020e9ab2580572dd90aeaee5deabd62da

4ab63a2d

Re-add CleartextKeysetHandle#parseFrom which is used in a client. · 52e523e3

Thai Duong authored 7 years ago

Change-Id: I27f1243eeff8c89dd90c68d17685bbbe216bcac6
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: b3b0c5c0a947be89f278685b4a8ac6b58634a849

52e523e3

Add APIs for registering and loading KmsClient impls. · 59a30aaf

Thai Duong authored 7 years ago

Also provide an API that automatically load KmsClient impls annotated
with @AutoService using java.util.ServiceLoader. Tinkey will use this
API to talk to custom, in-house KMS.

Change-Id: Id1cabb6a17df96597afb10f3b4bd1f9331bc0c67
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: a6a18a88fef36b17c58b4bc4e18df91d73e94ffa

59a30aaf

Adding helpers for Tink configuration. · c87880f1

Bartosz Przydatek authored 7 years ago

Change-Id: I7076732524ac5e6da6455456f01c281717dbe435
ORIGINAL_AUTHOR=Bartosz Przydatek <przydatek@google.com>
GitOrigin-RevId: c4fbef5be03f00715d87aab3030f259e2fa0eec4

c87880f1

Change all methods in Registry to static. · 73ca35b5

Thai Duong authored 7 years ago

This changes our APIs from Registry.INSTANCE.getPrimitive(...)
to Registry.getPrimitive() which is nicer.

Change-Id: I1708150d9dd83df8ec36491e5c6d4c991f86f7f6
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 9f92a005a91d943f2a0ea9592e9e02249e6fd064

73ca35b5

Temporarily remove the EnvelopeMe example. · ab0ab53d

Thai Duong authored 7 years ago

Reason: this example is deprecated because it's using a set of APIs
that are going through heavy refactoring. I've written a new example,
but it needs to wait until the refactoring is done.

Change-Id: I78187c6e713f521f7695130ba846469ac69bcf9e
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 4153a2bf758e9afd2fc081b5d28dfc81d7f5bc31

ab0ab53d

Obj-C implementation of mac and initial support for objc protos. · 1696b8ca

Haris Andrianakis authored 7 years ago

Change-Id: I7d5c19b8ba195516f305ecc7a9c96366f98e4c89
ORIGINAL_AUTHOR=Haris Andrianakis <candrian@google.com>
GitOrigin-RevId: a9cd65c470ac24270bd4e865ba83637a15209887

1696b8ca

Aug 14, 2017

Only CleartextKeysetHandle is allowed to read/write cleartext keysets. · b24b6575

Thai Duong authored 7 years ago

Also renaming fromKeysetReader to read.

Change-Id: I3266583ed1fa8a155ed882508dd93423304c07b1
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: a2187fc5d1d0a6d0e0c6b9f2aed354edbae2c287

b24b6575

Make KeysetHandle.getKeyset() package-private. · 63aa979e

Thai Duong authored 7 years ago

This is part of an effort to ensure that users cannot freely read/write
cleartext keysets.

Change-Id: Ib694a33279808938a0b8923f920a2ed99ad7be9c
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 8682d887f14a7286650bdbd3f26c83a4a4087990

63aa979e

Moves Poly1305 algorithm to Poly1305.java. · 4c626dd5

Erhan Nergiz authored 7 years ago

Change-Id: Ic18dddb3d24d4b39c87950a3900e0df3c9f0df19
ORIGINAL_AUTHOR=Erhan Nergiz <anergiz@google.com>
GitOrigin-RevId: dfc34a2fe9b8a3b6fc4ee86582910aa912eabd11

4c626dd5

Aug 11, 2017

Refactor keyset handles and add KeysetReader and KeysetWriter. · fd2c97a7

Thai Duong authored 7 years ago

KeysetHandle can read encrypted keysets from KeysetReader, and write
cleartext or encrypted keysets to KeysetWriter. This allows removing
EncryptedKeysetHandle and CleartextKeysetHandle.generateNew.

Also:
- Remove KeysetManager.Builder.
- Add a bunch of useful keyset readers and writers.

Change-Id: I5eb0681232c19fc435d08e9373a7a9edbdab958c
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 9bfaa1539963ed21ff223939798b20dd13bd64d9

fd2c97a7

Emphasizes Mac.java interface is for multi-time MACs · 9021dd8e

Erhan Nergiz authored 7 years ago

Change-Id: Ie13878c2bc60227c70a3d785029c6b76c73874b5
ORIGINAL_AUTHOR=Erhan Nergiz <anergiz@google.com>
GitOrigin-RevId: 6ca24e5da13f9ee64878e60a5648c2a15fc1bc2c

9021dd8e

Set OutputPrefixType as a field of the KeyTemplate proto. · 8d3bf858

Thai Duong authored 7 years ago

This ensures that all APIs that generate new keys from KeyTemplate can
generate keys with non-TINK prefix types.

If a key template proto does not contain an output prefix type, uses
the TINK prefix type.

Change-Id: I041c335eabaa87c41c88bbe5e51ee02c867b6970
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 87d37eb7bba823db0b5f00f70ca247ffcc1d1ade

8d3bf858

Make com.google.crypto.tink independent of com.google.crypto.tink.subtle. · 35e795ba

Thai Duong authored 7 years ago

This allows users that just want to use the former not to have to include
the later.

Change-Id: I13d282104d9b5dc0c963a756e67bed54f6c6b238
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 78c186af2d9bbf25dd20712e78950f8454eda1dd

35e795ba

Modifies XChaCha20Poly1305 to use IETF version of the Poly1305. · 89f3b725

Erhan Nergiz authored 7 years ago

Change-Id: If31a9090b415dc0ea877417b9ecc33ad082bb583
ORIGINAL_AUTHOR=Erhan Nergiz <anergiz@google.com>
GitOrigin-RevId: e904dd01bc42e6112493f3046c2a2d2e17818dc1

89f3b725