Commits · ee6b44b1495f46bc9b11f0ddddafa7e8a6832f52 · fuchsia-mirror / fuchsia.googlesource.com-third_party-tink

Oct 26, 2017

Downloading maven jars with java_import_external which is faster. · ee6b44b1

Thai Duong authored 7 years ago

Change-Id: I01b6b387b8a3e384412290ed7373cd013d62c3da
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: b96305caccc0de6831482810d64d3fd3b7374bf0

ee6b44b1

Upgrading bazel to the latest version before running tests. · 18f94fc5

Thai Duong authored 7 years ago

This is a temporary workaround until Kokoro upgrades its copy.

Change-Id: I018f04ef495f7135fd0b235aed0b8195e6f2e562
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: d8be177e1e9b982d4e2f73566fbb280465af31bb

18f94fc5

Allowing Kokoro to access our copy of JDK on X20. · fdbecf82

Thai Duong authored 7 years ago

Change-Id: I224c3b48973c56ab6d0689e74588fa951af1ad30
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: a68bbb90236ddf5c32e0dc927cb12dca01aa1221

fdbecf82

Disable Ecdsa's 31-th testcase. · e4577ff2

Quan Nguyen authored 7 years ago

Change-Id: I8811d5b2f4ca0aa63643eaf4e35d8317d4975b99
ORIGINAL_AUTHOR=Quan Nguyen <quannguyen@google.com>
GitOrigin-RevId: 7f01d6b4b65e3d2545b8690f8e32aef8e823a1c4

e4577ff2

Replacing StringPiece with const std::string& when it makes sense. · 34de6dd9

Thai Duong authored 7 years ago

This makes sense if the StringPiece is converted to std::string
with StringPiece.ToString() which does copy the string, thus should
be avoided.

This also makes the migration to absl::string_view easier. Somehow
one cannot pass a string_view to methods that take const std::string&
(it's possible to do that with StringPiece so I guess it's because
string_view does not provide an implicit conversion to const std::string&,
but I'm not sure).

Change-Id: Ic905a78752c63ac60f25d73ba7898f723e41d9df
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: fbd1fb69494ac4b9b982804c86fcae1f2902aef7

34de6dd9

Explicitly reconstruct the public key using private's key curve. · 89146caa

Quan Nguyen authored 7 years ago

Make the test failed with modified public key.

Change-Id: I638ba24ca03c162d20a5dce07938f6a4c1fcfbe8
ORIGINAL_AUTHOR=Quan Nguyen <quannguyen@google.com>
GitOrigin-RevId: c68cb8eb63ffee64f02d86ed0715c64bb200f5c1

89146caa

Using streams instead of channels for streaming encryption. · 5d68cda4

Thai Duong authored 7 years ago

Structure of the streaming encryption:

StreamingAead.java  the interface for the streaming primitive. Instances
of this
  contain a key and can construct streams for encryption and decryption.
NonceBasedStreamingAead an abstract implementation of StreamAead based
on the paper
  https://eprint.iacr.org/2015/189.pdf
  This class is abstract since it defines for example no cipher.
StreamingAeadSegmentEncrypter.java An interface for a class that
encrypts segments in
  NonceBasedStreamingAead.
StreamingAeadSegmentDecrypter.java The same for decrypting segments.

AesCtrHmacStreaming.java A subclass of NonceBasedStreamingAead that uses
Aes in CTR mode
  with HMAC to implement the cipher.
AesGcmHkdfStreaming.java Another subclass of NonceBasedStreamingAead
that uses Aes-Gcm
  as underlying cipher.

StreamingAeadDecryptingChannel.java
  A ReadableByteChannel based on NonceBasedStreamingAead

State of this CL:
- Encryption and Decryption with Streams did pass all tests.
- Tests with files and streams are still missing.
- Tests with writers and streams are still missing.
- thread safety.

This CL is the result of merging Daniel's cr/169684739.

Change-Id: Id64336a2f538fee2b15a2a9f01e9e24dfa6c35b3
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 9802e0ee9bae44f4247975873ee1143e8a34b620

5d68cda4

Moving common hybrid encryption methods to subtle.EllipticCurves. · 96eb5b9d

Thai Duong authored 7 years ago

When computing the ECDH shared secret, validating that the public key's
domain paramters are the same as the private key's. Also validating
that the ECDH shared secret is a x-coordinate of a valid point on the
private key's curve.

Adding tests and removing the useless checkPublicKey function.

Change-Id: I3c5400d6f3cced3e26a7d159d09c3087f6128dd3
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 407b8b44ec0281c1bcf680ba3438f53ee96323ab

96eb5b9d

Skipping tests that don't work on Android. · 7da15cdf

Thai Duong authored 7 years ago

Change-Id: Ia4e811b225f95d119358dd9090eb7f8f2475e526
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: b9631e4dc85f8ec1fe4153c448b18d52a43b0b0b

7da15cdf

Fixing compat and Lint errors when syncing to google3. · 01b7aff1

Thai Duong authored 7 years ago

Change-Id: Ib1af3c9b6d297d45df29cf09de74ebc0a6e9bebe
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 82f37cd1d3287c16ea62e2f4cd3dd3df93bba1b5

01b7aff1

Adding to //cc:cc headers for public APIs. · 7974387b

Thai Duong authored 7 years ago

Change-Id: Ia03fe3c51d79f608617975807451cfe188fb4ed2
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: e54c1e40a5736d71ef7d9dd63cb64aea694eb4c8

7974387b

Cleaning up BUILD files, setting default visiblity to internal packages. · aa784310

Thai Duong authored 7 years ago

Change-Id: Idc91dd3978d7d3456fdce281541c6a8dd6f10dec
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 005561b04d1f26f32e2fb77d0c07e92aeb839123

aa784310

Adding AES-CTR-HMAC-AEAD in C++ hybrid encryption. · 301e7ae9

Thai Duong authored 7 years ago

Change-Id: Ie92cb3bffd8728e003961723a7c8393fd00205fd
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 9c3ae95b9ff53cdc4a3bffd7afc0ba2155539fc8

301e7ae9

Adding AesCtrHmacAeadKeyManager. · 0df23c2d

Thai Duong authored 7 years ago

Deleting AesCtrHmacAeadParams proto as it's not used anywhere.

Change-Id: I069b6ee749ce3522c4a5935fb7b8628921bc6f0b
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: e958abc862f4f4fce1b6d55ce1bb0dc3e12bf4dc

0df23c2d

Adding C++ EncryptThenAuthenticate. · 1a5bb274

Thai Duong authored 7 years ago

Change-Id: I904ec277887a576df3d4a23ef87ca000f87ed87c
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 6ae02a096733fbc60a689b1cadc6f77ea756584d

1a5bb274

Adding AesCtrBoringSsl. · ec2e19bc

Thai Duong authored 7 years ago

Change-Id: I24b4caab40bc8b257ffe02f394a05db438cde292
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 01c331e3bd6eb9304143306ccdd1fa12ce170830

ec2e19bc

Fixing Lint errors and adding some cosmetic changes to make sync easier. · 1bef57ef

Thai Duong authored 7 years ago

Adding a temporary constructor to C++ KeysetHandle so that ObjC code
doesn't break.

Change-Id: I2566ea54c1a650d49dda57dad0d949d5ff82ffc1
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: c15b141b9daf88987f32ac425068292c8bb5bdd7

1bef57ef

Changing tests that use Wycheproof test vectors with a field "message". · 0b63e57c

Thai Duong authored 7 years ago

Change-Id: Id078262045f2b021acc4a352006685acd13292e8
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 361ea038a50b612e14c9acfd24483dc047b99024

0b63e57c

Skipping tests when key size is not supported. · 511dd7ce

Thai Duong authored 7 years ago

Also don't run tests that depend on external data files on Android.

Change-Id: Ic38fa7ac0b92f652d253eb5717ee78beab0acf24
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 0991f5c340a44e08af6a9a0167cb23888ed2c44d

511dd7ce

Oct 17, 2017

Add pre-generated StreamingAEAD key templates (#61) · c279836a

pkorth authored 7 years ago

* Add pre-generated StreamingAEAD key templates

* PR feedback

* Use proper Javadoc list format

c279836a

Oct 14, 2017

Use Wycheproof test vector for AesEaxJce. · f589755e

Quan Nguyen authored 7 years ago

Move checkAlgAndVersion method to WycheproofTestUtil.

Change-Id: I25b81f9bf421a4c5c34604cdd3335c6714f4e2ce
ORIGINAL_AUTHOR=Quan Nguyen <quannguyen@google.com>
GitOrigin-RevId: 3e3c339ad6a5059da0cead658bc3783f67fb4def

f589755e

Fixing typos and inconsistent naming. · 0e79bbb0

Bartosz Przydatek authored 7 years ago

Change-Id: I3bd570ab5b5e083909e6207eaeb113a5fdfad601
ORIGINAL_AUTHOR=Bartosz Przydatek <przydatek@google.com>
GitOrigin-RevId: 41746baffdb7a330921903f83db4722a688c37dc

0e79bbb0

Use Wycheproof tests for EcdsaVerifyJce. · b39d72f9

Quan Nguyen authored 7 years ago

Change-Id: I97538d118af94c103d7aa3bd15f1791614df999c
ORIGINAL_AUTHOR=Quan Nguyen <quannguyen@google.com>
GitOrigin-RevId: d17b7d35bd7f53443f61eeba3189573f88f1e668

b39d72f9

Adding C++ JsonKesetReader. · a0054b9b

Bartosz Przydatek authored 7 years ago

Change-Id: I9979511b250f4e50decd6fc3efa8a2d0d94043c9
ORIGINAL_AUTHOR=Bartosz Przydatek <przydatek@google.com>
GitOrigin-RevId: 0d0cff5f71b452c6a2b0ff64ae8722e01b5cabc5

a0054b9b

Adding C++ KeysetReader. · 9fb56133

Bartosz Przydatek authored 7 years ago

Change-Id: I33c2a09d2983cd5aee28a1eec886eb22e31bf9f9
ORIGINAL_AUTHOR=Bartosz Przydatek <przydatek@google.com>
GitOrigin-RevId: e6763b4edc0b874dec4e7056bd124271eeca9f2d

9fb56133

Fixing style and Lint errors. · 3e4c19bd

Thai Duong authored 7 years ago

Change-Id: I6a671070796278d4a98fffe2fb86e07d317bf8cf
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 718c47fb03cfc42f0ec2d0d47597f8e668e31e27

3e4c19bd

Oct 06, 2017

Adding license boilerplate. · 94481cb0

Thai Duong authored 7 years ago

Change-Id: I8ac2ae70b41281875c9e8b35f76bb2a3df6ce562
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 9b6a7f502f8614ecbdf2e908ed45b47395dc51f5

94481cb0

This is a workaround of a bug in Conscrypt. · 5c1bb848

Thai Duong authored 7 years ago

When one does

cipher.update(buffer1, output);
cipher.doFinal(buffer2, output)

if buffer2 is empty Conscrypt didn't update output at all.

This edge case happened in Tink when users write single bytes to an encrypting channel.

Equivalent internal Cl: cr/171306593.

Change-Id: I9429b668e3a87027e1a28f44ea1f5e7785081e18
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 80247f359461c3a7f1e8f09ca510a21a8966b804

5c1bb848

Fixing b/67416642 by allocating 16 bytes more for each plaintext segement. · 0faa8b50

Thai Duong authored 7 years ago

Equivalent CL: cr/171304870.

Change-Id: Ibebd0da981520e7f05317aa30de5fe2b606bd208
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 9cf419f9f338d80e5fd00df7dfb97cb4b59a109e

0faa8b50

Moving common streaming test methods to StreamingTestUtil. · ab5c1a08

Thai Duong authored 7 years ago

Streaming tests no longer depend on java.nio.file package, thus
they should run well on Android pre 26.

Also fixing the bug in testFileEncryption that Quan encountered
in http://sponge/292f80ca-818a-4f6f-9f9d-7c18f344e477.

Change-Id: I22f557b478149ee4e7a4a04c666e440843095d30
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 3c185a66d753436f3b6d9db2eb2fceb774b8cbff

ab5c1a08

Fixing style and Lint errors. · 06769f33

Thai Duong authored 7 years ago

Change-Id: I0c4af7ce40698561e1d4c98c66628bdc6319990b
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 02289b9631aca3c5aeec907e45a97d76c825b152

06769f33

Fixing issues found during sync. · f77a51a1

Thai Duong authored 7 years ago

- Moving wycheproof test vectors to testdata/wycheproof so that
they can be excluded in sync.

- StreamingAeadConfig does not use AeadConfig, removing the
dependency.

- Adding ToString() in a few places.

- Removing unused dependencies in AesGcmBoringSsl.

- Removing TestUtil.getBytes() and renaming TestUtil.getJsonObject
to readJson.

Change-Id: I5216275fa7050524af98c11ce6a8007cbab37212
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 4fdc9b5759d0f37b0ce054fe56a57bb27c3ba594

f77a51a1

Accepting multiple registration of same key manager in C++ registry. · 8e331022

Bartosz Przydatek authored 7 years ago

Change-Id: I0b1d48d5a29e7d12df805f1cc28aab07d2d9affb
ORIGINAL_AUTHOR=Bartosz Przydatek <przydatek@google.com>
GitOrigin-RevId: 44205bea27caded86c765b480a47fb78b8a72eca

8e331022

More C++ Config catch-up, adding C++ HOW-TO, fixing typos. · 6256d7cd

Bartosz Przydatek authored 7 years ago

Change-Id: Ifc49082cfcbcf04335a69e047cf6e7589463a18a
ORIGINAL_AUTHOR=Bartosz Przydatek <przydatek@google.com>
GitOrigin-RevId: aea52716172a1da2cb250f9afe81a71bfc5cd353

6256d7cd

Don't depend on protobuf-java-util which doesn't support Android. · b0de1cc1

Thai Duong authored 7 years ago

Change-Id: Ib465cc0feeeca5a0f6f31e8b5968af3c1e4d75f5
Bug: 67385998
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 3cf99a121e531d693ca3ba3ff33cba0b0f66a8f6

b0de1cc1

Replacing git_repository with http_archive which is faster. · 8142ab2b

Thai Duong authored 7 years ago

See https://docs.bazel.build/versions/master/best-practices.html#repository-rules.

Change-Id: If546cbf1572e0366d764469343d1d8109a1d5863
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: 178a4ee2ce686a1832ae1ec809fd8fd11eb73212

8142ab2b

Adding C++ configurations support. · 19a6b693

Bartosz Przydatek authored 7 years ago

Change-Id: I4b17e65859db914458a32d3359f1a44b5b1b6bde
ORIGINAL_AUTHOR=Bartosz Przydatek <przydatek@google.com>
GitOrigin-RevId: b67033740fe4d4f49410c397aeab503da6365950

19a6b693

Fix a bug in Ed25519 and add Wycheproof tests. · 2da371ee

Quan Nguyen authored 7 years ago

The bug is that isNonZeroVarTime assumes the input is reduced while it
isn't. Furthermore, the reduced number representation is not unique,
e.g., the following array is essentially zero
[67108845,33554431,67108863,33554431,67108863,33554431,67108863,33554431,67108863,33554431]
We have to call Field25519.contract() before checking for zero.

Change-Id: Ib4f80a686de3f72e44dc602664c9f12616663db8
ORIGINAL_AUTHOR=Quan Nguyen <quannguyen@google.com>
GitOrigin-RevId: c735f0857fad861647a53eb842838cf0e499636d

2da371ee

Oct 03, 2017

Making headers in Java-HOWTO linkable. · c4f271a2

Thai Duong authored 7 years ago

Also fixing a small typo in README.

Change-Id: I9c63f12e7f73488cd8acef2011f9c91181770f2d
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: eab43f5125abef1bc60eaa0b47f0c5b6d291b884

c4f271a2

Adding thread-safety tests for StreamingAead. · ad485bec

Daniel Bleichenbacher authored 7 years ago

Change-Id: I6ebc49fb037f9df83e354ab2868949c26cef96fb
Bug: 66921440
ORIGINAL_AUTHOR=Daniel Bleichenbacher <bleichen@google.com>
GitOrigin-RevId: 72eb999537f173a148feed26f2a32f7cf45f7abd

ad485bec