Calls to fuchsia.device.Controller/Bind should only return once the
operation completes, which is when
fuchsia.device.manager.DeviceController/BindDriver is called.

ZX-3991 #done

Change-Id: I10607640072c8f779ac1d5be79d5a2da6de6288b

When an environment() sets variant_selectors so it doesn't match the
default list used in common environments, things get even hairier for
environment_redirect().  Previously environment() documented that
default_variants must be in the list for environment_redirect() to work
right, but even that was not actually enough.  Instead, remove that
requirement and make environment() always define a dummy environment with
the "default redirect" variant name that environment_redirect() will
choose.  Make that logic choose only from default_variants and line up with
the fallback dummy variant name logic in environment().

Bug: BLD-430
Change-Id: I399a38ba494f4fafc28a3d9e93dece101eab3732

This allows the OTA tests to be used between two local builds.

Change-Id: Ib9e4088fe0d6d17dda57d6b628e5ca636e48b806

- Convenience methods GetProperties,GetConfig no longer that convenient
- move to "internal" namespace
- use weak pointer to access Controller functionality

Tested: fx run-test cpuperf_tests
Change-Id: I36002719309a4798447b6e3c79692298990fb1e2

This reverts commit 1651ebe6.

Reason for revert: The change rolled too much into one commit and did not get anything green.  It needs to be split up and reviewed properly.

Original change's description:
> [utest] Don't hard-code /boot location for zircon test files
> 
> This change fixes the zircon tests that were failing in the `bringup`
> build.
> 
> The tests were failing because they had hardcoded paths at "/boot/..."
> which failed when the tests were run from "/system". The fix is for
> runtests to pass a TEST_ROOT_DIR environment variable, which is
> "/system" or "/boot" depending on the location of the test. The tests
> use this variable instead of hardcoding the path.
> 
> Bug: BLD-463 #comment fix broken tests
> Change-Id: Id6478f68600a55f13dc8c0bde19253c909a03694

TBR=mcgrathr@google.com,geb@google.com,shayba@google.com
Bug: BLD-463

Change-Id: I9d5a296eee311d48ac45a7dd8339d889aca18d4d

Change-Id: Ida400311e4757c34aa23e42fee0c658966ce13a4

Happy to tweak wording as necessary.

Change-Id: I4db141b3ad0436a861d90905b9bf7c9040b649c5

Change-Id: I9378d445e53b88cade30ecdab28021bb4dc4137c

This integrates the component_manager logger, which sends logs to the
kernel debuglog facility, with the log crate instead of defining our own
macros. It also adds a panic hook to ensure that panics are also sent to
the debuglog, rather than relying on component_manager's stderr to be
wired up properly.

Also removes the stderr fallback path, which is unnecessary.

Change-Id: I3510b04239c7f9ab306254663bddaab245f48197

Update #ifdef gates for headers to match their new location in
src/connectivity.

TEST: Compiles
Change-Id: I94f3509a24e91a9e93e4ec6b697fa602fa4bec62

This change implements the minfs inspector backend for different on-disk structures like
superblock, inode table, inode, journal et al and returns each of these as a generic DiskObject.
Please note that alloc block bitmap and inode bitmap are not implemented as part of this
change and will be implemented as a later CL.
This CL also splits the Minfs class and InodeManager class to make them more easy to accomodate
unit testing.

Testing: Added unit tests for root, superblock, inode table, inode and journal.

Change-Id: I3bed793a8c0301bf8ce4367fbca48e31a6f44772

This cl implements Settings Manager based on the recent settings.fidl
submitted for A11y. This cl includes following changes:
  * Implementation of Settings Manager.
  * Unit Tests with Mock for SettingsService and SettingsWathcer.
  * Added a comment in settings.fidl to document expected behavior of
    SettingsWatcher.

Testing:
  * Build: Passed
  * Installed image on device.
  * Unit Test: Passed
    Command Used: fx run-test a11y_tests

MI4-1567 #comment
MI4-1477 #comment

Change-Id: Ib4c36b2e660e39760d34c58cb91864b3d60d7169

Tests: build
Change-Id: If8c72b099513338b5cdbff5fbcdb5c822ec2f9d2

Devs should be able to query for its properties and enumerate children.

CF-768 #done

TEST= added new test.

Change-Id: Ib52c90fef60acc50e9ce0b9c6c85e41983089017

also clean up dependencies and includes in edited integration tests

TESTED=`fx run-test crashpad_agent_tests -t crashpad_agent_integration_test`
TESTED=`fx run-test feedback_agent_tests -t feedback_agent_integration_test`

Change-Id: Ib1a6039aedf7ff49aa8cfd3f8652c587577f15fe

This change adds a new set of tests test that drive amberctl within nested
environments containing isolated instances of Amber to ensure, end to
end, that its interactions with the service produce the expected results

PKG-604 #done

Change-Id: Ib3843f075d51f34e5bc2ddc5bd04cadf6dd6e466

This CL adds an admin-only method to enable or disable the
systemwide creation and update of audio device settings files.

This work is being done in preparation for the creation of long-
running audio tests that (among other things) create and destroy
an endless number of audio input and output devices (in conjunction
with virtualaudio), which otherwise would completely fill all
available storage with audio device settings files.  While we do
also want eventually to test the out-of-storage scenario, we also
want to be able to remove this factor, in order to find the other
factors that may stop us from being able to operate indefinitely.

Test: to be created

Change-Id: I1f0f9fff815b6c6f9d088c50b76d961f852902bb

The write hook to dmctl has been removed.

Tested by causing bootserver to send a reboot command. One way to do
this is to pass bootserver an FVM but not a kernel.

out/default.zircon/tools/bootserver \
  --board_name chromebook-x64 \
  --fvm /out/default/obj/build/images/fvm.sparse.blk \
  -n <node name>

ZX-4038 #comment

Change-Id: Ibb9ea419feb542aa811c60e0d280f68ae2b86144

Add a document describing suggestions for vocabulary usage and avoidance
to aid in clear communication and understandable code.

Change-Id: Iaf7fbdfbb351f0a0e101adbffdaf1d08b9276941

Right now we only support big endian u16, but other uint widths are needed
when using LayoutVerified for various frame types.

Test: Added unit test coverage for new types.
Change-Id: Ie4a4ac66153918b28300bd0ef57a03994e20ee62

Change-Id: I566fe282b50282ae27ff636f70656b4d1691441c

This CL corrects a bug ('-F' vs. '--F') and improves the tests so that
will catch such a case next time.

Bug: SEC-278
Test: python scripts/fuzzing/test/device_test.py
Change-Id: I759c1bc234c7b0100ab4592564a2436ecc272170

Test: CQ

Change-Id: Iace1e57ab28b1feadba2f57a7858108c4d27718f

The BP member of the StackFrame originally came from the unwinder but
normally we use the frame base from the symbols since the BP register
isn't necessarily used (it never is for our release builds). In the
current default mode (Android unwinder), it's always set the same as the
stack pointer so is actively misleading.

Removes printing the BP in the long backtrace format. This doesn't
handle async results and now sometimes the base pointer requires
asynchronous evaluation. We can add this back later if we desire.

Other than the printing change, there should be no noticeable behavior
change in normal usage so the existing tests should cover it. IN some
"symbols corrupt or missing" cases, the default BP value changed from
the register to 0, but 0 is probably less misleading when the base
pointer isn't really known.

Change-Id: Id6a5f18d27186bc2337957dfefda5fc26ca21cb3

Test: Compiles, no behavioral change.
Change-Id: Ia4cf6f0283f9bfeb0695204a0c70b68070e5be04

Change-Id: I43e1b255b10dce3fcc326ac0784d2b8262a9afbc

Test: no behavior change
Change-Id: I6cdf37178e7a7b293df9d53c21798da34a9774cd

There's no clear difference between zx_info_vmo_t.create_options and
zx_info_vmo_t.flags. Flags is more general, so remove create_options and
move its function into flags. This also introduces actual define values
for resizability and contiguity.

Change-Id: Ia4110cc8362e29c38150f8841aeabcd1e1fbc072

TESTED=fx run-test rust-crates-tests -t fuchsia_inspect_lib_test

CF-607 #comment

Change-Id: Iaaea5be26b3e3b27650fee9405a8092eb3d8aef5

This change introduces logs around factory reset and login
override to better track these events.

Bug: QA-728
Change-Id: Ic456fda63decdab2dd7aef5de68d171b7938d942

This Cl adds a method to the Dockyard to convert a DockyardId to a string (or
dockyard path).

Bug: 20
Test: run system_monitor_tests
Change-Id: I200db5aab15a79a2c07127c7842021ad5010dfdd

FLK-224: #done

Change-Id: Ic79aa7d6c9bec31d762771c03a8603877ceaeee2

Add storage capabilities to FIDL definitions, followup commits will add
storage concepts to CM, CML, and cm_rust, and add support for storage to
component_manager.

Change-Id: I0100d9a3efcb5f1cbc0d8504d85fb2fe66af5391

- Use lazy global initialization for the singular system topology
  graph instance. Enable the init check option to prevent multiple
  initializations.
- Add a general static initializer to handle building Graph
  instances that might fail. This moves closer to named constructors
  using the result type pattern, once it's available.
- Make construction of the global system topology more explicit
  using a static initializer instead of a method.
- Minor namspace and anonymous namespace adjustments.

Test: k ut system-topology and k ut x86_topology passes.
Change-Id: Ibefcf5e24c6fa3362b2208d3b508740b64e2d75c

- Collapse Percpus into percpu type to remove redundant type bloat.
- Use lazy initialization for the boot percpu global to avoid init
  sequencing hazards with global ctors and permit non-trivial ctor.
- Use slightly more consistent style for trivial accessors.
- Minor fixups to perfect forwarding of callables.

Test: System boots and tests pass; observe multi-cpu traces.
Change-Id: I3520439a9e70e6d7a7e61c32c14cd0fec26c4906

Introduce a utility wrapper type to remove global ctor/dtor from
global variables and make initialization explicit.

Explicit initialization of globals has the following advantages:
  * Order of initialization between globals is explicit.
  * Safer sequencing of initialization and code running before and
    after call_constructors() is invoked.
  * Globals may have non-trivial constructors that take runtime
    parameters.

Destructors may be enabled/disabled at compile time, supporting
future ASAN builds that require destructors vs. production builds
without destructors. Destructors may also be hard disabled for
individual globals to avoid more complex __cxa_atexit() hazards.

Test: Included test passes.
Change-Id: I8b8554c69322d6a0ef557f1c63af773c8ececbeb

This small patch was accidentally left out of
I4a23916a6264df9b0ebced6764e3f9a573793a19 due to a git stash mistake.

Test: New tests pass
Change-Id: I3e7d047a40e26fcdfbc906c910816265a17d3aa0

Change-Id: I08f1e2a82557dfebe50e13fe2e8d3a239919237f

Change-Id: I898f28e392adc07538225823ca51363b43b8ffce

This is a quick hack to kill basemgr_launcher after 5 seconds.
This will be removed in a follow-up CL that determines when basemgr has
successfully read configs from basemgr_launcher.

MF-359 #comment Add 5 second timeout

Change-Id: I60272dc81bd9c1530085d584f19d104d04792990