[iquery] Refactor iquery to use new reader interface
This change replaces iquery's manual traversal code with the new inspect/reader.h interface. To simplify iquery path handling and to make parts of the path more clear, this change also introduces a delimiter between the file part and inspect part of a particular path. Consider the inspect tree: objects: table-0x0: row-0x1: table-0x2: Previously we would write: $ iquery --ls --full_paths objects/table-0x0 objects/table-0x0/row-0x1 Now we write: $ iquery --ls --full_paths objects#table-0x0 objects#table-0x0/row-0x1 The delimiter '#' separates the file part of the path from the inspect part, which makes the meaning more clear ("open inspect at this location, then traverse to this child" vs. "expect to find an inspect endpoint along this path and once that is open continue traversing to the proper location"). CF-218: #progress Change-Id: I31df97351aca4e3df5f53df4aa842c7207c2e18d
Showing
- garnet/bin/iquery/BUILD.gn 4 additions, 2 deletionsgarnet/bin/iquery/BUILD.gn
- garnet/bin/iquery/connect.cc 0 additions, 138 deletionsgarnet/bin/iquery/connect.cc
- garnet/bin/iquery/connect.h 0 additions, 38 deletionsgarnet/bin/iquery/connect.h
- garnet/bin/iquery/formatter.h 3 additions, 1 deletiongarnet/bin/iquery/formatter.h
- garnet/bin/iquery/formatters/json.cc 34 additions, 21 deletionsgarnet/bin/iquery/formatters/json.cc
- garnet/bin/iquery/formatters/json.h 1 addition, 1 deletiongarnet/bin/iquery/formatters/json.h
- garnet/bin/iquery/formatters/text.cc 43 additions, 22 deletionsgarnet/bin/iquery/formatters/text.cc
- garnet/bin/iquery/formatters/text.h 1 addition, 1 deletiongarnet/bin/iquery/formatters/text.h
- garnet/bin/iquery/main.cc 26 additions, 12 deletionsgarnet/bin/iquery/main.cc
- garnet/bin/iquery/modes.cc 277 additions, 221 deletionsgarnet/bin/iquery/modes.cc
- garnet/bin/iquery/modes.h 70 additions, 4 deletionsgarnet/bin/iquery/modes.h
- garnet/bin/iquery/testing/BUILD.gn 8 additions, 0 deletionsgarnet/bin/iquery/testing/BUILD.gn
- garnet/bin/iquery/testing/goldens/cat-recursive-absolute.txt 21 additions, 21 deletionsgarnet/bin/iquery/testing/goldens/cat-recursive-absolute.txt
- garnet/bin/iquery/testing/goldens/cat-recursive-full.txt 21 additions, 21 deletionsgarnet/bin/iquery/testing/goldens/cat-recursive-full.txt
- garnet/bin/iquery/testing/goldens/cat-single-absolute.txt 2 additions, 2 deletionsgarnet/bin/iquery/testing/goldens/cat-single-absolute.txt
- garnet/bin/iquery/testing/goldens/cat-single-full.txt 2 additions, 2 deletionsgarnet/bin/iquery/testing/goldens/cat-single-full.txt
- garnet/bin/iquery/testing/goldens/cat-single.txt 1 addition, 1 deletiongarnet/bin/iquery/testing/goldens/cat-single.txt
- garnet/bin/iquery/testing/goldens/explicit-file-full.txt 6 additions, 0 deletionsgarnet/bin/iquery/testing/goldens/explicit-file-full.txt
- garnet/bin/iquery/testing/goldens/explicit-file.txt 6 additions, 0 deletionsgarnet/bin/iquery/testing/goldens/explicit-file.txt
- garnet/bin/iquery/testing/goldens/find-recursive-json.txt 21 additions, 21 deletionsgarnet/bin/iquery/testing/goldens/find-recursive-json.txt
Loading
Please register or sign in to comment