[debugger] Attach to the root job by default.
Previously the debugger would automatically attach to the component root. But this misses some processes. What came up recently was Zircon system tests. Having to do extra steps to watch the right job for these common tests is confusing for developers. Now the system root job is attached to by default on connection. Added switches to the "attach" verb to refer to either the system root or component root job without having to look up its koid. Enhanced the "attach" documentation. Did some minor cleanup of the job status messaging. The state was copied from the process object and included a state we didn't use "starting" and using "running" for a job is confusing. The messaging is now either "Not attached", "Attaching", or "Attached". Change-Id: I386921f3efb4b310b36dfd27c8773e86d743e6e7
Showing
- src/developer/debug/debug_agent/debug_agent.cc 80 additions, 85 deletionssrc/developer/debug/debug_agent/debug_agent.cc
- src/developer/debug/debug_agent/debug_agent.h 9 additions, 4 deletionssrc/developer/debug/debug_agent/debug_agent.h
- src/developer/debug/debug_agent/integration_tests/debugged_job_test.cc 47 additions, 0 deletions.../debug/debug_agent/integration_tests/debugged_job_test.cc
- src/developer/debug/debug_agent/system_info.cc 30 additions, 0 deletionssrc/developer/debug/debug_agent/system_info.cc
- src/developer/debug/debug_agent/system_info.h 4 additions, 0 deletionssrc/developer/debug/debug_agent/system_info.h
- src/developer/debug/ipc/protocol.cc 2 additions, 0 deletionssrc/developer/debug/ipc/protocol.cc
- src/developer/debug/ipc/protocol.h 11 additions, 4 deletionssrc/developer/debug/ipc/protocol.h
- src/developer/debug/zxdb/client/job_context.h 9 additions, 12 deletionssrc/developer/debug/zxdb/client/job_context.h
- src/developer/debug/zxdb/client/job_context_impl.cc 12 additions, 10 deletionssrc/developer/debug/zxdb/client/job_context_impl.cc
- src/developer/debug/zxdb/client/job_context_impl.h 9 additions, 8 deletionssrc/developer/debug/zxdb/client/job_context_impl.h
- src/developer/debug/zxdb/client/system_impl.cc 5 additions, 6 deletionssrc/developer/debug/zxdb/client/system_impl.cc
- src/developer/debug/zxdb/console/command_utils.cc 5 additions, 7 deletionssrc/developer/debug/zxdb/console/command_utils.cc
- src/developer/debug/zxdb/console/nouns.cc 1 addition, 1 deletionsrc/developer/debug/zxdb/console/nouns.cc
- src/developer/debug/zxdb/console/verbs_process.cc 75 additions, 27 deletionssrc/developer/debug/zxdb/console/verbs_process.cc
Loading
Please register or sign in to comment