Skip to content
Snippets Groups Projects
Commit 61f85391 authored by Taylor Cramer's avatar Taylor Cramer Committed by CQ bot account: commit-bot@chromium.org
Browse files

Revert "[cobalt-fidl] Add new CobaltEvent methods"

This reverts commit 95288e7e.

Reason for revert: causing build failure in higher layers, see
e.g. https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8926667935749990112/+/steps/build/0/steps/build_fuchsia/0/steps/ninja/0/stdout

Original change's description:
> [cobalt-fidl] Add new CobaltEvent methods
> 
> This will alow us to support multiple events at once as well as
> multiple event codes per event.
> 
> CB-197
> 
> Test: No functional changes, CQ
> Change-Id: Ifaf2f1ddf19a9f87299deff88692413208daafee

TBR=rudominer@google.com,azani@google.com,zmbush@google.com

Change-Id: I60cad9e595abe3ec4de7ee59fe2600c934a7cdb8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
parent 0e3d1717
No related branches found
No related tags found
No related merge requests found
......@@ -491,41 +491,6 @@ struct HistogramBucket {
uint64 count;
};
// A structured 'Count' event.
struct CountEvent {
int64 period_duration_micros;
int64 count;
};
// The union of all possible event types.
union Event {
// A Count event.
CountEvent event_count;
// An IntHistogram event.
vector<HistogramBucket> int_histogram;
};
struct CobaltEvent {
// ID of the metric to use. It must be one of the Metrics from the
// ProjectProfile used to obtain this Logger, and it must be of the correct
// type.
uint32 metric_id;
// A list of event codes for each of the event code groups in the config.
// The indexed set of all event code groups and their labels is specified in
// the metric definition.
vector<uint32>:5 event_codes;
// Optionally, a component associated with integer-valued measurements may
// also be logged. Any notion of component that makes sense may be used or
// use the empty string if there is no natural notion of component.
string:64? component;
// The event-specific information for the event to be logged.
Event event;
};
// Logger is an extension of the LoggerBase interface that adds some additional
// methods that do not naturally conform to the Simple layout. We opt for
// a natural easy-to-understand interface at the cost of not being "Simple".
......@@ -574,14 +539,6 @@ interface Logger : LoggerBase {
// be consistent with the dimensions declared in the Metric definition.
101: LogCustomEvent(uint32 metric_id, vector<CustomEventValue> event_values)
-> (Status status);
// Logs a structured CobaltEvent object.
[Transitional]
102: LogCobaltEvent(CobaltEvent event) -> (Status status);
// Logs a list of structured CobaltEvent objects.
[Transitional]
103: LogCobaltEvents(vector<CobaltEvent> events) -> (Status status);
};
/////////////////////////////////////////////////////////////////////
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment